Dev July 2010

dev@lists.roundcube.net

31 participants
40 discussions

Fwd: Roundcube plugin
by yannis.rossetto 17 Oct '10

17 Oct '10

-------- Original Message -------- Roundcube plugin Thu, 27 May 2010 17:30:22 +0200 Yannis dev(a)lists.roundcube.net Hello (from France), First of all, sorry for my approximate English. I created a plugin for the Roundcube webmail, which works in complement with the Thunderbird's plugin : Addressbook Synchronizer. More informations about my plugin's functioning are available here : http://cric.grenoble.cnrs.fr/logiciels/AddressBook-RoundCube/?lang=en [1] I write you to know if that possible to have some comments, some suggestions and some remarks about my program and, particularly, about the source code. You can download the plugin on the following link : http://cric.grenoble.cnrs.fr/logiciels/AddressBook-RoundCube/abook_sync-0.1… [2] Thanks a lot Links: ------ [1] http://cric.grenoble.cnrs.fr/logiciels/AddressBook-RoundCube/?lang=en [2] http://cric.grenoble.cnrs.fr/logiciels/AddressBook-RoundCube/abook_sync-0.1… _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

rcube_imap_generic readLine issues
by Brad Davidson 10 Sep '10

10 Sep '10

Hi all, I've recently been playing with Dovecot 2.0's Director proxy as a backend for Roundcube. I've been using Dovecot 1.2 for months without problems, but since switching to the Director I've had problems with Apache processes getting stuck. It looks like imapproxy is getting disconnected while inactive, and is therefore disconnecting Roundcube just after LOGIN. I'm trying to figure out why it's getting disconnected, but in the mean time I thought I'd investigate the Roundcube behavior. [root@webmail ~]# grep 'Maximum execution time' /var/log/roundcubemail/errors | awk '{print $14 ":" $17}' | sort | uniq -c 2 /usr/share/roundcubemail/program/include/rcube_imap_generic.php:169 1 /usr/share/roundcubemail/program/include/rcube_imap_generic.php:171 6 /usr/share/roundcubemail/program/include/rcube_imap_generic.php:173 7 /usr/share/roundcubemail/program/include/rcube_imap_generic.php:348 11 /usr/share/roundcubemail/program/include/rcube_imap_generic.php:349 6 /usr/share/roundcubemail/program/include/rcube_imap_generic.php:350 4 /usr/share/roundcubemail/program/include/rcube_imap_generic.php:356 The problem here is that there are LOTS of places in the rcube_imap_generic code (old ilohamail, I know) that run in a DO...WHILE loop around readLine and don't ever check to see if it's returning NULL. I know that this is intended to loop around possible untagged IMAP replies until the desired response line is found, but there needs to be some code to break out of the loop if a NULL is encountered. There are so many places that this would need to be fixed that I'm not really sure where to start, or even if my patch would be accepted. Alec, Thomas, what do you guys think? -Brad _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

improved extended address book patch with group management
by Phil Weir 12 Aug '10

12 Aug '10

Hi, I have improved my extended address book patch to include a "Groups" tab, this lists all the groups a contact is in (limited by address book) and allows users to add or remove the contact from a group by ticking a box (like the folder subscriptions). I'm not 100% sure about the group management stuff so if any one has any better ideas on how to do it please let me know. I have also extended the support for alternative email addresses to allow any number of email address to be added. This is only for the default SQL address book. Like before there is no need for any SQL changes. Complete list of changes: *) Add "date_only" config option to specify the format when displaying a contacts birthday *) Add more fields based on vCard; alt email, address, telephone etc *) Move auto_complete function into address book class to allow different for searching of custom fields (like those in the vCard) *) Add new blankcontact.html template file *) Add support for multiple email address *) Add "Groups" management tab The extended address book patch also incorporates the patch from this ticket http://trac.roundcube.net/ticket/1486851. It's been tested with the default SQL address book, I'm not sure how well it will get on with LDAP as I don't have access to an LDAP address book at the moment, if any one would like to help me test it that would be appreciated. Screenshot and patch attached. Phil http://www.tehinterweb.co.uk/roundcube --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/fm/Xq5dOtaO/addressbook.jpg http://detached.gigo.com/rc/fm/Xq5dOtaO/rc_addressbook.r3814.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

5 9

GnuPG/PGP plugin for roundcube
by Jonas 05 Aug '10

05 Aug '10

hello, i'm new to roundcube, but i think it's a very promising project. but i really do miss a plugin which implements server-side support for gnupg/pgp encryption/decryption. searching in forum, wiki, trac, lists etc, I already found a lot of discussions regarding this issue.[1,2,3,4] many people even promised to work on this feature. some suggested to wait for the plugin api before implementing gpg/pgp support. if i got it right, the plugin api is available in the svn repository now. everyone cc'ed in this mail stated somewhere that s/he either plans to or already did work on gpg/pgp support in roundcube. maybe i find the time to work on this feature within the next months. but before i start, please tell me: do you have any code (maybe already using the plugin api from svn) that i could use? my plan is to develop _serverside_ support, so both public and private key will need to be stored on the host that runs roundcube. but in the case that you're the admin of this host anyway this is not a problem at all. second,i don't want to take a usb-stick with me all the time, so serverside gpg encryption is the only option here. and i plan to use the gnupg php library[5] instead of a gnupg library as i guess that more systems do have the gpgme library installed than the gnupg binary. greetings, jonas [1] http://trac.roundcube.net/ticket/1440396 [2] http://lists.roundcube.net/mail-archive/dev/2008-01/0000033.html [3] http://lists.roundcube.net/mail-archive/dev/2006-02/0000229.html [4] http://www.roundcubeforum.net/requests/491-gpg-pgp-support.html [5] http://www.php.net/manual/en/function.gnupg-sign.php _______________________________________________ List info: http://lists.roundcube.net/dev/

9 33

Button from plugin with javascript only action
by David Harris 04 Aug '10

04 Aug '10

[[ I'm happy to work with a consultant to answer this and other questions, as per my previous email. However, Thomas suggested I send some questions to the dev list, so I'm doing that. ]] I see when you define a button from a plugin, you can give it a command: $this->add_button(array( 'command' => 'plugin.markasjunk', 'imagepas' => $skin_path.'/junk_pas.png', 'imageact' => $skin_path.'/junk_act.png', 'title' => 'markasjunk.buttontitle'), 'toolbar'); } And register a PHP callback to handle that command: $this->register_action('plugin.markasjunk', array($this, 'request_action')); I want to define some buttons that execute javascript in the browser, instead of creating HTTP request to the server to run a PHP callback. Is there a way that I can register a command name (for example 'plugin.move_to_next_message') along with javascript code to be run for that command? I could always modify program/js/app.js to add a new command, but if there is a hook to do this, I'd prefer to do that. Thanks! David Harris DRH Internet Inc. 972-572-0900 _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Button conditional on current mailbox
by David Harris 04 Aug '10

04 Aug '10

Hi, [[ I'm happy to work with a consultant to answer this and other questions, as per my previous email. However, Thomas suggested I send some questions to the dev list, so I'm doing that. ]] I want to add some buttons to the message listing toolbar and the message view toolbar, but I want them to be conditional based on the mailbox. I've been looking at some existing plugins for guidance. I see in the "markasjunk" plugin: function init() { ... $rcmail = rcmail::get_instance(); if ($rcmail->action == '' || $rcmail->action == 'show') { ... $this->add_button(array( 'command' => 'plugin.markasjunk', 'imagepas' => $skin_path.'/junk_pas.png', 'imageact' => $skin_path.'/junk_act.png', 'title' => 'markasjunk.buttontitle'), 'toolbar'); } } My problem is that the current mailbox does not appear to be available at this step. And if I did conditionally print this button based on mailbox, when the user clicks to a different mailbox roundcube displays the new data without a page reload, so the button would need to be hidden/shown with JavaScript. My guess is that I should always print the button, but then modify some JavaScript code to update the display CSS property based on what mailbox we are in. Is there a standard hook for doing this? Or a location where other code does this which would be a logical place to add? I see that buttons are grayed based on if a message is selected or not. Thanks, David Harris DRH Internet Inc. 972-572-0900 _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Message page navigation performance
by A.L.E.C 02 Aug '10

02 Aug '10

http://lists.roundcube.net/mail-archive/users/2010-07/0000021.html I'm not sure all of you are reading users list. THREAD preformance issue has been fixed. Still on big mailboxes it can took a few seconds for handling threads. BTW, my proposition to make displaying messages (in 'show' action) faster is to create page navigation (#countcontrols) in separate (ajax) request after message.html page is loaded. Any thoughts? -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

Plugin to migrate user address book from SQL to LDAP
by Christoph Langguth 26 Jul '10

26 Jul '10

Hi everyone, I have recently upgraded to the latest stable version (0.3.1). I was pleased to see that the users' private address books can now nicely be stored in LDAP as well. I like this because it enables address book synchronization with Thunderbird (albeit TB still can only access it read-only, but it's a step forward). So I wrote up a small plugin that can migrate the address books from SQL-backed storage to LDAP-backed one when a user logs in. The file goes into plugins/addrbook_sql2ldap/ I realize that this has a rather narrow scope and is probably only useful for a few people; nevertheless I'm attaching it here and leave it up to the maintainers to decide whether to include it in the distribution or to throw it away :-) License is GPL, of course. This was written for 0.3.1, I don't know if there are any changes required for the latest development version. I doubt it, but in case there are, it should be a matter of minutes to adapt it because it's not exactly a lot of code. Oh, one more completely unrelated thing: on every login, I keep getting the following warning in logs/errors: PHP Warning: sort() expects parameter 1 to be array, boolean given in program/include/rcube_imap.php on line 1118 It doesn't seem to do any harm, but if there's a suggestion for a fix, I'd be grateful. I have to admit I didn't really understand where it comes from ;-) Best regads, Chris --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Hq/RZioUZda/addrbook_sql2ldap.php Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

One more update for ru_RU translation
by Сергей Дукачёв (Sergey Dukachev) 26 Jul '10

26 Jul '10

Hello! Please update it. labels.inc is for RoundCube; plugins_ru_RU.patch is for help & password plugins. С уважением, Сергей Дукачёв (Sergey Dukachev) mailto:admin@mfitness.ru --------------------------- Отдел IT MFitness +7 (495) 974 1234 (доб. 106) --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Eh/ITKjEkdc/labels.inc http://detached.gigo.com/rc/Eh/ITKjEkdc/plugins_ru_RU.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Adding new column to mailbox listing
by David Harris 25 Jul '10

25 Jul '10

Hi, [[ I'm happy to work with a consultant to answer this and other questions, as per my previous email. However, Thomas suggested I send some questions to the dev list, so I'm doing that. ]] I want to modify roundcube to add a new column to the mailbox listing based on an X- header in the email messages, conditionally based on the mailbox name. I've found these functions involved in creating the message listing: program/steps/mail/func.inc:rcmail_message_list program/steps/mail/func.inc:rcmail_js_message_list It looks like the message list both printed as HTML and updated by javascript. I tired modifying their output to add some new columns, but the resulting display was really weird. The new column ended up to the right of the actual column listing, and I don't think had the right data. Just to see how the system works, I tried modifying the configuration $rcmail_config['list_cols'] and adding 'cc' or 'replyto' (both identified as supported columns) and they did not show up as new columns in the message listing. When I remove a column (such as 'date') it does disappear from the listing. I'd appreciate any pointers. I'm running roundcubemail-0.3.1. Thanks! David Harris DRH Internet Inc. 972-572-0900 _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev July 2010