Dev November 2012

dev@lists.roundcube.net

27 participants
37 discussions

Re: [RCD] [Svn] [roundcube/roundcubemail] e30500: Enable default behavior of the browser when shift/...
by Michael Heydekamp 15 Nov '12

15 Nov '12

Am 14.11.2012 10:30, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: e30500643fbe0c9f9237570b73e59992f776cf0c > > https://github.com/roundcube/roundcubemail/commit/e30500643fbe0c9f9237570b7… > Author: Thomas Bruederli <thomas(a)roundcube.net> > Date: 2012-11-14 (Wed, 14 Nov 2012) > > Changed paths: > M program/include/rcube_output_html.php > M program/js/app.js > > Log Message: > ----------- > Enable default behavior of the browser when shift/ctrl-click task links (e.g. open in new window/tab) Great, thanks! :) So this is related to http://trac.roundcube.net/ticket/1488800, right? Are you going to close it (I think I can't do this)? Greets, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

1 0

Update 0.8.4 is out
by Thomas Bruederli 14 Nov '12

14 Nov '12

Dear Roundcube lovers, We just published new packages for Roundcube webmail. This service update mainly fixes the nasty bug which sneaked into the last 0.8.3 release. In addition to that, we also packed some more fixes into this release, one of them a recently reported XSS vulnerability. The buggy previous version makes the compose screen to randomly reload itself which may result in a loss of the unsent message. So if you already installed 0.8.3, please immediately update your installation with this new version. Download it from http://roundcube.net/download We apologize for the inconvenience with the previous release! Best, Thomas

1 0

template engine
by Cor Bosman 13 Nov '12

13 Nov '12

Hey all, ive been wondering if we couldnt make a change to the way templates are rendered. If you look at the way this happens now, I think it's kinda backwards. Normally a plugin would call output->parse() to load a template, then inside the template add containers or objects to load data. Then this data is usually created inside php with kind of ugly code like: $out .= ''<div id="mydiv">'; This totally counteracts the reason for having templates! Wouldnt it be possible to add an associative data array to the parse function: $output->parse('my_plugin.my_template', $data); All elements inside the data array then get changed to variables that are usable inside the template. $data = { 'my_array' =>array('1','2','3'), 'my_var' => $var } So in the template you can say: ------- <div id="mydiv"> <ul> <?= foreach($my_array as $somevar) : ?> <li><?= $somevar ?></li> <? endforeach; ?> </ul> </div> ------- You can maybe do something similar using <roundcube:env..> but it seems no one actually uses that. Cor

1 0

keep-alive changes
by A.L.E.C 13 Nov '12

13 Nov '12

Digging into session issues I've found this keep-alive thing a little bit overcomplicated and unclear. The keep-alive setting handles two things: session keeping and new-mail checking. Some plugins also bind to keep-alive to do some recurring actions (e.g. to display calendar alarms, etc.). I think we should split these functionalities. So keep-alive action should be used only for session keeping. In such case we need to execute keep-alive action only after some inactivity time (e.g. session_lifetime - 1min [or 5%]). It means timer should be resetted on every reequest. Also it means we don't need a separate config option, because the interval would be calculated from session_lifetime. For session_lifetime=0 there would be no keep-alive requests. Another thing is recurring check for new-mail. This would work as is, but... see below. Last but not least. We should provide some "global" recurring action which would work across all tasks so, plugins could bind to it. One "global" action to minimize session race-conditions when few plugins will create their own recurring requests on the same time. In mail task we could "bind" our check-recent action to this global action. In my opinion this would be a much clearer solution and would give as some additional possibilities: - possibility to disable recurring checks (for new mail etc.) at all, - better overall performance because keep-alive out of mail task will be executed less frequently I think also, we could rename keep_alive option description ("Check for new messages on") into something like "Update system state (check for new mail, etc.) on", and move it to User Interface section, so we could use it as our global action interval. ps. I'm not sure we should change draft auto-save interval in any way to fit into this. For simplicity would be nice to use the same global action and its interval. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

3 8

adding topline to template_container hook
by Sébastien BLAISOT 11 Nov '12

11 Nov '12

Hi folks, Larry skin introduced topline (the line on top of screen showing About and support link on the left and username and logout link on the right). I want to make a plugin to add/change some information on that line without making a new skin. (first need is to add last login information) template_container hook seems to be just fine for that but unfortunately, this container doesn't exist in that call. Could it be possible to add that container to this hook ? Actually, I'm playing with template_object_username to change this part of the topline because it is not called anywhere else in larry skin, but I think this can broke other plugins or skins. regards, -- Sébastien BLAISOT

3 6

html autolink
by Sébastien BLAISOT 10 Nov '12

10 Nov '12

Hi all, When composing an HTML message with roundcube and writing an URL in the message body, it seems that this URL is not converted to link (i.e. it is not clickable) neither when composing the message nor when further viewing the sent message. It would be cool, IMHO, that roundcube can at least convert URL to link in one of this two situations. (so that users sending mail from roundcube to another roundcube user can juste copy/paste URLs when sending and just click the URL when receiving) The easy way is to enable the autolink plugin of tinyMCE (maybe with a configurable option like spelcheck). It is also possible to add some code to automatically convert URL to links when displaying HTML messages as it is done on plain text messages but I don't like this one as if HTML message contain a text which is not a link, this means that the sender don't want it to be a link. thunderbird act the first way (detecting URL and making them a link when sending) What do you think of that ? regards, S.B.

1 0

Plugins, Versioning - How does it work?
by till 10 Nov '12

10 Nov '12

Hello RoundCube-devs! To update everyone — we've been testing the setup for the plugin repository with a few people and since Sébastien emailed me with a couple questions, I wanted to take it on-list to inform more people. On Thursday, November 8, 2012 at 6:23 PM, sebastien BLAISOT wrote: > On Thursday, November 8, 2012 at 12:24 AM, Sébastien BLAISOT wrote: > > > Le 07/11/2012 14:20, till a écrit : > > > > > Hey, > > > > > > sounds good — please head over to http://plugins.roundcube.net, sign up and submit your plugin. > > > > > > It's a little rough around the edges, but should work. > > > > > > Thanks for helping! > > > > > > Hi, > > > > I've created an account but need some extra explanations before > > submiting the plugin. > > How is this plugin repository supposed to work ? does it pull the last > > version/revision of trunk ? or can I choose a particular revision ? > A plugin is essentially powered by the `composer.json` file. And this is how composer works (in a nutshell): * it takes the URL of the repository (git, svn, hg) * it scans all tags and branches (e.g. trunk/master) for `composer.json` files * it will use all tags/branches where it finds a `composer.json` file E.g. (for SVN): trunk/composer.json branches/super-feature/composer.json tags/1.0.0/composer.json tags/0.9.0/<no composer.json> The plugin repository would detect: * dev-trunk * dev-super-feature * 1.0.0 So once a `composer.json` is in trunk, it should get copied with each branch you create from trunk or each time you create a tag. This process works for git or hg as well. > > Will it be automatically updated everytime a commit is made ? Our current setup is that the cronjobs to update the site are run every 10 minutes. We can crank that up when required. When the cronjob runs, we scan your repository (see above). Why are all commits "used"? Because a commit is arbitrary and can mean all of the following: * updates to a file in trunk * creating a release (aka tag) * creating a branch > > This is a bit confusing for me right now and I don't want to make a mistake. > > My need is to control the release of future versions and not having each > > commit automatically pushed to users as they are not fully tested at the > > time of the commit. > You want your users to use tags and not a trunk/master branch — then not every commit will end up with the user. Let's say, in my local copy of RoundCube, I add the following to my (!) `composer.json`: "require": { "sebastien/plugin": "1.0.0" } This ensures that I stay on 1.0.0. This assumes that you wouldn't change the tag of course. ;-) With sane versioning and backward compatibility this shouldn't be an issue. E.g. I personally assume that a point release does not break everything or will require me to do changes that require more changes. So keeping this in mind, I could do something like: "require": { "sebastien/plugin": "1.0.*" } The above allows me to stay up to date with e.g. bug fixes. If I feel more "bleeding edge", I could rely on a branch (e.g. trunk) as well. But that's up to me/the user. On top of this, the user's composer uses a `composer.lock` file as well. This lock ensures what is installed: http://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file So once I `./composer.phar install`'ed a certain version from trunk, the lock ensures I get the same revision every time. The `composer.lock` is only updated when I `./composer.phar update`. > > Perhaps do I need to make a particular branch dedicated to releases ? Or > > can it be base on tagged revisions ? > Yes sir — you can actually do both. I personally prefer tags because it's fixed/done — a branch is always a moving target for me. > > > > Oh, and I'm using svn as source versionning system, not github. is this > > an issue ? > So, I personally prefer any kind of git. But composer also supports hg (Mercurial) and Subversion. > > > > Can you please explain it a bit ? > I hope I did with this email! :) Till

2 5

Update 0.8.3 released
by Thomas Bruederli 10 Nov '12

10 Nov '12

Dear subscribers Today we can announce another service release of the Roundcube webmail package. This update adds small bug fixes and improvements to the 0.8 stable series. It also fixes a possible, although unintended, DoS to the webserver running Roundcube. See http://trac.roundcube.net/wiki/Changelogfor details. We consider it stable and we recommend to update all existing Roundcube installation with this release. Download it from http://roundcube.net/download Have a nice weekend! Thomas

1 0

Line length for body wrapping
by Michael Heydekamp 10 Nov '12

10 Nov '12

Please apologize this possible silly question, but I'm not a PHP developer. In sendmail.inc, I see the following statement: > // set line length for body wrapping > $LINE_LENGTH = $RCMAIL->config->get('line_length', 72); Do I understand it correctly that RC first reads the setting "$rcmail_config['line_length']" in main.inc.php (which we have set to 76), and only if it does not exist, it will use a default value of 72? If so, that's good. And does this statement apply to un-quoted lines only (and only if format_flowed = false), or to both un-quoted and quoted lines? I just need to know which behaviour for un-quoted and quoted lines is the deliberate one, before I'm creating a senseless ticket in the bugtracker. Regards, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 1

How can I modify my default sender e-mail address?
by Holló Zoltán 10 Nov '12

10 Nov '12

Dear Roundcube Developers, Administrators, I have installed a roundcube webmail to my website: http://hollozoltan.extra.hu/roundcubemail/ But my webmail client use this e-mail address:no-reply@hollozoltan.extra.hu instead of my default e-mail address:hollozoltan@extra.hu In which configuration file can I modify these settings? I will look forward to hearing from you: Yours Faithfully, Zoltan Hollo

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev November 2012