Dev July 2012

dev@lists.roundcube.net

27 participants
21 discussions

keep-alive changes
by A.L.E.C 13 Nov '12

13 Nov '12

Digging into session issues I've found this keep-alive thing a little bit overcomplicated and unclear. The keep-alive setting handles two things: session keeping and new-mail checking. Some plugins also bind to keep-alive to do some recurring actions (e.g. to display calendar alarms, etc.). I think we should split these functionalities. So keep-alive action should be used only for session keeping. In such case we need to execute keep-alive action only after some inactivity time (e.g. session_lifetime - 1min [or 5%]). It means timer should be resetted on every reequest. Also it means we don't need a separate config option, because the interval would be calculated from session_lifetime. For session_lifetime=0 there would be no keep-alive requests. Another thing is recurring check for new-mail. This would work as is, but... see below. Last but not least. We should provide some "global" recurring action which would work across all tasks so, plugins could bind to it. One "global" action to minimize session race-conditions when few plugins will create their own recurring requests on the same time. In mail task we could "bind" our check-recent action to this global action. In my opinion this would be a much clearer solution and would give as some additional possibilities: - possibility to disable recurring checks (for new mail etc.) at all, - better overall performance because keep-alive out of mail task will be executed less frequently I think also, we could rename keep_alive option description ("Check for new messages on") into something like "Update system state (check for new mail, etc.) on", and move it to User Interface section, so we could use it as our global action interval. ps. I'm not sure we should change draft auto-save interval in any way to fit into this. For simplicity would be nice to use the same global action and its interval. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

3 8

PDO-based DB layer
by A.L.E.C 29 Oct '12

29 Oct '12

I've finished the new DB layer for Roundcube based on PHP PDO. It uses less memory (1.2 MB less) and should be faster than our old solution. The main differences: uses PDO modules, no prepared statements. Please, get 'pdo' branch and give it a try, so we could use this in 0.9. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

4 5

too late to offer feedback on larry?
by Benjamin Connelly 08 Aug '12

08 Aug '12

I hear 0.8 is almost ready to be released. Exciting (and anxiety producing ;) I really love the new artwork/icons, but below is a list of things I'd love to see improved with the skin before feeling comfortable rolling it out to our users. (I'm testing code grabbed daily using git clone https://github.com/roundcube/roundcubemail.git Is this the best way to test the latest changes?) 0) I have a 1024x768 display, and if I reset the zoom level (ctrl+0) in the browser, then the mailbox view (with or without preview pane) does not fit on the screen. A horizontal scroll bar appears, but who want's to have to scroll right just to see the "Settings" and "Logout" buttons, half of "Address Book" button, columns right of Date etc.? It takes two zoom out's (ctrl+-) to get to a point where the horizontal scroll bar goes away, but at that point the text is uncomfortably small. At 1280 this is not a problem. 1) In "Settings" at this 1024 resolution, a lot of the various sections create a horizontal scroll bar in the third (far right) pane. I think they layout of 3 columns is nifty, but also a lot of screen real estate gets wasted and all the content feels cramped to the right. Especially true with more complicated areas like the managesieve plugin's filter form. I actually prefer the old "tabs" for the first level of hierarchy in settings, then a two column view with plenty of room to work with the actual content in a wider right column. 2) I really like that Larry shows who you're logged in as, but that top bar with just "about" on the left and these items on the right also seems to consume a bit more real estate than it actually needs. 3) The next bar down is even thicker, and seems to create a big void of unusable space top center, pushing everything down. 4) With the status messages moved to the bottom of the screen means there is yet another blank bar down there most of the time, instead of sometimes using the empty real estate top center as the old skin did. 5) I actually prefer the way the old skin had a soft fading dividing line between the "Mail, Address Book, Settings, Logout" buttons, instead of being hard all the way across. And the gradient of this new "Mail, Address Book, Settings" button bar seems messy between the gorgeous light and dark grey linen textures (especially the way the active button has it's gradient reversed.) Couldn't they all just be the ligher grey linen texture? 6) The folder actions icon seems inordinately large. Also in Settings -> Folders and Identities, those similar icons (new identity, add a folder, folder actions) seem big to me. And in addressbook. 7) In composing messages, the body box seems cramped, and almost a little hard to know it's there, or where it is. (Old skin had nice thin black lines and clean white. Now I find myself squinting to make out subtly greyer areas around the various rectangles.) Is it possible to not have the attachments column to the right, unless the user has actually clicked the button above to "Attach" a file? (it also adds a redundant redundant "Attach a file" button.) 8) The new feature of having the addressbook contacts appear to the left seems nifty. Is it possible to expand them by default? Without clicking "Personal addreses", folks might not know how useful this can be ;) 9) The various blues and greys and just aren't doing it for me. It feels branded but not in our company's colors. Any hope for configurability, or something a little more neutral (whiter?) (Or perhaps we can just tweak the CSS to use different colors?) 10) "threads" vs "list" buttons are not super obvious to me which is active, and when clicked they seem to leave a dotted blue box around them going all the way to the left edge of the screen, until I click elsewhere? 11) when viewing a message not just in the preview pane (but by double clicking it) the "Back" button creates a strange vertical line to the left of it in the linen texture -- much like the "Reply All" and "Forward" buttons have to their right, but that's because they have drop down list options. This is a super duper minor critique. I feel terrible laying all this on what has been a tremendous effort! I just wanted to share my honest opinion / impression. Benjamin ben(a)electricembers.net

4 4

Remove user.alias column
by A.L.E.C 31 Jul '12

31 Jul '12

That column is used only for log in. The current behaviour allows only one alias. Also not every installation is using it at all. What I propose is to:[[BR]] 1. remove this column. 2. add an option which will search for the username in identities table. SELECT u.* FROM users.u JOIN identities i ON (i.user_id = u.user_id) WHERE email = ? LIMIT 1 So, this way searching for alias would be optional (which will improve performance, when not needed, e.g. there's a plugin which do alias mapping) and will give more possibilities. What I'm afraid of is that there's a use-case where alias is not an email address. http://trac.roundcube.net/ticket/1488581 -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

3 3

UI inconsistency
by Cor Bosman 31 Jul '12

31 Jul '12

hey all, I just noticed this small inconsistency. In settings->identities there is a trashcan to delete an identity, but settings->folders has a gear as a submenu. I think it would be more consistent if settings->folders had a trashcan at that icon area as well. Cor

2 4

Ready for the switch?
by Thomas Bruederli 27 Jul '12

27 Jul '12

Hello plugin developers et al! As previously announced and finally confirmed by the recent poll, the new Larry skin shall become the new default UI for Roundcube with the upcoming stable release 0.8. The most direct way to do that is to rename the skin folder from "larry" to default and make the current default to "legacy". The big drawback though is that all the plugins providing skin templates are also forced to do so. If we leave the old skin as "default", hardly anybody will benefit from the new skin unless the local config file is altered. As an alternative to the rough way proposed above, we could rename the current default folder to "legacy" and keep Larry as "larry" and instead resolve the config value "default" to "larry" within the code. While I prefer the rough way, I'd still like to hear some opinions from the plugin developers. Those using rcube_plugin::local_skin_path() shouldn't have any troubles no matter which way we choose. All the others please speak up or change your code :-) Best, Thomas

5 8

Some plan for a "local folder" ?
by Claudio Filho 26 Jul '12

26 Jul '12

Hi Exist some plan or plugin to do a "local folder", similar to Google Gear (?) ? I saw in other webmail client this resource and, for corporate client is a very nice feature, mainly when the user have a limited space and wish preserve his old emails. Thanks in advanced, Claudio

3 3

translation policy
by Jernej Porenta 24 Jul '12

24 Jul '12

Heya, What is the current policy for incorporating translations from launchpad to current source of Roundcube? I am asking this, because I've noticed that some of the translations from launchpad (e.g: Slovenian password plugin translation) do not come into the sources of Roundcube and users should take care of that (http://trac.roundcube.net/wiki/Doc_Plugins#Internationalization). Are there any plans to make this process easier on the users? Cheers, Jernej

4 3

Updated and corrected Catalan translation
by Jordi Sanfeliu 19 Jul '12

19 Jul '12

New messages.inc and labels.inc attached. Many thanks. -- Jordi Sanfeliu FIBRANET Network Services Provider http://www.fibranet.cat

2 1

Managesieve plugin - setting variables, patch
by Paweł Słowik 17 Jul '12

17 Jul '12

Currently the Managesieve plugin has no GUI for displaying variable definitions (RFC 5229). Variables from an existing script are parsed and saved correctly, but the GUI is blank. The attached patch adds a simple GUI. -- Paweł Słowik IQ PL Sp. z o.o.

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev July 2012