Dev November 2013

dev@lists.roundcube.net

13 participants
17 discussions

Re: [RCD] [Svn] [roundcube/roundcubemail] 0f4c9b: check if the new password matched the requirements
by Michael Heydekamp 08 Nov '13

08 Nov '13

Just wanted to confirm that the commit below appears to work (see screenshot attached). :) Just one thing: Is there any way to keep those AJAX messages (or however they are called) on the screen until they have been "clicked away" (or confirmed with the Enter key) by the user? Especially in this case that would make most sense as it takes some time to read (and understand) the message, but it does appear on the screen for just 7 seconds or so. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 04.11.2013 17:53, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: 0f4c9b850f665f0fdafb00809b4b9f100c59f331 > > https://github.com/roundcube/roundcubemail/commit/0f4c9b850f665f0fdafb00809… > Author: Till Krüss <me(a)tillkruess.com> > Date: 2013-10-15 (Tue, 15 Oct 2013) > > Changed paths: > M plugins/password/drivers/domainfactory.php > > Log Message: > ----------- > check if the new password matched the requirements; code cleanup > > > Commit: 910a3581be47da1d19eb15a68ea6b51c2c31ef67 > > https://github.com/roundcube/roundcubemail/commit/910a3581be47da1d19eb15a68… > Author: Till Krüss <me(a)tillkruess.com> > Date: 2013-10-15 (Tue, 15 Oct 2013) > > Changed paths: > M plugins/password/drivers/domainfactory.php > > Log Message: > ----------- > check if password was changed successfully, before looking for error messages > > > Commit: d4f27d90d57b62a833e643fa9e823d4a8aaa1dcf > > https://github.com/roundcube/roundcubemail/commit/d4f27d90d57b62a833e643fa9… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-11-04 (Mon, 04 Nov 2013) > > Changed paths: > M plugins/password/drivers/domainfactory.php > > Log Message: > ----------- > Merge pull request #136 from tillkruess/extend-df-password-driver > > Extend domainfactory password driver > > > Compare: > https://github.com/roundcube/roundcubemail/compare/a8b004e8d8f0...d4f27d90d… > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

2 3

Re: [RCD] [Svn] [roundcube/roundcubemail] e769a7: need to reset shift_start on control select
by Michael Heydekamp 07 Nov '13

07 Nov '13

Works on IE10. :) -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 05.11.2013 08:58, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: e769a7b588dde028a41cde482995601b63ad87b2 > > https://github.com/roundcube/roundcubemail/commit/e769a7b588dde028a41cde482… > Author: cmcnulty <cmcnulty(a)kznf.com> > Date: 2013-10-30 (Wed, 30 Oct 2013) > > Changed paths: > M program/js/list.js > > Log Message: > ----------- > need to reset shift_start on control select > > reproduce steps: shift-select some messages, hold down control and > select another message. hold down shift+control and select more > messages - desired behavior, two separate ranges of selected messages. > (consistent with outlook/thunderbird/windows explorer) > > > Commit: 5e3e4fe0c6f8e8ab1ff29ec685f127281700c953 > > https://github.com/roundcube/roundcubemail/commit/5e3e4fe0c6f8e8ab1ff29ec68… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-11-04 (Mon, 04 Nov 2013) > > Changed paths: > M program/js/list.js > > Log Message: > ----------- > Merge pull request #152 from cmcnulty/control-shift > > Reset shift_start on control select > > > Compare: > https://github.com/roundcube/roundcubemail/compare/04fbc555b939...5e3e4fe0c… > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 0

Re: [RCD] [Svn] [roundcube/roundcubemail] a8b004: Improve identity selection based on From: header (#1489378)
by Michael Heydekamp 07 Nov '13

07 Nov '13

This one appears to work as well now. Thanks a lot! As we finally seem to be done with all those different identity selection scenarios upon replying to a message: Is there any hope that we will be able to assign a default identity to an entry in the address book? Example: When I compose a new message to any Roundcube list, I still have to change the identity manually (and am sometimes missing that, so the message won't be delivered). Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 04.11.2013 11:20, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: a8b004e8d8f040d868e4b19da9527c177be9959d > > https://github.com/roundcube/roundcubemail/commit/a8b004e8d8f040d868e4b19da… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-11-04 (Mon, 04 Nov 2013) > > Changed paths: > M CHANGELOG > M program/steps/mail/func.inc > M tests/MailFunc.php > > Log Message: > ----------- > Improve identity selection based on From: header (#1489378) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 0

Keyboard navigation "fixes"
by Michael Heydekamp 04 Nov '13

04 Nov '13

I'm not sure what the intention of those several Ctrl+click fixes is and what the space bar should now do exactly, but Ctrl+click in the message list doesn't work in latest 1.0-git - at least not with IE10. It does still work in 0.9.5. Why don't you just leave it as it was? ;) Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 30.10.2013 14:45, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: bc35e865ae700b21ce6085aa33ba8354a2b09ac9 > > https://github.com/roundcube/roundcubemail/commit/bc35e865ae700b21ce6085aa3… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-10-30 (Wed, 30 Oct 2013) > > Changed paths: > M program/js/list.js > > Log Message: > ----------- > Fix Ctrl+click selection after recent refactorings of keyboard nawigation on list widget > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn Am 30.10.2013 12:53, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: 9806c72764e4c3f82f3b249b5456137662211e2d > > https://github.com/roundcube/roundcubemail/commit/9806c72764e4c3f82f3b249b5… > Author: cmcnulty <cmcnulty(a)kznf.com> > Date: 2013-10-29 (Tue, 29 Oct 2013) > > Changed paths: > M program/js/list.js > > Log Message: > ----------- > replace space bar with arrow key thread handling and switch spacebar to select messages > > > Commit: a8876fba93a1e52dd0daab6fa3b7b74fedbdc252 > > https://github.com/roundcube/roundcubemail/commit/a8876fba93a1e52dd0daab6fa… > Author: cmcnulty <cmcnulty(a)kznf.com> > Date: 2013-10-29 (Tue, 29 Oct 2013) > > Changed paths: > M program/js/list.js > > Log Message: > ----------- > Revert "simplify home/end key behavior" > > This reverts commit 3bef61232bc2e0e470a66dda6d88248100fdc36f. > > > Commit: 0fb8940d066fc6ecac5a8c97385380c152b69acd > > https://github.com/roundcube/roundcubemail/commit/0fb8940d066fc6ecac5a8c973… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-10-30 (Wed, 30 Oct 2013) > > Changed paths: > M program/js/list.js > > Log Message: > ----------- > Merge pull request #151 from cmcnulty/new-key-navigation > > Spacebar for message selection, left/right arrow for thread collapse/expand > > > Compare: > https://github.com/roundcube/roundcubemail/compare/c11a3f81acdc...0fb8940d0… > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

3 30

Purpose of change_identity JavaScript event trigger? (was: [Svn] [roundcube/roundcubemail] af61b9: Adds change_identity JavaScript event trigger)
by Michael Heydekamp 04 Nov '13

04 Nov '13

Hi there, may I ask what the intention of the commit quoted below exactly is...? Here it changed the behaviour of select_identity apparently in so far as the address in the From: header is now being selected as the identity, even if it does not match the full mailbox spec (name+address). This is in contradiction to what Alec recently wrote: ---------------------------------------------------------------------------- Am 14.10.2013 11:03, schrieb A.L.E.C: > On 10/14/2013 10:47 AM, Michael Heydekamp wrote: > >> Thanks. But are you sure about "From"? During my tests I didn't manage to >> select the identity in the From: header at all. The default identity had >> been selected instead (unless From: and Return-path: were identical). > > Well, From header check matches full mailbox spec., e.g. "Roundcube > Users <dev(a)lists.roundcube.net>". > > This is because we want to handle correctly situation when user has many > identities with same address but different name. It's not perfect and > I'm not saying we don't need an improvement here. ---------------------------------------------------------------------------- And an hour later, he wrote: ---------------------------------------------------------------------------- Am 14.10.2013 12:03, schrieb A.L.E.C: > For To/Cc the matching is different. We check addresses, but give bigger > prio to identity where address+name matches. So, here we're safe. > I suppose we could do the same for From with some more coding. Feel free > to create a ticket. ---------------------------------------------------------------------------- So I created a ticket: http://trac.roundcube.net/ticket/1489378 Is the commit below now the reaction to this ticket? Most likely not, as the ticket hasn't been closed yet. But the commit serves at least a part of the purpose of this ticket (= use From: header as identity even if it doesn't match full mailbox spec). So I'm not sure what's this all about, and if the result that I'm seeing is indeed intentional. Or am I wrong and the behaviour described above is related to a totally different commit...? Cheers, Michael (confused) -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 18.10.2013 21:40, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: af61b9705e40efa938bd38d95173a41cf210e6dc > > https://github.com/roundcube/roundcubemail/commit/af61b9705e40efa938bd38d95… > Author: Niklas Femerstrand <nik(a)qnrq.se> > Date: 2013-10-18 (Fri, 18 Oct 2013) > > Changed paths: > M program/js/app.js > > Log Message: > ----------- > Adds change_identity JavaScript event trigger > > > Commit: 771a82df9031485b3f9e7decf6b263c6847507b1 > > https://github.com/roundcube/roundcubemail/commit/771a82df9031485b3f9e7decf… > Author: Thomas B. <thomas(a)roundcube.net> > Date: 2013-10-18 (Fri, 18 Oct 2013) > > Changed paths: > M program/js/app.js > > Log Message: > ----------- > Merge pull request #139 from qnrq/master > > Adds change_identity JavaScript event trigger > > > Compare: > https://github.com/roundcube/roundcubemail/compare/1498ac81c946...771a82df9… > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

3 3

Plugins, $config and RC 1.0
by Michael Heydekamp 04 Nov '13

04 Nov '13

Hi there, we're unsure and a bit confused about how to handle the plugin configs in our 1.0-git test environment: 1) Almost all plugins do still use the legacy "$rcmail_config" array in their .dist file, rather than "$config". Do we need to manually run a search/replace across all config.inc.php(.dist)? 2) The plugin 'password' for instance does already use the "$config" array in it's config.php.dist. But this is not being reflected in config.inc.php (shouldn't there be some sort of automatism?). 3) Furthermore, the same plugin 'password' does contain a number of new config settings in .dist - but also those did not find their way into the .php file. So we have to merge them into .php as well? If so: Hmmm, I have seen (and even developed) more convenient and automated ways of updating configs already, but that was decades ago under DOS/16... ;) JFTR: The 'password' plugin is just an arbitrary example, the same may/will most likely apply to other plugins as well. But 'password' is just the first one where we recognized that "$config" is being used at least in the .dist file already. Any helpful advice appreciated. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

3 12

Regression upon right-clicking on message
by Michael Heydekamp 04 Nov '13

04 Nov '13

See attached: In 0.9.5, a sub-menu opens upon right-clicking and hovering the mouse on the "Mehr..." item. In 1.0-git, no such sub-menu opens. But it did still open a few days ago. <sigh> (Win7/64, IE10) Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

3 3

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev November 2013