Dev March 2013

dev@lists.roundcube.net

23 participants
26 discussions

Poll: HTML/Text switch vs. alternative part on attachments list
by A.L.E.C 23 Mar '13

23 Mar '13

So, now when we have nice HTML/Text switch (ability to toggle between html and plain text mode of message preview) we need to do something with "HTML message" attachment on attachments list. It looks redundant, or at least inconsistent. I see two solutions: 1. Don't add alternative parts to attachments list. Ie. there will be no "HTML message" on attachments list in case of a message with alternative parts. +1 from me. 2. In html mode add text part to attachments list, in text mode add html part to attachments list. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

5 4

Poll: Reply-All and Reply-To header
by A.L.E.C 23 Mar '13

23 Mar '13

You can check the behavior by clicking Reply All button (not Reply List) on this message. Example message from our mailing list contains headers: To: dev(a)lists.roundcube.net Reply-To: dev(a)lists.roundcube.net From: original(a)poster.tld So, current behavior is that you end up with one recipient dev(a)lists.roundcube.net in To field. Thunderbird for example, will add original(a)poster.tld in Cc field. So, the problem is related to Reply-To header handling. Poll: 1. Keep current behavior. 2. If To: and Reply-To: are the same and From: is different - add From: address to Cc field. I prefer current solution (1). Because I think that if Reply-To is defined a senders intention is to not receive replies to his From: address, no matter if Reply, Reply-All or Reply-List is used. I however understand that "private reply" to poster is sometimes wanted. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

7 11

Re: [RCD] Top-posting and signature below the quote
by Arne Berglund 21 Mar '13

21 Mar '13

On 03/21/2013 01:40, A.L.E.C wrote: > According to short discussion in > http://trac.roundcube.net/ticket/1489001 I see that it is possible to > set top-posting with signature below the quote. It sounds confusing > and > useless. > > Now when we have "When replying" option (reply_mode) I propose to > remove > "When replying or forwarding place signature" option (sig_above). > Signature position should be always below the reply text (not the > quote) > and reply_mode already defines this position. > > reply_mode=0 -> reply below the quote with sig below the reply text > reply_mode=1 -> reply above the quote with sig below the reply text > > Any objections? My organization (and our users) support this change 100%. Fewer useless and confusing user options is a good thing. -- Arne Berglund System Administrator, Internet Services Lane Education Service District Eugene, OR ____________

1 0

"Save this draft" doesn't (always) save
by Michael Heydekamp 20 Mar '13

20 Mar '13

Scenario: - Select a message in the Sent folder - Choose "Edit as new" - Click on "Save this draft" - Exit/close the message - Look in the Drafts folder: Surprosingly, the message is not there I found out that something needs to be changed in the message (i.e. set the dirty flag) before you can manually save it as a draft. That makes sense for the auto-save function, but if I manually want to save a message (just to put it in the draft folder for instance, see above), a missing dirty flag shouldn't prevent me from doing that, IMO. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 1

Fwd: Re: [RCU] Line wrapping f*cked up upon forwarding - why?
by Michael Heydekamp 17 Mar '13

17 Mar '13

As there was still no reply to the attached message of Jan 19th yet, I'd just like to mention that this issue does still persist in 1.0-git (just verified it). It should be easy to fix, if my assumption stated at the end of the attached message should be correct. It's IMO just a counting error. The reason why I forwarded the message as an attachment (rather than quoting it inline) is that I wanted to make sure that the line wrapping doesn't get f*cked up even more and that the format will be exactly preserved. As I'm still running against this wall several times a day, a fix would be welcome and highly appreciated. I'm BTW seeing a similar behaviour upon editing a draft message, but hopefully this will have the same cause, so I'll just wait until this particular forwarding issue will be fixed. Should it then still apply to draft messages as well, I'll of course report. The entire thread can be read in the RCU list. Cheers (and thanks again to all developers of the best webmail client ever), -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

1 0

Text/HTML toggle
by Michael Heydekamp 17 Mar '13

17 Mar '13

Missed a bit the latest RC developments, due to other tasks that I had to follow during the last wekks/months. But just now I realize that we finally have a Text/HTML toggle at the very right of the display of the subject header line. Just great, thanks to all who have contributed to this! Of course I tested it instantly, and found the following: 1) It seems to be stored somewhere which part had lastly been viewed for a particular message, am I seeing this correct...? And if so, how and where is this (safely) being stored? I'm wondering if RC shouldn't first and always display the part according to the setting "Display HTML" under "Displaying Messages" after selecting back and forth between messages (would look more consistent to me)? 2) Toggling between Text and HTML part seems to work flawlessly (using the icon at the right of the subject header). 3) But: Viewing the Text part, there is still the well-known link "HTML message" below the header. Viewing the HTML part, opposed to this there is (still) no correspondent link "Text message" below the header. Anyway, the still existing link "HTML message" is sort of redundant to the toggle at the right of the subject header. This should be more consistent (either showing an additional link below the header always or never, no matter which part is being viewed). I would prefer a link below the header ONLY anyway (as the icon at the right of the subject header is hard to detect and the text "HTML message" or "Text message" is more user-friendly, better visible and better understandable than those - pretty small - icons). Alternatively, both toggles should exist. The least solution from my point of view would be to have JUST these icons. 4) There is a problem when I'm viewing the Text part and click on the above mentioned and still existing link "HTML message" below the header: The HTML part is being displayed, but the display of the header disappears entirely (see screenshot comparison attached). 5) At a first quick test, it seems that a reply does quote the part which is currently being viewed. Is this correct and intentional? If so: Great! Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 8

"Show" link doesn't work at all anymore?!
by Michael Heydekamp 15 Mar '13

15 Mar '13

Besides all those problems already discussed, the "Show" link of picture attachments doesn't now work at all anymore. <sigh> The link right below the header DOES still work, though. The differences between the links are: Link right below the header: ---------------------------- <roundcube-URL>/?_task=mail&_framed=1&_action=get&_mbox=Sent&_uid=6818&_part=2&_frame=1 "Show" link: ------------ <roundcube-URL>/?_task=mail&_uid=6818&_mbox=Sent&_action=get&_part=2 Does that help...? RC 0.9-git [GIT 20130313.1902], IE8. -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 1

[PATCH] show full email along with display name (#1488732)
by Jan Fader 15 Mar '13

15 Mar '13

Hi Roundcube-Devs I have created a patch for trac-ticket #1488732 and testet it successfully on my instance roundcube.git. Could you please take a look at this new feature, provide suggestions if needed or include it into your maintree? Kind regards Jan Signed-off-by: Jan Fader <jan.fader(a)web.de> --- CHANGELOG | 1 + program/localization/en_GB/labels.inc | 1 + program/steps/mail/func.inc | 15 ++++++++++++++- program/steps/settings/func.inc | 11 +++++++++++ program/steps/settings/save_prefs.inc | 1 + 5 files changed, 28 insertions(+), 1 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 6fef2d0..729510a 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,6 +1,7 @@ CHANGELOG Roundcube Webmail =========================== +- show full email along with display name (#1488732) - Fix HTML part detection for some specific message structures (#1488992) - Don't show fake address - phishing prevention (#1488981) - Fix forward as attachment bug with editormode != 1 (#1488991) diff --git a/program/localization/en_GB/labels.inc b/program/localization/en_GB/labels.inc index fb9ebe3..c7bdd09 100644 --- a/program/localization/en_GB/labels.inc +++ b/program/localization/en_GB/labels.inc @@ -393,6 +393,7 @@ $labels['pagesize'] = 'Rows per page'; $labels['signature'] = 'Signature'; $labels['dstactive'] = 'Summer time'; $labels['showinextwin'] = 'Open message in a new window'; +$labels['show_fullemail'] = 'Show full email along with display name'; $labels['composeextwin'] = 'Compose in a new window'; $labels['htmleditor'] = 'Compose HTML messages'; $labels['htmlonreply'] = 'on reply to HTML message only'; diff --git a/program/steps/mail/func.inc b/program/steps/mail/func.inc index 137e87d..7d821fe 100644 --- a/program/steps/mail/func.inc +++ b/program/steps/mail/func.inc @@ -1463,13 +1463,26 @@ function rcmail_address_string($input, $max=null, $linked=false, $addicon=null, } else if (check_email($part['mailto'], false)) { if ($linked) { - $address = html::a(array( + $user_prefs=$RCMAIL->user->get_prefs(); + if ($user_prefs['message_show_fullemail']) { + $address = html::a(array( + 'href' => 'mailto:'.$mailto, + 'onclick' => sprintf("return %s.command('compose','%s',this)", JS_OBJECT_NAME, JQ($mailto)), + 'title' => $mailto, + 'class' => "rcmContactAddress", + ), + + Q($name? sprintf('"%s" %s',$name,$mailto): $mailto)); + } + else { + $address = html::a(array( 'href' => 'mailto:'.$mailto, 'onclick' => sprintf("return %s.command('compose','%s',this)", JS_OBJECT_NAME, JQ($mailto)), 'title' => $mailto, 'class' => "rcmContactAddress", ), Q($name ? $name : $mailto)); + } } else { $address = html::span(array('title' => $mailto, 'class' => "rcmContactAddress"), diff --git a/program/steps/settings/func.inc b/program/steps/settings/func.inc index 2f726c7..59104a3 100644 --- a/program/steps/settings/func.inc +++ b/program/steps/settings/func.inc @@ -418,6 +418,17 @@ function rcmail_user_prefs($current=null) ); } + // show checkbox to show full email instead of name + if (!isset($no_override['message_show_fullemail'])) { + $field_id = 'rcmfd_message_show_fullemail'; + $input_msgshowfullemail = new html_checkbox(array('name' => '_message_show_fullemail', 'id' => $field_id, 'value' => 1)); + + $blocks['main']['options']['message_show_fullemail'] = array( + 'title' => html::label($field_id, Q(rcube_label('show_fullemail'))), + 'content' => $input_msgshowfullemail->show($config['message_show_fullemail']?1:0), + ); + } + // show checkbox for HTML/plaintext messages if (!isset($no_override['prefer_html'])) { $field_id = 'rcmfd_htmlmsg'; diff --git a/program/steps/settings/save_prefs.inc b/program/steps/settings/save_prefs.inc index 5daab0d..765c2f5 100644 --- a/program/steps/settings/save_prefs.inc +++ b/program/steps/settings/save_prefs.inc @@ -60,6 +60,7 @@ switch ($CURR_SECTION) case 'mailview': $a_user_prefs = array( 'message_extwin' => intval($_POST['_message_extwin']), + 'message_show_fullemail' => isset($_POST['_message_show_fullemail']) ? TRUE : FALSE, 'prefer_html' => isset($_POST['_prefer_html']) ? TRUE : FALSE, 'inline_images' => isset($_POST['_inline_images']) ? TRUE : FALSE, 'show_images' => isset($_POST['_show_images']) ? intval($_POST['_show_images']) : 0, -- 1.6.0.2

2 1

test
by A.L.E.C 15 Mar '13

15 Mar '13

test after mail server problems. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

1 0

RE : Re: Debugging
by sebastien BLAISOT 13 Mar '13

13 Mar '13

Thanks for the feedback. Can you tell us what server you are using and what you did (code changing or server conf you added in order for rc to work) to let us know ? Maybe there is some code to change or a doc to write for this particular server ? -- Sébastien BLAISOT -------- Message d'origine -------- De : Guido Berhoerster <guido+roundcube.net(a)berhoerster.name> Date : A : dev(a)lists.roundcube.net Objet : Re: [RCD] Debugging * Sébastien BLAISOT <sebastien(a)blaisot.org> [2013-03-12 19:38]: > Is the logs directory of your roundcube installation writable by your > apache user ? > > the logs usually are here, but this directory have to be writable to the > user running the web server. I'm not using apache but the logs directory is owned by the same user the server runs as and in fact the sql log that I cited was created there. The actual problem was that the server was corrupting request variables so that the request token went missing. I only found out after looking through the code and inserting my own debug statements here and there, the built-in logging mechanisms simply does not log anything in this case making it very hard to diagnose what's going on. -- Guido Berhoerster _______________________________________________ Roundcube Development discussion mailing list dev(a)lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev

2 1

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev March 2013