Dev July 2013

dev@lists.roundcube.net

13 participants
19 discussions

The identities_list hook
by Philipp Kewisch 12 Jul '13

12 Jul '13

Hello Folks, I have a question regarding the identities_list hook. I would like to replace the full list of identities by my own using a plugin. It seems to me the identities_list hook is only used for display, as the original identities from the database are added. Is this just an oversight, or is it supposed to be that way? I would like to propose to make use of the identities_list hook more often. The ideal solution would be to query the plugin hook in rcube_user.php's list_identities, returning the plugin defined list of identities everywhere. The only downside is that the current caller in program/steps/settings/func.inc will have to query the plugin twice, once directly to get the array of columns and once indirectly via rcube_user.php. I'm happy to provide the patch myself, I would just like to ask here before I send a PR. Alternatively, is there another way to intercept the identities and user management? We would like to use our own user management backend. Philipp

2 9

merge sessions between owncloud and roundcube
by Michée Lengronne 12 Jul '13

12 Jul '13

Hello, I have an owncloud and a roundcube sharing the same session pool via a memcache server and I would like them to work with an unique session. I changed the cookie session.name to have the same for owncloud and roundcube and I tried a lot of tricks: to pass the session id then the session name via url, to change the $_SESSION['user_id' in roundcube because owncloud has the same variable, to avoid the cookie creation in the session_init from roundcube, etc... But, the roundcube session always erase the owncloud one which causes owncloud not to login anymore. What is the trick ? Is there a method somewhere to do that ? Thanks. PS: I use the 'RoundcubeLogin.class.php <http://blog.philippheckel.com/uploads/2008/05/RoundcubeLogin.class.phps>' to perform the login from owncloud to roundcube but it creates separate sessions for each. -- Signature Michée Lengronne Coppint Michée Lengronne ------------------------------------------------------------------------ Ce message et ses éventuelles pièces jointes sont personnels, confidentiels et à l'usage exclusif de leur destinataire. Si vous n'étes pas la personne à laquelle ce message est destiné, veuillez noter que vous avez reçu ce courriel par erreur et qu'il vous est strictement interdit d'utiliser, de diffuser, de transférer, d'imprimer ou de copier ce message. This e-mail and any attachments hereto are strictly personal, confidential and intended solely for the addressee. If you are not the intended recipient, be advised that you have received this email in error and that any use, dissemination, forwarding, printing, or copying of this message is strictly prohibited. ------------------------------------------------------------------------ Logo CopPInt 30440 Saint Laurent le Minier France *Compagnie pour des Prestations Internet* Téléphone personnel : +41 (0)791 94 71 98 Téléphone professionnel : +33 (0) 4 84 25 23 67 poste 102 Téléphone professionnel : 0805 696 8 9 0 poste 102 France uniquement Courriel : michee.lengronne(a)Coppint.com <mailto:michee.lengronne@coppint.com> ------------------------------------------------------------------------

1 0

Inserting images in HTML messages with <Ctrl+V>
by Michael Heydekamp 10 Jul '13

10 Jul '13

What we just realized here: Inserting an image with <Ctrl+V> in an HTML message does work with Firefox and Cyberfox, but not with: - Chrome - IE8 - IE10 Roundcube or browser issue?? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

1 0

Folders tab not accessible in git-master anymore (was: [Svn] [roundcube/roundcubemail] e89d8f: Performance fix: Do not ask for folder attributes if we know that folder do not exists)
by Michael Heydekamp 09 Jul '13

09 Jul '13

In git-master, the folders tab is not accessible anymore (no matter which user is logged in). FF does display a blank page (as a FF user is telling me), IE8 is throwing a HTTP 500 along with a message that the page can't be displayed (see attached). I assume it has to do with the change quoted below. In 0.9.2, all is still working fine. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 09.07.2013 18:57, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: e89d8f1fec3743e9ee1018d3bab1a375ab79cebf > > https://github.com/roundcube/roundcubemail/commit/e89d8f1fec3743e9ee1018d3b… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-07-09 (Tue, 09 Jul 2013) > > Changed paths: > M program/steps/settings/folders.inc > > Log Message: > ----------- > Performance fix: Do not ask for folder attributes if we know that folder > do not exists > > > Commit: 95a18fa549c9576b7035d27ef1712c5dfd01422d > > https://github.com/roundcube/roundcubemail/commit/95a18fa549c9576b7035d27ef… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-07-09 (Tue, 09 Jul 2013) > > Changed paths: > M plugins/help/help.js > M plugins/help/help.php > M plugins/help/skins/classic/help.css > M plugins/help/skins/classic/templates/help.html > M plugins/help/skins/larry/templates/help.html > > Log Message: > ----------- > Merge branch 'master' of github.com:roundcube/roundcubemail > > > Compare: > https://github.com/roundcube/roundcubemail/compare/d8e10161098d...95a18fa54… > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 0

Logic of identity selection
by Michael Heydekamp 09 Jul '13

09 Jul '13

I need to cover some quite special scenarios here in terms of identity selection, and therefore wanted first to understand the current logic how an identity is being selected (in order to implement a correct and working patch later on). I got stuck already at first attempt. Say we have the following two messages with their headers (please don't ask why there are two headers "Envelope-To:", just please take it as a matter of fact): Message #1: ---------------------------------------------- Delivery-date: Sat, 06 Jul 2013 20:29:21 +0200 Return-path: <theo1(a)tester.de> Envelope-To: identity1(a)test.de Envelope-To: identity2(a)test.de MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 06 Jul 2013 20:29:21 +0200 From: theo1(a)tester.de To: theo2(a)tester.de Subject: Test #1 (Envelope-To: identity1(a)test.de, Envelope-To: identity2(a)test.de) Message-ID: <identity1(a)tester.de> X-Sender: theo1(a)tester.de User-Agent: Roundcube Webmail/1.0-git Test - pls ignore. ---------------------------------------------- Message #2: ---------------------------------------------- Delivery-date: Sat, 06 Jul 2013 20:29:21 +0200 Return-path: <theo1(a)tester.de> Envelope-To: identity2(a)test.de Envelope-To: identity1(a)test.de MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 06 Jul 2013 20:29:21 +0200 From: theo1(a)tester.de To: theo2(a)tester.de Subject: Test #1 (Envelope-To: identity2(a)test.de, Envelope-To: identity1(a)test.de) Message-ID: <identity2(a)tester.de> X-Sender: theo1(a)tester.de User-Agent: Roundcube Webmail/1.0-git Test - pls ignore. ---------------------------------------------- Please also take it as a matter of fact that "identity1(a)test.de" and "identity2(a)test.de" are being defined as identities in Roundcube. The main difference between these two messages is the order of the "Envelope-To:" headers. But apparently that doesn't make any difference at all, as when replying to these messages, the identity "identity1(a)test.de" is being used as the sender in the "From:" header in both cases. Hmm...?!? This logic escapes me and makes my life more difficult, as this behaviour is telling me that the order (of both the same headers in the same message!) doesn't make any difference. Is the choice being taken because of the alphabetical order of the sender addresses (so that "identity1(a)test.de" is preceding "identity2(a)test.de")? At this point I stopped testing, and my next question is: As I'm able to create any custom header right before delivery, how can I make sure that this - and only this - custom header will be respected with regards to identity selection, disregarding any other headers/addresses and the entire rest of the logic...? This would be a private patch, of course. Any help and hint appreciated, for I'm a noob in terms of PHP (= I have an idea of the logic, but just can't code it). Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

3 9

quote chars not recognized as quote chars in HTML parts?
by Michael Heydekamp 09 Jul '13

09 Jul '13

Received a multipart/alternative message today, produced with Roundcube 0.9.2 stable (first part text/plain, second part text/html), where the quote chars ">" in the HTML part were not recognized as quote chars upon displaying in RC 1.0-git. See display comparison attached. The HTML code of the relevant paragraph (additionally qp-encoded, charset UTF-8): > > --------------------------------------------------- > >> =E2=94=82 /usr/share/vim/vim73/syntax > >> =E2=94=82 fetchmail.vim > >> =E2=94=82 /usr/share/vim/vim73/ftplugin > >> =E2=94=82 fetchmail.vim > >> =E2=94=82 /usr/share/zsh/4.3.15/functions/Completion/Unix > >> =E2=94=82 _fetchmail > > --------------------------------------------------- Is the displayed result of the HTML part how it should be...? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 9

Re: [RCD] [Svn] [roundcube/roundcubemail] 3b944e: Fix bug where signature wasn't changed on identity selection when editing a draft (#1489229)
by Michael Heydekamp 08 Jul '13

08 Jul '13

Thanks alec, works for me! Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 08.07.2013 10:53, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: 3b944edb02a838e92f5f849b1266f157ccfb7040 > > https://github.com/roundcube/roundcubemail/commit/3b944edb02a838e92f5f849b1… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-07-08 (Mon, 08 Jul 2013) > > Changed paths: > M CHANGELOG > M program/js/app.js > M program/steps/mail/compose.inc > > Log Message: > ----------- > Fix bug where signature wasn't changed on identity selection when > editing a draft (#1489229) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 0

Re: [RCD] [Svn] [roundcube/roundcubemail] c3762a: Fix folder names truncation in Classic skin (#1489220)
by Michael Heydekamp 05 Jul '13

05 Jul '13

Am 04.07.2013 11:20, schrieb GitHub: > Log Message: > ----------- > Fix folder names truncation in Classic skin (#1489220) Thanks! But well, they're shortened rather than trucated (at least in IE8), that's how it should be, right? > Fix bug where not all event handlers were executed (because body onload > was executed after rcmail init function, sometimes) Interesting... Which possible and visible bugs (could) have occurred due to this? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 2

Re: [RCD] bb5d72: Use also Envelope-To for identity selection (#1488...
by Michael Heydekamp 02 Jul '13

02 Jul '13

Currently Roundcube uses "Envelope-To:" and "Delivered-To:" for identity selection (besides "To:" and probably other standard headers). After we recently moved from a dedicated server to a managed server at df.eu (domainfactory), all messages do not have a header "Envelope-To:" anymore, but a header "X-Envelope-To:" instead. This often leads to a wrong identity selection (e.g. always when replying to the Roundcube lists). May I kindly request to support the header "X-Envelope-To:" as well? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 12.12.2012 08:55, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: bb5d7282855dd83ccdd211cb77d0776dce71468e > > https://github.com/roundcube/roundcubemail/commit/bb5d7282855dd83ccdd211cb7… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2012-12-11 (Tue, 11 Dec 2012) > > Changed paths: > M CHANGELOG > M program/lib/Roundcube/rcube_storage.php > M program/steps/mail/compose.inc > > Log Message: > ----------- > Use also Envelope-To for identity selection (#1488553) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

3 6

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev July 2013