Dev August 2013

dev@lists.roundcube.net

17 participants
13 discussions

Codebase cleanup, PSR-1/2 compliance - and before you say no, I'm offering to do the work
by David Deutsch 25 Sep '13

25 Sep '13

Hey everybody, I'm David and I would like to help out. Starting on any project, it's usually best to get familiar with the codebase. Now - I really enjoy combing through and cleaning up codebases and that's usually a great way to do just that. To give an example, I've recently done this to RedBeanPHP, you can check out the details here: Discussion: https://groups.google.com/forum/#!topic/redbeanorm/S8EnZTIZPDE Repository: https://github.com/gabordemooij/redbean Pull Requests: https://github.com/gabordemooij/redbean/pull/281 https://github.com/gabordemooij/redbean/pull/282 https://github.com/gabordemooij/redbean/pull/289 So - in a nutshell, that's what I'm offering to do for Roundcube. Examples, picked at random: /plugins/archive/archive.php Original: https://github.com/roundcube/roundcubemail/blob/master/plugins/archive/arch… Cleanup: https://gist.github.com/daviddeutsch/6285028 /installer/rcube_install.php Original: https://github.com/roundcube/roundcubemail/blob/master/installer/rcube_inst… Cleanup: https://gist.github.com/daviddeutsch/6285286 /program/lib/Roundcube/rcube_vcard.php Original: https://github.com/roundcube/roundcubemail/blob/master/program/lib/Roundcub… Cleanup: https://gist.github.com/daviddeutsch/6285504 All as one commit: https://github.com/daviddeutsch/roundcubemail/commit/568051120f98070b554bc0… I like code concise and self explanatory. I think if there are more than three indents (within a function), you can usually simplify the code and make it easier to understand while you're at it. I actually, weirdly, enjoy a 80 character line limit and while I usually prefer tabs (I disagree with PSR-2 on that), I'm fine coding with 4 spaces for indentation. I'd be happy to accommodate to special customs, of course, although I do think that sticking to PSR - flawed as it may be in spots - really helps enable collaboration by convention. Let me know if this sounds like something that would at all be welcome in this project. best regards, David Deutsch

15 97

Larry: improved attachment preview page?
by A.L.E.C 02 Sep '13

02 Sep '13

While I work on a new plugin for files management. I found that we could improve our current attachment preview page. I'm attaching a screenshot from my plugin. I'd like to make attachment preview page to look the same, i.e. attachment properties on the left and toolbar with buttons (Download for now, but we could add other e.g. Print, Save, Edit). What do you think? An opposite layout would be to make it more looking as message preview page with properties on top and small buttons in right-top corner (and no toolbar). I however, prefer the solution with toolbar. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

3 4

Address book display bug when email type is "main" [0.9.2]
by Rob Sheldon 30 Aug '13

30 Aug '13

One of my customers did an Outlook export / Roundcube import of his contacts, and none of the contacts were displaying their email address in the address book's vcard section. In the database, all of his contacts had been saved with, "EMAIL;TYPE=INTERNET;TYPE=MAIN:address@host.com". My contacts for example are, "EMAIL;TYPE=INTERNET;TYPE=OTHER:address@host.com". Changing TYPE=OTHER to TYPE=MAIN in one of my contacts caused that one to also not display correctly. I traced this back to program/steps/addressbook/func.inc: 29c29 < 'email' => array('type' => 'text', 'size' => 40, 'maxlength' => 254, 'label' => rcube_label('email'), 'subtypes' => array('home','work','other'), 'category' => 'main'), --- > 'email' => array('type' => 'text', 'size' => 40, 'maxlength' > => 254, 'label' => rcube_label('email'), 'subtypes' => > array('home','work','other','main'), 'category' => 'main'), ...but I'm not sure if this is generally desired behavior or not, so I'm posting here for discussion instead of trac. Thanks, - R. -- [__ Robert Sheldon [__ No Problem [__ Information technology support and services [__ (530) 575-0278

2 7

Re: [RCD] suggested new features
by Matee Moshkovits 29 Aug '13

29 Aug '13

hi guys COR BOSMAN WROTE: > THIS COULD BE DONE WITH A PLUGIN. AND I EVEN THINK THERE ALREADY IS A PLUGIN FOR THAT? > OR DOESNT LARRY HAVE HOOKS FOR A SPOT TO PUT THE REMEMBER ME HTML? > > COR I tried Larry it looks good but I can not find the hook, also that assumes that people are not using other skins and that all Admins are PHP smart to enable the hook as well as install plugins I was thinking of having it as an admin config thing .... config.php so it will exist on every skin and be idiot proof ARNE BERGLUND WROTE: > How is this different than the built-in option for browser auth caching? > > // Allow browser-autocompletion on login form. > // 0 - disabled, 1 - username and host only, 2 - username, host, > password > $rcmail_config['login_autocomplete'] = 0; > > -- > Arne Berglund > System Administrator, Internet Services > Lane Education Service District > Eugene, OR not all browsers have a good working auto-complete, (Internet Exploder 6.0 - 8.0, Opera (All versions), Android Browser (pre: Ice Cream Sandwitch)) and of those that do, how many people think that remember my password is a bad idea ... this gives a choice where it only does the username ... and not the password .... so if the admin has browser auth caching turned off (obviously a security aware admin) it still works ... -- If you have any questions, please do not hesitate to contact our office. Thank you Matee Moshkovits Chief Technology Officer AffordHost Inc. Tel: 416-238-7698 ext. 225 E-mail: mmmoshko(a)affordhost.com

2 2

Roundcube 0.9.3 - iframes scrollbars
by Rosali 28 Aug '13

28 Aug '13

I'm testing with Chrome 29.0.1547.57 m. I get an unnecessary scrollbars for all iframes (preview pane, settings iframe) - Larry skin. I have fixed it by including on global level some js stuff: // iframes $('iframe').height('99%'); NOTE: It happens without any plugins active. By default iframes have the following css properties: element.style { width: 100%; height: 100%; } It looks like height 100% is causing the issue. Anyone else with such issues? Is it a known issue? -- Rosali MyRoundcube Dev Team

2 1

suggested new features
by Matee Moshkovits 28 Aug '13

28 Aug '13

hi Roundcube Master I have been using roundcube for a few years now ... and lurking on the developers list for a few months. I run a hosting company, for the last 9 years we have been using squirrel mail (squirrely mail is the name our help desk have given it). We have not adopted Round cube because it is missing 2 very key features: - Multiple Folder search (just like the search in Thunderbird or Outlook (I feel dirty now that I wrote Roundcube and Thunderbird on the same line as a MS want to be mail program) - "Remember me" - a feature that I have written a patch for that lets the user save the USERNAME on the machine (see: http://newwebmail.affordhost.com) - I can provide the code for this is you wish ... As I appreciate your program I hope to help make it better .... Thank you. -- If you have any questions, please do not hesitate to contact our office. Thank You Matee Moshkovits Chief Technology Officer AffordHost Inc. Direct Telephone: (416)273-9914 Office Telephone: (416)238-7698 x 225 Email: mmmoshko(a)affordhost.com Business-Class Web Hosting at Affordable Prices

3 2

Update 0.9.3 released
by Thomas Bruederli 23 Aug '13

23 Aug '13

Hello folks We can proudly announce the third service release for the stable 0.9 series of Roundcube webmail. It fixes 25 more bugs including two recently reported XSS vulnerabilities with HTML messages and signatures. Along with that, we also optimized the UI behavior for touch devices to make Roundcube work nice and smoothly on tablets running iOS or Android. It's considered stable and we recommend to update all productive installations of Roundcube with this version. Download it from http://roundcube.net/download, see the full changelog here:http://trac.roundcube.net/wiki/Changelog Kind regards, Thomas

3 2

Re: [RCD] Move identity selection based on non-standard headers into (new) identity_select plugin (#1488553)
by Michael Heydekamp 18 Aug '13

18 Aug '13

Where can I download this plugin (the whole package, I mean, not every single file through GitHub)? Couldn't find it on plugins.roundcube.net ... Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 04.08.2013 10:41, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: b825f86108a91957f6467176e418cfc257874658 > > https://github.com/roundcube/roundcubemail/commit/b825f86108a91957f6467176e… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-08-04 (Sun, 04 Aug 2013) > > Changed paths: > M CHANGELOG > A plugins/identity_select/identity_select.php > A plugins/identity_select/package.xml > A plugins/identity_select/tests/IdentitySelect.php > M program/lib/Roundcube/rcube_storage.php > M program/steps/mail/func.inc > > Log Message: > ----------- > Move identity selection based on non-standard headers into (new) identity_select plugin (#1488553) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

2 1

Strange link, not fully being recognized as a link in plain text messages
by Michael Heydekamp 17 Aug '13

17 Aug '13

Yesterday, somebody sent me that link in a plain text message: https://rapidshare.com/#!download|856p1|2938527513|EngNewsBlinkfeedPatch.zi… Roundcube doesn't fully recognize that as a link (only until "download"). Then he sent me the same link in a HTML message, there it is fully being recognized. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

4 5

Re: [RCD] [Svn] [roundcube/roundcubemail] 9263f5: Ignore Reply-To when replying to own message (#148...
by Michael Heydekamp 17 Aug '13

17 Aug '13

Thanks, Alec! :-) -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 05.08.2013 09:15, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: 9263f55a634cafc805307a138f3f2d54df1faa21 > > https://github.com/roundcube/roundcubemail/commit/9263f55a634cafc805307a138… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-08-05 (Mon, 05 Aug 2013) > > Changed paths: > M program/steps/mail/compose.inc > > Log Message: > ----------- > Ignore Reply-To when replying to own message (#1489230) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev August 2013