From steinhof@umich.edu Thu Oct  9 19:15:06 2008
From: Kris Steinhoff <steinhof@umich.edu>
To: dev@lists.roundcube.net
Subject: [RCD] New window for compose
Date: Thu, 09 Oct 2008 22:14:57 -0400
Message-ID: <bd3888db94bc2db37e6107c578cceb6c@umich.edu>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4716287805995661338=="

--===============4716287805995661338==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable


We (the University of Michigan) launched RoundCube today as a webmail
option. In this first day, more that 20,000 users have tried RoundCube for
the first time. We have received a lot of feedback, the much of it is
enthusiastically positive.

Many people have asked that a separate window be used for message
composition. We=20
are looking into implementing this functionality. I've created a ticket in
trac:

http://trac.roundcube.net/ticket/1485486

Does anyone have any perspective or guidance they'd like to share about=20
implementing this?

many thanks
-kris


See also:
http://lists.roundcube.net/mail-archive/dev/2008-10/0000010.html
http://roundcubeforum.net/requests/3362-compose-optionally-open-new-window.ht=
ml


--
Kris Steinhoff
Web/DB Team
Information Technology Central Services
The University of Michigan
_______________________________________________
List info: http://lists.roundcube.net/dev/

--===============4716287805995661338==--


From nullchar@gmail.com Fri Oct 10 17:40:40 2008
From: gnul <nullchar@gmail.com>
To: dev@lists.roundcube.net
Subject: Re: [RCD] New window for compose
Date: Fri, 10 Oct 2008 18:40:33 -0600
Message-ID: <95c99b0e0810101740k727e8917ided4b369b0e3c4e3@mail.gmail.com>
In-Reply-To: <bd3888db94bc2db37e6107c578cceb6c@umich.edu>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4398376824029622049=="

--===============4398376824029622049==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Since 'compose in a new window' works via middle-click (or
right-click, open in new window/tab), it certainly is possible.

I have no idea about the Right Way to do this.. A proper solution
would probably involve modifying the skin so that the compose window
does not include the taskbar, and that the Back and Cancel buttons
close the window.

Unfortunately, due to the event handlers attached to the anchor (<a
href=3D"./?_task=3Dmail&amp;_action=3Dcompose" ...), you can't simply add
the "rel" attribute or a class, then use some simple javascript to set
the anchor's target attribute to "_blank".  (I tried but it didn't
work for me.)

I'm still using 0.1, but I think the key is this function in program/js/app.j=
s:
  this.redirect =3D function(url, lock) {...}

You probably to add an additional parameter to that function to open
URLs in a new window.  Then you would need some way to pass that
parameter in when constructing the compose action.  Finally, based on
the "newwindow" parameter, instead of the default "location.href =3D
url;", you would call "window.open(url)".

As a quick and dirty hack, I modified the function, just to test this out:

  this.redirect =3D function(url, lock)
  {
    if (lock || lock =3D=3D=3D null)
      this.set_busy(true);

    if (this.env.framed && window.parent) {
      parent.location.href =3D url;
    }
    else {
      if (/_action=3Dcompose/.test(url)) // HACK!! Don't do it this way!
        window.open(url);
      else
        location.href =3D url;
    }
  };


However, personally I enjoy that roundcube stays in one window, and if
I choose to open a new window via middle-click, I can.  (That is how I
prefer most of the web, as window.open() is often blocked to prevent
pop-ups.)

good luck.
 -gnul


On Thu, Oct 9, 2008 at 8:14 PM, Kris Steinhoff <steinhof(a)umich.edu> wrote:
>
> We (the University of Michigan) launched RoundCube today as a webmail
> option. In this first day, more that 20,000 users have tried RoundCube for
> the first time. We have received a lot of feedback, the much of it is
> enthusiastically positive.
>
> Many people have asked that a separate window be used for message
> composition. We
> are looking into implementing this functionality. I've created a ticket in
> trac:
>
> http://trac.roundcube.net/ticket/1485486
>
> Does anyone have any perspective or guidance they'd like to share about
> implementing this?
>
> many thanks
> -kris
>
>
> See also:
> http://lists.roundcube.net/mail-archive/dev/2008-10/0000010.html
> http://roundcubeforum.net/requests/3362-compose-optionally-open-new-window.=
html
>
>
> --
> Kris Steinhoff
> Web/DB Team
> Information Technology Central Services
> The University of Michigan
> _______________________________________________
> List info: http://lists.roundcube.net/dev/
>
_______________________________________________
List info: http://lists.roundcube.net/dev/

--===============4398376824029622049==--