From roundcube@gmail.com Sat Jul 14 15:57:34 2007
From: Thomas Bruederli <roundcube@gmail.com>
To: dev@lists.roundcube.net
Subject: Re: SVN 439/440; settings dialog
Date: Wed, 03 Jan 2007 22:36:35 +0100
Message-ID: <459C21E3.2000200@gmail.com>
In-Reply-To: <459BC5F2.4020904@introweb.nl>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7865150184558049099=="

--===============7865150184558049099==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

My fault. Mixed up multibyte substring functions with non-multibyte
strrpos calls.

Fixed in rev. 445

~Thomas


Robin Elfrink wrote:
> Hi,
> 
> 
> SVN 440 introduced a bug that prevents me from clicking the 'Save'
> button on the settings page. I found that on my system rc_substr uses
> mb_substr now, and somehow that causes following change in output of the
> HTML:
> 
> ====================================
> --- substr.html 2007-01-03 15:59:19.582425500 +0100
> +++ mb_substr.html      2007-01-03 15:59:02.676391900 +0100
> @@ -173,7 +173,8 @@
> 
>  </script>
> 
> -<script type="text/javascript">
> +</body>
> +</<script type="text/javascript">
>  <!--
> 
>  if (window.call_init)
> ====================================
> 
> 
> Now I have absolutely no experience with multibyte strings, so somebody
> else will have to figure out why mb_substr() causes to add '</body>' and
> one too many '</' to the HTML output.
> 
> 
> 
> Robin
> 
> 


--===============7865150184558049099==--