- Dev - Roundcube mailing lists

Conditional HTML and preview pane
by Robin Elfrink 20 Nov '07

20 Nov '07

Hi, Another go at a preview pane. I implemented conditional HTML which works like this: <roundcube:if condition="config:preview==true" /> html bla bla <roundcube:else /> other html bla bla <roundcube:endif /> The preview code was mostly Thomas', plus a bit of myself to let the user decide for herself. Code is not yet optimized, so it looks like poo, and I suspect IE6 will have problems, because I delete some CSS which made it look strange in IE7. Robin Index: config/main.inc.php.dist =================================================================== --- config/main.inc.php.dist (revision 380) +++ config/main.inc.php.dist (working copy) @@ -228,5 +228,11 @@ // save compose message every 300 seconds (5min) $rcmail_config['draft_autosave'] = 300; +// Enable preview pane +$rcmail_config['enable_preview'] = FALSE; + +// Default setting if preview pane is enabled +$rcmail_config['preview'] = FALSE; + // end of config file ?> Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 380) +++ program/include/main.inc (working copy) @@ -1106,9 +1106,8 @@ return FALSE; } - // parse for specialtags - $output = parse_rcube_xml($templ); + $output = parse_rcube_xml(parse_rcube_conditions($templ)); $OUTPUT->write(trim(parse_with_globals($output)), $skin_path); @@ -1269,6 +1268,48 @@ } +// parse conditional code +function parse_rcube_conditions($input) + { + global $CONFIG; + if (($matches = preg_split('/<roundcube:(if|elseif|else|endif)\s+([^>]+)>/is', $input, 2, PREG_SPLIT_DELIM_CAPTURE)) && + (count($matches)==4)) + { + if (preg_match('/^(else|endif)$/i', $matches[1])) + return $matches[0] . '' . parse_rcube_conditions($matches[3]); + else + { + $attrib = parse_attrib_string($matches[2]); + if (isset($attrib['condition']) && + preg_match('/^(session|config):([a-zA-Z0-9_]+)([=<>!]+)(.*)$/i', $attrib['condition'], $opts)) + { + $condmet = false; + if ($opts[1]=='session') + $condmet = eval("return (\$_SESSION['" . $opts[2] . "']" . $opts[3] . "'" . $opts[4] . "');"); + elseif ($opts[1]=='config') + $condmet = eval("return (\$CONFIG['" . $opts[2] . "']" . $opts[3] . "'" . $opts[4] . "');"); + $submatches = preg_split('/<roundcube:(elseif|else|endif)\s+([^>]+)>/is', $matches[3], 2, PREG_SPLIT_DELIM_CAPTURE); + if ($condmet) + $result = $submatches[0] . preg_replace('/.*<roundcube:endif\s+[^>]+>/is', '', $submatches[3]); + else + $result = '<roundcube:' . $submatches[1] . $submatches[2] . $submatches[3]; + return $matches[0] . '' . parse_rcube_conditions($result); + } + else + { + raise_error(array('code' => 500, + 'type' => 'php', + 'line' => __LINE__, + 'file' => __FILE__, + 'message' => "Unable to parse conditional tag " . $matches[2]), TRUE, FALSE); + } + } + } + else + return $input; + } + + // create and register a button function rcube_button($attrib) { Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 380) +++ program/localization/en_US/labels.inc (working copy) @@ -211,6 +211,7 @@ $labels['dstactive'] = 'Daylight savings'; $labels['htmleditor'] = 'Compose HTML messages'; $labels['htmlsignature'] = 'HTML signature'; +$labels['preview'] = 'Show preview pane'; $labels['autosavedraft'] = 'Automatically save draft'; $labels['everynminutes'] = 'every $n minutes'; Index: program/js/app.js =================================================================== --- program/js/app.js (revision 380) +++ program/js/app.js (working copy) @@ -151,8 +151,15 @@ this.enable_command('firstmessage', true); } } + + // make preview/message frame visible + if (this.env.action == 'preview' && this.env.framed && parent.rcmail) + { + this.enable_command('compose', 'add-contact', false); + parent.rcmail.show_messageframe(true); + } - if (this.env.action=='show' && this.env.blockedobjects) + if ((this.env.action=='show' || this.env.action=='preview') && this.env.blockedobjects) { if (this.gui_objects.remoteobjectsmsg) this.gui_objects.remoteobjectsmsg.style.display = 'block'; @@ -637,7 +644,7 @@ case 'load-images': if (this.env.uid) - this.show_message(this.env.uid, true); + this.show_message(this.env.uid, true, this.env.action=='preview'); break; case 'load-attachment': @@ -667,22 +674,22 @@ case 'nextmessage': if (this.env.next_uid) - this.show_message(this.env.next_uid); + this.show_message(this.env.next_uid, false, this.env.action=='preview'); break; case 'lastmessage': if (this.env.last_uid) - this.show_message(this.env.last_uid); + this.show_message(this.env.last_uid, false, this.env.action=='preview'); break; case 'previousmessage': if (this.env.prev_uid) - this.show_message(this.env.prev_uid); + this.show_message(this.env.prev_uid, false, this.env.action=='preview'); break; case 'firstmessage': if (this.env.first_uid) - this.show_message(this.env.first_uid); + this.show_message(this.env.first_uid, false, this.env.action=='preview'); break; case 'checkmail': @@ -1052,6 +1059,9 @@ this.msglist_select = function(list) { + if (this.preview_timer) + clearTimeout(this.preview_timer); + var selected = list.selection.length==1; if (this.env.mailbox == this.env.drafts_mailbox) { @@ -1063,16 +1073,25 @@ this.enable_command('show', 'reply', 'reply-all', 'forward', 'print', selected); this.enable_command('delete', 'moveto', list.selection.length>0 ? true : false); } + + // start timer for message preview (wait for double click) + if (selected && this.env.contentframe) + this.preview_timer = setTimeout(this.ref+'.msglist_get_preview()', this.dblclick_time + 10); + else if (this.env.contentframe) + this.show_messageframe(false); }; this.msglist_dbl_click = function(list) { + if (this.preview_timer) + clearTimeout(this.preview_timer); + var uid = list.get_single_selection(); if (uid && this.env.mailbox == this.env.drafts_mailbox) this.goto_url('compose', '_draft_uid='+uid+'&_mbox='+urlencode(this.env.mailbox), true); else if (uid) - this.show_message(uid); + this.show_message(uid, false, false); }; @@ -1085,18 +1104,29 @@ }; + this.msglist_get_preview = function() + { + var uid = this.get_single_uid(); + if (uid && this.env.contentframe) + this.show_message(uid, false, true); + else if (this.env.contentframe) + this.show_messageframe(false); + }; + + /*********************************************************/ /********* (message) list functionality *********/ /*********************************************************/ // when user doble-clicks on a row - this.show_message = function(id, safe) + this.show_message = function(id, safe, preview) { var add_url = ''; + var action = preview ? 'preview': 'show'; var target = window; - if (this.env.contentframe && window.frames && window.frames[this.env.contentframe]) + if (preview && this.env.contentframe && window.frames && window.frames[this.env.contentframe]) { target = window.frames[this.env.contentframe]; add_url = '&_framed=1'; @@ -1107,13 +1137,27 @@ if (id) { - this.set_busy(true, 'loading'); - target.location.href = this.env.comm_path+'&_action=show&_uid='+id+'&_mbox='+urlencode(this.env.mailbox)+add_url; + var url = '&_action='+action+'&_uid='+id+'&_mbox='+urlencode(this.env.mailbox)+add_url; + if (action == 'preview' && String(target.location.href).indexOf(url) >= 0) + this.show_messageframe(true); + else + { + this.set_busy(true, 'loading'); + target.location.href = this.env.comm_path+url; + } } }; + this.show_messageframe = function(show) + { + var frm; + if (this.env.contentframe && (frm = rcube_find_object(this.env.contentframe))) + frm.style.display = show ? 'block' : 'none'; + }; + + // list a specific page this.list_page = function(page) { Index: program/steps/settings/func.inc =================================================================== --- program/steps/settings/func.inc (revision 380) +++ program/steps/settings/func.inc (working copy) @@ -155,6 +155,16 @@ rep_specialchars_output(rcube_label('htmleditor')), $input_htmleditor->show($CONFIG['htmleditor']?1:0)); + if ($CONFIG['enable_preview']) + { + $field_id = 'rcmfd_preview'; + $input_preview = new checkbox(array('name' => '_preview', 'id' => $field_id, 'value' => 1)); + $out .= sprintf("<tr><td class=\"title\"><label for=\"%s\">%s</label></td><td>%s</td></tr>\n", + $field_id, + rep_specialchars_output(rcube_label('preview')), + $input_preview->show($CONFIG['preview']?1:0)); + } + if (!empty($CONFIG['drafts_mbox'])) { $field_id = 'rcmfd_autosave'; @@ -242,4 +252,4 @@ } -?> \ No newline at end of file +?> Index: program/steps/settings/save_prefs.inc =================================================================== --- program/steps/settings/save_prefs.inc (revision 380) +++ program/steps/settings/save_prefs.inc (working copy) @@ -29,6 +29,8 @@ $a_user_prefs['pagesize'] = is_numeric($_POST['_pagesize']) ? (int)$_POST['_pagesize'] : $CONFIG['pagesize']; $a_user_prefs['prefer_html'] = isset($_POST['_prefer_html']) ? TRUE : FALSE; $a_user_prefs['htmleditor'] = isset($_POST['_htmleditor']) ? TRUE : FALSE; +if ($CONFIG['enable_preview']) + $a_user_prefs['preview'] = isset($_POST['_preview']) ? TRUE : FALSE; $a_user_prefs['draft_autosave'] = isset($_POST['_draft_autosave']) ? intval($_POST['_draft_autosave']) : 0; // MM: Date format toggle (Pretty / Standard) Index: program/steps/mail/show.inc =================================================================== --- program/steps/mail/show.inc (revision 380) +++ program/steps/mail/show.inc (working copy) @@ -34,8 +34,14 @@ // go back to list if message not found (wrong UID) if (!$MESSAGE['headers'] || !$MESSAGE['structure']) { - $_action = 'list'; - return; + show_message('messageopenerror', 'error'); + if ($_action=='preview' && template_exists('messagepreview')) + parse_template('messagepreview'); + else + { + $_action = 'list'; + return; + } } $MESSAGE['subject'] = $IMAP->decode_header($MESSAGE['headers']->subject); @@ -131,28 +137,6 @@ -// return an HTML iframe for loading mail content -function rcmail_messagecontent_frame($attrib) - { - global $COMM_PATH, $OUTPUT, $GET_URL, $JS_OBJECT_NAME; - - // allow the following attributes to be added to the <iframe> tag - $attrib_str = create_attrib_string($attrib); - $framename = 'rcmailcontentwindow'; - - $out = sprintf('<iframe src="%s" name="%s"%s>%s</iframe>'."\n", - $GET_URL, - $framename, - $attrib_str, - rcube_label('loading')); - - - $OUTPUT->add_script("$JS_OBJECT_NAME.set_env('contentframe', '$framename');"); - - return $out; - } - - function rcmail_remote_objects_msg($attrib) { global $CONFIG, $OUTPUT, $JS_OBJECT_NAME; @@ -177,8 +161,10 @@ } -if ($_action=='print') +if ($_action=='print' && template_exists('printmessage')) parse_template('printmessage'); +else if ($_action=='preview' && template_exists('messagepreview')) + parse_template('messagepreview'); else parse_template('message'); -?> \ No newline at end of file +?> Index: program/steps/mail/func.inc =================================================================== --- program/steps/mail/func.inc (revision 380) +++ program/steps/mail/func.inc (working copy) @@ -481,6 +481,7 @@ $javascript .= sprintf("%s.set_env('pagecount', %d);\n", $JS_OBJECT_NAME, ceil($message_count/$IMAP->page_size)); $javascript .= sprintf("%s.set_env('sort_col', '%s');\n", $JS_OBJECT_NAME, $sort_col); $javascript .= sprintf("%s.set_env('sort_order', '%s');\n", $JS_OBJECT_NAME, $sort_order); + $javascript .= sprintf("%s.set_env('preview', '%s');\n", $JS_OBJECT_NAME, $CONFIG['enable_preview'] && $CONFIG['preview']); if ($attrib['messageicon']) $javascript .= sprintf("%s.set_env('messageicon', '%s%s');\n", $JS_OBJECT_NAME, $skin_path, $attrib['messageicon']); @@ -558,6 +559,28 @@ } +// return an HTML iframe for loading mail content +function rcmail_messagecontent_frame($attrib) + { + global $OUTPUT, $JS_OBJECT_NAME; + + if (empty($attrib['id'])) + $attrib['id'] = 'rcmailcontentwindow'; + + // allow the following attributes to be added to the <iframe> tag + $attrib_str = create_attrib_string($attrib, array('id', 'class', 'style', 'src', 'width', 'height', 'frameborder')); + $framename = $attrib['id']; + + $out = sprintf('<iframe name="%s"%s></iframe>'."\n", + $framename, + $attrib_str); + + $OUTPUT->add_script("$JS_OBJECT_NAME.set_env('contentframe', '$framename');"); + + return $out; + } + + // return code for search function function rcmail_search_form($attrib) { Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 380) +++ skins/default/templates/mail.html (working copy) @@ -42,6 +42,22 @@ </div> +<roundcube:if condition="config:preview==true" /> +<div id="mailcontframe" class="preview"> +<roundcube:object name="messages" + id="messagelist" + cellspacing="0" + summary="Message list" + messageIcon="/images/icons/dot.png" + unreadIcon="/images/icons/unread.png" + deletedIcon="/images/icons/deleted.png" + repliedIcon="/images/icons/replied.png" + attachmentIcon="/images/icons/attachment.png" /> +</div> +<div id="mailpreviewframe"> +<roundcube:object name="messagecontentframe" id="messagecontframe" width="100%" height="100%" frameborder="0" src="/watermark.html" /> +</div> +<roundcube:else /> <div id="mailcontframe"> <roundcube:object name="messages" id="messagelist" @@ -53,6 +69,7 @@ repliedIcon="/images/icons/replied.png" attachmentIcon="/images/icons/attachment.png" /> </div> +<roundcube:endif /> <div id="listcontrols"> <roundcube:label name="select" />:  Index: skins/default/templates/messagepreview.html =================================================================== --- skins/default/templates/messagepreview.html (revision 0) +++ skins/default/templates/messagepreview.html (revision 0) @@ -0,0 +1,19 @@ +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> +<head> +<title><roundcube:object name="pagetitle" /></title> +<link rel="stylesheet" type="text/css" href="/common.css" /> +<link rel="stylesheet" type="text/css" href="/mail.css" /> +</head> +<body class="iframe"> + +<div class="messageheaderbox"> +<roundcube:object name="messageHeaders" class="headers-table" cellspacing="0" cellpadding="2" addicon="/images/icons/plus.gif" summary="Message headers" /> +<roundcube:object name="messageAttachments" id="attachment-list" /> +</div> + +<roundcube:object name="blockedObjects" id="remote-objects-message" /> +<roundcube:object name="messageBody" id="messagebody" /> + +</body> +</html> Index: skins/default/mail.css =================================================================== --- skins/default/mail.css (revision 380) +++ skins/default/mail.css (working copy) @@ -117,10 +117,34 @@ overflow: auto; /* css hack for IE */ width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); - height: expression((parseInt(document.documentElement.clientHeight)-125)+'px'); } +#mailcontframe.preview { + bottom: auto; + height: 210px; +} +#mailpreviewframe +{ + position: absolute; + top: 300px; + left: 200px; + right: 40px; + bottom: 40px; + border: 1px solid #999999; + background-color: #F9F9F9; + /* css hack for IE */ + width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); + height: expression((parseInt(document.documentElement.clientHeight)-340)+'px'); +} + +#messagecontframe +{ + width: 100%; + height: 100%; + border: 0; +} + #messagepartframe { border: 1px solid #999999; Index: index.php =================================================================== --- index.php (revision 380) +++ index.php (working copy) @@ -262,7 +262,7 @@ { include_once('program/steps/mail/func.inc'); - if ($_action=='show' || $_action=='print') + if ($_action=='show' || $_action=='preview' || $_action=='print') include('program/steps/mail/show.inc'); if ($_action=='get')

2 3

Korean translation file
by Kim Hanjo 20 Nov '07

20 Nov '07

Hi all, This is my first message for this mailing list. Please have the attachment file, localization for Korean. I use this file in my own installation. Hanjo Kim http://lordmiss.com --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/FB/Yoxtw11f/kr.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

"Supported" browsers
by chasd 15 Nov '07

15 Nov '07

At the link <http://trac.roundcube.net/wiki/Howto_Requirements> Only this is mentioned for browser requirements : * Javascript enabled * Accept cookies * Support for XMLHttpRequest Since I have some users on old or odd platforms, I was wondering if there should be a list of "tested" browsers. This may be incorrect, but from reading the Dev mail list, it seems the main developers test on the major browsers. IMHO it seems that RoundCube is "tested" on IE 6 ( Win XP ) and 7 ( Win XP and Vista ) Safari 2 ( OS X 10.4.x ) and 3 ( OS X 10.4.x and 10.5.x, Win XP, Vista ) Firefox 2 ( Win XP, OS X 10.4.x ) Should that specifically be mentioned in the browser requirements ? Are there others that are smoketested by Devs ? If other browsers are known to work by users, those could be added to a "reported to work" section, so there is not an implication those browsers are regularly used by the Devs. I think Opera 9 is used by others on the Dev list, and I use Camino, although always the very latest release. Maybe there should also be a "known not to work" section so bugs don't get filed that will likely never be addressed ? I realize that if IE 6 works, you have covered almost every Windows user, but the Mac platform has had many different browsers available for it, and many different versions of those. Sadly each with differing capabilities as far as HTML, CSS, and ECMAScript support. Such browsers would be Safari 1.2x or 1.0.x ( OS X 10.3.x, 10.2.x ), Firefox 1.0.x or 1.5.x, Mozilla Suite ( Mac OS 9 ), IE 4.x ( Mac OS 9 ), iCab, etc. Charles Dostale System Admin - Silver Oaks Communications http://www.silveroaks.com/ 824 17th Street, Moline IL 61265 _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

Re: [RCD] iPhone usability
by markevich＠inbox.lv 15 Nov '07

15 Nov '07

Hello, Joel. I’m not completely sure that Iphone’s Safari browser is absolutely the same as desktop one. As far as I know all mobile versions have limited functionality because of architecture limitations. Anyway further analysis should be done on this but only few people are having Iphone so there is might be a problem in testing and fixing of this possible problem. If you are agree to participate in the development and make some tests and coding you are highly welcomed. In other case I don’t think that it’s possible to investigate and fix this problem now. Regards, Andris > From: Joel Clermont > Subject: Re: [RCD] iPhone usability > To: Drarok Ithaqua > Cc: RoundCube Dev > Message-ID: > Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes > > The issues I ran into with using RoundCube via an iPhone was the > inability to double click and drag/drop. > > In my case, I support the mail server, so it's not just about getting > access to my mailbox. Sometimes it's nice to be able to bring up > RoundCube on the road to check a problem in someone else's mailbox. > Fixing the UI gotchas for the iPhone should not be a huge ordeal. The > app itself renders fine, it is just some of the behaviors that are not > available.. > > Joel Clermont > 262-377-9930 > joel(a)orionweb.net -- Tavs bezmaksas pasts Inbox.lv _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] "Supported" browsers
by markevich＠inbox.lv 15 Nov '07

15 Nov '07

Hello, Charles. I was using Firefox 2.x (Windows, Linux), Opera 9.x (Windows, Linux), Internet Explorer. Everything was working fine except for 1 annoying bug in the latest release that's denies to login on Firefox. I don't think that browser names should be displayed in the requirements, because there are a lot of differences in the browsers engine realization (even in the same family). The key here is to specify generic functionality that is used in the Roundcube that at least must be supported in order to work. If we’ll add some browser’s names to the list it would mean that we’ll give support obligations to the community to 100% support for these browsers and it wouldn’t be right. My advice is to keep things like they are now – if your browser is supporting specified functions in the requirement it should work, if it’s supporting and not working – create ticket and we’ll try to investigate the problem. I agree that there is should be a list with the browsers that were reported as working/non-working but definitely not in the requirements section but may be at the bottom of the page. Regards, Andris > Date: Wed, 14 Nov 2007 09:31:48 -0600 > From: chasd > Subject: [RCD] "Supported" browsers > To: RoundCube Dev > Message-ID: > Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed > > At the link > > > Only this is mentioned for browser requirements : > > * Javascript enabled > * Accept cookies > * Support for XMLHttpRequest > > Since I have some users on old or odd platforms, I was wondering if > there should be a list of "tested" browsers. > This may be incorrect, but from reading the Dev mail list, it seems > the main developers test on the major browsers. > > IMHO it seems that RoundCube is "tested" on > > IE 6 ( Win XP ) and 7 ( Win XP and Vista ) > Safari 2 ( OS X 10.4.x ) and 3 ( OS X 10.4.x and 10.5.x, Win XP, Vista ) > Firefox 2 ( Win XP, OS X 10.4.x ) > > Should that specifically be mentioned in the browser requirements ? > Are there others that are smoketested by Devs ? > > If other browsers are known to work by users, those could be added to > a "reported to work" section, so there is not an implication those > browsers are regularly used by the Devs. > I think Opera 9 is used by others on the Dev list, and I use Camino, > although always the very latest release. > Maybe there should also be a "known not to work" section so bugs > don't get filed that will likely never be addressed ? > I realize that if IE 6 works, you have covered almost every Windows > user, but the Mac platform has had many different browsers available > for it, and many different versions of those. Sadly each with > differing capabilities as far as HTML, CSS, and ECMAScript support. > Such browsers would be Safari 1.2x or 1.0.x ( OS X 10.3.x, 10.2.x ), > Firefox 1.0.x or 1.5.x, Mozilla Suite ( Mac OS 9 ), IE 4.x ( Mac OS > 9 ), iCab, etc. > Charles Dostale > System Admin - Silver Oaks Communications > http://www.silveroaks.com/ > 824 17th Street, Moline IL 61265 -- Tavs bezmaksas pasts Inbox.lv _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Session handler with custom session-methods are not thread-safe.
by Micha 15 Nov '07

15 Nov '07

Hi to all. I discovered a problem with the login, where after some logins and logouts, every new Login-Attempt kicked me back to the login screen. Without any mention of a problem in the logs. I searched the forum and found that some users experienced similar problems. After some debugging I found the weak point. The problem is, that the sess_read and sess_write methods that are used during logout and also used from the periodical mail checking process, are not "synchronized" (thread-safe). So it is possible that the two events occur at the same time: The events occur in the following order: 1. Logout calls sess_read 2. Periodical Mail Check calls sess_read 3. Logout calls sess_write (with $vars (temp|b:1)) 4. Periodical Mail Check calls sess_write ($vars without temp) Step 4 ("mail check") overwrites the Session-Parameters from Step 3 ("logout"). The concrete problem in this case is the temp-Parameter. Next login, session_start reads in the session parameter, where "temp" must be true, to start a new session. Otherwise when ("temp" == false), roundcube expects a valid session and tries to resume that session. (In index.php $_SESSION['temp'] will be checked but fails.) The only way a new login is possible, is to reset the cookies (restart IE and delete cookies in Firefox). >From my point of view, the session handlers (session_start(), session_destroy() and session_regenerate_id()) must be atomic. So the session handler must have exclusive access to the custom session methods in session.inc. Micha. _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Filters Patch
by emi＠algorismia.com 15 Nov '07

15 Nov '07

Hi all!! Here is the filter patch. There are some differences between the svn copy I took last week and the one I did the patch diff with, but I think these are minor changes. If finally you want the gziped src (not patched), tell me. Take a look!! emi --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Yk/KCtBesrs/RC_Filters_patch.txt.gz Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Diff'ing filters
by emi＠algorismia.com 15 Nov '07

15 Nov '07

Hi!! Thomas said me to use 'svn diff' to make the filters patch, but with this option new files are not taken. How can I add them into the patch? Or just add the patch & new files into a .tar.gz? Thanks for all! emi _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] Filters
by markevich＠inbox.lv 14 Nov '07

14 Nov '07

Hello, Emi. I completely agree with Michael, that there are a lot of implementation questions that are not so easily solvable. You should always take in mind that Roundcube is only a client and use filters on all content only in it is not right way to do. All mails are stored on the IMAP server and all filtering should be done there also. Just imagine, not all users check there mails every day or keeping mail client open all the time, it’s normal to have 100 unread messages, so filter should be run at least at the startup causing peak loads on the server (web+imap) and how do you plan to check existing mails for filtering ( was filters applied to this message or no? ) I think that you are heading to the wrong direction. I’m planning to implement my own filters but I will do it in a bit different way. I would create independent table for storing filter data and new preference page would be created for filter management. That’s all that goes for web related stuff. Than external script will be created (for ex. perl) which will fetch data from the table and convert it to the according MDA (mail delivery agent) format for the according mailbox. Such scheme is necessary because not always (in real environment the percentage is about 70-80%) IMAP server with all mailboxes resides on the same file system as Roundcube. In my case they reside on a different machines and I’m unable to access directly mailboxes from the Roundcube. So we have external script that will run for ex. from cron job to generate MDA scripts for mail transferring from the filter table data. All parsing will spread across the working time without any peak loads. I suppose we could cooperate on this task and maybe something usable come out of it. Everything that written above is my IMHO and shouldn’t be taken personally, just FYI. Regards, Andris > From: emi(a)algorismia.com > Subject: [RCD] Filters > To: dev(a)lists.roundcube.net > Message-ID: > Content-Type: text/plain;charset=iso-8859-1 > > Hi there!! > I've made a filters function (in early version) for roundcube. I've > done over the svn version of last week. The modifications uses a new > SQL table, filters, wich can be filled as done with identities. Then it > filters messages using this filters, on rcmail_js_message_list and > rcmail_message_list. > > I've seen some discussion on why not to do it, if doing internally or > with sieve or with .forward or so. Look, I've done this, then we can > update to permit select the filtering system from configuration. From > now, we have internal filters. > I think that this is a very earlier version and that can be much more > developed. But it runs ok! > Well, my problem is that I don't know so much on using svn. If some one > can tell me how can I 'upload' the work without disturbing anybody... > Comments and discussions about this are welcome. > Thanks a lot!!! > emi -- Tavs bezmaksas pasts Inbox.lv Regards, Andris _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Indonesian (Bahasa Indonesia) Language Translation Update
by klunxer 14 Nov '07

14 Nov '07

Hi all, I already updating the language translation for Bahasa Indonesia. Please check the attachment and feel free to give some corrections. Best Regards, Arya --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/4H/NEi5E0xk/id_ID.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Filters
by emi＠algorismia.com 13 Nov '07

13 Nov '07

Hi there!! I've made a filters function (in early version) for roundcube. I've done over the svn version of last week. The modifications uses a new SQL table, filters, wich can be filled as done with identities. Then it filters messages using this filters, on rcmail_js_message_list and rcmail_message_list. I've seen some discussion on why not to do it, if doing internally or with sieve or with .forward or so. Look, I've done this, then we can update to permit select the filtering system from configuration. From now, we have internal filters. I think that this is a very earlier version and that can be much more developed. But it runs ok! Well, my problem is that I don't know so much on using svn. If some one can tell me how can I 'upload' the work without disturbing anybody... Comments and discussions about this are welcome. Thanks a lot!!! emi _______________________________________________ List info: http://lists.roundcube.net/dev/

4 6

IMAP
by I J 12 Nov '07

12 Nov '07

Hi guys, it seems like the forums are pretty much dead so I'll get my help from here, I configured everything ran the script, seemed to work. The problem is, it continues to tell me "connect to IMAP server failed", my question is, do I have to type in the path to the IMAP in the main.inc.php file? Kind Regards. __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

Roundcube Licensing question.
by I J 12 Nov '07

12 Nov '07

Hi, I was told by Brett to send you guys an email about the licensing question I had. Is their any possible way to purchase a copy of the roundcube script from you that isn't released under the GPL license? I'm willing to pay any reasonable price; the reason for the copy of the roundcube script not released under the GPL is to allow my company (Dynno.com coming soon) to be able to place our copyright on the script. Please be assured that your script won't be used for resale however, it will be used to provide email addresses to our members. Send me a reply if or if not this is possible, Best Regards. __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com _______________________________________________ List info: http://lists.roundcube.net/dev/

4 4

Re: [RCD] Roundcube Licensing question.
by till 11 Nov '07

11 Nov '07

On Nov 9, 2007 12:09 PM, I J <imageyourself(a)yahoo.com> wrote: > > no no, not my copyright on someone else's work, I must of miss-read the GPL > license but from what I understood was I can't place a site wide copyright > such as "(c) whatever.com; I give full credit to roundcube don't get me > wrong here. *please always copy the list* Basically, I don't get what keeps you from using RoundCube. GPL-code doesn't even require a public "powered by" etc., so what's the deal? Till _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Odd javascript problem - not working after attachment download
by Sam Bailey 07 Nov '07

07 Nov '07

Hi Guys (inc. Gals of course), I hope to be of more use of the next few months - but we'll see. I noticed that after downloading a non-pdf attachment via the link, none of the navigation buttons in RoundCube work. Seems as if the javascript gets disabled as it works if you refresh the page first. Occurs under Win(FF2, IE7, Safari3.0.1, Opera9.21), Linux(FF2, Prism0.8) Oh - using rc2 See: http://trac.roundcube.net/ticket/1484653 Much appreciated getting some help on this. Sam Bailey _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] Framework for AJAX?
by Frederic Leroux 06 Nov '07

06 Nov '07

Maybe Framework is not the right word, IDE would be better :) On Nov 5, 2007 1:46 AM, kourge <kourge(a)gmail.com> wrote: > As far as I'm aware of, Roundcube does not use any. > > On 11/4/07, Frederic Leroux <leroux.frederic(a)gmail.com> wrote: > > Hi, > > > > I would like to know which framework you use to develop RoundCube or for > > PHP/AJAX. > > > > I actually just use an text editor but i'm wondering if there is better > way > > to develop :) > > > > > > Thank you for your suggests. > > > > Fred > > > > _______________________________________________ > > List info: http://lists.roundcube.net/dev/ > > > > > _______________________________________________ List info: http://lists.roundcube.net/dev/

7 8

Re: [RCD] Framework for AJAX?
by Frederic Leroux 05 Nov '07

05 Nov '07

Yes :) On Nov 5, 2007 8:32 AM, kourge <kourge(a)gmail.com> wrote: > (You meant "editor" or "environment".) > > On 11/4/07, kourge <kourge(a)gmail.com> wrote: > > Oh, then in that case Thomas would be the one who'd be able to answer > > your question ;) > > > > On 11/4/07, Frederic Leroux <leroux.frederic(a)gmail.com> wrote: > > > Maybe Framework is not the right word, IDE would be better :) > > > > > > > > > > > > > > > On Nov 5, 2007 1:46 AM, kourge <kourge(a)gmail.com> wrote: > > > > As far as I'm aware of, Roundcube does not use any. > > > > > > > > > > > > > > > > > > > > On 11/4/07, Frederic Leroux <leroux.frederic(a)gmail.com> wrote: > > > > > Hi, > > > > > > > > > > I would like to know which framework you use to develop RoundCube > or for > > > > > PHP/AJAX. > > > > > > > > > > I actually just use an text editor but i'm wondering if there is > better > > > way > > > > > to develop :) > > > > > > > > > > > > > > > Thank you for your suggests. > > > > > > > > > > Fred > > > > > > > > > > _______________________________________________ > > > > > List info: http://lists.roundcube.net/dev/ > > > > > > > > > > > > > > > > > > > > > > > _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Framework for AJAX?
by Frederic Leroux 04 Nov '07

04 Nov '07

Hi, I would like to know which framework you use to develop RoundCube or for PHP/AJAX. I actually just use an text editor but i'm wondering if there is better way to develop :) Thank you for your suggests. Fred _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

XSS
by rosenfield.albert＠gmail.com 03 Nov '07

03 Nov '07

Have you guys tested RoundCube for XSS vulnerabilities, for example using this list? http://ha.ckers.org/xss.html Is it possible to completely disable the display of HTML messages in the web interface (ie make sure that HTML parts are only available as "Content-Type: attachment" http streams)? Cc pls ;) _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] Mettre l'ordre des colonnes des mails dans les
by krowix krowix 01 Nov '07

01 Nov '07

OK, OK i will write in english. I would like to know if there is a user preference order option for 'list_cols' ( subject,from,date,size). If exist, tell me where i can find it. Thx. _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Mettre l'ordre des colonnes des mails dans les preferences utilisateurs
by krowix krowix 31 Oct '07

31 Oct '07

Bonjour, je ne sais pas si cela est en preparation ou si cela a déjà été fait , c'est pour cela que je pose cette question. Est ce que la possibiblité de mettre l'ordre des colonnes subject,from,date,size ( $CONFIG['list_cols']) dans les preferences de l'utilisateur a déjà été envisagée ? Merci de vos reponses. _______________________________________________ List info: http://lists.roundcube.net/dev/

4 4

Re: [RCD] Patch for new features
by markevich＠inbox.lv 31 Oct '07

31 Oct '07

Hello. I have some comments on moving spam to Spam folder buttons feature. I agree that such a feature would be a good addition to the source, so I would suggest expanding your new feature like this: 1) there is should be on/off switch in config file for this feature; 2) there are should be mail folder names to move spam/non-spam to in the config file (not hard coded but customizable); 3) there is should be mail forwarding feature for spam emails. There are might be 2 config variables which contain email address for spam/non-spam messages to be forwarded to for retraining. This forwarder must NOT modify message body and headers. If these config variables are empty so no forwarding would be done only moving email to the folder after pressing corresponding button. I can explain why I think that 3) note is so critical. It's ok to use retraining scripts for all found e-mails in all mailboxes when you have 10-100 users, but if your user count reaches 100k-1m your server simply will die parsing such amount of data (millions of e-mails). In this case mail forwarding is used for retraining, but current Roundcube implementation doesn't allow taking full advantage of this approach because it's deleting original header from the forwarded e-mail which contain anti-spam signatures. We can store these signatures in the mail body but I'm deadly against disturbing user's correspondence with any additional "junk" not related to the mail content. This is my opinion how it should look, please fill free to comment and suggest improvements. Regards, Andris ---------- Forwarded message ---------- From: Marcelo Salhab Brogliato Date: Oct 27, 2007 1:32 PM Subject: Re: [RCD] Patch for new features To: till Hello till, I don't have svn installed in the shell that I'm working on.. but I already sent an email asking for instalation! Soon I'll send my first patch :)) About the last feature that I sad: Let's get a situation: you are on the compose page writing some email.. so you wan't to see the address book to add more recipients. When you click Address Book, you "lost" your email (you can save in the draft)... Does you guys have a patch to solve this? Thanks for your help Salhab On 10/27/07, till wrote: Hi Salhab, no problem, but please CC the list, so others learn from this. :) Basically the best way is the following: 1) Get latest code from SVN (trunk) 2) Migrate all your changes in there, test 3) Create patches using "svn diff > feature.patch" Till On 10/27/07, Marcelo Salhab Brogliato wrote: Hi Till, that's my first contribution to open source projects... I'm completelly a newbie! :)) How can I create a patch? I have no idea... I think it isn't just attaching the files that I changed.. Maybe a CHANGELIST? Or a little tutorial with the codes and where they should be inserted? What do you mean by "configurable"? The name of the folders are fixed by now.. but a little change in the source make it user-defined :) Thanks for your answer. Salhab On 10/27/07, till wrote: Hi Salhab, On 10/27/07, Marcelo Salhab Brogliato < msbrogli(a)gmail.com> wrote: Hi to everyone, I'm new to the list and working on RoundCube.. but I changed him a little to satisfy my needs. I implemented 3 features that you can check at: http://www.vialink.com.br/webmail4/ email: msbrogli2(a)vialink.com.br password: 123456 Essentially, it is: * a checkbox at the left... to make the life of the ones who aren't familiarized with AJAX (in my case, my customers) easier... so, they can easily select more than a message.. I thought there were discussions already and I don't think this will make its way into the source. The reason is - we aim to provide a desktop-like look and feel.I don't see checkboxes in Outlook, Eudora, Thunderbird or kMail. * a droplist to move selected messages between the folders * 2 buttons called SPAM and NO-SPAM.. they move the message to the folders Spam and No-Spam... but why? because I developed a script to periodically check that folders and train spamassassin to work better... Not a bad idea. Are the folders configurable? (I obviously haven't check your patch yet, because there was none attached. ;-)). now I'm working on a preview window in the list page... like Outlook.. just click the message and see the content.. a double click maximize the message... I think a preview pane is already included. and my last modification (for now) will be a way to throw the compose page add emails from contact list.. Not sure I understand. In general, if you want to provide a patch, make sure to open tickets on our trac (0) and make sure to provide one patch per issue/feature - not a giant patch. sorry about my english... if i'm not clear, please ask! Thanks for your work! Looking forward to your thoughts! Till _______________________________________________ List info: http://lists.roundcube.net/dev/

3 2

Re: [RCD] Dev Digest, Vol 4, Issue 26
by Andris Markevich 31 Oct '07

31 Oct '07

Hello. I agree, we can do like this, but physically it will be the same action but within another mail's body. In this case if we'll send all mail's within 1 mail's body we'll minimize load on the mail server but it's harder to code. It's on the author which approach to choose. Regards, Andris On Wed, 2007-10-31 at 12:00 -0700, dev-request(a)lists.roundcube.net wrote: > Date: Wed, 31 Oct 2007 16:06:07 +0100 > From: "Michael Tobler" <TheTrueBorg(a)gmx.de> > Subject: Re: [RCD] Patch for new features > To: dev(a)lists.roundcube.net > Message-ID: <20071031150607.294740(a)gmx.net> > Content-Type: text/plain; charset="us-ascii" > > Hi > > I have an other suggestion for point 3) > Why not simply mark all Spam email, click a button and forward them as > attachment (no header loss) to an address (like spam(a)example.com) > where sa-learn or some other scripts is run only over all attachments? > > In this way we do not need a special Forward, but just a button spam. > After forwarding all marked mails can be moved to the local Junk > folder. > > Best, > Michael _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Fwd: Patch for new features
by Marcelo Salhab Brogliato 30 Oct '07

30 Oct '07

---------- Forwarded message ---------- From: Marcelo Salhab Brogliato <msbrogli(a)gmail.com> Date: Oct 27, 2007 1:32 PM Subject: Re: [RCD] Patch for new features To: till <klimpong(a)gmail.com> Hello till, I don't have svn installed in the shell that I'm working on.. but I already sent an email asking for instalation! Soon I'll send my first patch :)) About the last feature that I sad: Let's get a situation: you are on the compose page writing some email.. so you wan't to see the address book to add more recipients. When you click Address Book, you "lost" your email (you can save in the draft)... Does you guys have a patch to solve this? Thanks for your help Salhab On 10/27/07, till <klimpong(a)gmail.com > wrote: > > Hi Salhab, > > no problem, but please CC the list, so others learn from this. :) > > Basically the best way is the following: > > 1) Get latest code from SVN (trunk) > 2) Migrate all your changes in there, test > 3) Create patches using "svn diff > feature.patch" > > Till > > On 10/27/07, Marcelo Salhab Brogliato <msbrogli(a)gmail.com> wrote: > > Hi Till, > > > > that's my first contribution to open source projects... I'm completelly > a > > newbie! :)) > > How can I create a patch? I have no idea... > > I think it isn't just attaching the files that I changed.. > > Maybe a CHANGELIST? Or a little tutorial with the codes and where they > > should be inserted? > > > > What do you mean by "configurable"? The name of the folders are fixed by > > now.. but a little > > change in the source make it user-defined :) > > > > Thanks for your answer. > > Salhab > > > > > > > > On 10/27/07, till <klimpong(a)gmail.com> wrote: > > > Hi Salhab, > > > > > > On 10/27/07, Marcelo Salhab Brogliato < msbrogli(a)gmail.com> wrote: > > > > Hi to everyone, > > > > I'm new to the list and working on RoundCube.. but I changed him a > > little to > > > > satisfy my needs. > > > > I implemented 3 features that you can check at: > > > > http://www.vialink.com.br/webmail4/ > > > > email: msbrogli2(a)vialink.com.br > > > > password: 123456 > > > > > > > > Essentially, it is: > > > > * a checkbox at the left... to make the life of the ones who aren't > > > > familiarized with AJAX (in my case, my customers) easier... > > > > so, they can easily select more than a message.. > > > > > > I thought there were discussions already and I don't think this will > > > make its way into the source. The reason is - we aim to provide a > > > desktop-like look and feel.I don't see checkboxes in Outlook, Eudora, > > > Thunderbird or kMail. > > > > > > > * a droplist to move selected messages between the folders > > > > * 2 buttons called SPAM and NO-SPAM.. they move the message to the > > folders > > > > Spam and No-Spam... but why? > > > > because I developed a script to periodically check that folders > and > > train > > > > spamassassin to work better... > > > > > > Not a bad idea. Are the folders configurable? (I obviously haven't > > > check your patch yet, because there was none attached. ;-)). > > > > > > > now I'm working on a preview window in the list page... like > Outlook.. > > just > > > > click the message and see the content.. > > > > a double click maximize the message... > > > > > > I think a preview pane is already included. > > > > > > > and my last modification (for now) will be a way to throw the > compose > > page > > > > add emails from contact list.. > > > > > > Not sure I understand. > > > > > > In general, if you want to provide a patch, make sure to open tickets > > > on our trac (0) and make sure to provide one patch per issue/feature - > > > > not a giant patch. > > > > > > > > > > sorry about my english... if i'm not clear, please ask! > > > > > > > > > > Thanks for your work! Looking forward to your thoughts! > > > > > > Till > _______________________________________________ List info: http://lists.roundcube.net/dev/

5 9

Re: [RCD] Right-to-Left Layout
by Ossama Khayat 30 Oct '07

30 Oct '07

As I pointed earlier the best solution would be to use a separate .css file the RTL language(s), which includes Arabic, Hebrew, Persian, Urdu and maybe others. - Ossama ----- Original Message ---- From: Robin Elfrink <elfrink(a)introweb.nl> To: RoundCube Development Mailing List <dev(a)lists.roundcube.net> Sent: Tuesday, October 30, 2007 2:43:04 PM Subject: Re: [RCD] Right-to-Left Layout Hi all, Attached is my first idea of how to implement right-to-left layouts. My native language is left-to-right, so I cannot help develop this further. Work is needed on image stuff as well. I haven't investigated, but probably most image-problems with rtl languages come from background images that should be moved to the other side. Maybe an include of a 'rtl.css' that overrides background settings will do? Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Ur/SjPNsK7C/rtl.20071030-1235.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev