Hi everybody
I just moved most of the remaining tickets to 0.1-stable in order to
get this release ready. Now I'd like to request the testers to test
the current trunk on their environments, especially creating and
updating the database. I can only test mysql and sqlite but there are
others...
Also all translators are requested to check for missing texts using
our online tool: http://translator.roundcube.net/
Thanks so far!
~Thomas
_______________________________________________
List info: http://lists.roundcube.net/dev/
Thanks for your assistance, Harold and Fahrzin.
I've developed the patch and have attached it to this message (let me know
if there's someplace else I should send it instead).
A few concerns:
1) The search() method in rcube_contacts.inc; I think while testing this
patch, I think I found a glitch in it. If you have a contact in your
address book
and you delete it by mistake, then try to add the same contact again, it
will see it as a
duplicate and won't let you add it. This is because the search() method
searches all contacts, even those with the `del` flag set. Should I try to
fix this, or just file a bug report? Does anybody more familiar with the
source know if it will break anything if I make it only search records not
deleted? Or maybe when instructed to add a duplicate contact, Roundcube
should simply turn off the 'del' flag if it's set?
2) I didn't know the best way to get the raw email address from the
$MESSAGE headers, so I wrote a simple method that uses preg_match to
extract it. If there's a better way, please let me know and I'll update my
patch.
3) Caching causes a bit of a glitch in my patch. If you click a message
with remote objects, click Always display, it will add the sender to the
address book and display the images. If you go right back to the message
however it will show the cached version so you have to Shift-Reload or it
will appear it was unsuccessful. I'd be grateful if anybody knows a way
around this.
4) As I'm monolinguistic, I've only added the message for it
($messages['alwaysshow']) to the en_US locale, so it won't display properly
if your locale is different. Sorry.
Let me know what you think.
Thanks,
Ben
On Mon, 8 Oct 2007 23:12:20 +0200, Harold Aling <h.aling(a)home.nl> wrote:
>
> On Mon, 8 Oct 2007 15:57:12 -0400, Ben <ben(a)forlent.com> wrote:
>> to start by writing a patch that allows you to "always display" images
> in
>> messages from specific senders, so you don't have to click "display
>> images"
>> each time you open their message.
>>
>> Being kind of new to this, my questions are as follows:
>>
>> 1) is anybody already working on this feature?
>
> Check the bug reports/feature requests on trac...
>
>> 2) If I do develop it, would it likely be added to the project?
>
> If it's well written, modulair and easy to implement: sure...
>
>> 3) How would I go about implementing it? Just download the SVN and patch
>> it? Then do I send this list the patched files or just the snippets I
>> modified or something else?
>
> I believe that's the best way to do it. It'll probably won't make it into
> 1.0, so I'd guess writing it against SVN would give you the best base...
>
>> 4) From a technical standpoint, what would be the best way to store the
>> whitelist of email senders? Flatfile, new database table, or in the
>> address
>> book?
>
> I'd go for the addressbook option. Email addresses which are stored in
the
> addressbook are in my case always trusted...
>
>>
>> Thanks,
>> Ben
>
> Good luck!
>
>
> -H-
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/mW/maW5sP0T/display_images.patch
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hey everybody,
I've been using Roundcube for a couple weeks now and am absolutely thrilled
to have a real replacement for GMail. There are a couple features I'd like
to see plus I've been meaning to get involved in FOSS development. I'd like
to start by writing a patch that allows you to "always display" images in
messages from specific senders, so you don't have to click "display images"
each time you open their message.
Being kind of new to this, my questions are as follows:
1) is anybody already working on this feature?
2) If I do develop it, would it likely be added to the project?
3) How would I go about implementing it? Just download the SVN and patch
it? Then do I send this list the patched files or just the snippets I
modified or something else?
4) From a technical standpoint, what would be the best way to store the
whitelist of email senders? Flatfile, new database table, or in the address
book?
Thanks,
Ben
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hello,
I got the latest code from Subversion and tested it to see how it looks in
Persian. RoundCube seems to have no support for right-to-left languages such
as Persian and Arabic. It didn't change the layout to right-to-left when I
chose Persian or Arabic. Please correct me if I'm wrong.
Is there any plan to implement it?
--
Mohammad Ebrahim Mohammadi Panah
_______________________________________________
List info: http://lists.roundcube.net/dev/
Got this in a private message on the forums. Thought I'd pass it along:
You and the rest of the team are doing a great job.
This might not be the right way to send this information but I have
posted about this before with no results, so here it is for You and
the rest of the team to do whatever You want with.
My improvements to the identity section.
The easy one is about the sort order in the indentity list.
Code:
/program/steps/settings/func.inc
function rcmail_indentities_list.....
// get contacts from DB
ORDER BY standard DESC,
name ASC,
email ASC // this one is new....
The second one is a bit more. It improves the identity section in two ways.
1. You can NOT add an identity 'outside' your own domain. That is if
You are logged in as 'mail(a)gunfro.com' You could only add identities
to that domain.
2. You can NOT add an identity if it already exists in the domain. The
domain You are logged into.
I made this in one chunk so it easier to add. It might be better to
put the code more where it belongs, hope You get my point.
Code:
/program/steps/settings/save_identities.php
// check input
if (empty($_POST['_name']) || empty($_POST['_email']))
{
$OUTPUT->show_message('formincomplete', 'warning');
rcmail_overwrite_action('edit-identitiy');
return;
}
//*********************************************************************
// MOD GUNFRO START
$newa = explode("@", $_POST['_email']);
$curr = explode("@", $_SESSION['username']);
// Check valid domain.
if ($newa[1] != $curr[1])
{
$OUTPUT->show_message('domainnotvalid', 'warning');
rcmail_overwrite_action($_framed ? 'edit-identity' : 'identities');
return;
}
// Check if changing email and it exits.
if ($_POST['_iid'])
{
$DB->query("SELECT * FROM ".get_table_name('identities')."
WHERE identity_id=?
AND del<>1",
$_POST['_iid']);
$curri = $DB->fetch_assoc();
if ($curri['email'] <> $_POST['_email'])
{
$DB->query("SELECT * FROM ".get_table_name('identities')."
WHERE email=?
AND del<>1",
$_POST['_email']);
if ($DB->fetch_assoc() != NULL)
{
$OUTPUT->show_message('emailexists', 'warning');
rcmail_overwrite_action($_framed ? 'edit-identity' : 'identities');
return;
}
}
} else { // Just new a identity
$DB->query("SELECT * FROM ".get_table_name('identities')."
WHERE email=?
AND del<>1",
$_POST['_email']);
if ($DB->fetch_assoc() != NULL)
{
$OUTPUT->show_message('emailexists', 'warning');
rcmail_overwrite_action($_framed ? 'edit-identity' : 'identities');
return;
}
}
// MOD GUNFRO END
//*********************************************************************
// update an existing contact
if ($_POST['_iid'])
That was my contribution for now.
Best regards
Gunnar Frödin / GunFro
--
~ Brett Patterson
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
I translated RoundCube to Esperanto; see attachment.
Andreas
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/YJ/Ad9KsuC0/eo.tar.gz
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Please find attached an up-to-date version of the French localisation.
Best regards.
Jonathan Ernst
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/sH/75tKS+7D/fr.tar.gz
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
On Wed, 26 Sep 2007 17:34:03 +0200, "Thomas Bruederli"
<roundcube(a)gmail.com> wrote:
> 2007/9/26, Robin Elfrink <elfrink(a)introweb.nl>:
>> Thomas Bruederli wrote:
>>
>> > My folders are all top-level and $IMAP->delimiter is empty. The
>> > resulting expression is /.*/ which removes all characters from the
>> > folder name. I'd suggest to split the folder name by the delimiter and
>> > then use the last array index (which would be 0 in my case).
>>
>> An empty delimiter. Never thought of that. Okay, fixed.
>
> I tested it on my Mac (IMAP daemon from Postfix Enabler which is
> derived from UW-IMAP) and added a default delimiter (r824). The server
> did not define any and exploding a string by NULL results in an empty
> array.
>
I might be wrong about this, but about the time this 'fix' got in, my
folder list doesn't nest folders anymore.
Folder
Folder.Subfolder
-instead of-
Folder
Subfolder
How can I set the delimiter(.) again? I'm on r851/Dovecot-imapd btw.
-H-
> Sorry for bitching again but there are still some issues (see
> http://trac.roundcube.net/trac.cgi/ticket/1457344#comment:12) which
> should be solved before we can consider this feature as completed.
>
> ~Thomas
> _______________________________________________
> List info: http://lists.roundcube.net/dev/
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi
Updated Persian translation is attached.
P.S. I read about people having to confirm the translations, if it's done like this, tell me how exactly they should confirm. (because I do know some friends and others who use RoundCube with Persian language)
Regards
Ardnoosh
---------------------------------
Pinpoint customers who are looking for what you sell.
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/cf/GP4UXk7N/labels.inchttp://detached.gigo.com/rc/cf/GP4UXk7N/messages.inc
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
I have installed rc the latest from the website. I just get a blank page. My error log says:
[02-Oct-2007 12:07:27] PHP Fatal error: Call to a member function on a non-object in /home/brentadv/public_html/rc/program/include/rcube_db.inc on line 366
[02-Oct-2007 12:35:45] PHP Fatal error: Call to a member function on a non-object in /home/brentadv/public_html/rc/program/include/rcube_db.inc on line 366
[02-Oct-2007 12:36:45] PHP Fatal error: Call to a member function on a non-object in /home/brentadv/public_html/rc/program/include/rcube_db.inc on line 366
Line 366 says:
return "now()";
:s but I don't think it's that.
Also I couldn't work out how to do this in cpanel. I have already set up my database with correct username and pass.
Database Setup
While we're uploading (or after we're done) we have one final step to do before we can start using Roundcube. We need to set up our database. Open your website control panel. You first need to create a database and user with the information we decided earlier. Then add that user to the database. Next we execute the SQL file found in the "/SQL/" directory in Roundcube that is named: "*.initial.sql" where * is your database backend type (mySQL, PostgreSQL, SQLite).
For example with mysql enter the following code on the command line:
mysql --user=(your_db_user_name) -p (your_db_name) < mysql.initial.sql
=
--
Powered By Outblaze
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi there,
I've just tested RoundCube, and feel that's great, because simply is the
best. After used some hours, I have some suggestions and a bug want to
report.
Suggestions:
1. After deleted a message, wish it will select next message by auto
for easy deletion by keyboard. (Because if every time need to use mouse
click maybe too slow.?)
Bugs?
1. When loading the list of messages, the icon background always in
gray, and change to white. The row height also changing on that moment.
Thanks for your great tools.
Best regards,
anDY
_______________________________________________
List info: http://lists.roundcube.net/dev/
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi !
Here is my first patch for my filter's system.
I separate my filter system (named mc_filters) from the filter's interface.
In lib/Filters are the different classes for filter's system (for the moment
only mc_filters and the base class).Filter's system used are stored in the
main.inc.php.
So.. I'm open to all your remarks, like horribles English's mistakes ;).
The code is a bit ugly for the moment (I try to not edit your base files and
the CSS so I re-use for ex. the classes for another pages for settings) ^^,
but I will correct this later.
All is based on the revision 740 of the trunk.
What do you think about it ? What I have to change ?
Regards,
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: http://firegpg.tuxfamily.org
iD8DBQFG6rMsjKKs5/FTCjURAobAAJ9s4vbrbevV4na9GaUv8evfgwagjwCgxr6H
zr83rNB+tT4wA9+bhpwDhHg=
=5So1
-----END PGP SIGNATURE-----
--
( o _ Maximilien Cuony [The glu]
/ / \ Mon Blog : http://theglu.tuxfamily.org
V_ /_ www.ubuntu-fr.orgwww.getfirefox.com
Ce mail est signé numériquement avec FireGPG.
Clé publique : http://theglu.tuxfamily.org/public/cle.pgp
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/6C/pgpRjvEb/filters.patch
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
I finished folder drag/drop. Enables drag/dropping of folders onto a new
parent folder, or to the root of the tree if dropped onto one of the
'protected' folders.
In the process I fixed sort_subscription_list(). Not that anybody ever
noticed it was broken, but still.
Comments please, and tests on different browsers on different platforms.
Firefox on win32 works fine, no need to test that :)
Robin
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/1j/DANjXG8A/folder-dragdrop.2007.patch
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hello,
I've updated Polish translation ('movingmessage' and
'movemessagetotrash' translated).
Best regards, Janusz
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/En/smPv68hE/polish20070925.zip
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
I just complete translated Thai language please see the attachment.
I also edit index.inc in "program/localization" change "th" to "th_TH"
Regards,
Wiraphan Treeratphan
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/Gf/XWMqcJCC/th_TH.zip
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
Is anybody working on support for shared folders?
If not I volunteer to try and implement them. It doesn't seem too hard,
just a lot of work. Especially a number of changes in the IlohaMail IMAP
library.
Robin
PS. IlohaMail development seems to be dead, no CVS commits for over 2
years. Does anybody have more info about that?
_______________________________________________
List info: http://lists.roundcube.net/dev/
I am cutting and pasting the reply I got from Microsoft today. They
definitely acknowledge it as a bug, but they seem to be implying it
is something that they may or may not fix. Please read over his reply
and give me any direction you can on how to proceed. I already
replied and told him that neither "workaround" he lists is valid for
us. Based on previous discussions, it sounds like roundcube intends
to maintain a real <a> tag pointing to a real URL.
Hi Joel,
The DIV case is really a different scenario. It does not have any
special meaning when Ctrl + Click so that should be consistent with
what you see in IE6. IE7 added a special case for Anchor tag
handling when Ctrl + Click. I am currently working on this issue
with my escalation engineer, Shahinur. You raise a valid point about
the onclick event should be fired for Ctrl + Click regardless of
which window the navigation happens in. At this point this does look
like a bug in IE7. I don’t see any good workaround for this
problem. There are a few ideas that that you may have already knew
or touched on at some point:
1) Try avoid using the Anchor tag, you can use other elements
like DIV (you already knew) or SPAN tag and still mimic the Anchor
tag appearance. Some thing like this:
<span style="text-decoration: underline; cursor:hand; color:blue"
onclick="aFunction()" >
click this "link"
</span>.
2) It seems that if the Anchor tag does not have a valid href
URL attribute. If the href attribute is set to “” (empty string) or
“#” or even non-existant then things are working as expected. Below
is an example of the href missing:
If these workarounds do not work for you, we can request a hotfix
from the product team. Keep in mind that there is always a chance
that the hotfix request can be rejected. If you diecide to pursue
this route, I would need to have a Business Impact statement from you
addressing the following questions. Once I have the Business Impact
Statement, I can file a formal hotfix request to the product team:
1. Business Impact
- How does this bug affect your business
- Why are current workarounds, if any, unacceptable
2. Financial Impact (include how it was calculated)
- What is the financial impact of the bug
- What is the financial impact of the best
workaround, if any
3. Problem's frequency and probability?
4. Number of companies impacted
5. Number of corporate desktops and servers impacted
6. Number of consumer desktops (ie. home users) impacted
7. What IE platform is the hot fix needed?
- IE 6.0 sp2 on XP SP2
- IE 6.0 on Windows 2003 Server
- IE 6.0 on Windows 2003 Server SP1
- IE 7.0 on Vista
- IE 7.0 on XP SP2
- IE 7.0 on Windows 2003 Server SP1
9. What type of hot fix package do you need?
QFE – This package takes about 1-2 months to release
and has a strict acceptance criteria. It is only distributed to
customers by contacting Microsoft Support referencing a KB article.
It is also redistributable only within a corporation (but not to the
corporation’s customers). The fix is usually enabled by setting a
specific registry key on the machine.
GDR – This package takes about 3-6 months to release
and is subjected to more testing and an even higher acceptance
criteria. It is distributed to customers by downloading it from a
public Microsoft link. This package is normally not available if a
QFE meets your needs.
8. What languages (English, Chineses,...) are needed?
Joel Clermont
joel(a)orionweb.net
262-377-9930
_______________________________________________
List info: http://lists.roundcube.net/dev/
You may not need to after all. Someone proposed a workaround that
actually works! But if you wanted to you can call Microsoft and open
a formal support ticket like I did. I suppose the more complaints
they get, the better.
Joel Clermont
joel(a)orionweb.net
262-377-9930
On Sep 23, 2007, at 5:37 PM, Martin Kealey wrote:
> We have 10^N (N>5) customers depending on RoundCube, so this is a
> real issue for us.
>
> Where do we sign up to complain?
>
> -Martin
> --
> Martin D Kealey, ihüg engineering
>
>> -----Original Message-----
>> From: Joel Clermont [mailto:joel@orionweb.net]
>> Sent: Sunday, September 23, 2007 12:45 AM
>> To: Michael Büker
>> Cc: dev(a)lists.roundcube.net
>> Subject: Re: [RCD] control-click bug in IE7
>>
>> I had a long talk with this support rep on the phone the
>> other day. He said that a number of people (though he
>> wouldn't tell me how many) have filed a bug notice on this
>> very issue. Internally, the bug is graded as "fix in next
>> release", which means IE 8. That is probably at least 3 years
>> off, and likely longer. He said that no one has yet opened a
>> formal support ticket on this issue. We are the first. It's a
>> shame we have to play their game, but the only way to get
>> your bug's priority bumped is to make a business impact case.
>> Then again, there is no guarantee that they will escalate the
>> bug even with this document. And even if they do escalate it,
>> the best case time frame for a generally deployed fix is 3 -
>> 6 months. Despite this, I think it is still worth submitting
>> the document and getting the process started.
>>
>> In the meantime, I wanted to propose an alternate solution.
>> As I understand it, making the subject text an <A> tag was to
>> accommodate a small subset of users. Could we possibly create
>> a new setting in the personal settings area where the
>> individual user could toggle whether they want this as an <A>
>> tag or not? Ideally, the server admin could set a default
>> value and then let users override it. I think this might be
>> the best short term solution until MS fixes the real bug, if
>> they ever do.
>>
>> What does everyone think? Also, could someone take a few
>> minutes and explain to me again the full reason for the <A>
>> tag with a real href? Was it just accessibility reasons?
>>
>> Joel Clermont
>> joel(a)orionweb.net <mailto:joel@orionweb.net>
>> 262-377-9930
>>
>>
>>
>>
>> On Sep 22, 2007, at 5:50 AM, Michael Büker wrote:
>>
>>
>> On Friday 21 September 2007, Joel Clermont wrote:
>>
>> If these workarounds do not work for you, we
>> can request a hotfix
>> from the product team. Keep in mind that there
>> is always a chance
>> that the hotfix request can be rejected. If
>> you diecide to pursue
>> this route, I would need to have a Business
>> Impact statement from you
>> addressing the following questions. Once I
>> have the Business Impact
>> Statement, I can file a formal hotfix request
>> to the product team:
>>
>> <we'll only fix this if you are important enough>
>>
>>
>> I can't believe this! You've proven to them it's a
>> nonstandard behaviour, it
>> breaks actions that are expected, they even admitted
>> it's a _bug_, and they
>> tell you to get down on your knees and beg so they
>> _might_ fix it, but only
>> if they deem you important enough, _and_ there's enough
>> money involved!
>>
>> How much would I like to put a fat notice on the
>> roundcube homepage
>> saying "IE7 broken!", we don't support it period.
>>
>> What a bunch of arrogant, superbureaocratic, incapable assholes!
>>
>> Sorry, I had to let this steam off ;)
>>
>> ~Mik
>>
>> --
>> Heisenberg gets stopped by a cop for speeding.
>> "Do you have any idea how fast you were going?", asks the cop.
>> "No. But I know exactly where I am!"
>> _______________________________________________
>> List info: http://lists.roundcube.net/dev/
>>
>>
>>
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
I finally found a fix for #1484187.
Instead of the currently used dynamic height and width settings, it
simpy positions absolutely inside the containing (and also absolutely
positioned) div.
I may look hackish, and maybe it is, but this patch makes another hack
unneeded :)
Tested in the following browsers:
- Firefox 2.0.0.7 on Window XP
- Internet Explorer 6 on Linux (IEs4Linux project)
- Internet Explorer 7 on Windows XP
- Konqueror 3.5.6 on Linux (the bottom border of the containing div
disappeared...)
- Opera 9.02 on Windows XP
- Safari 2.0.4 on Mac OS X
- Safari 3.0.3 on Windows XP
If there are no problems in any other (major) browsers on other (major)
platforms I'll commit this in the weekend.
Robin
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/cn/EAeQ7c+x/_1484187.20070921161.patch
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi, since I updated to the latest SVN version (800) I can't send emails.
Mail delivery failed: returning message to sender
Gid 32299 is not permitted to relay mail, or has directly called
/usr/sbin/exim instead of /usr/sbin/sendmail.
??
Regards /Søren
_______________________________________________
List info: http://lists.roundcube.net/dev/
I run a small web hosting business and we just switched from
SquirrelMail to RoundCube. Overall, our clients love it. The polished
interface is so nice coming from the previous app.
The biggest problem people moan about is multi-select. It is not
intuitive to use a key modifier like Shift or Control to select
multiple messages. In addition, in IE7 when you control-click it
opens the message in another tab, so if you control-click 10 messages
to delete them, you now also have 10 tabs to close.
Is there something I am missing on this problem? Is there a setting
where I can enable an old school checkbox column for people to use in
multi-select?
Joel Clermont
joel(a)orionweb.net
262-377-9930
_______________________________________________
List info: http://lists.roundcube.net/dev/