- Dev - Roundcube mailing lists

#1267231 Folder hierarchy collapsing
by Robin Elfrink 26 Sep '07

26 Sep '07

Hi, Folder collapsing in the main screen (feature request #1267231). Works in Firefox and Opera. Works but looks like sh*t in Explorer 7 and Safari 3. Looks like sh*t in Safari 2. So more work is needed on the CSS part. Not-working in Safari 2 probably has to do with CSS. List of collapsed folders is stored in a cookie. Maybe the database is a better place? Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/WN/qV3HR70y/_1267231.20070925130.patch http://detached.gigo.com/rc/WN/qV3HR70y/_1267231.folder-minu.png http://detached.gigo.com/rc/WN/qV3HR70y/_1267231.folder-plus.png Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

Folder management drag/drop
by Robin Elfrink 26 Sep '07

26 Sep '07

Hi, I finished folder drag/drop. Enables drag/dropping of folders onto a new parent folder, or to the root of the tree if dropped onto one of the 'protected' folders. In the process I fixed sort_subscription_list(). Not that anybody ever noticed it was broken, but still. Comments please, and tests on different browsers on different platforms. Firefox on win32 works fine, no need to test that :) Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/1j/DANjXG8A/folder-dragdrop.2007.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 7

Updated Polish translation
by Janusz Zamecki 26 Sep '07

26 Sep '07

Hello, I've updated Polish translation ('movingmessage' and 'movemessagetotrash' translated). Best regards, Janusz --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/En/smPv68hE/polish20070925.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

3 4

Translated Thai language
by admin＠modoeye.com 26 Sep '07

26 Sep '07

I just complete translated Thai language please see the attachment. I also edit index.inc in "program/localization" change "th" to "th_TH" Regards, Wiraphan Treeratphan --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Gf/XWMqcJCC/th_TH.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

3 2

Shared folders (Feature request #1403507)
by Robin Elfrink 25 Sep '07

25 Sep '07

Hi, Is anybody working on support for shared folders? If not I volunteer to try and implement them. It doesn't seem too hard, just a lot of work. Especially a number of changes in the IlohaMail IMAP library. Robin PS. IlohaMail development seems to be dead, no CVS commits for over 2 years. Does anybody have more info about that? _______________________________________________ List info: http://lists.roundcube.net/dev/

4 5

control-click bug in IE7
by Joel Clermont 24 Sep '07

24 Sep '07

I am cutting and pasting the reply I got from Microsoft today. They definitely acknowledge it as a bug, but they seem to be implying it is something that they may or may not fix. Please read over his reply and give me any direction you can on how to proceed. I already replied and told him that neither "workaround" he lists is valid for us. Based on previous discussions, it sounds like roundcube intends to maintain a real <a> tag pointing to a real URL. Hi Joel, The DIV case is really a different scenario. It does not have any special meaning when Ctrl + Click so that should be consistent with what you see in IE6. IE7 added a special case for Anchor tag handling when Ctrl + Click. I am currently working on this issue with my escalation engineer, Shahinur. You raise a valid point about the onclick event should be fired for Ctrl + Click regardless of which window the navigation happens in. At this point this does look like a bug in IE7. I don’t see any good workaround for this problem. There are a few ideas that that you may have already knew or touched on at some point: 1) Try avoid using the Anchor tag, you can use other elements like DIV (you already knew) or SPAN tag and still mimic the Anchor tag appearance. Some thing like this: <span style="text-decoration: underline; cursor:hand; color:blue" onclick="aFunction()" > click this "link" </span>. 2) It seems that if the Anchor tag does not have a valid href URL attribute. If the href attribute is set to “” (empty string) or “#” or even non-existant then things are working as expected. Below is an example of the href missing: If these workarounds do not work for you, we can request a hotfix from the product team. Keep in mind that there is always a chance that the hotfix request can be rejected. If you diecide to pursue this route, I would need to have a Business Impact statement from you addressing the following questions. Once I have the Business Impact Statement, I can file a formal hotfix request to the product team: 1. Business Impact - How does this bug affect your business - Why are current workarounds, if any, unacceptable 2. Financial Impact (include how it was calculated) - What is the financial impact of the bug - What is the financial impact of the best workaround, if any 3. Problem's frequency and probability? 4. Number of companies impacted 5. Number of corporate desktops and servers impacted 6. Number of consumer desktops (ie. home users) impacted 7. What IE platform is the hot fix needed? - IE 6.0 sp2 on XP SP2 - IE 6.0 on Windows 2003 Server - IE 6.0 on Windows 2003 Server SP1 - IE 7.0 on Vista - IE 7.0 on XP SP2 - IE 7.0 on Windows 2003 Server SP1 9. What type of hot fix package do you need? QFE – This package takes about 1-2 months to release and has a strict acceptance criteria. It is only distributed to customers by contacting Microsoft Support referencing a KB article. It is also redistributable only within a corporation (but not to the corporation’s customers). The fix is usually enabled by setting a specific registry key on the machine. GDR – This package takes about 3-6 months to release and is subjected to more testing and an even higher acceptance criteria. It is distributed to customers by downloading it from a public Microsoft link. This package is normally not available if a QFE meets your needs. 8. What languages (English, Chineses,...) are needed? Joel Clermont joel(a)orionweb.net 262-377-9930 _______________________________________________ List info: http://lists.roundcube.net/dev/

6 10

Re: [RCD] control-click bug in IE7
by Joel Clermont 23 Sep '07

23 Sep '07

You may not need to after all. Someone proposed a workaround that actually works! But if you wanted to you can call Microsoft and open a formal support ticket like I did. I suppose the more complaints they get, the better. Joel Clermont joel(a)orionweb.net 262-377-9930 On Sep 23, 2007, at 5:37 PM, Martin Kealey wrote: > We have 10^N (N>5) customers depending on RoundCube, so this is a > real issue for us. > > Where do we sign up to complain? > > -Martin > -- > Martin D Kealey, ihüg engineering > >> -----Original Message----- >> From: Joel Clermont [mailto:joel@orionweb.net] >> Sent: Sunday, September 23, 2007 12:45 AM >> To: Michael Büker >> Cc: dev(a)lists.roundcube.net >> Subject: Re: [RCD] control-click bug in IE7 >> >> I had a long talk with this support rep on the phone the >> other day. He said that a number of people (though he >> wouldn't tell me how many) have filed a bug notice on this >> very issue. Internally, the bug is graded as "fix in next >> release", which means IE 8. That is probably at least 3 years >> off, and likely longer. He said that no one has yet opened a >> formal support ticket on this issue. We are the first. It's a >> shame we have to play their game, but the only way to get >> your bug's priority bumped is to make a business impact case. >> Then again, there is no guarantee that they will escalate the >> bug even with this document. And even if they do escalate it, >> the best case time frame for a generally deployed fix is 3 - >> 6 months. Despite this, I think it is still worth submitting >> the document and getting the process started. >> >> In the meantime, I wanted to propose an alternate solution. >> As I understand it, making the subject text an <A> tag was to >> accommodate a small subset of users. Could we possibly create >> a new setting in the personal settings area where the >> individual user could toggle whether they want this as an <A> >> tag or not? Ideally, the server admin could set a default >> value and then let users override it. I think this might be >> the best short term solution until MS fixes the real bug, if >> they ever do. >> >> What does everyone think? Also, could someone take a few >> minutes and explain to me again the full reason for the <A> >> tag with a real href? Was it just accessibility reasons? >> >> Joel Clermont >> joel(a)orionweb.net <mailto:joel@orionweb.net> >> 262-377-9930 >> >> >> >> >> On Sep 22, 2007, at 5:50 AM, Michael Büker wrote: >> >> >> On Friday 21 September 2007, Joel Clermont wrote: >> >> If these workarounds do not work for you, we >> can request a hotfix >> from the product team. Keep in mind that there >> is always a chance >> that the hotfix request can be rejected. If >> you diecide to pursue >> this route, I would need to have a Business >> Impact statement from you >> addressing the following questions. Once I >> have the Business Impact >> Statement, I can file a formal hotfix request >> to the product team: >> >> <we'll only fix this if you are important enough> >> >> >> I can't believe this! You've proven to them it's a >> nonstandard behaviour, it >> breaks actions that are expected, they even admitted >> it's a _bug_, and they >> tell you to get down on your knees and beg so they >> _might_ fix it, but only >> if they deem you important enough, _and_ there's enough >> money involved! >> >> How much would I like to put a fat notice on the >> roundcube homepage >> saying "IE7 broken!", we don't support it period. >> >> What a bunch of arrogant, superbureaocratic, incapable assholes! >> >> Sorry, I had to let this steam off ;) >> >> ~Mik >> >> -- >> Heisenberg gets stopped by a cop for speeding. >> "Do you have any idea how fast you were going?", asks the cop. >> "No. But I know exactly where I am!" >> _______________________________________________ >> List info: http://lists.roundcube.net/dev/ >> >> >> _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Fix for #1484187: Preview pane height incorrect in Safari & Konquerer
by Robin Elfrink 21 Sep '07

21 Sep '07

Hi, I finally found a fix for #1484187. Instead of the currently used dynamic height and width settings, it simpy positions absolutely inside the containing (and also absolutely positioned) div. I may look hackish, and maybe it is, but this patch makes another hack unneeded :) Tested in the following browsers: - Firefox 2.0.0.7 on Window XP - Internet Explorer 6 on Linux (IEs4Linux project) - Internet Explorer 7 on Windows XP - Konqueror 3.5.6 on Linux (the bottom border of the containing div disappeared...) - Opera 9.02 on Windows XP - Safari 2.0.4 on Mac OS X - Safari 3.0.3 on Windows XP If there are no problems in any other (major) browsers on other (major) platforms I'll commit this in the weekend. Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/cn/EAeQ7c+x/_1484187.20070921161.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Can't send emails - "directly called /usr/sbin/exim instead of /usr/sbin/sendmail"
by Søren Aggeboe 20 Sep '07

20 Sep '07

Hi, since I updated to the latest SVN version (800) I can't send emails. Mail delivery failed: returning message to sender Gid 32299 is not permitted to relay mail, or has directly called /usr/sbin/exim instead of /usr/sbin/sendmail. ?? Regards /Søren _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

multi select question
by Joel Clermont 20 Sep '07

20 Sep '07

I run a small web hosting business and we just switched from SquirrelMail to RoundCube. Overall, our clients love it. The polished interface is so nice coming from the previous app. The biggest problem people moan about is multi-select. It is not intuitive to use a key modifier like Shift or Control to select multiple messages. In addition, in IE7 when you control-click it opens the message in another tab, so if you control-click 10 messages to delete them, you now also have 10 tabs to close. Is there something I am missing on this problem? Is there a setting where I can enable an old school checkbox column for people to use in multi-select? Joel Clermont joel(a)orionweb.net 262-377-9930 _______________________________________________ List info: http://lists.roundcube.net/dev/

5 16

Fwd: Problem with http://roundcube.tobix.org/
by Brett Patterson 19 Sep '07

19 Sep '07

Forgot to "reply to all"..... ---------- Forwarded message ---------- From: Brett Patterson <brett1434(a)gmail.com> Date: Sep 19, 2007 1:15 PM Subject: Re: [RCD] Problem with http://roundcube.tobix.org/ To: Thomas Bruederli <roundcube(a)gmail.com> Not to be a pain.... but how can you have a September 30, 2007 build already? I mean, I know there's a time difference, but two weeks ahead of time :) I'd also like to point out that tobix.org puts up nightly builds in the literal sense. Instead of just having nighlty builds that are only published if things are modified (like nightly.roundcube.net) he does a build every night no matter what. So what some people find to be "the latest" is really 3 weeks ago stuff. Is there any code behind the nightly.roundcube.net stuff? If there is, I'd be willing to take a look at it and see if I can't get some information up there so there's something like: Latest Nightly Build: September, 13, 2007 Revision 675 Notes on Build: This is where the commit notes would be displayed Previous Builds: September 10, 2007 Revision 674 July 31, 2007 Revision 67x I'm not 100% sure how this would work out, but something like that would be better. Do it for both the devel-vnext and trunk builds. That way there's no reason to have 30 different nightlies, we could just set up rsynced mirrors (so that roundcube.tobix.org, nightly.roundcubeforum.net both use rsync to grab the info from nightly.roundcube.net and mirror it). Just a suggestion. ~Brett On 9/19/07, Thomas Bruederli <roundcube(a)gmail.com > wrote: > > 2007/9/19, Julien Wadin <julien(a)wadin.be >: > > Thomas Bruederli a écrit : > > > Hi Julien, > > > > > > If you need help with a RoundCube installation, then the users mailing > > > list is the one to contact. This list is reserved to discuss the > > > ongoing development. Please read the instructions > > > (http://lists.roundcube.net/) before posting! > > > > > > > Hi Thomas, > > This website is not mine > > It containts archives with all svn versions, so he's very useful to > > always have the latstet dev version > > My message was destinated to the maintener of this website, if present > here. > > Well, I did not remember this. Some more details than "Can anyone fix > it" would have been helpful. Nevertheless this is still the wrong > place to ask. When looking for the owner of that server > whois > tobix.org might help. > > But after searching the wiki you finally pointed me to some outdated > content. You can download nightly SVN builds from > http://nightly.roundcube.net. > > ~Thomas > _______________________________________________ > List info: http://lists.roundcube.net/dev/ > -- ~ Brett Patterson -- ~ Brett Patterson _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Problem with http://roundcube.tobix.org/
by Julien Wadin 19 Sep '07

19 Sep '07

Hi all, http://roundcube.tobix.org/ says Forbidden. Can anyone fix it ? Thanks -- Wadin Julien Tel : +32 (0) 475 632 168 Web : http://blog.julienwadin.be/ Simplifiez vous Postfix : http://postfixwinadmin.jwhosting.eu _______________________________________________ List info: http://lists.roundcube.net/dev/

4 6

status on the forums?
by kyle 19 Sep '07

19 Sep '07

Anyone know when the forums will be back up? Thanks. -- kyle http://ronpaul2008.com - official website _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

incorporating "change password" into roundcube
by kyle 19 Sep '07

19 Sep '07

There is a post on the forums that told how to add "change password" functionality into RoundCube. I can no longer access the forums and am hoping someone can give me (or point me to) some instructions on how to add this functionality. I had this working, but when I updated, the changes obviously went away and I couldn't figure out how to duplicate it. Thanks. -- kyle http://ronpaul2008.com _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Missing recipient/subject on replys
by Ethan Erchinger 17 Sep '07

17 Sep '07

Nobody has seen this, or everyone is ignoring the question? ================================================ Hi, I looked quite a bit but didn't see anyone else complaining about this. I recently (3 weeks ago) upgraded to the latest SVN, and migrated configuration files, and database data to the new schema. Actually I wasn't sure what may have changed in the schema, so I created a new DB, and just migrated the contacts to the new DB. After that sometimes when clicking on reply in a message, the compose window comes up, with all details, except the recent window is blank, and the subject contains on "re:". Finally the header inserted at the top of the message "On <date>, <recipient> wrote," is missing the date and recipient data. Any ideas what could be wrong? I see no errors in apache error_log or in any files in "logs". I believe filesystem permissions are set correctly. Thanks for any help you can provide. Ethan _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

Fwd: Question about Templates
by Brett Patterson 14 Sep '07

14 Sep '07

Jorge: There isn't a list of items used, so you'd have to search in the code to see what's available to you. $CONFIG (I think that's what it is) and $_POST and $_SESSION is available always as they're global. Other than that, you'd have to look through the documentation that's written in the wiki or through the code. sorry. ~Brett On 9/14/07, Jorge Asch <jasch(a)conexion.co.cr> wrote: > > If this works as advertised, where can I get a list of common variables > that might be in use. > > What do you mean by "proper template engine"? What roundcube has is > perfectly fine. There's no need to hunker down and rework the entire code > to use SMARTY or any other PHP templating system, or to use a different > one. The one we have works, and works well. > > > -- > Jorge Asch Revilla > CONEXION DCR > www.conexion.co.cr > 800-CONEXION > > > -- ~ Brett Patterson -- ~ Brett Patterson _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Question about Templates
by Jorge Asch 14 Sep '07

14 Sep '07

How would I print out a variable on a template. For example, I would like to display a text with the user's email address, or display a text with the currently choosen language setting. How would I acomplish this on a template? Thanks. -- Jorge Asch Revilla CONEXION DCR www.conexion.co.cr 800-CONEXION _______________________________________________ List info: http://lists.roundcube.net/dev/

4 3

Firefox line break issue
by Joel Clermont 13 Sep '07

13 Sep '07

I have noticed that plain text emails in Firefox lose the line breaks if I copy and paste into a new message. The line breaks are preserved if I use an HTML message, or if I use plain text with Safari or IE. Has anyone else noticed this? Is there a workaround? Joel Clermont joel(a)orionweb.net 262-377-9930 _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

Problems with last version from SVN
by Julien Wadin 12 Sep '07

12 Sep '07

Hi all, I took the last version from the SVN because it has a built-in html editor. Very very nice ! The problem I have is that when I reply to a message in my inbox, the To filed is left blank... Also, when I send a message, an alert says me that my body is blank. I push OK and the message is sent correctly, with the body I wrote. Any ideas about these 2 issues ? Many thanks -- Wadin Julien Tel : +32 (0) 475 632 168 Web : http://blog.julienwadin.be/ Simplifiez vous Postfix : http://postfixwinadmin.jwhosting.eu _______________________________________________ List info: http://lists.roundcube.net/dev/

3 5

Missing recipient/subject on replys
by Ethan Erchinger 11 Sep '07

11 Sep '07

Hi, I looked quite a bit but didn't see anyone else complaining about this. I recently (3 weeks ago) upgraded to the latest SVN, and migrated configuration files, and database data to the new schema. Actually I wasn't sure what may have changed in the schema, so I created a new DB, and just migrated the contacts to the new DB. After that sometimes when clicking on reply in a message, the compose window comes up, with all details, except the recent window is blank, and the subject contains on "re:". Finally the header inserted at the top of the message "On <date>, <recipient> wrote," is missing the date and recipient data. Any ideas what could be wrong? I see no errors in apache error_log or in any files in "logs". I believe filesystem permissions are set correctly. Thanks for any help you can provide. Ethan _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

MySQL usage to much??
by crow 11 Sep '07

11 Sep '07

Hello All, I setup a Roundcube webmail, and it is working fine. Some part not but i can live with that. The problem is that my Server admin is complaining about mysql usage and threads that Roundcube make. I disabeled CACHE but that didnt help either: / enable caching of messages and mailbox data in the local database. // this is recommended if the IMAP server does not run on the same machine $rcmail_config['enable_caching'] = FALSE; // lifetime of message cache // possible units: s, m, h, d, w $rcmail_config['message_cache_lifetime'] = '10d'; Readed that on forum: http://roundcubeforum.net/forum/index.php?topic=116.msg927#msg927 Here is list of thread that are on MySQL5 > Id User Host/IP DB Time Cmd Query > or State > -- ---- ------- -- ---- --- > ---------- > 7547906 root localhost USERNAME_test 0 Query show > full processlist > 7547970 USER1_em localhost USER1_ema 0 > Sleep > > 7547997 USER1_em localhost USER1_ema 1 > Sleep > > 7546309 USER1_em localhost USER1_ema 3 > Sleep > > 7547986 USER1_em localhost USER1_ema 10 > Sleep > > 7547875 USER1_em localhost USER1_ema 84 > Sleep > > 7547789 USER1_em localhost USER1_ema 139 > Sleep > > 7546131 eximstats localhost eximstats 200 > Sleep > > 7546390 USER1_em localhost USER1_ema 259 > Sleep > > 7547605 USER1_em localhost USER1_ema 266 > Sleep > > 7546367 USER1_em localhost USER1_ema 318 > Sleep > > 7546235 USER1_em localhost USER1_ema 325 > Sleep > > 7546220 USER1_em localhost USER1_ema 502 > Sleep > > 7546209 USER1_em localhost USER1_ema 562 > Sleep > > 7546684 USER1_em localhost USER1_ema 802 > Sleep > > 7546414 USER1_em localhost USER1_ema 982 > Sleep > > 7546406 USER1_em localhost USER1_ema 991 > Sleep > > 7546358 USER1_em localhost USER1_ema 1019 > Sleep > > 7546350 USER1_em localhost USER1_ema 1029 > Sleep > > 7546141 USER1_em localhost USER1_ema 1149 > Sleep > If someone have any suggestion pls let me know. Btw: runing last SVN from roundcubemail. thNX _______________________________________________ List info: http://lists.roundcube.net/dev/

6 9

Switch character seta
by Yoshikazu Tsuji 11 Sep '07

11 Sep '07

Hello. Some mailler doesn't suuport UTF-8. So, we japanese need to switch charater set. Maybe, I think other people who use multibyte language also need to switch. This is patch to add character set selector. This code was exist in older version. ============================================================ --- ./skins/default/templates/compose.html (svn rev 667) +++ ./skins/default/templates/compose.html (changed) @@ -104,6 +104,9 @@ <roundcube:button type="input" command="list" class="button" label="cancel" /> </td> <td align="right"> +<roundcube:label name="charset" />: <roundcube:objectname="charsetSelector"> +</td> +<td align="right"> <roundcube:label name="editortype" />: <span class="radios-left"><roundcube:object name="editorSelector" tabindex="9" /></span> </td> ============================================================ This is patch to set default character set every languages. ============================================================ --- ./program/localization/index.inc_ (svn rev 672) +++ ./program/localization/index.inc (changed) @@ -88,7 +88,11 @@ 'tw' => 'zh_TW' ); -$rcube_charsets = array(); +$rcube_languages_default_charset = array( + 'en_US' => 'ASCII', + 'en_GB' => 'ASCII', + 'kr' => 'EUC-KR', + 'zh_TW' => 'BIG5', + 'zh_CN' => 'GB2312', + 'ja' => 'ISO-2022-JP' +); +$rcube_charsets = array(); ?> ============================================================ This is patch to set default character to charset_selector. ============================================================ --- rcmail_template.inc_ (svn rev 732) +++ rcmail_template.inc (changed) @@ -824,7 +824,12 @@ function rcmail_charset_selector($attrib) { global $OUTPUT; + global $sess_user_lang; + static $rcube_languages_default_charset; + if (empty($rcube_languages_default_charset)) + @include($INSTALL_PATH.'program/localization/index.inc'); + // pass the following attributes to the form class $field_attrib = array('name' => '_charset'); foreach ($attrib as $attr => $value) @@ -853,7 +858,12 @@ $select = new select($field_attrib); $select->add(array_values($charsets), array_keys($charsets)); - $set = $_POST['_charset'] ? $_POST['_charset'] : $OUTPUT->get_charset(); + // language has default charset configured + if (isset($rcube_languages_default_charset[$sess_user_lang])) + $set = $rcube_languages_default_charset[$sess_user_lang]; + else + $set = 'UTF-8'; + return $select->show($set); } ============================================================ Yoshikazu. -- /** ----------------------------------------- * Yoshikazu Tsuji @ church.ne.jp * * E-mail : yskzt(a)church.ne.jp * Web : http://church.ne.jp/ * ------------------------------------------ */ _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] Ticket #1484429
by yskzt＠church.ne.jp 11 Sep '07

11 Sep '07

Hi. I thought mbstring functions can handle chr(160) in UTF-8. But, when I test my patch, mbstring return false and report error "mb_strpos(): Unknown encoding or conversion error.". like this: mb_internal_encoding("UTF-8"); $test_str = "abcd".chr(160)."efg"; mb_strpos($test_str, chr(160)) ==> false I searched web sites. - The chr(160) in UTF-8 is incorrect. (http://en.wikipedia.org/wiki/UTF-8) - In UTF-8, no-break space(nbsp) is 0xC2 0xA0. (http://www.fileformat.info/info/unicode/char/00a0/index.htm) So, how about this? =================================== --- main.inc_ 2007-09-03 16:10:32.000000000 +0900 (rev 774) +++ main.inc 2007-09-12 01:05:31.000000000 +0900 (changed) @@ -1103,6 +1103,17 @@ return $str; } +function mb_str_replace($search_str, $replace_str, $str) + { + $current_pos = 0; + while (($found_pos = mb_strpos($str, $search_str, $current_pos)) !== false) + { + $str = mb_substr($str, 0, $found_pos).$replace_str.mb_substr($str, $found_pos + mb_strlen($search_str)); + $current_pos = $found_pos + strlen($replace_str); + } + + return $str; + } /** * Replacing specials characters to a specific encoding type @@ -1123,7 +1134,12 @@ // convert nbsps back to normal spaces if not html if ($enctype!='html') - $str = str_replace(chr(160), ' ', $str); + { + if ($OUTPUT->get_charset()=='UTF-8') + $str = mb_str_replace(chr(194).chr(160), ' ', $str); + else + $str = str_replace(chr(160), ' ', $str); + } // encode for plaintext if ($enctype=='text') =================================== Yoshikazu. On Wed, 5 Sep 2007 03:05:21 +0200, till <klimpong(a)gmail.com> wrote: > On 9/3/07, Yoshikazu Tsuji <yskzt(a)church.ne.jp> wrote: >> Hi. >> >> The following code causes Ticket #1484429 >> (http://trac.roundcube.net/trac.cgi/ticket/1484429). >> ============================================================= >> = "program/include/main.inc" function rep_specialchars_output >> >> // convert nbsps back to normal spaces if not html >> if ($enctype!='html') >> $str = str_replace(chr(160), ' ', $str); >> ============================================================= >> >> This problem is happened in multibyte enviroment (japanese too). >> In message list, function rep_specialchars_output garbled >> UTF-8 message subjects. >> >> Is converting chr(160) to space really necessary ? >> >> This is patch using multi byte functions. >> >> =============================================================== >> --- main.inc_ 2007-09-03 16:10:32.000000000 +0900 >> +++ main.inc 2007-09-03 16:22:59.000000000 +0900 >> @@ -1122,8 +1122,17 @@ >> $enctype = $GLOBALS['OUTPUT_TYPE']; >> >> // convert nbsps back to normal spaces if not html >> - if ($enctype!='html') >> - $str = str_replace(chr(160), ' ', $str); >> + if ($enctype!='html') { >> + $current_pos = 0; >> + while(true) { >> + $found_pos = mb_strpos($str, chr(160), $current_pos); >> + if($found_pos == false) >> + break; >> + >> + $str = mb_substr($str, 0, $found_pos)." ".mb_substr($str, > $found_pos >> + 1, mb_strlen($str)); >> + $currentpos += 1; >> + } >> + } >> >> // encode for plaintext >> if ($enctype=='text') >> =============================================================== > > multibyte looks like the better alternative, especially since we are > dealing with people from different countries. And since we are using > mb already, I have no issues with this. > > Just one thing, can you add this to the trac? Please? :) > > Thanks, > Till _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Small LDAP patch
by Harold Aling 11 Sep '07

11 Sep '07

Dear list, I'm a novice in Roundcube 'hacking', but I plan to fix a few items in the future, since I really like RC! To enable my local LDAP addressbook, I had to change the following line in 'rcube_ldap.inc' (svn version): Index: rcube_ldap.inc =================================================================== --- rcube_ldap.inc (revision 774) +++ rcube_ldap.inc (working copy) @@ -90,7 +90,7 @@ { if ($lc = @ldap_connect($host, $this->prop['port'])) { - ldap_set_option($lc, LDAP_OPT_PROTOCOL_VERSION, $this->prop['port']); + ldap_set_option($lc, LDAP_OPT_PROTOCOL_VERSION, 3); $this->prop['host'] = $host; $this->conn = $lc; break; Maybe $this->prop['ldap_version'] can be added to the preferences? -H- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] multi select question
by Thomas Bruederli 11 Sep '07

11 Sep '07

2007/9/10, Michael Baierl <mail(a)mbaierl.com>: > Thomas Bruederli wrote: > > Joel Clermont wrote: > >> The biggest problem people moan about is multi-select. It is not > >> intuitive to use a key modifier like Shift or Control to select multiple > >> messages. > > > > What is not intuitive in this behavior? All apps behave like this. > Windows Apps: yes. > Web apps: no. Users are not used to use Strg+Shift on Webapps and most > users are not even used to that on Windows - they just use the mouse. > Watch your mum and you will see ;) I kind of expected this answer... But nevertheless web apps are starting to replace desktop applications and also copy the way to control them. Yahoo! Mail found a nice way to support both: they have checkboxes (not real ones but HTML elements) but also allow to multi-select messages using shift/ctrl. ~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev