- Dev - Roundcube mailing lists

Re: Next Beta Release
by chasd 22 Dec '06

22 Dec '06

> Matt Kaatman said: > > Do we have any goals before we release the next beta? > > Maybe a feature freeze is in order to get a newer beta out? I think a release that includes the vulnerability fix - <http://trac.roundcube.net/trac.cgi/ticket/1484109> should be made, so new RoundCube users don't have to patch their fresh install. Many first time users will likely choose to download a beta release rather than an SVN snapshot that contains the fix. Charles Dostale System Admin - Silver Oaks Communications http://www.silveroaks.com/ 824 17th Street, Moline IL 61265

2 1

Hungarian language files, updated
by Szalma László 22 Dec '06

22 Dec '06

Here goes the updated Hungarian language files, please somebody commit it with the next update. http://dblaci.hu/hu.tar.gz Thanks DB

1 0

Re: #1326320
by Thomas Bruederli 22 Dec '06

22 Dec '06

Hi Pierre Please update your local copy to the latest revision (svn update) and then create the diff again. The current one removes newly added features :-( ~Thomas Pierre Lena wrote: > Here is the diff file. > > Regards. >

3 3

Webmail competition
by Thomas Bruederli 22 Dec '06

22 Dec '06

Hi everybody, Looks like the others are getting closer: Gmail like AJAX powered Web 2.0 version of IMP http://janschneider.de/news/25/252 Duroty System (BETA) is the open source Gmail http://www.duroty.com/en/index.jsp The main problem of RoundCube is the project manager's lack of time and as a consequence of that the bad project organization, both my faults. If somebody thinks he or she could afford some time (actually it's a full-time job) and who has some experience in project management, I'm willing to give away the "power" and become a regular developer (that's what I really am). Regards, Thomas

9 13

1388203 - Reuse HTTP authentication for login - PATCH
by Black.myst 21 Dec '06

21 Dec '06

Hello, I try to find a issue for bug 1388203 (http://trac.roundcube.net/trac.cgi/ticket/1388203) Diff explanation : - config/main.inc.php.dist : Add new configuration boolean 'http_authent'. False : use the standard login page. (default) True : use $_SERVER["PHP_AUTH_USER"] to log user. - skins/default/includes/taskbar.html : Add a <roundcube:if> to remove logout button when used http_authent - program/include/main.inc : Fixe <roundcube:include> to parse <roundcube:if> in included file. (Else my <roundcube:if> in taskbar.html not work!) - index.php : Add code to allow http authent. - program/steps/error.inc : Add "Allow cookies" in browser requirement page. (I display this page (409) if the user disable cookies with http_authent) Black Myst Index: config/main.inc.php.dist =================================================================== --- config/main.inc.php.dist (revision 414) +++ config/main.inc.php.dist (working copy) @@ -77,6 +77,9 @@ // best server supported one) $rcmail_config['smtp_auth_type'] = ''; +// use http authentication : get login and pass from PHP variables +$rcmail_config['http_authent'] = FALSE; + // Log sent messages $rcmail_config['smtp_log'] = TRUE; Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 414) +++ program/include/main.inc (working copy) @@ -1265,7 +1265,7 @@ { $incl = fread($fp, filesize($path)); fclose($fp); - return parse_rcube_xml($incl); + return parse_rcube_xml(parse_rcube_conditions($incl)); } break; Index: program/steps/error.inc =================================================================== --- program/steps/error.inc (revision 414) +++ program/steps/error.inc (working copy) @@ -35,6 +35,7 @@ <br /> »  JavaScript enabled<br /> »  Support for XMLHTTPRequest<br /> +»  Allow cookies<br /> <p><i>Your configuration:</i><br /> $user_agent</p> @@ -115,4 +116,4 @@ </html> EOF; -?> \ No newline at end of file +?> Index: skins/default/includes/taskbar.html =================================================================== --- skins/default/includes/taskbar.html (revision 414) +++ skins/default/includes/taskbar.html (working copy) @@ -2,5 +2,7 @@ <roundcube:button command="mail" label="mail" class="button-mail" /> <roundcube:button command="addressbook" label="addressbook" class="button-addressbook" /> <roundcube:button command="settings" label="settings" class="button-settings" /> +<roundcube:if condition="config:http_authent != true" /> <roundcube:button command="logout" label="logout" class="button-logout" /> -</div> \ No newline at end of file +<roundcube:endif /> +</div> Index: index.php =================================================================== --- index.php (revision 414) +++ index.php (working copy) @@ -162,8 +162,42 @@ } +// try to log in if http_authen +if ($CONFIG['http_authent'] && (!isset($_SESSION['user_id']) || !rcmail_authenticate_session())) + { + if (empty($_COOKIE) && !$_action=='login') + { // if no cookie, force reload the page to check if cookies is enabled. + header("Location: $COMM_PATH&_action=login"); + exit; + } + else if (empty($_COOKIE) && $_action=='login') + { // if action login and no cookies: user has disabled cookies -> error + raise_error( + array('code' => 409, + 'type' => 'php', + 'message' => "User not allow cookies"), + FALSE, + TRUE); + } + else if (isset($_SERVER["PHP_AUTH_USER"]) && isset($_SERVER["PHP_AUTH_PW"]) && + rcmail_login($_SERVER["PHP_AUTH_USER"], $_SERVER["PHP_AUTH_PW"], + rcmail_autoselect_host())) + { + // http_authen success + } + else + { // http_authent faild ! + raise_error( + array('code' => 401, + 'type' => 'imap', + 'message' => "Http_authent faild for user :".$_SERVER['PHP_AUTH_USER']), + TRUE, + TRUE); + exit; + } + } // try to log in -if ($_action=='login' && $_task=='mail') +else if (!$CONFIG['http_authent'] && $_action=='login' && $_task=='mail') { $host = rcmail_autoselect_host();

2 5

SysAdmins and RoundCube
by Brennan Stehling 21 Dec '06

21 Dec '06

As Jim stated in the previous email... "On another subject: It seems we have a lot of sysadmins offering time, so we might even be able to dedicate certain ones to certain setups ("specialists" I guess they could be called). For example, it would be best to have an admin who uses Dovecot on a daily basis to be responsible for its testing. They would be more likely to know quirks and what might be a configuration issue. If someone reports a problem, a specialist could test, attempt to reproduce the problem, and gather more information before the ticket is passed on to an actual developer. Just another idea..." If you are a SysAdmin and would like to be involved in a non-developer aspect please respond to this email. It sounds like Jim has some resources at his disposal and we could pool our efforts to produce a good testing environment. What Jim and I have already discussed is scheduling a script to pull down the current versions from SVN and redeploy and test the RC installs. Scripting the syncing via SVN, putting the files in place, adjusting the config file and rebuilding the database are all simple steps that we can put together. From there we need to generate a set of sample emails into the system so that we can test show RC handles it. One way to automate those test is the Selenium tool. (http://www.openqa.org/selenium/) We can put together a series of testing using Selenium IDE (http://www.openqa.org/selenium-ide/) which one of can run manually to go through each of the automated tests. We can log any bugs as they happen. And the Selenium tests will run in FireFox, MSIE, Opera or Safari, so once we have these tests working we can make the available for testers to run on the various browser and platform versions beyond what we may test among ourselves. I expect to just test FireFox and MSIE. These tests will help accelerate development and offload some of the testing done by the developers. Brennan Stehling Offwhite.net LLC brennan(a)offwhite.net

1 0

Re:
by Ryan Rittenhouse 20 Dec '06

20 Dec '06

I've been hacking away at this trying to get it to work with the latest svn, mostly by manually going through and patching everything. So far, no luck. I get to the Mail rules page and the button to add new rules does nothing. I guess the next step is for me to backup to v400 and try it first. Has anyone gotten this working yet? -Ryan Network Administrator Goshen College (574) 535-7004 Pierre Lena wrote: > The diff file can be downloaded there > http://www.mangoose.org/RoundCube/filters/filters_diff.diff > > The table structure to handle mailrule is: > CREATE TABLE `mailrules` ( > `mailrule_id` int(11) NOT NULL auto_increment, > `from` varchar(128) default NULL, > `to` varchar(128) default NULL, > `subject` varchar(128) default NULL, > `user_id` int(10) unsigned NOT NULL default '0', > `del` tinyint(1) NOT NULL default '0', > `location` varchar(128) default NULL, > PRIMARY KEY (`mailrule_id`) > ) TYPE=MyISAM; > > Here are the added files: > http://www.mangoose.org/RoundCube/filters/addmailrule.html goes to skins/default/templates > http://www.mangoose.org/RoundCube/filters/delete_mailrule.inc goes to program/steps/settings/ > http://www.mangoose.org/RoundCube/filters/editmailrule.html goes to skins/default/templates > http://www.mangoose.org/RoundCube/filters/edit_mailrule.inc goes to program/steps/settings/ > http://www.mangoose.org/RoundCube/filters/mailrules.html goes to skins/default/templates > http://www.mangoose.org/RoundCube/filters/mailrules.inc goes to program/steps/settings > http://www.mangoose.org/RoundCube/filters/save_mailrule.inc goes to program/steps/settings/ > > Regards. > > > On Wed, 20 Dec 2006 20:37:40 +0100, Pierre Lena <plena(a)mangoose.org> wrote: >> Here is the diff file. >> >> Regards. >> >> On Wed, 20 Dec 2006 20:17:59 +0100, Pierre Lena <plena(a)mangoose.org> >> wrote: >>> How do I create the diff? >>> Do I need to reload the svn400 to create it? >>> >>> On Wed, 20 Dec 2006 20:14:53 +0100, Tomasz Pajor <t.pajor(a)kei.pl> >> wrote: >>>> You send the diff to mailing list, or create a ticket on >>>> http://trac.roundcube.net/ >>>> >>>> -- >>>> Best regards >>>> Tom >>>> >>>> Dnia Wed, 20 Dec 2006 19:56:36 +0100 napisales[as]: >>>>> Hi, >>>>> >>>>> I am new to the list. >>>>> I developped mail filters for roundcube based on svn400. >>>>> How can I send the file I modified to make them part of the project? >>>>> >>>>> Regards. >>>>> Pierre >>>>> >>>>> >>>>> --- >>>>> Antivirus avast! : message Sortant sain. >>>>> Base de donnees virale (VPS) : 0661-0, 20/12/2006 >>>>> Analyse le : 20/12/2006 19:56:37 >>>>> avast! - copyright (c) 1988-2006 ALWIL Software. >>>>> http://www.avast.com >>>>> > > >

2 1

(no subject)
by Pierre Lena 20 Dec '06

20 Dec '06

The diff file can be downloaded there http://www.mangoose.org/RoundCube/filters/filters_diff.diff The table structure to handle mailrule is: CREATE TABLE `mailrules` ( `mailrule_id` int(11) NOT NULL auto_increment, `from` varchar(128) default NULL, `to` varchar(128) default NULL, `subject` varchar(128) default NULL, `user_id` int(10) unsigned NOT NULL default '0', `del` tinyint(1) NOT NULL default '0', `location` varchar(128) default NULL, PRIMARY KEY (`mailrule_id`) ) TYPE=MyISAM; Here are the added files: http://www.mangoose.org/RoundCube/filters/addmailrule.html goes to skins/default/templates http://www.mangoose.org/RoundCube/filters/delete_mailrule.inc goes to program/steps/settings/ http://www.mangoose.org/RoundCube/filters/editmailrule.html goes to skins/default/templates http://www.mangoose.org/RoundCube/filters/edit_mailrule.inc goes to program/steps/settings/ http://www.mangoose.org/RoundCube/filters/mailrules.html goes to skins/default/templates http://www.mangoose.org/RoundCube/filters/mailrules.inc goes to program/steps/settings http://www.mangoose.org/RoundCube/filters/save_mailrule.inc goes to program/steps/settings/ Regards. On Wed, 20 Dec 2006 20:37:40 +0100, Pierre Lena <plena(a)mangoose.org> wrote: > Here is the diff file. > > Regards. > > On Wed, 20 Dec 2006 20:17:59 +0100, Pierre Lena <plena(a)mangoose.org> > wrote: >> How do I create the diff? >> Do I need to reload the svn400 to create it? >> >> On Wed, 20 Dec 2006 20:14:53 +0100, Tomasz Pajor <t.pajor(a)kei.pl> > wrote: >>> You send the diff to mailing list, or create a ticket on >>> http://trac.roundcube.net/ >>> >>> -- >>> Best regards >>> Tom >>> >>> Dnia Wed, 20 Dec 2006 19:56:36 +0100 napisales[as]: >>>> Hi, >>>> >>>> I am new to the list. >>>> I developped mail filters for roundcube based on svn400. >>>> How can I send the file I modified to make them part of the project? >>>> >>>> Regards. >>>> Pierre >>>> >>>> >>>> --- >>>> Antivirus avast! : message Sortant sain. >>>> Base de donnees virale (VPS) : 0661-0, 20/12/2006 >>>> Analyse le : 20/12/2006 19:56:37 >>>> avast! - copyright (c) 1988-2006 ALWIL Software. >>>> http://www.avast.com >>>>

1 0

Re: #1326320
by Pierre Lena 20 Dec '06

20 Dec '06

Here is the diff file. Regards. On Wed, 20 Dec 2006 20:17:59 +0100, Pierre Lena <plena(a)mangoose.org> wrote: > How do I create the diff? > Do I need to reload the svn400 to create it? > > On Wed, 20 Dec 2006 20:14:53 +0100, Tomasz Pajor <t.pajor(a)kei.pl> wrote: >> You send the diff to mailing list, or create a ticket on >> http://trac.roundcube.net/ >> >> -- >> Best regards >> Tom >> >> Dnia Wed, 20 Dec 2006 19:56:36 +0100 napisales[as]: >>> Hi, >>> >>> I am new to the list. >>> I developped mail filters for roundcube based on svn400. >>> How can I send the file I modified to make them part of the project? >>> >>> Regards. >>> Pierre >>> >>> >>> --- >>> Antivirus avast! : message Sortant sain. >>> Base de donnees virale (VPS) : 0661-0, 20/12/2006 >>> Analyse le : 20/12/2006 19:56:37 >>> avast! - copyright (c) 1988-2006 ALWIL Software. >>> http://www.avast.com >>>

1 0

Re:
by Tomasz Pajor 20 Dec '06

20 Dec '06

For example: diff -aur newdir olddir for more information: man diff -- Best regards Tom Dnia Wed, 20 Dec 2006 20:17:59 +0100 napisales[as]: > How do I create the diff? > Do I need to reload the svn400 to create it? > > On Wed, 20 Dec 2006 20:14:53 +0100, Tomasz Pajor t.pajor(a)kei.pl> wrote: >> You send the diff to mailing list, or create a ticket on >> http://trac.roundcube.net/ >> >> -- >> Best regards >> Tom >> >> Dnia Wed, 20 Dec 2006 19:56:36 +0100 napisales[as]: >>> Hi, >>> >>> I am new to the list. >>> I developped mail filters for roundcube based on svn400. >>> How can I send the file I modified to make them part of the project? >>> >>> Regards. >>> Pierre >>> >>> >>> --- >>> Antivirus avast! : message Sortant sain. >>> Base de donnees virale (VPS) : 0661-0, 20/12/2006 >>> Analyse le : 20/12/2006 19:56:37 >>> avast! - copyright (c) 1988-2006 ALWIL Software. >>> http://www.avast.com >>> > -- -- Pozdrawiam Tomasz Pajor

1 0

Re: #1326320
by Tomasz Pajor 20 Dec '06

20 Dec '06

You send the diff to mailing list, or create a ticket on http://trac.roundcube.net/ -- Best regards Tom Dnia Wed, 20 Dec 2006 19:56:36 +0100 napisales[as]: > Hi, > > I am new to the list. > I developped mail filters for roundcube based on svn400. > How can I send the file I modified to make them part of the project? > > Regards. > Pierre > > > --- > Antivirus avast! : message Sortant sain. > Base de donnees virale (VPS) : 0661-0, 20/12/2006 > Analyse le : 20/12/2006 19:56:37 > avast! - copyright (c) 1988-2006 ALWIL Software. > http://www.avast.com >

2 1

#1326320
by Pierre Lena 20 Dec '06

20 Dec '06

Hi, I am new to the list. I developped mail filters for roundcube based on svn400. How can I send the file I modified to make them part of the project? Regards. Pierre --- Antivirus avast! : message Sortant sain. Base de donnees virale (VPS) : 0661-0, 20/12/2006 Analyse le : 20/12/2006 19:56:37 avast! - copyright (c) 1988-2006 ALWIL Software. http://www.avast.com

1 0

MIME messages with no body
by Jim Pingle 20 Dec '06

20 Dec '06

There are several tickets that appear to be related, all related to MIME messages that have attachments but no body (or bodies in alternative content types) The changes made by robin in SVN revision 413 have helped quite a bit, but there are still some quirks. Most of these can probably be closed with a little bit of testing to be sure they have been fixed. If not, it would be nice if someone could take a closer look at them. Ticket #1484050 (Bugs) Messages with attachment only (no body part) are not parsed correctly "attachment" (really the only part) shows up now and I can download it, but the message list does not indicate that an attachment is present in the message. Ticket #1483818 (Feature Requests) Support for viewing Content-Type: application/pgp et al. I can't reproduce this, but it looks like the programs I'm using to test are encoding the messages differently than the messages the original ticket opener sees. Thunderbird/Enigmail-generated messages work OK for me. I opened a bunch of signed PGP/MIME messages from some mailing lists, all worked OK. Ticket #1443276 (Bugs) mail rendering problem with base64 encoded messages This may be fixed now but oddly enough I can't find a test message with a base64-encoded text body to see if it works. base64-encoded attachment bodies work for me since SVN rev 413. Ticket #1484072 (Bugs) Weird forward behaviour. When attempting to forward one of these messages with only an attachment and no body text, it is not included. I'm not sure this one is really related or not, but it could use a couple people to test on their systems and comment on it or close it. Ticket #1483968 (Bugs) Message is not showing content Messages from Cron show up fine for me on FreeBSD, but if someone on Linux could double check this can probably be closed.

1 0

Re: Patch to allow 12 hour date to display for emails sent today.
by Doug Mandell 20 Dec '06

20 Dec '06

Whoops, meant to send this to the list. Anyhow, here's the fixed version of my patch, if there's a better way for me to submit these please let me know. Thanks, Doug Index: roundcubemail/config/main.inc.php.dist =================================================================== --- roundcubemail/config/main.inc.php.dist (revision 400) +++ roundcubemail/config/main.inc.php.dist (working copy) @@ -107,6 +107,9 @@ // the default locale setting $rcmail_config['locale_string'] = 'en'; +// use this format for today's date display +$rcmail_config['date_today'] = 'H:i'; + // use this format for short date display $rcmail_config['date_short'] = 'D H:i'; Index: roundcubemail/program/include/main.inc =================================================================== --- roundcubemail/program/include/main.inc (revision 400) +++ roundcubemail/program/include/main.inc (working copy) @@ -1687,7 +1687,7 @@ // define date format depending on current time if ($CONFIG['prettydate'] && !$format && $timestamp > $today_limit) - return sprintf('%s %s', rcube_label('today'), date('H:i', $timestamp)); + return sprintf('%s %s', rcube_label('today'), date($CONFIG['date_today'] ? $CONFIG['date_today'] : 'H:i', $timestamp)); else if ($CONFIG['prettydate'] && !$format && $timestamp > $week_limit) $format = $CONFIG['date_short'] ? $CONFIG['date_short'] : 'D H:i'; else if (!$format)

3 4

week old trash deletion
by Jason 20 Dec '06

20 Dec '06

I'm on revision 394 and I'm noticing that in the .Trash directory of my maildir folder emails older than 7 days are getting deleted. I don't remember this happening in r361. I also don't see any way to configure this. What's the deal with this? There should be no automatic deletion of emails unless specifically configured to do so. Am I missing something, is this configurable? Is it a bug? Is it different in more recent revisions? Thanks, Jason

2 2

PasswordPatch
by andy 20 Dec '06

20 Dec '06

I was wondering if u could make this password patch:: http://roundcubeforum.net/forum/index.php?topic=42.0 an official feature? It is working fine here and the only way for my users to change their passwords. regards, Andy

3 3

Re: PasswordPatch
by Tomasz Pajor 20 Dec '06

20 Dec '06

I was thinking about doing that, but not every body is working on such configuration. So I don't know. It would be good as a plugin. By the way is anybody working on plugin framework? Will think about it anyway. -- Best regards Tom Dnia Wed, 20 Dec 2006 12:12:11 +0100 napisales[as]: > I was wondering if u could make this password patch:: > > http://roundcubeforum.net/forum/index.php?topic=42.0 > > an official feature? > It is working fine here and the only way for my users to change their passwords. > > > regards, > Andy >

1 0

1484091 - bcc recipients not saved in draft message - PATCH
by Black.myst 20 Dec '06

20 Dec '06

Hello, A fix for minor bug #1484091 (http://trac.roundcube.net/trac.cgi/ticket/1484091) Diff explanation : - program/steps/mail/compose.inc : to send 'bcc' data in the form. - skins/default/templates/compose.html : to see 'bcc' field if it's not empty. Black Myst Index: program/steps/mail/compose.inc =================================================================== --- program/steps/mail/compose.inc (revision 416) +++ program/steps/mail/compose.inc (working copy) @@ -150,7 +150,10 @@ } case 'bcc': if (!$fname) + { $fname = '_bcc'; + $header = 'bcc'; + } $allow_attrib = array('id', 'class', 'style', 'cols', 'rows', 'wrap', 'tabindex'); $field_type = 'textarea'; Index: skins/default/templates/compose.html =================================================================== --- skins/default/templates/compose.html (revision 416) +++ skins/default/templates/compose.html (working copy) @@ -135,6 +135,9 @@ var cc_field = document.form._cc; if (cc_field && cc_field.value!='') rcmail_toggle_display('compose-cc'); +var bcc_field = document.form._bcc; +if (bcc_field && bcc_field.value!='') + rcmail_toggle_display('compose-bcc'); //--> </script>

6 6

New install: Could not load message
by Kevin Baker 20 Dec '06

20 Dec '06

So I just installed roundcube. I setup as instructed in INSTALL. I can log in, but get the following message when I try to *double* click a message to view it. "Could not load message." Any ideas? - k __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 2

Address Groups extension from Shane
by Martin Schwartz 19 Dec '06

19 Dec '06

Hi guys, are there any news about the integration or non integration of shane (@gnative.com)'s address group enhancement? Like some general concerns or cheers? I haven't heard anything about it since he sent his departure message in October. And I asked merry Santa for it for christmas :) Cheers Martin

2 1

changes to spanish translations (again, part 2)
by Mario Vazquez 18 Dec '06

18 Dec '06

After looking that I include non trunk labels in the Spanish translations, I recheck them and found other labels that must be corrected. More info at: http://trac.roundcube.net/trac.cgi/ticket/1484174 Again, my apologies to the developers. Mario

1 0

Ticket 1483949 - Spam messages
by roundcube-dev＠alldesign.de 18 Dec '06

18 Dec '06

Hi, first i'm new one here. good project. i decided to work a little bit for. What's your opinion what RoundCube could / should do with Spam. I found a ticket for that and i decided to solve this. The Question is, what does RoundCube should do. I think to move / show SPAM-Flag: yes Messages move to the Junk directly is not the best think and not the job from Roundcube. So i add some things to my feature list. - Color the Messages (brown) in Inbox if the are spam. Over Spamassassin Junk Stars, but other milter are also possible. - Add a button to move it to junk folder. - On Moving to junk folder it possible to run sa-learn with user settings for bayes. - Is also possible to set up this work automaticly (move spam to junkfolder on login), but only with imap. - Set up Spamassassin user Setting via file oder mysql databases (supports also confixx) I try also to programm a filter thats identify also Newsletter or other Messagetypes and color it (grey) Many thanks to guzu, he's on the right way. I'm afraid to here more opinion and wishes for that. Thanks

6 5

changes to spanish translations (again)
by Mario Vazquez 18 Dec '06

18 Dec '06

The Spanish labels.inc that I previously submitted were approved in SVN 408 includes some fields that do not belong the the RoundCube trunk, and should be removed. Those fields are translations for a extended contact information. Info about the bug can be found here: http://trac.roundcube.net/trac.cgi/ticket/1484172 Included are both the new revised es/labels.inc without those fields, and the diff that removes it from the SVN trunk repo (v414 at the time of this writing). Sorry for the inconvenience. Mario

1 0

Re: Resize Preview pane .. With the diff
by David Glick 18 Dec '06

18 Dec '06

Thanks for throwing this up here Ryan. Here's an updated patch (for svn 410) that also works in IE and Opera in addition to Firefox. (Can someone test Safari?) This one also resizes the splitter bar when the window is resized. The setting still isn't saved in user_prefs but I'm sure Ryan will have that working soon... peace, David Glick > I really am batting 1000 today. Here's the diff. Going to bed. > Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 410) +++ program/include/main.inc (working copy) @@ -1277,6 +1277,7 @@ // GENERAL 'loginform' => 'rcmail_login_form', 'username' => 'rcmail_current_username', + 'splitter' => 'rcube_splitter', // MAIL 'mailboxlist' => 'rcmail_mailbox_list', @@ -1912,7 +1913,19 @@ return $select->show($set); } +function rcube_splitter($attrib) + { + global $OUTPUT, $JS_OBJECT_NAME; + + // register splitter in the system + $OUTPUT->add_script(sprintf("%s.register_splitter('%s', '%s', '%s');", + $JS_OBJECT_NAME, + $attrib['first'], + $attrib['second'], + $attrib['orientation'])); + } + /****** debugging functions ********/ Index: program/js/common.js =================================================================== --- program/js/common.js (revision 410) +++ program/js/common.js (working copy) @@ -380,6 +380,187 @@ } +/** + * RoundCube splitter GUI class + * + * @constructor + */ +function rcube_splitter(attrib) + { + this.p1id = attrib.p1; + this.p2id = attrib.p2; + this.id = this.p1id + '_' + this.p2id + '_splitter'; + this.orientation = attrib.orientation; + this.horizontal = (this.orientation == 'horizontal'); + + this.init = function() + { + this.p1 = document.getElementById(this.p1id); + this.p2 = document.getElementById(this.p2id); + + // create and position the handle for this splitter + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + var top = this.p1pos.y + this.p1.offsetHeight; + var height = this.p2pos.y - this.p1pos.y - this.p1.offsetHeight; + var left = this.p1pos.x + this.p1.offsetWidth; + var width = this.p2pos.x - this.p1pos.x - this.p1.offsetWidth; + if (this.horizontal) + this.layer = new rcube_layer(this.id, {x: this.p1pos.x, y: top, height: height, zindex: 1, vis: 1}); + else + this.layer = new rcube_layer(this.id, {x: left, y: this.p1pos.y, width: width, zindex: 1, vis: 1}); + this.elm = this.layer.elm; + this.elm.className = 'splitter'; + if (this.horizontal) + this.elm.style.paddingTop = Math.floor(height / 2) + 'px'; + else + this.elm.style.paddingLeft = Math.floor(width / 2) + 'px'; + + this.line = document.createElement('DIV'); + this.line.className = 'splitterLine'; + if (this.horizontal) + { + this.line.style.borderTopWidth = '1px'; + this.line.style.width = '100%'; + this.line.style.height = '1px'; + } + else + { + this.line.style.borderLeftWidth = '1px'; + this.line.style.width = '1px'; + this.line.style.height = '100%'; + } + + this.elm.appendChild(this.line); + rcube_event.add_listener({element: this.elm, event:'mouseover', object:this, method:'onMouseOver'}); + rcube_event.add_listener({element: this.elm, event:'mouseout', object:this, method:'onMouseOut'}); + + // add the event to start dragging when the handle is pressed + var s = this; + this.elm.onmousedown = function(e){ return s.onDragStart(e); }; + } + + this.onDragStart = function(e) + { + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + + // start listening to mousemove events + rcube_event.add_listener({element:document, event:'mousemove', object:this, method:'onDrag'}); + rcube_event.add_listener({element:document, event:'mouseup', object:this, method:'onDragStop'}); + + // need to listen in any iframe documents too, b/c otherwise the splitter stops moving when we move over an iframe + var iframes = document.getElementsByTagName('IFRAME'); + this.iframe_events = Object(); + for (var n in iframes) + { + var iframedoc = null; + if (iframes[n].contentDocument) + iframedoc = iframes[n].contentDocument; + else if (iframes[n].contentWindow) + iframedoc = iframes[n].contentWindow.document; + else if (iframes[n].document) + iframedoc = iframes[n].document; + if (iframedoc) + { + // I don't use the add_listener function for this one because I need to create closures to fetch + // the position of each iframe when the event is received + var s = this; + var id = iframes[n].id; + this.iframe_events[n] = function(e){ e._rc_pos_offset = rcube_get_object_pos(document.getElementById(id)); return s.onDrag(e); } + if (iframedoc.addEventListener) + iframedoc.addEventListener('mousemove', this.iframe_events[n], false); + else if (iframes[n].attachEvent) + iframedoc.attachEvent('onmousemove', this.iframe_events[n]); + else + iframedoc['onmousemove'] = this.iframe_events[n]; + + rcube_event.add_listener({element:iframedoc, event:'mouseup', object:this, method:'onDragStop'}); + } + } + } + + this.onDrag = function(e) + { + var pos = rcube_event.get_mouse_pos(e); + if (e._rc_pos_offset) + { + pos.x += e._rc_pos_offset.x; + pos.y += e._rc_pos_offset.y; + } + + if (this.horizontal) + { + if (((pos.y - this.layer.height * 1.5) > this.p1pos.y) && ((pos.y + this.layer.height * 1.5) < (this.p2pos.y + this.p2.offsetHeight))) + { + // resize the panels + this.p2.style.top = Math.round(pos.y + this.layer.height / 2 + 1 - (bw.ie ? 10 : 0)) + 'px'; + this.p1.style.height = Math.round(pos.y - this.p1pos.y - this.layer.height / 2 - 1) + 'px'; + + // move the splitter handle + this.layer.move(this.layer.x, Math.round(pos.y - this.layer.height / 2 + 1)); + } + } + else + { + if (((pos.x - this.layer.width * 1.5) > this.p1pos.x) && ((pos.x + this.layer.width * 1.5) < (this.p2pos.x + this.p2.offsetWidth))) + { + this.p1.style.width = Math.round(pos.x - this.p1pos.x - this.layer.width / 2 - 1) + 'px'; + this.p2.style.left = Math.round(pos.x + this.layer.width / 2 + 1) + 'px'; + + this.layer.move(Math.round(pos.x - this.layer.width / 2 + 1), this.layer.y); + } + } + + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + return false; + } + + this.onDragStop = function(e) + { + // cancel the listening for drag events + rcube_event.remove_listener({element:document, event:'mousemove', object:this, method:'onDrag'}); + rcube_event.remove_listener({element:document, event:'mouseup', object:this, method:'onDragStop'}); + var iframes = document.getElementsByTagName('IFRAME'); + for (var n in iframes) + { + var iframedoc; + if (iframes[n].contentDocument) + iframedoc = iframes[n].contentDocument; + else if (iframes[n].contentWindow) + iframedoc = iframes[n].contentWindow.document; + else if (iframes[n].document) + iframedoc = iframes[n].document; + if (iframedoc) + { + if (this.iframe_events[n]) { + if (iframedoc.removeEventListener) + iframedoc.removeEventListener('mousemove', this.iframe_events[n], false); + else if (iframedoc.detachEvent) + iframedoc.detachEvent('onmousemove', this.iframe_events[n]); + else + iframedoc['onmousemove'] = null; + } + + rcube_event.remove_listener({element:iframedoc, event:'mouseup', object:this, method:'onDragStop'}); + } + } + return rcube_event.cancel(e); + } + + // events to make the handle appear when the mouse hovers over it + // (pure CSS doesn't work b/c IE only applies :hover classes to links) + this.onMouseOver = function(e) + { + this.line.style.visibility = 'visible'; + } + this.onMouseOut = function(e) + { + this.line.style.visibility = 'hidden'; + } + } + // check if input is a valid email address // By Cal Henderson <cal(a)iamcal.com> // http://code.iamcal.com/php/rfc822/ Index: program/js/app.js =================================================================== --- program/js/app.js (revision 410) +++ program/js/app.js (working copy) @@ -24,6 +24,7 @@ this.env = new Object(); this.labels = new Object(); this.buttons = new Object(); + this.splitters = new Object(); this.gui_objects = new Object(); this.commands = new Object(); @@ -78,6 +79,13 @@ }; + // add a splitter to the splitter list + this.register_splitter = function(p1, p2, orientation) + { + this.splitters[p1 + '_' + p2] = new rcube_splitter({p1: p1, p2: p2, orientation: orientation}); + } + + // register a specific gui object this.gui_object = function(name, id) { @@ -108,6 +116,10 @@ // enable general commands this.enable_command('logout', 'mail', 'addressbook', 'settings', true); + + // initialize splitters + for (var n in this.splitters) + this.splitters[n].init(); switch (this.task) { Index: skins/default/common.css =================================================================== --- skins/default/common.css (revision 410) +++ skins/default/common.css (working copy) @@ -213,7 +213,21 @@ border: 1px solid #CCCCCC; } +.splitter +{ + position: absolute; + cursor: move; + background: url(images/cleardot.png); +} +.splitterLine +{ + visibility: hidden; + border-color: #ff0000; + border-style: solid; + border-width: 0; +} + /***** common table settings ******/ table.records-table thead tr td Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 410) +++ skins/default/templates/mail.html (working copy) @@ -55,6 +55,7 @@ </div> <roundcube:if condition="config:preview_pane == true" /> +<roundcube:object name="splitter" first="mailcontframe" second="mailpreviewframe" orientation="horizontal" /> <div id="mailpreviewframe"> <roundcube:object name="messagecontentframe" id="messagecontframe" width="100%" height="100%" frameborder="0" src="/watermark.html" /> </div> Index: skins/default/templates/addressbook.html =================================================================== --- skins/default/templates/addressbook.html (revision 410) +++ skins/default/templates/addressbook.html (working copy) @@ -31,6 +31,8 @@ <roundcube:object name="addresslist" id="contacts-table" class="records-table" cellspacing="0" summary="Contacts list" /> </div> +<roundcube:object name="splitter" first="addresslist" second="contacts-box" orientation="vertical" /> + <div id="contacts-box"> <roundcube:object name="addressframe" id="contact-frame" width="100%" height="100%" frameborder="0" src="/watermark.html" /> </div> Index: skins/default/addresses.css =================================================================== --- skins/default/addresses.css (revision 410) +++ skins/default/addresses.css (working copy) @@ -70,10 +70,19 @@ border: 1px solid #999999; overflow: hidden; /* css hack for IE */ - width: expression((parseInt(document.documentElement.clientWidth)-530)+'px'); + width: expression((parseInt(document.documentElement.clientWidth)-80-document.getElementById('addresslist').offsetWidth)+'px'); height: expression((parseInt(document.documentElement.clientHeight)-135)+'px'); } + +#addresslist_contacts-box_splitter +{ + bottom: 40px; + /* css hack for IE */ + height: expression((parseInt(document.documentElement.clientHeight)-135)+'px'); +} + + body.iframe, #contact-frame { Index: skins/default/mail.css =================================================================== --- skins/default/mail.css (revision 410) +++ skins/default/mail.css (working copy) @@ -131,9 +131,16 @@ background-color: #F9F9F9; /* css hack for IE */ width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); - height: expression((parseInt(document.documentElement.clientHeight)-340)+'px'); + height: expression((parseInt(document.documentElement.clientHeight)-130-document.getElementById('mailcontframe').offsetHeight)+'px'); } +#mailcontframe_mailpreviewframe_splitter +{ + right: 40px; + /* css hack for IE */ + width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); +} + #messagecontframe { width: 100%;

4 3

Two patches submitted to trac, kudos on resizable preview pane
by Doug Mandell 17 Dec '06

17 Dec '06

Hi, First, I wanted to say the resizable preview pane works very well in Firefox, thanks for the additional functionality. Second, I've submitted two patches to Trac that I hope one of you would take a look at, they're the patches I previously submitted to the list. One allows a 12 hour clock for emails received today, the other allows tabbing from the message body to the Send button. If I'm doing something wrong please let me know. Thanks, Doug Mandell

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev