- Dev - Roundcube mailing lists

roundcube basque translation
by pi 25 Jan '06

25 Jan '06

Hello I try roundcube and is usefull for me. I have transalted the files to basque an the line to add to index.inc is: 'eu' => 'Euskara', I have test the translation and all seems ok, Can any add this translation to the cvs ? thanks --

1 0

FR localization problems
by Pierre HAEGELI 25 Jan '06

25 Jan '06

It seems there is a problem in the french localization files: in messages.inc: $messages['nomessagesfound'] = 'Auncun message trouvÃ© dans cette boÃ®te aux lettres'; should be: $messages['nomessagesfound'] = 'Aucun message trouvÃ© dans cette boÃ®te aux lettres'; There is still a problèmes with some special characters display for the message count display on the upper right of the message tab: Messages 1 ? 2 It should be : Messages 1 à 2 Thanx for the changes. Roundcube is now and still the best webmail app. Keep on. P.

1 0

bad header
by Florin Andrei 25 Jan '06

25 Jan '06

Using: RoundCube-20051021 postfix-2.2.2-2 cyrus-imapd-2.2.12-6.fc4 amavisd-new-2.3.2-1.2.fc4.rf apache-2.0.54-10.2 Linux Fedora Core 4 I configured Postfix to use amavisd-new as a scanning hub (using SpamAssassin for spam and ClamAV for viruses). When composing messages in RoundCube and sending them through Postfix/Amavisd-new, the messages get flagged by amavis as "bad header": X-Amavis-Alert: BAD HEADER Improper use of control character (char 0D hex) in message header 'MIME-Version': MIME-Version: 1.0\r\n What's the cause? Do you need any other info to diagnose this issue? -- Florin Andrei http://florin.myip.org/

2 1

feature request
by brunto＠timorsea.org 25 Jan '06

25 Jan '06

Hi, your webmail is powerful but some features are needed like "acknowledgement of delivery" and a system of "feature request" on your website. thanks bruno bruno(a)altnetvision.info

2 1

Subject as link
by Dennis Duggen 24 Jan '06

24 Jan '06

Hi, Yesterday i tried to navigate with keyboard (my mouse didn't work) in RC. It was less than a success since i couldn't get into my mails. The sender column is a link, so i could write new messages to people, but it wasn't really what i wanted. Therefor this feature request. Is it possible to make the subject as a link, this way keyboard navigation would be possible. Maybe it could be solution to the discussion about singe and double click to open new messages. If the entire row except subject and sender text would act on double click. Any thoughts? Regards, Dennis -- Airconditioners and computers have one thing in common: Once you open windows everything fails. -- Firefox - Safer, Faster, Better http://www.mozilla.org/products/firefox/

5 8

DB error after cvs update
by Carlos Galisteo de Cabo 24 Jan '06

24 Jan '06

Hi. After my early morning cvs update I get the following error when reading messages: DB Error in /var/www/roundcubemail/program/include/rcube_db.inc (427): DB Error: no such field Query: INSERT INTO messages (user_id, del, cache_key, created, idx, uid, subject, `from`, `to`, cc, date, size, headers) [private data here ;)] I've fixed it by creating the missing field 'created': ALTER TABLE `messages` ADD `created` DATETIME DEFAULT '0000-00-00 00:00:00' NOT NULL AFTER `cache_key` ; I suppose (something like)this to be included in a further *.update.sql, meanwhile, here is my workaround just for the record.

2 2

Escaped characters
by Tancredi D'Onofrio 23 Jan '06

23 Jan '06

Hi, when I enter my name which includes an apostrophe (D'Onofrio) in the Identities tab it is displayed as D\'Onofrio. Any chance of fixing this? Thanks.

6 8

Fwd: Email Headers are shown in other email clients such as GMail...
by Jason 23 Jan '06

23 Jan '06

More info from Michael: ---------- Forwarded message ---------- From: Michael D'Auria <michael.dauria(a)gmail.com> Date: Jan 23, 2006 11:23 AM Subject: Re: Email Headers are shown in other email clients such as GMail... To: Jason <random.numbers(a)gmail.com> What i just tried is to hard code the "\n" right into the creation of the MAIL_mime instance and it seemed to work. This makes me believe that the sendmail.inc cannot see the configuration file. : Michael :. On 1/23/06, Jason <random.numbers(a)gmail.com> wrote: > I'm glad it worked. I'm not actually a dev on this project though, so > I'll forward this to the list so hopefully it can get taken care of. > > To the list: Aparently setting the > "$rcmail_config['mail_header_delimiter']" parameter to "\n" doesn't > alieviate the extra carriage return issues with php's mail() function. > Read below for more info. > > Thanks, > Jason > > On 1/23/06, Michael D'Auria <michael.dauria(a)gmail.com> wrote: > > Your hard coded replace worked, whereas the configuration change did not. > > So i guess i would mark this as a bug at the moment, for the record i am > > using the latest cvs snapshot. > > > > Thanks for the fix! > > > > > > .: Michael :. > > > > > > On 1/23/06, Jason < random.numbers(a)gmail.com> wrote: > > > Interesting, yes, I would think that it would have solved your > > > problem. I ran into this before that configuration parameter existed, > > > so I didn't remember it was there. If you try the str_replace() > > > solution, and it works, but setting the header delimiter to "\n" > > > doesn't work, email the mailing list again with the info because that > > > sounds like it could be a bug. > > > > > > On 1/23/06, Michael D'Auria <michael.dauria(a)gmail.com> wrote: > > > > I thought that the configuration: > > > > $rcmail_config['mail_header_delimiter'] = "\n"; > > > > would have fixed my problem, but i guess not. > > > > > > > > I will try both methods and see what i can do. > > > > > > > > Thanks! > > > > > > > > .: Michael :. > > > > > > > > > > > > > > > > On 1/23/06, Jason < random.numbers(a)gmail.com> wrote: > > > > > This has to do with the difference between Windows and *nix line > > > > > endings. I'm guessing you're using *nix and you don't have RC > > > > > configured to use a sendmail server. You can fix this one of two > > > > > ways. You can either edit the file > > > > "program/steps/mail/sendmail.inc" > > > > > and replace every occurrence of "$header_str = > > > > > $MAIL_MIME->txtHeaders($headers);" with "$header_str > > = > > > > > str_replace("\r", '', > > > > $MAIL_MIME->txtHeaders($headers));". This will > > > > > remove the extra carriage returns that are inserted by php's mail() > > > > > function. The second option is to configure RC to use a sendmail > > > > > server. If you're running one on the same box you can probably set > > > > > "$rcmail_config['smtp_server'] = 'localhost';" and > > > > > "$rcmail_config['smtp_port'] = 25;", or whatever is appropriate for > > > > > your situation. > > > > > > > > > > Jason > > > > > > > > > > On 1/23/06, Michael D'Auria < michael.dauria(a)gmail.com> wrote: > > > > > > Hello all! > > > > > > > > > > > > I really like the way this email client looks and acts, having AJAX > > > > allows > > > > > > users to feel close to their desktop at all times. I would really > > like > > > > to > > > > > > allow the users that i host to take advantage of this software, but > > i > > > > have > > > > > > found a couple of issues with it at the moment. > > > > > > > > > > > > Whenever i send a message the headers are not hidden as with other > > email > > > > > > clients: > > > > > > > > > > > > ------------------------------------------------------------------------------------------ > > > > > > From: < michael(a)testing.com > > > > > > > Cc: michael.test(a)gmail.com > > > > > > Message-ID: > > > > < c5a40c8d3e4a8525545c3ba8825199cb@localhost> > > > > > > > > > > > > X-Sender: michael(a)testing.com > > > > > > > > > > > > User-Agent: RoundCube Webmail > > > > > > > > > > > > > > > > > > > > > > > > sdfgfdghfdhghg > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------------------ > > > > > > > > > > > > Also, the name comes up as "unknown sender" but i know i have set > > the c > > > > flag > > > > > > when creating user accounts with vpopmail... > > > > > > > > > > > > .: Michael :. > > > > > > > > > > > > > > > > > > > > >

1 0

Re: Email Headers are shown in other email clients such as GMail...
by Jason 23 Jan '06

23 Jan '06

I'm glad it worked. I'm not actually a dev on this project though, so I'll forward this to the list so hopefully it can get taken care of. To the list: Aparently setting the "$rcmail_config['mail_header_delimiter']" parameter to "\n" doesn't alieviate the extra carriage return issues with php's mail() function. Read below for more info. Thanks, Jason On 1/23/06, Michael D'Auria <michael.dauria(a)gmail.com> wrote: > Your hard coded replace worked, whereas the configuration change did not. > So i guess i would mark this as a bug at the moment, for the record i am > using the latest cvs snapshot. > > Thanks for the fix! > > > .: Michael :. > > > On 1/23/06, Jason <random.numbers(a)gmail.com> wrote: > > Interesting, yes, I would think that it would have solved your > > problem. I ran into this before that configuration parameter existed, > > so I didn't remember it was there. If you try the str_replace() > > solution, and it works, but setting the header delimiter to "\n" > > doesn't work, email the mailing list again with the info because that > > sounds like it could be a bug. > > > > On 1/23/06, Michael D'Auria <michael.dauria(a)gmail.com> wrote: > > > I thought that the configuration: > > > $rcmail_config['mail_header_delimiter'] = "\n"; > > > would have fixed my problem, but i guess not. > > > > > > I will try both methods and see what i can do. > > > > > > Thanks! > > > > > > .: Michael :. > > > > > > > > > > > > On 1/23/06, Jason < random.numbers(a)gmail.com> wrote: > > > > This has to do with the difference between Windows and *nix line > > > > endings. I'm guessing you're using *nix and you don't have RC > > > > configured to use a sendmail server. You can fix this one of two > > > > ways. You can either edit the file > > > "program/steps/mail/sendmail.inc" > > > > and replace every occurrence of "$header_str = > > > > $MAIL_MIME->txtHeaders($headers);" with "$header_str > = > > > > str_replace("\r", '', > > > $MAIL_MIME->txtHeaders($headers));". This will > > > > remove the extra carriage returns that are inserted by php's mail() > > > > function. The second option is to configure RC to use a sendmail > > > > server. If you're running one on the same box you can probably set > > > > "$rcmail_config['smtp_server'] = 'localhost';" and > > > > "$rcmail_config['smtp_port'] = 25;", or whatever is appropriate for > > > > your situation. > > > > > > > > Jason > > > > > > > > On 1/23/06, Michael D'Auria < michael.dauria(a)gmail.com> wrote: > > > > > Hello all! > > > > > > > > > > I really like the way this email client looks and acts, having AJAX > > > allows > > > > > users to feel close to their desktop at all times. I would really > like > > > to > > > > > allow the users that i host to take advantage of this software, but > i > > > have > > > > > found a couple of issues with it at the moment. > > > > > > > > > > Whenever i send a message the headers are not hidden as with other > email > > > > > clients: > > > > > > > > > ------------------------------------------------------------------------------------------ > > > > > From: < michael(a)testing.com > > > > > > Cc: michael.test(a)gmail.com > > > > > Message-ID: > > > <c5a40c8d3e4a8525545c3ba8825199cb@localhost> > > > > > > > > > > X-Sender: michael(a)testing.com > > > > > > > > > > User-Agent: RoundCube Webmail > > > > > > > > > > > > > > > > > > > > sdfgfdghfdhghg > > > > > > > > > > > > > > ------------------------------------------------------------------------------------------ > > > > > > > > > > Also, the name comes up as "unknown sender" but i know i have set > the c > > > flag > > > > > when creating user accounts with vpopmail... > > > > > > > > > > .: Michael :. > > > > > > > > > > > > > >

2 2

Email Headers are shown in other email clients such as GMail...
by Michael D'Auria 23 Jan '06

23 Jan '06

Hello all! I really like the way this email client looks and acts, having AJAX allows users to feel close to their desktop at all times. I would really like to allow the users that i host to take advantage of this software, but i have found a couple of issues with it at the moment. Whenever i send a message the headers are not hidden as with other email clients: ------------------------------------------------------------------------------------------ From: <michael(a)testing.com> Cc: michael.test(a)gmail.com Message-ID: <c5a40c8d3e4a8525545c3ba8825199cb@localhost> X-Sender: michael(a)testing.com User-Agent: RoundCube Webmail sdfgfdghfdhghg ------------------------------------------------------------------------------------------ Also, the name comes up as "unknown sender" but i know i have set the c flag when creating user accounts with vpopmail... : Michael :.

2 1

Fw: Escaped characters
by Marcel Bueno 23 Jan '06

23 Jan '06

----- Original Message ----- From: "Marcel Bueno" <marcel(a)bueno.com.br> To: "Jon Daley" <roundcube(a)jon.limedaley.com> Sent: Monday, January 23, 2006 12:50 PM Subject: Re: [RoundCube Dev] Escaped characters > (http://www.olate.co.uk/forums/index.php?showtopic=956) > > Ow. Excuse-me, I didn't know that ! Php can be configured to disallow > ini_set ! > If a server is configured to disallow the .htaccess too (and can be > configured to do this), it's impossible to disable magic_quotes ! > > In this case, how to process ? Do someone know a method to test if a php > alloow a ini_set or not ? I believe that it can be tested. Is accept, do, > else, do nothing or try to do with .htaccess. > > Well... > > The magic quotes (\') is putted for php in GET or POST vars to prevent > SQLInjection. > Get this example: "SELECT * FROM users WHERE user = '$var' " > If $var=" ' or ''=' ", the query was: "SELECT * FROM users WHERE user = '' > or ''='' " > The magic quotes prevent this, turning it "SELECT * FROM users WHERE user > = '\' or \'\'=\'' ". > But magic-quotes is used only with MySQL. the Microsoft SQLServer doesn't > understand the quotes. Arghhh ! > > I believe that was another 2 methods: > > - The first was use the stipslashes() function > (http://www.php.net/manual/pt_BR/function.stripslashes.php), but need to > be done in all code. There are some problems here. > The RFC of mail address say that the address can be somethng like this: > "Name" < email(a)some.domain > > > If a name is "Juca's", with magic quotes it will be turned "Juca\'s". In > this case, it's bed. > If a name is "Juca"s", with magic quotes it will be turned "Juca\"s". If > we remove magic quotes, it's a wrong RFC mail address: "Juca"s" < > email(a)some.domain > > > - An another method (but too much hard) is develop a Class to process the > headers of HTTPD without use the php vars $_POST and $_GET. Too much > work... > > > Someone have another idea ??? > > > Regards, > > Valber Marcel Bueno > > > ----- Original Message ----- > From: "Jon Daley" <roundcube(a)jon.limedaley.com> > To: <dev(a)lists.roundcube.net> > Sent: Monday, January 23, 2006 12:13 PM > Subject: Re: [RoundCube Dev] Escaped characters > > >> Not all hosts allow ini_set, and I get occasional complaints from people >> who get error messages and say LifeType is junk because you can't run it >> without errors, due to the few ini_set commands that we do include in the >> code. >> >> On Mon, 23 Jan 2006, Marcel Bueno wrote: >>> I think that some configurations can be inserted in constants file of >>> the rcube project, like this: >> >

2 1

Outlook Express mails - rendering problem
by Hegedüs Ervin 23 Jan '06

23 Jan '06

hello, I found an interesting problem. There is a mail, an original, and its reply. All users use OE, HTML format. The problem is: user, who reads the the reply mail, doesn't see the answer... here is the part of original mail: ------=_NextPart_000_0068_01C61F42.B9B901D0 Content-Type: text/html; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN"> <HTML xmlns=3D"http://www.w3.org/TR/REC-html40" xmlns:o =3D=20 "urn:schemas-microsoft-com:office:office" xmlns:w =3D=20 "urn:schemas-microsoft-com:office:word"><HEAD> <META http-equiv=3DContent-Type content=3D"text/html; = charset=3Diso-8859-2"> <META content=3D"MSHTML 6.00.2900.2802" name=3DGENERATOR> <STYLE>@page Section1 {size: 595.3pt 841.9pt; margin: 70.85pt 70.85pt = 70.85pt 70.85pt; } P.MsoNormal { FONT-SIZE: 12pt; MARGIN: 0cm 0cm 0pt; FONT-FAMILY: "Times New Roman" } [...] } </STYLE> </HEAD> <BODY lang=3DHU vLink=3Dpurple link=3Dblue> <DIV dir=3Dltr align=3Dleft><SPAN class=3D146375609-22012006><FONT = face=3DArial=20 color=3D#0000ff size=3D2> and here is the rendered source by RoundCube: <div class="message-part"><!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">    <STYLE>@page Section1 {size: 595.3pt 841.9pt; margin: 70.85pt 70.85pt 70.85pt 70.85pt; } #messagebody P.MsoNormal { FONT-SIZE: 12pt; MARGIN: 0cm 0cm 0pt; FONT-FAMILY: "Times New Roman" } [...] </STYLE>  <div class="rcmBody"> <DIV dir=ltr align=left><SPAN class=146375609-22012006><FONT face=Arial color=#0000ff size=2> What may the problem? Is this the known problem? Thank you: a.

1 0

feature requests - wordwrap troubles
by sofar 23 Jan '06

23 Jan '06

Hi all, I'm enjoying RC a lot except for a few basic nuisances: * I really don't like typing in non-monospaced fonts and prefer to use monospace fonts for both reading and writing mail. Currently the default style allows me to view mails using a monospaced font, but I would prefer to write mails using that same fontset too. * on top of that the wordwrapping is annoying - it's applied to the mail after I send it, and since I don't often remember that, my mails arrive in shambles looking like this: The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. The quick brown fox jumps over the lazy dog. which, as you can see, is utterly frustrating! To fix this, either the wordwrap needs to be implemted in the clientside (and thus optional), or turned off. With this respect, does the RC client wordwrap itself too? I'm getting strange wrapped e-mails a lot ... Auke

2 1

Getting started adding to roundcube
by Andrew Bates 22 Jan '06

22 Jan '06

I'm really impressed with roundcube so far. Does anybody have a list (maybe RTFM?) of the goals of roundcube? I've got some good ideas (like whitelist,blacklist,spam tag/delete integration) that I want to integrate into roundcube. I want to make sure that I'm going to be doing this the right way so that others can benefit from my work. Any pointers on where to get started, what needs to be done, what's being worked on, etc etc would be great. - Andrew

2 1

Re: Subject as link
by William Ross 20 Jan '06

20 Jan '06

On 20 Jan 2006, at 20:44, Charles McNulty wrote: > William Ross wrote: >> >> Could it be as simple as checking the (scrolled) position of the >> lower border of the highlighted row against the height of the >> enclosing div, and scrolling the div contents if it's not visible? >> You'd only have to do it on first highlighting a row: if it >> scrolls out of view later that's ok. >> >> I've not explored the insides of roundcube very much - RC was the >> thing that finally persuaded me to install php, but that was only >> this week :) - but I'd be very happy to implement this if you >> like. It would be a useful way to get acquainted. >> >> best, >> >> will >> > > Sounds like a promising idea. I'll try to implement that this > weekend and if I can't figure it out by the end of the weekend, I'd > be happy to pass on to you what I've done so far and you can take a > crack at it. If you haven't yet, take a look at the bug list and > feature request list on sourceforge. ok. sounds like a much better idea. you know how it is: question in front of you seems interesting. The bug lists are so large and undifferentiated as to be useless from the outside, though: where would you start? So I guess the thing is to pay attention for a while first. best will

1 0

Updated bosnian translation
by Begzudin Omerovic 20 Jan '06

20 Jan '06

Hi, here comes the updated version of the bosnian translation, now in utf-8. Put this files in the bs_BA directory and please add in the index.inc file (program/localization/ directory) $rcube_languages = array( 'bs_BA' => 'Bosnian (Bosanski)' and $rcube_language_aliases = array( 'bs' => 'bs_BA', Regards, -- Begzudin Omerovic www.oglasi.com

1 0

Pbs with the french version
by Contact 20 Jan '06

20 Jan '06

I'll try to speak english, but.... I have a problem with french version : when i have some accent in my message, it will not appear. exemple : Concernant la r?n?tion, l'agence est commissionn?áuteur de 0.5 % ±%. Comme convenu lors de la r?ion, 40 % TTC seront revers?directement ìa personne qui a prescrit. in stade of Concernant la rémunération, l'agence est commissionnée à auteur de 0.5 % à 1%. Comme convenu lors de la réunion, 40 % TTC seront reversés directement à la personne qui a prescrit. I have verify the source of the mail and it was correct Some one could help me ?

2 1

Next release?
by John Galt 20 Jan '06

20 Jan '06

What's the ETA on the next release?

2 1

%u not parsing during SMTP authentication.
by Kevin Landers 19 Jan '06

19 Jan '06

Hi list, I am currently using the CVS from the first week of January. In my config file I use the following pieces of code to generate a login based upon what domain a user is accessing round cube from. // the mail host chosen to perform the log-in // leave blank to show a textbox at login, give a list of hosts // to display a pulldown menu or set one host as string. // To use SSL connection, enter ssl://hostname:993 $rcmail_config['default_host'] = 'mail.' . '' . str_replace("www.", "", $_SERVER['HTTP_HOST']); (This allows me to accept just the user name in the login screen and use this install across different domains.) I then do the same for the SMTP server. // use this host for sending mails. // to use SSL connection, set ssl://smtp.host.com // if left blank, the PHP mail() function is used $rcmail_config['smtp_server'] = 'mail.' . '' . str_replace("www.", "", $_SERVER['HTTP_HOST']); (This contacts the SMTP of the domain being accessed.) Next, our SMTP server requires that the user specify their full email address as their user name. In round cube I have been making this happen automatically by using the following code: // SMTP username (if required) if you use %u as the username RoundCube // will use the current username for login $rcmail_config['smtp_user'] = '%u' . '@' . '' . str_replace("www.", "", $_SERVER['HTTP_HOST']); It has been working so that it takes the domain, converts it to @domain.com and then adds the user's name before the @ symbol. However, upon using the CVS version, I am now showing in my SMTP-Auth logs that it is trying to login as %u(a)domain.com instead of username(a)domain.com Any ideas as to why this is no longer working? I am in the midst of updating to the newest CVS. I am just affraid that that is not going to be the problem. Round Cube's error log shows the following: [17-Jan-2006 12:27:58 -0500] SMTP Error: SMTP error: authentication failure in /domain.com/www/roundcube/program/steps/mail/sendmail.inc on line 216 Thanks in advance, Kevin L.

2 2

what's the current status for a serious release?
by sdk 19 Jan '06

19 Jan '06

Something comparable to Squirrelmail or Gmail? I work for an ISP and we are looking to move away from Squirrelmail. Thx, sdk

3 2

Re: shift-select and control-select patch
by Charles McNulty 19 Jan '06

19 Jan '06

Sorry about that. I just retried it and got the same problems. Try this one. I created the one I sent earlier with cvs diff. This one was created with Tortoise with whatever default options it throws into the bag. This one works fine with the latest CVS (1.27 of app.js, I believe.) Good luck. -Charles Daniel Paquet wrote: > Is the patch work with a freshly cvs'ed source? > > The patch is failing for me. With error > > patching file app.js > Hunk #3 FAILED at 1006. > Hunk #5 FAILED at 1043. > Hunk #6 FAILED at 1052. > Hunk #7 succeeded at 1048 (offset -25 lines). > Hunk #8 FAILED at 1053. > Hunk #9 succeeded at 1064 (offset -111 lines). > Hunk #10 succeeded at 1081 (offset -111 lines). > Hunk #11 succeeded at 2762 (offset -111 lines). > 4 out of 11 hunks FAILED -- saving rejects to file app.js.rej > > > Index: program/js/app.js =================================================================== RCS file: /cvsroot/roundcubemail/roundcubemail/program/js/app.js,v retrieving revision 1.27 diff -u -r1.27 app.js --- program/js/app.js 13 Jan 2006 17:14:38 -0000 1.27 +++ program/js/app.js 19 Jan 2006 05:23:23 -0000 @@ -13,6 +13,10 @@ $Id: app.js,v 1.27 2006/01/13 17:14:38 roundcube Exp $ */ +// Constants +var CONTROL_KEY = 1; +var SHIFT_KEY = 2; +var CONTROL_SHIFT_KEY = 3; var rcube_webmail_client; @@ -997,11 +1001,30 @@ if (this.dont_select) return false; + // selects currently unselected row if (!this.in_selection_before) - { - var ctrl = this.check_ctrlkey(e); - this.select(id, ctrl); + { + var mod_key = this.get_modifier(e); + if (!mod_key) { + this.select(id, false); + this.last_selected = id; + } else { + switch (mod_key) { + case SHIFT_KEY: { this.shift_select(id,false); break; } + case CONTROL_KEY: { + this.select(id, true); + this.last_selected = id; + break; + } + case CONTROL_SHIFT_KEY: { this.shift_select(id,true); break;} + default: { + this.select(id, false); + this.last_selected = id; + break; + } + } } + } if (this.selection.length) { @@ -1017,7 +1040,7 @@ // onmouseup-handler of message list row this.click_row = function(e, id) { - var shift = this.check_shiftkey(e); + var mod_key = this.get_modifier(e); // don't do anything (another action processed before) if (this.dont_select) @@ -1026,16 +1049,33 @@ return false; } - if (!this.drag_active && this.in_selection_before==id) - { - this.select(id, (shift && this.task!='settings')); + // unselects currently selected row + if (!this.drag_active && this.in_selection_before==id) { + if (!mod_key) { + this.last_selected = id; + this.select(id, false); + } else { + switch (mod_key) { + case SHIFT_KEY: { this.shift_select(id,false); break; } + case CONTROL_KEY: { + this.last_selected = id; + this.select(id, (this.task!='settings')); + break; + } + case CONTROL_SHIFT_KEY: {this.shift_select(id,true);break;} + default: { + this.select(id, false); + this.last_selected = id; + break; + } + } } - + } this.drag_start = false; this.in_selection_before = false; // row was double clicked - if (this.task=='mail' && this.list_rows && this.list_rows[id].clicked && !shift) + if (this.task=='mail' && this.list_rows && this.list_rows[id].clicked) { this.show_message(id); return false; @@ -1132,7 +1172,6 @@ this.selection = a_pre.concat(a_post); this.set_classname(this.list_rows[id].obj, 'selected', false); } - selected = (this.selection.length==1); } @@ -1150,6 +1189,28 @@ }; +// select all rows from the last selected row to the current one, while deselecting all other rows + this.shift_select = function(id,control) + { + var from_rowIndex = this.list_rows[this.last_selected].obj.rowIndex; + var to_rowIndex = this.list_rows[id].obj.rowIndex; + + var i = ((from_rowIndex < to_rowIndex)? from_rowIndex : to_rowIndex); + var j = ((from_rowIndex > to_rowIndex)? from_rowIndex : to_rowIndex); + + // iterate through the entire message list + for (var n in this.list_rows) { + if ((this.list_rows[n].obj.rowIndex >= i) && (this.list_rows[n].obj.rowIndex <= j)) { + if (!this.in_selection(n)) + this.select(n, true); + } else { + if (this.in_selection(n) && !control) + this.select(n, true); + } + } + }; + + this.clear_selection = function() { for(var n=0; n<this.selection.length; n++) @@ -2809,6 +2870,26 @@ return false; } + +// returns modifier key (constants defined at top of file) + this.get_modifier = function(e) + { + var opcode = 0; + if (e = e || window.event) + { + opcode += (e.ctrlKey && CONTROL_KEY) + (e.shiftKey && SHIFT_KEY); + return opcode; + } + if (e.cancelBubble) + { + e.cancelBubble = true; + e.returnValue = false; + } + else if (e.preventDefault) + e.preventDefault(); + } + + this.get_mouse_pos = function(e) { if(!e) e = window.event;

3 3

stability of CVS
by Jon Daley 19 Jan '06

19 Jan '06

Hi. This looks like an excellent piece of software. I have shown it to a couple people who care about design sorts of things, and they were quite impressed. I see the don't-use-the-cvs-version-unless-you-want-to-have-broken-email warning on the sourceforge page, and I am wondering how much you mean it. (: I am willing to put up with some instability, but I want it to work most of the time. Should I stick with the official releases? I am familiar with cvs (and svn - glad to hear that you are converting over sometime soon) and comfortable working on code. Do you have a suggestion? -- Jon Daley http://jon.limedaley.com/

6 5

5 features worth implementing?
by Sjon 18 Jan '06

18 Jan '06

After loosing an important mail composed under Roundcube (just pushed the send-button, 'something' went wrong and the email was lost forever) I have thought of ideas to avoid this. I think the following might be feasible: currently mails are send in the background; a failure means the message disappears. Might it be an idea not to use an AJAX backgrounded thread for sending the email, but staying on the foreground; only to return to the inbox once the message has succesfully been send? Some other stuff I thought of: * move the current overflow-scrollbar style from the table to the tbody. This would leave the thead always visible, while currently it will disappear when scrolling * make the attachment-icon (singleclick) in the messagelisting jump directly to the message-attachment. Currently it is just an icon without any link * a javascript prompt before any actual delete action, for example in the addressbook page * could we merge the _auth (GET) and sessid (COOKIE) into 1 sessionID? Comments welcome :) Regards, Sjon

9 11

shift-select and control-select patch
by popquizh＠popquizhotshot.com 18 Jan '06

18 Jan '06

I tried sending this message with RoundCube, but I don't think the attachment was working. Anyway, this patch changes the control-select and shift-select behavior for lists to emulate that of standard windows applications (or at least Outlook and Thunderbird which is what I tested it against). Please give it a try and let me know how it turns out. Also let me know if any further steps need to be taken to have this patch considered for merge into the main code. -Charles

4 5

Re: public ldap search features implemented
by justin randell 18 Jan '06

18 Jan '06

hi pieter, thanks for the feedback :-) > I've found one bug! When there is only one server, the server-dropdown > list is not displayed. This is fine. But, the javascript filling the > searchfield requires this dropdownlist! So, when there is only one > server, the searchfields are not filled and the searchfunction does > not work!! good catch - fix committed to cvs. > Another thing that confused me, was the $rcmail_config['ldap_public'] > config. The default value is false. But I wanted to enable it, so I > set it to true. But this doesn't work. It appears that you can set it > to false for disabling it, OR specify servers to enable it. I know > this is just the way PHP works, but it did confuse me... Maybe a > better way, to solve this, is not specify the > $rcmail_config['ldap_public'] = false; option in the default config, > and that this option is disabled because there aro no servers defined. or just add a note explaining that in the config file? i don't mind either way. what do others think? > Few suggestions: > * Could the interface be more integrated with the > addressbookinterface? (Listing the results on the left) there's a good chance that most of the results returned from a search of a large public ldap server wont be of any interest (eg - typing 'justin' to get my details from our public ldap server returns 11 results, only one of which is me), so automatically adding all results to the list on the left is probably not going to be that useful. i think its better to make it easy to act on the returned results (add to private addressbook or compose mail to) rather than just add them to the list on the left. its likely that i'm just missing a better way to do it, so i'd be happy if someone could suggest how to get around problems like the one above. > * Could there be a "List all" option? if the ldap server you are hitting will give you a list of all contacts. this will not be possible for all servers though, and could return very large results, so we would need to page them. do other people want this as well? > * I do no realy like the Searchfield dropdown. Could there be an > option so that automaticly all fields are searched? yep, we could even have it so that this is configurable by admins - they can have a choice, or they can set it to automatically search all fields. i'm prepared to implement that if people think it would be useful. what do others think? > * The searchfields could use aliasses... could you give me more detail on this point? > * Optional integration with the Autocompletion feature would be great! this is a tricky one, because the autocomplete works on a javascript array, not by sending keystrokes over the network. i think that the autocomplete would be too slow (even on a quick setup) if it wasn't operating on an in-memory array. as soon as any returned results are added to the private addressbook, they are available in the autocomplete for composing mail. one thing that occurred to me: maybe we should make an autocomplete for the private addressbook available in the contacts page. what do other people think? again, thanks for the feedback. justin

3 4

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev