- Dev - Roundcube mailing lists

Address book display bug when email type is "main" [0.9.2]
by Rob Sheldon 30 Aug '13

30 Aug '13

One of my customers did an Outlook export / Roundcube import of his contacts, and none of the contacts were displaying their email address in the address book's vcard section. In the database, all of his contacts had been saved with, "EMAIL;TYPE=INTERNET;TYPE=MAIN:address@host.com". My contacts for example are, "EMAIL;TYPE=INTERNET;TYPE=OTHER:address@host.com". Changing TYPE=OTHER to TYPE=MAIN in one of my contacts caused that one to also not display correctly. I traced this back to program/steps/addressbook/func.inc: 29c29 < 'email' => array('type' => 'text', 'size' => 40, 'maxlength' => 254, 'label' => rcube_label('email'), 'subtypes' => array('home','work','other'), 'category' => 'main'), --- > 'email' => array('type' => 'text', 'size' => 40, 'maxlength' > => 254, 'label' => rcube_label('email'), 'subtypes' => > array('home','work','other','main'), 'category' => 'main'), ...but I'm not sure if this is generally desired behavior or not, so I'm posting here for discussion instead of trac. Thanks, - R. -- [__ Robert Sheldon [__ No Problem [__ Information technology support and services [__ (530) 575-0278

2 7

Re: [RCD] suggested new features
by Matee Moshkovits 28 Aug '13

28 Aug '13

hi guys COR BOSMAN WROTE: > THIS COULD BE DONE WITH A PLUGIN. AND I EVEN THINK THERE ALREADY IS A PLUGIN FOR THAT? > OR DOESNT LARRY HAVE HOOKS FOR A SPOT TO PUT THE REMEMBER ME HTML? > > COR I tried Larry it looks good but I can not find the hook, also that assumes that people are not using other skins and that all Admins are PHP smart to enable the hook as well as install plugins I was thinking of having it as an admin config thing .... config.php so it will exist on every skin and be idiot proof ARNE BERGLUND WROTE: > How is this different than the built-in option for browser auth caching? > > // Allow browser-autocompletion on login form. > // 0 - disabled, 1 - username and host only, 2 - username, host, > password > $rcmail_config['login_autocomplete'] = 0; > > -- > Arne Berglund > System Administrator, Internet Services > Lane Education Service District > Eugene, OR not all browsers have a good working auto-complete, (Internet Exploder 6.0 - 8.0, Opera (All versions), Android Browser (pre: Ice Cream Sandwitch)) and of those that do, how many people think that remember my password is a bad idea ... this gives a choice where it only does the username ... and not the password .... so if the admin has browser auth caching turned off (obviously a security aware admin) it still works ... -- If you have any questions, please do not hesitate to contact our office. Thank you Matee Moshkovits Chief Technology Officer AffordHost Inc. Tel: 416-238-7698 ext. 225 E-mail: mmmoshko(a)affordhost.com

2 2

Roundcube 0.9.3 - iframes scrollbars
by Rosali 28 Aug '13

28 Aug '13

I'm testing with Chrome 29.0.1547.57 m. I get an unnecessary scrollbars for all iframes (preview pane, settings iframe) - Larry skin. I have fixed it by including on global level some js stuff: // iframes $('iframe').height('99%'); NOTE: It happens without any plugins active. By default iframes have the following css properties: element.style { width: 100%; height: 100%; } It looks like height 100% is causing the issue. Anyone else with such issues? Is it a known issue? -- Rosali MyRoundcube Dev Team

2 1

suggested new features
by Matee Moshkovits 27 Aug '13

27 Aug '13

hi Roundcube Master I have been using roundcube for a few years now ... and lurking on the developers list for a few months. I run a hosting company, for the last 9 years we have been using squirrel mail (squirrely mail is the name our help desk have given it). We have not adopted Round cube because it is missing 2 very key features: - Multiple Folder search (just like the search in Thunderbird or Outlook (I feel dirty now that I wrote Roundcube and Thunderbird on the same line as a MS want to be mail program) - "Remember me" - a feature that I have written a patch for that lets the user save the USERNAME on the machine (see: http://newwebmail.affordhost.com) - I can provide the code for this is you wish ... As I appreciate your program I hope to help make it better .... Thank you. -- If you have any questions, please do not hesitate to contact our office. Thank You Matee Moshkovits Chief Technology Officer AffordHost Inc. Direct Telephone: (416)273-9914 Office Telephone: (416)238-7698 x 225 Email: mmmoshko(a)affordhost.com Business-Class Web Hosting at Affordable Prices

3 2

Update 0.9.3 released
by Thomas Bruederli 22 Aug '13

22 Aug '13

Hello folks We can proudly announce the third service release for the stable 0.9 series of Roundcube webmail. It fixes 25 more bugs including two recently reported XSS vulnerabilities with HTML messages and signatures. Along with that, we also optimized the UI behavior for touch devices to make Roundcube work nice and smoothly on tablets running iOS or Android. It's considered stable and we recommend to update all productive installations of Roundcube with this version. Download it from http://roundcube.net/download, see the full changelog here:http://trac.roundcube.net/wiki/Changelog Kind regards, Thomas

3 2

Re: [RCD] Move identity selection based on non-standard headers into (new) identity_select plugin (#1488553)
by Michael Heydekamp 17 Aug '13

17 Aug '13

Where can I download this plugin (the whole package, I mean, not every single file through GitHub)? Couldn't find it on plugins.roundcube.net ... Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 04.08.2013 10:41, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: b825f86108a91957f6467176e418cfc257874658 > > https://github.com/roundcube/roundcubemail/commit/b825f86108a91957f6467176e… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-08-04 (Sun, 04 Aug 2013) > > Changed paths: > M CHANGELOG > A plugins/identity_select/identity_select.php > A plugins/identity_select/package.xml > A plugins/identity_select/tests/IdentitySelect.php > M program/lib/Roundcube/rcube_storage.php > M program/steps/mail/func.inc > > Log Message: > ----------- > Move identity selection based on non-standard headers into (new) identity_select plugin (#1488553) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

2 1

Strange link, not fully being recognized as a link in plain text messages
by Michael Heydekamp 17 Aug '13

17 Aug '13

Yesterday, somebody sent me that link in a plain text message: https://rapidshare.com/#!download|856p1|2938527513|EngNewsBlinkfeedPatch.zi… Roundcube doesn't fully recognize that as a link (only until "download"). Then he sent me the same link in a HTML message, there it is fully being recognized. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

4 5

Re: [RCD] [Svn] [roundcube/roundcubemail] 9263f5: Ignore Reply-To when replying to own message (#148...
by Michael Heydekamp 17 Aug '13

17 Aug '13

Thanks, Alec! :-) -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 05.08.2013 09:15, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: 9263f55a634cafc805307a138f3f2d54df1faa21 > > https://github.com/roundcube/roundcubemail/commit/9263f55a634cafc805307a138… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-08-05 (Mon, 05 Aug 2013) > > Changed paths: > M program/steps/mail/compose.inc > > Log Message: > ----------- > Ignore Reply-To when replying to own message (#1489230) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 1

Default and Special folder config options
by Phil Weir 05 Aug '13

05 Aug '13

Hi, In the config file there are options to set the special folders: drafts_mbox, sent_mbox, junk_mbox, trash_mbox and also to set the default_folders (the ones that can be protected on the folder management screen). On the preferences screen in the UI in the special folders section a user can override the special folder settings but this overrides both the special folders and the default folders. On my system I am using a plugin to get the default and speical folder information from the server when the user logs in (my IMAP supports the special-use extension). I would to separate the special folder and default folder config options in the UI so that a use is able to setup their own speical folders without changing the default folders setting. I realise I could do this with a plugin but it seemed a little odd to me that a user is able to change what folders are protected - if an admin wants to protect some folders then users should not be able to get around that. Phil

1 0

"Edit as new" creates strange (partially) HTML formatted messages
by Michael Heydekamp 02 Aug '13

02 Aug '13

1.0-git: When using "Edit as new" on a text/plain message, Roundcube suddenly prefixes each message with... -------------------------------------------------------------------------- > <body><p> -------------------------------------------------------------------------- ... and closes it with... ------------- > </p></body> ------------- Plus that certain characters such as ">" and the double quote itself in the body are converted to ">" and """. Interestingly, other 8bit chars such as German Umlauts keep untouched, which is somewhat unlogical. I have no idea why Roundcube does this (especially as it didn't do it before), but it doesn't look correct to me. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 2

Reg. "squirrelmail_usercopy" plugin
by Vivek Vetri 01 Aug '13

01 Aug '13

Hi all, Am currently in a process of migrating "squirrelmail address books" to roundcube. I have found one plugin named "squirrelmail_usercopy" in plugin repository. [updated version] I have installed , configured and enabled the plugin in configuration file. The error log is not revealing any errors (like dbconn failure,etc) but the plugin is not working (I mean, the address books in squirrelmail is automatically migrated to RC). Is anyone experiencing the same problem ? P.S : I have tried the solutions regarding the rc api file and am sure the plugin is configured correctly. -- Regards, Vivek Vetri " Taking Risk ! Takes Practice ! "

1 0

Invalid or Expired Session
by Rodrigo Castillo 31 Jul '13

31 Jul '13

We've had sporadic reports of expired or invalid sessions from users. They'll have a roundcube page open, possibly other tabs, too, then click on compose or on an email message and be presented with a login screen that says the session is invalid or expired. We're thinking it's possibly related to js getting stalled or the keep_alive not being run due to the page being 'busy' for any other reason, but reproducing the behavior, let alone diagnosing it, has been difficult. Our sessions are in mysql and have a length of 10min, keep_alive runs every 60s. Has anyone else had reports like this?

2 1

turning off a plugin from another plugin
by Cor Bosman 30 Jul '13

30 Jul '13

Hey all, anyone know if it's possible to turn off a plugin from another plugin? only certain people are currently allowed to use managesieve in our setup, and right now I have some hacks inside managesieve to do that but it would be cleaner if I could do that from a separate plugin, cor

2 2

Jenkins integration
by Michée Lengronne 29 Jul '13

29 Jul '13

Hello, I try to integrate Roundcube into Jenkins but the ant build seems to have a problem. Is there an official build.xml file ? Do you use Jenkins for continuous integration ? Thanks. -- Signature Michée Lengronne Coppint Michée Lengronne ------------------------------------------------------------------------ Ce message et ses éventuelles pièces jointes sont personnels, confidentiels et à l'usage exclusif de leur destinataire. Si vous n'étes pas la personne à laquelle ce message est destiné, veuillez noter que vous avez reçu ce courriel par erreur et qu'il vous est strictement interdit d'utiliser, de diffuser, de transférer, d'imprimer ou de copier ce message. This e-mail and any attachments hereto are strictly personal, confidential and intended solely for the addressee. If you are not the intended recipient, be advised that you have received this email in error and that any use, dissemination, forwarding, printing, or copying of this message is strictly prohibited. ------------------------------------------------------------------------ Logo CopPInt 30440 Saint Laurent le Minier France *Compagnie pour des Prestations Internet* Téléphone personnel : +41 (0)791 94 71 98 Téléphone professionnel : +33 (0) 4 84 25 23 67 poste 102 Téléphone professionnel : 0805 696 8 9 0 poste 102 France uniquement Courriel : michee.lengronne(a)Coppint.com <mailto:michee.lengronne@coppint.com> ------------------------------------------------------------------------

1 0

Re: [RCD] [RCU] Unexpected session timeouts using memcached session store
by Thomas Bruederli 23 Jul '13

23 Jul '13

Hi David Thanks a lot for the analysis and the proposed solution! Memcache support is still considered experimental and not tested by a broad audience. But your observations and the proposed fix seem reasonable and just applied the changes to git. Best regards, Thomas David Carter wrote: > We are currently running a pilot Roundcube service and are expecting to go > live a a couple of weeks time. Something that my users have picked up on is > that idle sessions appear to time out in unpredictable ways despite the > keep_alive requests fired off by the Web browser. > > A bit of digging over the weekend revealed a potential race condition in > program/lib/Roundcube/rcube_session.php : mc_write(). (Roundcube 0.9.2). > > I'm happy to write the following up as a ticket on trac.roundcube.net. I > wanted to make sure my analysis and proposed solution was correct first. > > Given the 10 minute (600 second) default session_lifetime, keep_alive > requests are fired off every 300 seconds. However these may not arrive > immediately, particularly if the Web browser, network or server is busy. > > Sessions stored in memcached expire after precisely 600 seconds unless they > are refreshed. > > mc_write() only refreshes session entries if the following is true: > > ($newvars !== $oldvars || $ts - $this->changed > $this->lifetime / 2) > > Most of the time with a idle login session: > ($this->lifetime / 2) will be 300 > ($ts - $this->changed) will be a tiny fraction more than 300. > > However if I add some logging it becomes clear that ($ts - $this->changed) > is occasionally less than 300. I imagine this happens when the previous > keep_alive was stuck in transit for a fraction of a second. It is an > asynchronous request and the timer for the next keep_alive doesn't wait. > > The mc_write() refresh on the session data is skipped when this happens. > > The following keep_alive is scheduled to arrive precisely the same second > that the session is due to expire in memcached. If you are unlucky the > keep_alive arrives just after the session has been expired, which leads a > "Session is invalid or has expired" error page. > > This is using memcached for session storage: the problem appears to go away > if I switch to using a database backend. I believe that this is because > session entries stored in memcached expire after precisely 600 seconds. > With a database backend sessions are expired by PHP garbage collection > later on. This will add a few seconds delay, at least on a inactive system. > > The attached patch appears to fix the problem, using two separate approaches: > > 1) A lower threshold for deciding when to refresh the session entry. (I am > tempted to remove the guard condition altogether and always update. > There isn't any I/O cost associated with a memcached back end). > > 2) A slightly longer expiry time for entries stored in memcached. > > However I may be missing some subtlety about the refresh process. > > -- > David Carter Email: David.Carter(a)ucs.cam.ac.uk > University Computing Service, Phone: (01223) 334502 > New Museums Site, Pembroke Street, Fax: (01223) 334679 > Cambridge UK. CB2 3QH. > > --- program/lib/Roundcube/rcube_session.php-DIST 2013-07-21 > 12:11:49.000000000 +0100 > +++ program/lib/Roundcube/rcube_session.php 2013-07-22 > 10:00:40.000000000 +0100 > @@ -310,9 +310,9 @@ > > $newvars = $oldvars !== null ? $this->_fixvars($vars, $oldvars) : > $vars; > > - if ($newvars !== $oldvars || $ts - $this->changed > > $this->lifetime / 2) { > + if ($newvars !== $oldvars || $ts - $this->changed > > $this->lifetime / 3) { // DPC > return $this->memcache->set($key, serialize(array('changed' => > time(), 'ip' => $this->ip, 'vars' => $newvars)), > - MEMCACHE_COMPRESSED, $this->lifetime); > + MEMCACHE_COMPRESSED, $this->lifetime + 60); // DPC > } > > return true; > _______________________________________________ > Roundcube Users mailing list > users(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/users

1 0

Configuration changes in git master
by Thomas Bruederli 22 Jul '13

22 Jul '13

Hello devs With today's commit [1] we took the first step towards a new and simplified configuration for Roundcube. We merged the two files main.inc.php and db.inc.php into one single config.inc.php file and a defaults.inc.php file respectively. The config.inc.php is meant to be the local config file and only containing those options which differ from the defaults. The defaults.inc.php will be part of the distribution is will be updated with every software update and thus should not be modified. The current git master will remain using the old config files as a fallback but we strongly recommend to upgrade your configs if you're running a bleeding edge git master version somewhere. You can do this by running bin/update.sh and letting the script migrate your config. The manual way of doing this is to copy config.inc.php.sample file and start from scratch. There's more to come related to configs [2] but this was the major change that just found its way back into git master. Kind regards, Thomas [1] https://github.com/roundcube/roundcubemail/commit/0703bfecd0 [2] http://trac.roundcube.net/ticket/1487311

3 8

RC in iframe: print, download, show source and open in new window button don't work properly.
by Michée Lengronne 22 Jul '13

22 Jul '13

Hello, I have roundcube embbeded in an iframe and I would like to have all the functionnalities working properly. Currently, the "print", "download", "show source" and "open in new window" buttons don't work properly in the iframe. They work properly in direct access. How can I adjust that ? Thanks. -- Signature Michée Lengronne Coppint Michée Lengronne ------------------------------------------------------------------------ Ce message et ses éventuelles pièces jointes sont personnels, confidentiels et à l'usage exclusif de leur destinataire. Si vous n'étes pas la personne à laquelle ce message est destiné, veuillez noter que vous avez reçu ce courriel par erreur et qu'il vous est strictement interdit d'utiliser, de diffuser, de transférer, d'imprimer ou de copier ce message. This e-mail and any attachments hereto are strictly personal, confidential and intended solely for the addressee. If you are not the intended recipient, be advised that you have received this email in error and that any use, dissemination, forwarding, printing, or copying of this message is strictly prohibited. ------------------------------------------------------------------------ Logo CopPInt 30440 Saint Laurent le Minier France *Compagnie pour des Prestations Internet* Téléphone personnel : +41 (0)791 94 71 98 Téléphone professionnel : +33 (0) 4 84 25 23 67 poste 102 Téléphone professionnel : 0805 696 8 9 0 poste 102 France uniquement Courriel : michee.lengronne(a)Coppint.com <mailto:michee.lengronne@coppint.com> ------------------------------------------------------------------------

2 1

Google Spellchecker
by Victor Benincasa 16 Jul '13

16 Jul '13

Hello Folks, The Google apparently turned off its spell check API since Jul 10, so the default Roundcube spell checker stopped working: https://www.google.com/tbproxy/spell Anybody have any additional/official information about it? Cheers, -- *Victor Benincasa* # *Mobile*: +55 (11) 99222-7227 | *Nextel*: 55*11*51775 | *Skype*: vbenincasa # *CTO / CIO* :: Networks, Applications, Systems, Security, Advanced Support

1 0

trac problem
by Michael Heydekamp 13 Jul '13

13 Jul '13

Just wanted to post a comment to http://trac.marketingxp.com/ticket/1488553, but when sending it, I get the following: ---------------------------------------------------------------------- > Trac wertet Ihre Übertragung als Spam. Um das Gegenteil zu beweisen, > geben Sie bitte Antwort auf folgendes. > > Input error: Invalid referer ---------------------------------------------------------------------- So I can't send the comment. What does "Invalid referer" mean and how can I avoid it? This spam warning is annoying anyway. Can't it be disabled at all?? I mean, I'm logged in, why does trac then think it might be spam...? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

3 3

Re: [RCD] [Svn] [roundcube/roundcubemail] 73ad4f: Finally: make message list header stay on top when scrolling (#1295420)
by Michael Heydekamp 13 Jul '13

13 Jul '13

See commit quoted below: Larry only? :-( ...Seconds later...: Ah, the message LIST header, not the message header...? Ideally, both (message list header as well as message header) should stay on top upon scrolling - and of course in both skins, IMO. I'd still love to kill the folks who invented Larry... ;-) Seriously: It's unfortunate that the Classic skin doesn't get the same attention by the devs anymore as the Larry skin. Although the Classic skin is still the better usable one, as being less fancy. <sigh> Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 09.07.2013 23:42, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: 73ad4f1bfdf104055104907c11f97315d6fb2ebe > > https://github.com/roundcube/roundcubemail/commit/73ad4f1bfdf104055104907c1… > Author: Thomas Bruederli <thomas(a)roundcube.net> > Date: 2013-07-09 (Tue, 09 Jul 2013) > > Changed paths: > M program/js/app.js > M program/js/list.js > M skins/larry/mail.css > M skins/larry/templates/mail.html > M skins/larry/ui.js > > Log Message: > ----------- > Finally: make message list header stay on top when scrolling (#1295420) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

2 2

The identities_list hook
by Philipp Kewisch 12 Jul '13

12 Jul '13

Hello Folks, I have a question regarding the identities_list hook. I would like to replace the full list of identities by my own using a plugin. It seems to me the identities_list hook is only used for display, as the original identities from the database are added. Is this just an oversight, or is it supposed to be that way? I would like to propose to make use of the identities_list hook more often. The ideal solution would be to query the plugin hook in rcube_user.php's list_identities, returning the plugin defined list of identities everywhere. The only downside is that the current caller in program/steps/settings/func.inc will have to query the plugin twice, once directly to get the array of columns and once indirectly via rcube_user.php. I'm happy to provide the patch myself, I would just like to ask here before I send a PR. Alternatively, is there another way to intercept the identities and user management? We would like to use our own user management backend. Philipp

2 9

merge sessions between owncloud and roundcube
by Michée Lengronne 12 Jul '13

12 Jul '13

Hello, I have an owncloud and a roundcube sharing the same session pool via a memcache server and I would like them to work with an unique session. I changed the cookie session.name to have the same for owncloud and roundcube and I tried a lot of tricks: to pass the session id then the session name via url, to change the $_SESSION['user_id' in roundcube because owncloud has the same variable, to avoid the cookie creation in the session_init from roundcube, etc... But, the roundcube session always erase the owncloud one which causes owncloud not to login anymore. What is the trick ? Is there a method somewhere to do that ? Thanks. PS: I use the 'RoundcubeLogin.class.php <http://blog.philippheckel.com/uploads/2008/05/RoundcubeLogin.class.phps>' to perform the login from owncloud to roundcube but it creates separate sessions for each. -- Signature Michée Lengronne Coppint Michée Lengronne ------------------------------------------------------------------------ Ce message et ses éventuelles pièces jointes sont personnels, confidentiels et à l'usage exclusif de leur destinataire. Si vous n'étes pas la personne à laquelle ce message est destiné, veuillez noter que vous avez reçu ce courriel par erreur et qu'il vous est strictement interdit d'utiliser, de diffuser, de transférer, d'imprimer ou de copier ce message. This e-mail and any attachments hereto are strictly personal, confidential and intended solely for the addressee. If you are not the intended recipient, be advised that you have received this email in error and that any use, dissemination, forwarding, printing, or copying of this message is strictly prohibited. ------------------------------------------------------------------------ Logo CopPInt 30440 Saint Laurent le Minier France *Compagnie pour des Prestations Internet* Téléphone personnel : +41 (0)791 94 71 98 Téléphone professionnel : +33 (0) 4 84 25 23 67 poste 102 Téléphone professionnel : 0805 696 8 9 0 poste 102 France uniquement Courriel : michee.lengronne(a)Coppint.com <mailto:michee.lengronne@coppint.com> ------------------------------------------------------------------------

1 0

Inserting images in HTML messages with <Ctrl+V>
by Michael Heydekamp 10 Jul '13

10 Jul '13

What we just realized here: Inserting an image with <Ctrl+V> in an HTML message does work with Firefox and Cyberfox, but not with: - Chrome - IE8 - IE10 Roundcube or browser issue?? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

1 0

Folders tab not accessible in git-master anymore (was: [Svn] [roundcube/roundcubemail] e89d8f: Performance fix: Do not ask for folder attributes if we know that folder do not exists)
by Michael Heydekamp 09 Jul '13

09 Jul '13

In git-master, the folders tab is not accessible anymore (no matter which user is logged in). FF does display a blank page (as a FF user is telling me), IE8 is throwing a HTTP 500 along with a message that the page can't be displayed (see attached). I assume it has to do with the change quoted below. In 0.9.2, all is still working fine. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 09.07.2013 18:57, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: e89d8f1fec3743e9ee1018d3bab1a375ab79cebf > > https://github.com/roundcube/roundcubemail/commit/e89d8f1fec3743e9ee1018d3b… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-07-09 (Tue, 09 Jul 2013) > > Changed paths: > M program/steps/settings/folders.inc > > Log Message: > ----------- > Performance fix: Do not ask for folder attributes if we know that folder > do not exists > > > Commit: 95a18fa549c9576b7035d27ef1712c5dfd01422d > > https://github.com/roundcube/roundcubemail/commit/95a18fa549c9576b7035d27ef… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-07-09 (Tue, 09 Jul 2013) > > Changed paths: > M plugins/help/help.js > M plugins/help/help.php > M plugins/help/skins/classic/help.css > M plugins/help/skins/classic/templates/help.html > M plugins/help/skins/larry/templates/help.html > > Log Message: > ----------- > Merge branch 'master' of github.com:roundcube/roundcubemail > > > Compare: > https://github.com/roundcube/roundcubemail/compare/d8e10161098d...95a18fa54… > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 0

Logic of identity selection
by Michael Heydekamp 09 Jul '13

09 Jul '13

I need to cover some quite special scenarios here in terms of identity selection, and therefore wanted first to understand the current logic how an identity is being selected (in order to implement a correct and working patch later on). I got stuck already at first attempt. Say we have the following two messages with their headers (please don't ask why there are two headers "Envelope-To:", just please take it as a matter of fact): Message #1: ---------------------------------------------- Delivery-date: Sat, 06 Jul 2013 20:29:21 +0200 Return-path: <theo1(a)tester.de> Envelope-To: identity1(a)test.de Envelope-To: identity2(a)test.de MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 06 Jul 2013 20:29:21 +0200 From: theo1(a)tester.de To: theo2(a)tester.de Subject: Test #1 (Envelope-To: identity1(a)test.de, Envelope-To: identity2(a)test.de) Message-ID: <identity1(a)tester.de> X-Sender: theo1(a)tester.de User-Agent: Roundcube Webmail/1.0-git Test - pls ignore. ---------------------------------------------- Message #2: ---------------------------------------------- Delivery-date: Sat, 06 Jul 2013 20:29:21 +0200 Return-path: <theo1(a)tester.de> Envelope-To: identity2(a)test.de Envelope-To: identity1(a)test.de MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 06 Jul 2013 20:29:21 +0200 From: theo1(a)tester.de To: theo2(a)tester.de Subject: Test #1 (Envelope-To: identity2(a)test.de, Envelope-To: identity1(a)test.de) Message-ID: <identity2(a)tester.de> X-Sender: theo1(a)tester.de User-Agent: Roundcube Webmail/1.0-git Test - pls ignore. ---------------------------------------------- Please also take it as a matter of fact that "identity1(a)test.de" and "identity2(a)test.de" are being defined as identities in Roundcube. The main difference between these two messages is the order of the "Envelope-To:" headers. But apparently that doesn't make any difference at all, as when replying to these messages, the identity "identity1(a)test.de" is being used as the sender in the "From:" header in both cases. Hmm...?!? This logic escapes me and makes my life more difficult, as this behaviour is telling me that the order (of both the same headers in the same message!) doesn't make any difference. Is the choice being taken because of the alphabetical order of the sender addresses (so that "identity1(a)test.de" is preceding "identity2(a)test.de")? At this point I stopped testing, and my next question is: As I'm able to create any custom header right before delivery, how can I make sure that this - and only this - custom header will be respected with regards to identity selection, disregarding any other headers/addresses and the entire rest of the logic...? This would be a private patch, of course. Any help and hint appreciated, for I'm a noob in terms of PHP (= I have an idea of the logic, but just can't code it). Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

3 9

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev