- Dev - Roundcube mailing lists

Configuration changes in git master
by Thomas Bruederli 22 Jul '13

22 Jul '13

Hello devs With today's commit [1] we took the first step towards a new and simplified configuration for Roundcube. We merged the two files main.inc.php and db.inc.php into one single config.inc.php file and a defaults.inc.php file respectively. The config.inc.php is meant to be the local config file and only containing those options which differ from the defaults. The defaults.inc.php will be part of the distribution is will be updated with every software update and thus should not be modified. The current git master will remain using the old config files as a fallback but we strongly recommend to upgrade your configs if you're running a bleeding edge git master version somewhere. You can do this by running bin/update.sh and letting the script migrate your config. The manual way of doing this is to copy config.inc.php.sample file and start from scratch. There's more to come related to configs [2] but this was the major change that just found its way back into git master. Kind regards, Thomas [1] https://github.com/roundcube/roundcubemail/commit/0703bfecd0 [2] http://trac.roundcube.net/ticket/1487311

3 8

RC in iframe: print, download, show source and open in new window button don't work properly.
by Michée Lengronne 22 Jul '13

22 Jul '13

Hello, I have roundcube embbeded in an iframe and I would like to have all the functionnalities working properly. Currently, the "print", "download", "show source" and "open in new window" buttons don't work properly in the iframe. They work properly in direct access. How can I adjust that ? Thanks. -- Signature Michée Lengronne Coppint Michée Lengronne ------------------------------------------------------------------------ Ce message et ses éventuelles pièces jointes sont personnels, confidentiels et à l'usage exclusif de leur destinataire. Si vous n'étes pas la personne à laquelle ce message est destiné, veuillez noter que vous avez reçu ce courriel par erreur et qu'il vous est strictement interdit d'utiliser, de diffuser, de transférer, d'imprimer ou de copier ce message. This e-mail and any attachments hereto are strictly personal, confidential and intended solely for the addressee. If you are not the intended recipient, be advised that you have received this email in error and that any use, dissemination, forwarding, printing, or copying of this message is strictly prohibited. ------------------------------------------------------------------------ Logo CopPInt 30440 Saint Laurent le Minier France *Compagnie pour des Prestations Internet* Téléphone personnel : +41 (0)791 94 71 98 Téléphone professionnel : +33 (0) 4 84 25 23 67 poste 102 Téléphone professionnel : 0805 696 8 9 0 poste 102 France uniquement Courriel : michee.lengronne(a)Coppint.com <mailto:michee.lengronne@coppint.com> ------------------------------------------------------------------------

2 1

Google Spellchecker
by Victor Benincasa 16 Jul '13

16 Jul '13

Hello Folks, The Google apparently turned off its spell check API since Jul 10, so the default Roundcube spell checker stopped working: https://www.google.com/tbproxy/spell Anybody have any additional/official information about it? Cheers, -- *Victor Benincasa* # *Mobile*: +55 (11) 99222-7227 | *Nextel*: 55*11*51775 | *Skype*: vbenincasa # *CTO / CIO* :: Networks, Applications, Systems, Security, Advanced Support

1 0

trac problem
by Michael Heydekamp 13 Jul '13

13 Jul '13

Just wanted to post a comment to http://trac.marketingxp.com/ticket/1488553, but when sending it, I get the following: ---------------------------------------------------------------------- > Trac wertet Ihre Übertragung als Spam. Um das Gegenteil zu beweisen, > geben Sie bitte Antwort auf folgendes. > > Input error: Invalid referer ---------------------------------------------------------------------- So I can't send the comment. What does "Invalid referer" mean and how can I avoid it? This spam warning is annoying anyway. Can't it be disabled at all?? I mean, I'm logged in, why does trac then think it might be spam...? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

3 3

Re: [RCD] [Svn] [roundcube/roundcubemail] 73ad4f: Finally: make message list header stay on top when scrolling (#1295420)
by Michael Heydekamp 13 Jul '13

13 Jul '13

See commit quoted below: Larry only? :-( ...Seconds later...: Ah, the message LIST header, not the message header...? Ideally, both (message list header as well as message header) should stay on top upon scrolling - and of course in both skins, IMO. I'd still love to kill the folks who invented Larry... ;-) Seriously: It's unfortunate that the Classic skin doesn't get the same attention by the devs anymore as the Larry skin. Although the Classic skin is still the better usable one, as being less fancy. <sigh> Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 09.07.2013 23:42, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: 73ad4f1bfdf104055104907c11f97315d6fb2ebe > > https://github.com/roundcube/roundcubemail/commit/73ad4f1bfdf104055104907c1… > Author: Thomas Bruederli <thomas(a)roundcube.net> > Date: 2013-07-09 (Tue, 09 Jul 2013) > > Changed paths: > M program/js/app.js > M program/js/list.js > M skins/larry/mail.css > M skins/larry/templates/mail.html > M skins/larry/ui.js > > Log Message: > ----------- > Finally: make message list header stay on top when scrolling (#1295420) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

2 2

The identities_list hook
by Philipp Kewisch 12 Jul '13

12 Jul '13

Hello Folks, I have a question regarding the identities_list hook. I would like to replace the full list of identities by my own using a plugin. It seems to me the identities_list hook is only used for display, as the original identities from the database are added. Is this just an oversight, or is it supposed to be that way? I would like to propose to make use of the identities_list hook more often. The ideal solution would be to query the plugin hook in rcube_user.php's list_identities, returning the plugin defined list of identities everywhere. The only downside is that the current caller in program/steps/settings/func.inc will have to query the plugin twice, once directly to get the array of columns and once indirectly via rcube_user.php. I'm happy to provide the patch myself, I would just like to ask here before I send a PR. Alternatively, is there another way to intercept the identities and user management? We would like to use our own user management backend. Philipp

2 9

merge sessions between owncloud and roundcube
by Michée Lengronne 12 Jul '13

12 Jul '13

Hello, I have an owncloud and a roundcube sharing the same session pool via a memcache server and I would like them to work with an unique session. I changed the cookie session.name to have the same for owncloud and roundcube and I tried a lot of tricks: to pass the session id then the session name via url, to change the $_SESSION['user_id' in roundcube because owncloud has the same variable, to avoid the cookie creation in the session_init from roundcube, etc... But, the roundcube session always erase the owncloud one which causes owncloud not to login anymore. What is the trick ? Is there a method somewhere to do that ? Thanks. PS: I use the 'RoundcubeLogin.class.php <http://blog.philippheckel.com/uploads/2008/05/RoundcubeLogin.class.phps>' to perform the login from owncloud to roundcube but it creates separate sessions for each. -- Signature Michée Lengronne Coppint Michée Lengronne ------------------------------------------------------------------------ Ce message et ses éventuelles pièces jointes sont personnels, confidentiels et à l'usage exclusif de leur destinataire. Si vous n'étes pas la personne à laquelle ce message est destiné, veuillez noter que vous avez reçu ce courriel par erreur et qu'il vous est strictement interdit d'utiliser, de diffuser, de transférer, d'imprimer ou de copier ce message. This e-mail and any attachments hereto are strictly personal, confidential and intended solely for the addressee. If you are not the intended recipient, be advised that you have received this email in error and that any use, dissemination, forwarding, printing, or copying of this message is strictly prohibited. ------------------------------------------------------------------------ Logo CopPInt 30440 Saint Laurent le Minier France *Compagnie pour des Prestations Internet* Téléphone personnel : +41 (0)791 94 71 98 Téléphone professionnel : +33 (0) 4 84 25 23 67 poste 102 Téléphone professionnel : 0805 696 8 9 0 poste 102 France uniquement Courriel : michee.lengronne(a)Coppint.com <mailto:michee.lengronne@coppint.com> ------------------------------------------------------------------------

1 0

Inserting images in HTML messages with <Ctrl+V>
by Michael Heydekamp 10 Jul '13

10 Jul '13

What we just realized here: Inserting an image with <Ctrl+V> in an HTML message does work with Firefox and Cyberfox, but not with: - Chrome - IE8 - IE10 Roundcube or browser issue?? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

1 0

Folders tab not accessible in git-master anymore (was: [Svn] [roundcube/roundcubemail] e89d8f: Performance fix: Do not ask for folder attributes if we know that folder do not exists)
by Michael Heydekamp 09 Jul '13

09 Jul '13

In git-master, the folders tab is not accessible anymore (no matter which user is logged in). FF does display a blank page (as a FF user is telling me), IE8 is throwing a HTTP 500 along with a message that the page can't be displayed (see attached). I assume it has to do with the change quoted below. In 0.9.2, all is still working fine. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 09.07.2013 18:57, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: e89d8f1fec3743e9ee1018d3bab1a375ab79cebf > > https://github.com/roundcube/roundcubemail/commit/e89d8f1fec3743e9ee1018d3b… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-07-09 (Tue, 09 Jul 2013) > > Changed paths: > M program/steps/settings/folders.inc > > Log Message: > ----------- > Performance fix: Do not ask for folder attributes if we know that folder > do not exists > > > Commit: 95a18fa549c9576b7035d27ef1712c5dfd01422d > > https://github.com/roundcube/roundcubemail/commit/95a18fa549c9576b7035d27ef… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-07-09 (Tue, 09 Jul 2013) > > Changed paths: > M plugins/help/help.js > M plugins/help/help.php > M plugins/help/skins/classic/help.css > M plugins/help/skins/classic/templates/help.html > M plugins/help/skins/larry/templates/help.html > > Log Message: > ----------- > Merge branch 'master' of github.com:roundcube/roundcubemail > > > Compare: > https://github.com/roundcube/roundcubemail/compare/d8e10161098d...95a18fa54… > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 0

Logic of identity selection
by Michael Heydekamp 09 Jul '13

09 Jul '13

I need to cover some quite special scenarios here in terms of identity selection, and therefore wanted first to understand the current logic how an identity is being selected (in order to implement a correct and working patch later on). I got stuck already at first attempt. Say we have the following two messages with their headers (please don't ask why there are two headers "Envelope-To:", just please take it as a matter of fact): Message #1: ---------------------------------------------- Delivery-date: Sat, 06 Jul 2013 20:29:21 +0200 Return-path: <theo1(a)tester.de> Envelope-To: identity1(a)test.de Envelope-To: identity2(a)test.de MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 06 Jul 2013 20:29:21 +0200 From: theo1(a)tester.de To: theo2(a)tester.de Subject: Test #1 (Envelope-To: identity1(a)test.de, Envelope-To: identity2(a)test.de) Message-ID: <identity1(a)tester.de> X-Sender: theo1(a)tester.de User-Agent: Roundcube Webmail/1.0-git Test - pls ignore. ---------------------------------------------- Message #2: ---------------------------------------------- Delivery-date: Sat, 06 Jul 2013 20:29:21 +0200 Return-path: <theo1(a)tester.de> Envelope-To: identity2(a)test.de Envelope-To: identity1(a)test.de MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 06 Jul 2013 20:29:21 +0200 From: theo1(a)tester.de To: theo2(a)tester.de Subject: Test #1 (Envelope-To: identity2(a)test.de, Envelope-To: identity1(a)test.de) Message-ID: <identity2(a)tester.de> X-Sender: theo1(a)tester.de User-Agent: Roundcube Webmail/1.0-git Test - pls ignore. ---------------------------------------------- Please also take it as a matter of fact that "identity1(a)test.de" and "identity2(a)test.de" are being defined as identities in Roundcube. The main difference between these two messages is the order of the "Envelope-To:" headers. But apparently that doesn't make any difference at all, as when replying to these messages, the identity "identity1(a)test.de" is being used as the sender in the "From:" header in both cases. Hmm...?!? This logic escapes me and makes my life more difficult, as this behaviour is telling me that the order (of both the same headers in the same message!) doesn't make any difference. Is the choice being taken because of the alphabetical order of the sender addresses (so that "identity1(a)test.de" is preceding "identity2(a)test.de")? At this point I stopped testing, and my next question is: As I'm able to create any custom header right before delivery, how can I make sure that this - and only this - custom header will be respected with regards to identity selection, disregarding any other headers/addresses and the entire rest of the logic...? This would be a private patch, of course. Any help and hint appreciated, for I'm a noob in terms of PHP (= I have an idea of the logic, but just can't code it). Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

3 9

quote chars not recognized as quote chars in HTML parts?
by Michael Heydekamp 09 Jul '13

09 Jul '13

Received a multipart/alternative message today, produced with Roundcube 0.9.2 stable (first part text/plain, second part text/html), where the quote chars ">" in the HTML part were not recognized as quote chars upon displaying in RC 1.0-git. See display comparison attached. The HTML code of the relevant paragraph (additionally qp-encoded, charset UTF-8): > > --------------------------------------------------- > >> =E2=94=82 /usr/share/vim/vim73/syntax > >> =E2=94=82 fetchmail.vim > >> =E2=94=82 /usr/share/vim/vim73/ftplugin > >> =E2=94=82 fetchmail.vim > >> =E2=94=82 /usr/share/zsh/4.3.15/functions/Completion/Unix > >> =E2=94=82 _fetchmail > > --------------------------------------------------- Is the displayed result of the HTML part how it should be...? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 9

Re: [RCD] [Svn] [roundcube/roundcubemail] 3b944e: Fix bug where signature wasn't changed on identity selection when editing a draft (#1489229)
by Michael Heydekamp 08 Jul '13

08 Jul '13

Thanks alec, works for me! Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 08.07.2013 10:53, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: 3b944edb02a838e92f5f849b1266f157ccfb7040 > > https://github.com/roundcube/roundcubemail/commit/3b944edb02a838e92f5f849b1… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-07-08 (Mon, 08 Jul 2013) > > Changed paths: > M CHANGELOG > M program/js/app.js > M program/steps/mail/compose.inc > > Log Message: > ----------- > Fix bug where signature wasn't changed on identity selection when > editing a draft (#1489229) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 0

Re: [RCD] [Svn] [roundcube/roundcubemail] c3762a: Fix folder names truncation in Classic skin (#1489220)
by Michael Heydekamp 05 Jul '13

05 Jul '13

Am 04.07.2013 11:20, schrieb GitHub: > Log Message: > ----------- > Fix folder names truncation in Classic skin (#1489220) Thanks! But well, they're shortened rather than trucated (at least in IE8), that's how it should be, right? > Fix bug where not all event handlers were executed (because body onload > was executed after rcmail init function, sometimes) Interesting... Which possible and visible bugs (could) have occurred due to this? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 2

Re: [RCD] bb5d72: Use also Envelope-To for identity selection (#1488...
by Michael Heydekamp 02 Jul '13

02 Jul '13

Currently Roundcube uses "Envelope-To:" and "Delivered-To:" for identity selection (besides "To:" and probably other standard headers). After we recently moved from a dedicated server to a managed server at df.eu (domainfactory), all messages do not have a header "Envelope-To:" anymore, but a header "X-Envelope-To:" instead. This often leads to a wrong identity selection (e.g. always when replying to the Roundcube lists). May I kindly request to support the header "X-Envelope-To:" as well? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 12.12.2012 08:55, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: bb5d7282855dd83ccdd211cb77d0776dce71468e > > https://github.com/roundcube/roundcubemail/commit/bb5d7282855dd83ccdd211cb7… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2012-12-11 (Tue, 11 Dec 2012) > > Changed paths: > M CHANGELOG > M program/lib/Roundcube/rcube_storage.php > M program/steps/mail/compose.inc > > Log Message: > ----------- > Use also Envelope-To for identity selection (#1488553) > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

3 6

File(skins/classic) is not within the allowed path(s)
by Reindl Harald 30 Jun '13

30 Jun '13

there should be used a full qualified path [23-Jun-2013 05:45:01 Europe/Vienna] PHP Warning: is_dir() [http://at.php.net/manual/de/function.is-dir.php]: open_basedir restriction in effect. File(skins/classic) is not within the allowed path(s): (/usr/share/roundcubemail:/var/log/roundcubemail:/etc/roundcubemail:/usr/share/pear) in /usr/share/roundcubemail/program/include/rcmail_output_html.php on line 156 _____________________ cronjob: umask 006; nice -n 19 ionice -c 3 php -d open_basedir="/usr/share/roundcubemail:/var/log/roundcubemail:/etc/roundcubemail:/usr/share/pear" /usr/share/roundcubemail/bin/cleandb.sh >> /var/log/roundcubemail/errors

2 1

Roundcube and Accessibility
by Paul Boddie 27 Jun '13

27 Jun '13

Hello, I have recently had reason to look at Roundcube's accessibility support, particularly for blind and visually impaired users who might consider using Roundcube with a screen reader. I am not in this audience, but I have been attempting to make myself more aware of projects, initiatives and specifications particularly related to Web development and accessibility. It has not escaped my attention that Roundcube is often deployed alongside other solutions, typically to offer users the choice of webmail client where Roundcube is perhaps regarded as the most "desktop-like", and other clients such as Horde and SquirrelMail are regarded as being less fancy. Some examples: https://calmail.berkeley.edu/ http://www.cms.hu-berlin.de/dl/kommunikation/email/webmail It did make me wonder whether the less "fancy" alternatives are being used because they offer a more accessible experience to screen reader users. As part of an evaluation of Kolab and Roundcube, I have been taking a look at the Roundcube interface in conjunction with accessibility tools such as Fangs [1], Orca [2] and Read2Me [3], also looking at the consensus around accessible Web application design. I also searched the mailing lists for discussion around accessibility issues with Roundcube, but found only the following things: http://trac.roundcube.net/ticket/1484257 http://trac.roundcube.net/ticket/1487041 It has been difficult to find much discussion in the last five years on the topic, and so I'm hoping to get some opinions on this matter now to see if anything needs doing and could be done fairly easily to improve Roundcube in this respect. To get started, I have been looking at what Fangs produces for the Roundcube calendar plugin provided with a full Kolab installation, trying to identify basic properties of the interface that could be enhanced to offer a potentially more navigable and accessible experience. According to various Web accessibility guides, exposing headings, page structure and links are all things that help people with screen readers. Roundcube uses headings quite successfully already, for example, although I haven't yet been able to assess how this translates to an improved screen reader experience. (My intention is to evaluate the experience with Orca and to try and devise concrete suggestions for improvements.) Another topic that has become prominent in recent times is that of the WAI-ARIA specifications/technologies. It appears that jQuery annotates elements in the DOM with ARIA attributes, but I haven't really investigated the specific Roundcube support for ARIA. It would be interesting to hear perspectives on such technologies from members of this list. At the moment, I'm really just testing the waters for the potential to improve Roundcube in this way. I'm not a major PHP/JavaScript developer, and the realm of Web accessibility is also rather new to me (in depth), but I'd like to know if developers on this list perceive any shortcomings of Roundcube in this regard and whether there might be convenient ways to make it better. Regards, Paul [1] https://addons.mozilla.org/en-US/firefox/addon/fangs-screen-reader-emulator/ [2] https://projects.gnome.org/orca/ [3] https://addons.mozilla.org/en-US/firefox/addon/read2me-speechify-the-web/

1 0

Roundcube Popups (IE9)
by Michael Heydekamp 23 Jun '13

23 Jun '13

Scenario: Popups are blocked in IE9. Double clicking on a message opens the message in a new popup window without any warning fom IE9. Pressing Enter on the same message does not open the message, but brings up a warning message of IE9, that Popups are blocked. Is this different behaviour a Roundcube or an IE9 issue? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 2

Re: [RCD] sig dashes broken in 1.0-git?
by Michael Heydekamp 18 Jun '13

18 Jun '13

Arne, uh, I must admit that this standard (?) with three sig dashes (without WSP) for top-posted replies is totally new to me, thanks for the input. Is this documented somewhere (RFCs)...? And what's the sense of and reason for it? My default setting is indeed top-posting, because most people I'm in touch with, are unfortunately not familiar with inline quoting. The problem is, that, depending on the person I'm replying to, I do not always use top-posting. In those cases I'm moving the the sig to the bottom of the mail. This would lead to a sig with three dashes at the bottom, so I would have to remove one of them manually, whenever I'm moving a sig to the bottom. Not very convenient... So I think it's better to include a two-dashes-separator in the sig (as I had it before) and always use this one, no matter if top or bottom. Fortunately, RC doesn't touch this, when being part of the sig. But as we speak, I'd like to emphasize again my proposal to have an option in the addressbook, in which way I want to reply to this particular person. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 06.06.2013 01:27, schrieb Arne Berglund: > The three dashes is correct for top-posted replies, and should only appear > when sig is inserted above the quote. If the sig is below the quote, 0.9.x > and earlier then inserts two dashes with WSP. > > I don't currently have a git version running, so I can't compare the > behavior to the production versions. > > This reply is top-posted from 0.9.1. > > --- > Arne Berglund > System Administrator, Internet Services > Lane Education Service District > Eugene, OR > ____________ > > > > On 2013-06-05 15:51, Michael Heydekamp wrote: >> I used to include the sig dashes "-- " in all o my my signatures, but as I >> realized today, Roundcube will add them anyway (if not existent). So I >> removed them in all signatures of all of my identities. >> >> This leads to the following behaviour: >> >> 1) Composing a new message: All OK. >> >> 2) Replying to to a message: Roundcube creates THREE sig dashes instead of >> two ("---"), and without the mandatory WSP at the end of the string. >> >> Strange, uh...? >> >> Cheers, > _______________________________________________ > Roundcube Development discussion mailing list > dev(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/dev

7 12

I need help
by Paul Sosthenes 17 Jun '13

17 Jun '13

Hello, I have attached a screen capture, for the problem I have come across, please see the attachment, and help me. -- Digital Seven D7, Mr. Paul K. Sosthenes, P.O.BOX 1312, Tabora-Tanzania E-mail : moul.76(a)gmail.com Phone No : 255752476139 Skype : pasonet

2 1

Update 0.9.2 released
by Thomas Bruederli 16 Jun '13

16 Jun '13

Hello folks We're proud to announce the second service release for the 0.9 series of Roundcube webmail. It contains 25 bug fixes and improvements as well as some translation updates for Estonian, Romanian Finnish and French. It's considered stable and we recommend to update all productive installations of Roundcube with this version. As usual, download it from http://roundcube.net/download, see the full changelog here: http://trac.roundcube.net/wiki/Changelog Have fun! Thomas

1 0

create folders from mail view
by Phil Weir 14 Jun '13

14 Jun '13

Hi, I have been looking into adding an option for quick folder creation from the mail view. Something like adding a "create folder" option to the contextmenu plugin. I think I remember some talk about this a little while ago but I cannot find anything on the list. I think the UI would be similar to the one used for adding groups in the addressbook. At the moment the folder creation functions are heavily linked into the folders settings page - sending AJAX requests to refresh it etc every time. My idea is to move the code to create and update folders into separate functions and then call those functions in save_folder.inc but also if would allow other things like plugins to reuse the code. Is this something that is interesting to people and more importantly acceptable to the devs? Thanks, Phil

2 2

Need 2 hooks and small patch for auto refresh virtual mailbox
by Sergey Sidlyarenko 12 Jun '13

12 Jun '13

trac.roundcube.net not worked!!! After add this Feature patch return message: Submission rejected as potential spam Content contained these blacklisted patterns: 'MESSAGE' I am use dovecot virtual mailbox \All, i am write plugin for auto refresh this box if changes in real boxes, but need small patch in core. {{{ diff --git a/program/steps/mail/func.inc b/program/steps/mail/func.inc index 1a687f5..4bedae3 100644 --- a/program/steps/mail/func.inc +++ b/program/steps/mail/func.inc @@ -539,7 +539,7 @@ function rcmail_get_mailbox_name_text() } -function rcmail_send_unread_count($mbox_name, $force=false, $count=null, $mark='') +function rcmail_send_unread_count($mbox_name, $force=false, $count=null, $mark='', $parent=false) { global $RCMAIL; @@ -551,7 +551,7 @@ function rcmail_send_unread_count($mbox_name, $force=false, $count=null, $mark=' $unseen = $count; if ($unseen != $old_unseen || ($mbox_name == 'INBOX')) - $RCMAIL->output->command('set_unread_count', $mbox_name, $unseen, + $RCMAIL->output->command(($parent ? 'parent.' : ''). 'set_unread_count', $mbox_name, $unseen, ($mbox_name == 'INBOX'), $unseen && $mark ? $mark : ''); rcmail_set_unseen_count($mbox_name, $unseen); diff --git a/program/steps/mail/mark.inc b/program/steps/mail/mark.inc index dfc892e..7c22ad2 100644 --- a/program/steps/mail/mark.inc +++ b/program/steps/mail/mark.inc @@ -130,4 +130,6 @@ else { $OUTPUT->show_message('internalerror', 'error'); } +$RCMAIL->plugins->exec_hook('mark_success', array()); + $OUTPUT->send(); diff --git a/program/steps/mail/show.inc b/program/steps/mail/show.inc index d8d4372..48b13e1 100644 --- a/program/steps/mail/show.inc +++ b/program/steps/mail/show.inc @@ -305,14 +305,6 @@ $OUTPUT->add_handlers(array( )); -if ($RCMAIL->action == 'print' && $OUTPUT->template_exists('messageprint')) - $OUTPUT->send('messageprint', false); -else if ($RCMAIL->action == 'preview' && $OUTPUT->template_exists('messagepreview')) - $OUTPUT->send('messagepreview', false); -else - $OUTPUT->send('message', false); - - // mark message as read if ($MESSAGE && $MESSAGE->headers && empty($MESSAGE->headers->flags['SEEN']) && ($RCMAIL->action == 'show' || ($RCMAIL->action == 'preview' && intval($CONFIG['preview_pane_mark_read']) == 0))) @@ -324,5 +316,15 @@ if ($MESSAGE && $MESSAGE->headers && empty($MESSAGE->headers->flags['SEEN']) && } } +$RCMAIL->plugins->exec_hook('show_success', array()); + +if ($RCMAIL->action == 'print' && $OUTPUT->template_exists('messageprint')) + $OUTPUT->send('messageprint', false); +else if ($RCMAIL->action == 'preview' && $OUTPUT->template_exists('messagepreview')) + $OUTPUT->send('messagepreview', false); +else + $OUTPUT->send('message', false); + + exit; }}}

2 4

Small glitch with Settings/Preferences/User_Interface/Refresh
by Michael Heydekamp 09 Jun '13

09 Jun '13

We just moved from a dedicated server to a managed server at df.eu (domainfactory) and therefore had to freshly create all our users on the new system. Checking the config defaults of these users after first login, the "Refresh" setting under Preferences/User_Interface was by default set to "never". When this setting is manually changed within Roundcube to "every 1 minute(s)" and being saved by clicking the Save button, it does indeed first look as if it would have been saved. But if you later look again at the User Interface page (after you checked all other pages such as "Mailbox view" etc.), Refresh is still set to "never". You need to change and save it a second time. All other settings of that page (Language, Time zone etc.) are correctly saved at first attempt. Even the option "every 60 minute(s)" of the Refresh item is correctly saved at the first attempt, just not the option "every 1 minute(s)". (Well, to be honest, I didn't check all options, just "1" and "60".) This applies to 0.9.1 [GIT 20130602.1444] with classic skin, didn't check 1.0-git (yet). Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

4 7

Saving "Special Folders" breaks custom sort order of special folders
by Michael Heydekamp 06 Jun '13

06 Jun '13

Just found that small glitch: The sort order of special folders is customized in the config this way (different to the default sort order): > $rcmail_config['default_folders'] = array('INBOX', 'INBOX.Sent', 'INBOX.Drafts', 'INBOX.Trash', 'INBOX.Junk'); This is being reflected in the database this way: s:15:"default_folders";a:5:{i:0;s:5:"INBOX";i:1;s:10:"INBOX.Sent";i:2;s:12:"INBOX.Drafts";i:3;s:11:"INBOX.Trash";i:4;s:10:"INBOX.Junk"; } All OK. But when I (accidentally or deliberately) save the page "Special Folders", the custom sort order in the database is being replaced with the default sort order, although config and database are telling different. This is not by design, is it...? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

1 0

sig dashes broken in 1.0-git?
by Michael Heydekamp 05 Jun '13

05 Jun '13

I used to include the sig dashes "-- " in all o my my signatures, but as I realized today, Roundcube will add them anyway (if not existent). So I removed them in all signatures of all of my identities. This leads to the following behaviour: 1) Composing a new message: All OK. 2) Replying to to a message: Roundcube creates THREE sig dashes instead of two ("---"), and without the mandatory WSP at the end of the string. Strange, uh...? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 2

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev