- Dev - Roundcube mailing lists

keep-alive changes
by A.L.E.C 13 Nov '12

13 Nov '12

Digging into session issues I've found this keep-alive thing a little bit overcomplicated and unclear. The keep-alive setting handles two things: session keeping and new-mail checking. Some plugins also bind to keep-alive to do some recurring actions (e.g. to display calendar alarms, etc.). I think we should split these functionalities. So keep-alive action should be used only for session keeping. In such case we need to execute keep-alive action only after some inactivity time (e.g. session_lifetime - 1min [or 5%]). It means timer should be resetted on every reequest. Also it means we don't need a separate config option, because the interval would be calculated from session_lifetime. For session_lifetime=0 there would be no keep-alive requests. Another thing is recurring check for new-mail. This would work as is, but... see below. Last but not least. We should provide some "global" recurring action which would work across all tasks so, plugins could bind to it. One "global" action to minimize session race-conditions when few plugins will create their own recurring requests on the same time. In mail task we could "bind" our check-recent action to this global action. In my opinion this would be a much clearer solution and would give as some additional possibilities: - possibility to disable recurring checks (for new mail etc.) at all, - better overall performance because keep-alive out of mail task will be executed less frequently I think also, we could rename keep_alive option description ("Check for new messages on") into something like "Update system state (check for new mail, etc.) on", and move it to User Interface section, so we could use it as our global action interval. ps. I'm not sure we should change draft auto-save interval in any way to fit into this. For simplicity would be nice to use the same global action and its interval. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

3 8

adding topline to template_container hook
by Sébastien BLAISOT 11 Nov '12

11 Nov '12

Hi folks, Larry skin introduced topline (the line on top of screen showing About and support link on the left and username and logout link on the right). I want to make a plugin to add/change some information on that line without making a new skin. (first need is to add last login information) template_container hook seems to be just fine for that but unfortunately, this container doesn't exist in that call. Could it be possible to add that container to this hook ? Actually, I'm playing with template_object_username to change this part of the topline because it is not called anywhere else in larry skin, but I think this can broke other plugins or skins. regards, -- Sébastien BLAISOT

3 6

html autolink
by Sébastien BLAISOT 10 Nov '12

10 Nov '12

Hi all, When composing an HTML message with roundcube and writing an URL in the message body, it seems that this URL is not converted to link (i.e. it is not clickable) neither when composing the message nor when further viewing the sent message. It would be cool, IMHO, that roundcube can at least convert URL to link in one of this two situations. (so that users sending mail from roundcube to another roundcube user can juste copy/paste URLs when sending and just click the URL when receiving) The easy way is to enable the autolink plugin of tinyMCE (maybe with a configurable option like spelcheck). It is also possible to add some code to automatically convert URL to links when displaying HTML messages as it is done on plain text messages but I don't like this one as if HTML message contain a text which is not a link, this means that the sender don't want it to be a link. thunderbird act the first way (detecting URL and making them a link when sending) What do you think of that ? regards, S.B.

1 0

Plugins, Versioning - How does it work?
by till 10 Nov '12

10 Nov '12

Hello RoundCube-devs! To update everyone — we've been testing the setup for the plugin repository with a few people and since Sébastien emailed me with a couple questions, I wanted to take it on-list to inform more people. On Thursday, November 8, 2012 at 6:23 PM, sebastien BLAISOT wrote: > On Thursday, November 8, 2012 at 12:24 AM, Sébastien BLAISOT wrote: > > > Le 07/11/2012 14:20, till a écrit : > > > > > Hey, > > > > > > sounds good — please head over to http://plugins.roundcube.net, sign up and submit your plugin. > > > > > > It's a little rough around the edges, but should work. > > > > > > Thanks for helping! > > > > > > Hi, > > > > I've created an account but need some extra explanations before > > submiting the plugin. > > How is this plugin repository supposed to work ? does it pull the last > > version/revision of trunk ? or can I choose a particular revision ? > A plugin is essentially powered by the `composer.json` file. And this is how composer works (in a nutshell): * it takes the URL of the repository (git, svn, hg) * it scans all tags and branches (e.g. trunk/master) for `composer.json` files * it will use all tags/branches where it finds a `composer.json` file E.g. (for SVN): trunk/composer.json branches/super-feature/composer.json tags/1.0.0/composer.json tags/0.9.0/<no composer.json> The plugin repository would detect: * dev-trunk * dev-super-feature * 1.0.0 So once a `composer.json` is in trunk, it should get copied with each branch you create from trunk or each time you create a tag. This process works for git or hg as well. > > Will it be automatically updated everytime a commit is made ? Our current setup is that the cronjobs to update the site are run every 10 minutes. We can crank that up when required. When the cronjob runs, we scan your repository (see above). Why are all commits "used"? Because a commit is arbitrary and can mean all of the following: * updates to a file in trunk * creating a release (aka tag) * creating a branch > > This is a bit confusing for me right now and I don't want to make a mistake. > > My need is to control the release of future versions and not having each > > commit automatically pushed to users as they are not fully tested at the > > time of the commit. > You want your users to use tags and not a trunk/master branch — then not every commit will end up with the user. Let's say, in my local copy of RoundCube, I add the following to my (!) `composer.json`: "require": { "sebastien/plugin": "1.0.0" } This ensures that I stay on 1.0.0. This assumes that you wouldn't change the tag of course. ;-) With sane versioning and backward compatibility this shouldn't be an issue. E.g. I personally assume that a point release does not break everything or will require me to do changes that require more changes. So keeping this in mind, I could do something like: "require": { "sebastien/plugin": "1.0.*" } The above allows me to stay up to date with e.g. bug fixes. If I feel more "bleeding edge", I could rely on a branch (e.g. trunk) as well. But that's up to me/the user. On top of this, the user's composer uses a `composer.lock` file as well. This lock ensures what is installed: http://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file So once I `./composer.phar install`'ed a certain version from trunk, the lock ensures I get the same revision every time. The `composer.lock` is only updated when I `./composer.phar update`. > > Perhaps do I need to make a particular branch dedicated to releases ? Or > > can it be base on tagged revisions ? > Yes sir — you can actually do both. I personally prefer tags because it's fixed/done — a branch is always a moving target for me. > > > > Oh, and I'm using svn as source versionning system, not github. is this > > an issue ? > So, I personally prefer any kind of git. But composer also supports hg (Mercurial) and Subversion. > > > > Can you please explain it a bit ? > I hope I did with this email! :) Till

2 5

Update 0.8.3 released
by Thomas Bruederli 10 Nov '12

10 Nov '12

Dear subscribers Today we can announce another service release of the Roundcube webmail package. This update adds small bug fixes and improvements to the 0.8 stable series. It also fixes a possible, although unintended, DoS to the webserver running Roundcube. See http://trac.roundcube.net/wiki/Changelogfor details. We consider it stable and we recommend to update all existing Roundcube installation with this release. Download it from http://roundcube.net/download Have a nice weekend! Thomas

1 0

Line length for body wrapping
by Michael Heydekamp 10 Nov '12

10 Nov '12

Please apologize this possible silly question, but I'm not a PHP developer. In sendmail.inc, I see the following statement: > // set line length for body wrapping > $LINE_LENGTH = $RCMAIL->config->get('line_length', 72); Do I understand it correctly that RC first reads the setting "$rcmail_config['line_length']" in main.inc.php (which we have set to 76), and only if it does not exist, it will use a default value of 72? If so, that's good. And does this statement apply to un-quoted lines only (and only if format_flowed = false), or to both un-quoted and quoted lines? I just need to know which behaviour for un-quoted and quoted lines is the deliberate one, before I'm creating a senseless ticket in the bugtracker. Regards, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 1

How can I modify my default sender e-mail address?
by Holló Zoltán 10 Nov '12

10 Nov '12

Dear Roundcube Developers, Administrators, I have installed a roundcube webmail to my website: http://hollozoltan.extra.hu/roundcubemail/ But my webmail client use this e-mail address:no-reply@hollozoltan.extra.hu instead of my default e-mail address:hollozoltan@extra.hu In which configuration file can I modify these settings? I will look forward to hearing from you: Yours Faithfully, Zoltan Hollo

2 1

Re: [RCD] dev Digest, Vol 65, Issue 8
by Shane Kamar 09 Nov '12

09 Nov '12

STOP Sent from my iPhone On Nov 9, 2012, at 5:00 AM, dev-request(a)lists.roundcube.net wrote: > Send dev mailing list submissions to > dev(a)lists.roundcube.net > > To subscribe or unsubscribe via the World Wide Web, visit > http://lists.roundcube.net/mailman/listinfo/dev > or, via email, send a message with subject or body 'help' to > dev-request(a)lists.roundcube.net > > You can reach the person managing the list at > dev-owner(a)lists.roundcube.net > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of dev digest..." > > > Today's Topics: > > 1. Re: Issue with listen events in 0.9-git? (Cor Bosman) > 2. Password plugin (Julian Matz) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Thu, 8 Nov 2012 23:39:02 +0100 > From: Cor Bosman <cor(a)xs4all.nl> > To: Roundcube Development discussion mailing list > <dev(a)lists.roundcube.net> > Subject: Re: [RCD] Issue with listen events in 0.9-git? > Message-ID: <9ED298BB-54B1-483E-A474-EE28902EC3D8(a)xs4all.nl> > Content-Type: text/plain; charset=iso-8859-1 > > > On Nov 8, 2012, at 11:14 PM, Michael Heydekamp <listuser(a)freexp.de> wrote: > >> The attached plugin keyboard_shortcuts v2.0 doesn't work anymore with RC >> 0.9-git and IE8. It does work flawlessly with RC 0.8.2 and IE8, though. >> >> So the question is: Has there been any significant change in 0.9-git with >> regards to listen events which may make this plugin inoperative? >> >> I did already contact Cor Bosman who removed some Javascript debug code and >> released v2.0.2 (see also attached). This partially solved the problem, but >> I'm still running into situations where certain keys (especially the help >> "?" key) don't work from time to time. >> >> So we're somewhat stuck at this stage. As even keyboard_shortcuts v2.0 >> (WITH the debug code) works with RC 0.8.2 and IE8, it more seems to be an RC >> issue rather than a plugin issue. Probably in combination with a browser >> issue. > > The debug code was merely a console.log which for some reason doesnt work anymore in 0.9. This may affect other plugins/code as well. > > Cor > > > > ------------------------------ > > Message: 2 > Date: Fri, 09 Nov 2012 05:44:05 +0000 > From: Julian Matz <julianmatz(a)netlink.ie> > To: dev(a)lists.roundcube.net > Subject: [RCD] Password plugin > Message-ID: <509C9825.8010802(a)netlink.ie> > Content-Type: text/plain; charset=ISO-8859-1 > > Hello! > > I have some ideas for the RC Password plugin. I think I've come up with > an effective way to make the plugin work with multiple servers / IMAP > hosts. It would work by loading host specific config files, if they > exist; if they don't exist, the plugin would simply fall back to the > default config.inc.php configuration file. > > I also have an updated cPanel driver file for this plugin. It uses the > cPanel XML API2, which makes it possible to perform the password changes > as the WHM root user or a reseller, using the user's remote access hash. > > I wanted to ask if there would be any interest for this in the RC > community. If so, I can create some pull requests on GitHub. > > Thanks, > Julian > > > ------------------------------ > > _______________________________________________ > List info: http://lists.roundcube.net/dev/ > > > End of dev Digest, Vol 65, Issue 8 > **********************************

1 0

Why does RC remove leading blanks when displaying quoted lines?
by Michael Heydekamp 09 Nov '12

09 Nov '12

Due to some reason RC does remove leading blanks when displaying quoted lines such as: Reply-To: theo(a)test.de, Roundcube Users mailing list <users(a)lists.roundcube.net> > Reply-To: theo(a)test.de, > Roundcube Users mailing list <users(a)lists.roundcube.net> The blanks are there, they're just not displayed. That's a bit annoying especially when plain text tables are quoted: Version RC 0.8.2 RC 09-git ------------------------------ yes no no yes > Version RC 0.8.2 RC 09-git > ------------------------------ > yes no > no yes See? Can this be avoided? Regards, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 5

translations
by Cor Bosman 09 Nov '12

09 Nov '12

Hi all, I noticed an untranslated string and wondered why I couldn't find it in launchpad. Then I noticed why: ./skins/larry/templates/about.html:<h3><roundcube:label name="installedplugins" en_US="Installed plugins" /></h3> I personally think adding a translation as a parameter is bad practice. It causes you to forget that this code needs translations. Cor

2 1

Password plugin
by Julian Matz 09 Nov '12

09 Nov '12

Hello! I have some ideas for the RC Password plugin. I think I've come up with an effective way to make the plugin work with multiple servers / IMAP hosts. It would work by loading host specific config files, if they exist; if they don't exist, the plugin would simply fall back to the default config.inc.php configuration file. I also have an updated cPanel driver file for this plugin. It uses the cPanel XML API2, which makes it possible to perform the password changes as the WHM root user or a reseller, using the user's remote access hash. I wanted to ask if there would be any interest for this in the RC community. If so, I can create some pull requests on GitHub. Thanks, Julian

1 0

How to add a listicon from a plugin
by Mark Moses 07 Nov '12

07 Nov '12

Hi all, I use an old plugin ( pf_alias) and I'd like to alter it to fit nicely into the new larry skin. I don't know however if it's possible to add a list-icon from a plugin. I checked the managesieve plugin ( although that one places an icon in the settings pane and not in the section pane) but it seems that one uses an icon outside it's own plugin directory ( one from listicons.png) Can anyone tell me if it's possible to add a custom icon from a plugin into the settings>section-pane without altering anything else but the plugin code? screenshot to clarify more: The plugin item doesn't have an icon BR, Mark

2 2

Option "Display attached images below the message" is broken in 0.9-git
by Michael Heydekamp 07 Nov '12

07 Nov '12

See subject. Please fix. :-) (Browser: IE8) -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

3 8

LDAP Addressbook Installation Problem with rcabook-setup.sh
by Andreas Lehr 03 Nov '12

03 Nov '12

Hi there, i tried installing the Roundcube LDAP Addressbook following the howto posted overe here: http://trac.roundcube.net/wiki/Howto_Ldap The ldap installation is working fine, but the rcabook-setup.sh script is returning an error and the configuration breaks: -create addressbook base directory: ou=rcabook,dc=localhost (as LDAP administator: cn=admin,dc=localhost) adding new entry "ou=rcabook,dc=localhost" -create the addressbook user: cn=rcuser,ou=rcabook,dc=localhost (as LDAP administator: cn=admin,dc=localhost) adding new entry "cn=rcuser,ou=rcabook,dc=localhost" -create subdirectory for public contacts: ou=public,ou=rcabook,dc=localhost (as Roundcube user: cn=rcuser,ou=rcabook,dc=localhost) adding new entry "ou=public,ou=rcabook,dc=localhost" ERROR-unable to create subdirectory! Can anybody assist? whats the problem here? Server is running debian testing with slapd 2.4.31 Thank you very much!

2 2

package.xml
by Cor Bosman 29 Oct '12

29 Oct '12

hey all, just wondering how people are creating the package.xml. Is there a method to auto-create it from source dir? Cor

3 2

PDO-based DB layer
by A.L.E.C 29 Oct '12

29 Oct '12

I've finished the new DB layer for Roundcube based on PHP PDO. It uses less memory (1.2 MB less) and should be faster than our old solution. The main differences: uses PDO modules, no prepared statements. Please, get 'pdo' branch and give it a try, so we could use this in 0.9. -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

4 5

CAUTION: MDB2 update breaks roundcube
by Reindl Harald 28 Oct '12

28 Oct '12

https://pear.php.net/bugs/bug.php?id=19677 -Status: Feedback +Status: Bogus The version of Roundcube does matter. The 0.8.2 release was improperly using the isError() method. There are two $this->db_handle->isError() calls in ./program/include/rcube_mdb2.php. That has been removed in master. Please open a ticket with Roundcube to get them to change the calls to MDB2::isError().

1 0

ServerError with php 5.4.8 rc 0.8.2
by Aleksandar Lazic 27 Oct '12

27 Oct '12

Hi, today I had some Server Errors. PHP: 5.4.8 Server API: FPM/FastCGI Build: './configure' '--prefix=/home/phpapps/installed/php5.4' '--enable-fpm' '--with-fpm-user=phpapps' '--with-fpm-group=phpapps' '--with-openssl' '--with-zlib' '--with-gd' '--enable-exif' '--with-jpeg-dir' '--with-png-dir' '--with-mysql=mysqlnd' '--with-mysqli=mysqlnd' '--with-pdo-mysql=mysqlnd' '--with-iconv-dir' '--enable-mbstring' '--enable-intl' '--with-mcrypt' '--with-imap' '--with-imap-ssl' '--with-kerberos' '--with-pspell' '--enable-ftp' '--with-freetype-dir' '--enable-zip' '--with-bz2' '--with-curl' '--enable-soap' '--with-tidy' xdebug trace http://download.none.at/php-5.4.8_rc-0.8.2_02.txt What could this be? Best regards Aleks

4 9

CardDAV plugin
by Rosali 27 Oct '12

27 Oct '12

Hi all, I'm coding a CardDAV plugin based on https://github.com/graviox/Roundcube-CardDAV. I'd like to ask all Roundcuber's for test accounts ... - Davical - Radical ... or whatever DAV-Protocol based servers are out there. Send me details for test accounts (url/user/pass) to myroundcube at mail4us dot net. Thanks, Rosali

1 0

Re: [RCD] Plugin Repo
by Thomas Bruederli 25 Oct '12

25 Oct '12

I'm taking this to the dev list again since the conversation became more general and interesting for all. till wrote: > On Thursday, October 25, 2012 at 6:59 PM, Thomas Bruederli wrote: > >> till wrote: >>> >>> On Thursday, October 25, 2012 at 11:00 AM, Thomas Bruederli wrote: >>> >>>> Cor Bosman wrote: >>>>> One thing that i find a little disappointing about this packagist/composer combo is that it really just is a bookmark list. Users have to actually move to github or google to fetch the plugin. >>>> >>>> That's true but on the other hand it encourages people to publish their >>>> stuff on github which clearly has it's advantages. >>> >>> Hey guys – there is a major confusion! ;-) >>> >>> What you do is this: >>> >>> Use the `composer.json` file in roundcubemail (currently available in master only), and add this to repositories: >>> >>> "repositories": [{ >>> "type": "composer", >>> "url": "http://plugins.roundcube.net/" >>> }] >>> >>> Then it require — something like >>> >>> "cor/message_highlighter" >>> >>> ./composer.phar install — and it's installed. >> >> I was now playing around with the composer scripts and tried to figure out >> a proper way how Roundcube plugins can actually be installed using >> composer. Here are some issue I came across: >> >> * one has to add the plugins wished to be installed to the required section >> of the composer.json file from the local Roundcube installation. That means >> one has to alter a file which is actually distributed with Roundcube. A >> possible solution could be to ship Roundcube with a file named >> composer.json.dist which one has to copy to a local copy named >> composer.json which can then be managed through composer. > > The .dist is a good idea. >> >> * Then all the components are installed into the "vendor" directory and not >> to plugins/. I already stitched together some scripts which hook into >> composer's "post-package-install" and "post-package-uninstall" hooks and >> then create or remove a symlink to the installed packaged within the >> plugins directory of Roundcube. They could even add or remove the >> particular entry to the plugins property in config/main.inc.php. > > Another idea would be this: > > We add a `"type": "roundcube-plugin"` and a custom installer to install somewhere else. > > Then all the plugin authors need to do is set this type and require the plugin installer. > > This wouldn't require post-install-cmd for every plugin — just a simple type. Sounds good. What would it take to create such a customer installer? And how would it be shipped? >> * The required PEAR packages are also installed into "vendor" while they're >> actually shipped with Roundcube itself. I suggest to remove them entirely >> from the composer.json file and only handle plugins there. > > I would rather not check them into GIT anymore. > > If you run from a git clone, you would `./composer.phar install` first and get everything installed. That would only work for people who have PHP 5.3 with composer and who have shell access. > > Or you would download a complete release which includes all the dependencies. I guess we still have to provide that for all the users who install Roundcube through FTP on a shared hosting or whatever. > > To create such a release, we would just `composer.phar install` before we zip/tar it up? That's actually a good plan. However, it happens that Roundcube ships with modified PEAR packages which are not yet publicly available. But I guess for such cases we can put these modified libs into a separate repository which is again referenced through the composer.json.dist file. >> >> * If plugins require further components or libraries though their >> composer.json file, they'll also be installed into the local vendor >> directory but Roundcube might fail to load them. Therefore the Roundcube >> core would have to use the autoloading scripts installed by composer. >> That's something I still have to implement and test. > > if (file_exists("vendor/autoload.php")) { > require "vendor/autoload.php"; > } That's what I had in mind, yes. >> The goal was to first evaluate whether composer would be a good base for >> Roundcube's plugin repository. While it seems to be OK for publishing >> plugins, their installation seems to be a bit tricky and limited to systems >> running PHP 5.3 because of composer's requirements and heavy use of namespaces. > > In all honesty — PHP 5.3 has been out for forever. 5.2 EOL'd 2 years ago: > http://www.php.net/archive/2010.php#id2010-12-16-1 > > Even Debian has 5.3 nowadays. ;-)) > > But yeah — this would come with the requirement for 5.3. But I don't think this will be a huge issue, unless we make it one. I guess we had that conversation recently in the list and some people still objected against dropping PHP 5.2 support. ~Thomas

2 3

bug in rc 0.8.x with php 5.4.x
by Benny Pedersen 25 Oct '12

25 Oct '12

date is displayed empty rc 0.7.1 still works with php 5.4.x can others confirm ?

4 5

New look of compose and message screens
by A.L.E.C 24 Oct '12

24 Oct '12

In last few changes I improved message display screen. So, now it looks the same as the preview frame. I think this way the UI looks more clean and unified. I hope you agree with me. This also matches the look of other tasks e.g. addressbook where white color is used for the whole contact information frame/box. Because I was never happy with that how mail compose screen looks like, the idea came to make the same with compose screen. I started to work on this. See attached screenshot. The main reason of this change is a unification, but it will fix some issues on compose screen. E.g. the whole compose box will be scrollable so there will be no problems with too small screen height (even with displayed all headers and options). Opinions? -- Aleksander 'A.L.E.C' Machniak LAN Management System Developer [http://lms.org.pl] Roundcube Webmail Developer [http://roundcube.net] --------------------------------------------------- PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl

16 27

[RFC] Plugin Repo
by till 24 Oct '12

24 Oct '12

Hey, I am working on the plugin repo – would anyone like to test with me? This is what I need: 1) Your repository to a plugin 2) The plugin must contain a composer.json file Example file (bare minimum): { "name": "yourprefix/name-of-the-plugin", "description": "What your plugin does", "license": "identifier" } http://getcomposer.org/doc/04-schema.md#license Please send some examples. :) Till

1 0

Plugin repository - with Composer?
by Thomas Bruederli 22 Oct '12

22 Oct '12

Hello folks Sadly, our attempts to set up a central repository for plugin failed so far. Till once started with the idea to install a PEAR channel and to use PEAR-style package descriptions to define dependencies but that project stuck a while ago. I'd like to ask again for volunteers to help us creating a plugin repository for Roundcube. There's a new star shining on the PHP packaging sky named Composer [1] and I was wondering if some of you already made some experiences with it. It seems like a light-weighted and easy-to-use system to define packages and dependencies including version checks. And there's the Packagist project [2] which exactly does what I have in mind as a plugin repository and which could be forked to tweaked for our needs. So if anybody is willing to create a prototype repository which could serve the Roundcube plugins, you'd make us and the entire community very happy. Any feedback in Composer vs. PEAR or general suggestions for the plugin repository are welcome! Best, Thomas [1] http://getcomposer.org [2] https://packagist.org

4 11

Embed images into message source
by Rosali 22 Oct '12

22 Oct '12

Hi all, If users embed image tags ... <img src="C:\xampp\htdocs\webmail\svn\temp/c98c8314b84edc17eca1dd4b3467f693.png" alt="" /> ... into HTML messages these images will be blocked by Roundcube and most other email clients by default (that's fine due to privacy reasons). I have coded a plugin to embed images into the email source (inspired by sendmail.inc :: rcmail_fix_emoticon_paths). So far, so good. If you take the time to check the plugin, you'll see, that I have the image source in embed_images :: message_outgoing_body :: line 134 ($content). Currently the image is save in Roundcube's temp_dir folder. I'm not happy with this step because basically this step is redundant. I have analized Roundcube's mime class (./program/lib/Mail/mime.php). The method addHTMLImage allows to add content from $content (see third param $isfile). When trying this, the image is correctly created as a message part. The problem I have at this step is, that cid url replacement results in a mess. I have played with: #1 - 4th param content id #2 - replace the image tag by an placeholder and create the tag again by <img src="cid: ... content_id ... @domain part of sender ... no sucess! Image urls results in a mess. Either I'm too dumb or there is a bug anywhere. Any advice is highly appreciated. Regards, Rosali

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev