- Dev - Roundcube mailing lists

Re: [RCD] [PATCH] Theaded view mode
by Eric Appelt 31 Aug '09

31 Aug '09

Hi Vladislav and all lurkers, I have found the Bug !!!!!!! in rcube_imap.php private function _list_headers if ($this->sort_field != 'default' && $this->get_capability('sort') && ($msg_index = iil_C_Sort($this->conn, $mailbox, $this->sort_field, $this->skip_deleted ? 'UNDELETED' : ''))) { // nothing more to do } else { $a_index = iil_C_FetchHeaderIndex($this->conn, $mailbox, "1:*", ($this->sort_field == 'default') ? '' : $this->sort_field, $this->skip_deleted); if (empty($a_index)) return array(); asort($a_index); // ASC $msg_index = array_keys($a_index); } remove the line asort($a_index); // ASC after this will works fine. I think the Problem are the sorting of the new in messagelist pushed messages !! I have long time testet and debug and now i think thats the solution. best Eric _______________________________________________ List info: http://lists.roundcube.net/dev/

3 2

Re: [RCD] [PATCH] Theaded view mode
by Eric Appelt 30 Aug '09

30 Aug '09

Hi Chris and Vladislav thx for your work show the attached image ... The green and yellow Messages are the same after deleting 4 Messages When i delete 4 Messages and the next 4 loads in the message list the 4 reloaded Messages are exists already in the message list the already exists Messages can't select or click this issue comes from threading patch testet with my patched installation clean RC0.3 snapshot and the snapshot from atomice.com this issue is only by the versions with threading it threading display enabled or disabled or preview is enabled or disabled is all the same after deleting some messages to four times some messages shows twice in messagelist i have testet with some browsers IE Firefox Opera and chrome on Windows XP and Gentoo and i have testet with an courier, cyrus and exim by all installations i have this issue with threading. I hope you find a solution Thx Lacri --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/jY/gdVQUrR4/threaded_bug.jpg Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

4 8

[PATCH] Set the port used for HTTPS connections
by Lex Brugman 30 Aug '09

30 Aug '09

Hi, I was just installing roundcube and noticed the force_https option, after enabling it I observed it was always assuming that the HTTPS port used is the default tcp port 443. My server has only one public ip address which forces me to use several 'custom' HTTPS ports, so this asked for an option to specify the HTTPS port used on the server, I've quickly implemented it and created a patch (see attachment) for the 0.3RC1 release. Maybe you would like to include this patch in future versions, or not :), it's up to you, just thought I should share this. Gr, Lex --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/bB/KQ9wWuRP/https_port.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Remote IMAP Accounts Plugin
by Roland Liebl 30 Aug '09

30 Aug '09

Hi all, I just "finished" an alpha release of a plugin to manage remote IMAP accounts. Please review! Notice: It depends on my "settings" plugin (http://myroundcube.googlecode.com). Regards, Roland --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/dx/5hUf1ma7/accounts.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] [Svn] r2851
by Eric Appelt 30 Aug '09

30 Aug '09

Hi Thomas and Vladislav, i have in my RC the quotadisplay moved in bottom of folderlist i think this is perfekt i have enough space in the footer for thread, folder and message list command links. i send yours an E-Mail with login Data to see my solution, @Vladislav you can see and test with the login data the threading problem with showing messages twice after delete. best Eric --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/1W/9F3ak858/vcard.vcf Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Updated Italian translation
by Uno 29 Aug '09

29 Aug '09

Updated Italian translation. -- Stefano --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/jE/t5QtWEfW/messages.inc http://detached.gigo.com/rc/jE/t5QtWEfW/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] [PATCH] Theaded view mode
by Eric Appelt 27 Aug '09

27 Aug '09

Hi Vladislav, i think this is independently from thread or thread leading messages i have the same bug when threading is disabled and the bug is only in the with threads patched RC not in the standard RC. And when because of this then the bug would not be sporadic. one two times is all ok and then sporadic comes the bug and messages shows twice. I have spend mass time on this and I do not find the reason or solution. best Eric _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

IMAP APPEND fails on Quota Exceeded
by Robin Elfrink 27 Aug '09

27 Aug '09

Hi, (bug dropped in my mailbox) After sending an e-mail RoundCube attempts to append the e-mail to the Sent folder. RoundCube (actually, the Iloha library) does not handle the response to the APPEND command correctly, resulting in a properly sent e-mail, and a client timing out. Example conversation: > a APPEND "Drafts" (\Seen) {555145} < a NO [OVERQUOTA] Quota exceeded (mailbox for user is full) RoundCube reads the response line but doesn't parse it. Attached patch at least fixes the not-parsing-and-client-hanging part, logging the actual response line to the error log. But a proper error message to the user would be better. Does anybody have any idea if IMAP errors are standardized, and if so, how would I get the message from program/lib/imap.inc back to program/steps/mail/sendmail.inc, to show the user a proper message? Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/7d/tCH2Il93/imap-append-error-ha.diff Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

updated lithuanian translation
by eg＠fbsd.lt 24 Aug '09

24 Aug '09

Hi, I made an update for Lithuanian translation. Edmondas --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/b7/By8tONnB/labels.inc http://detached.gigo.com/rc/b7/By8tONnB/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

[PATCH] Theaded view mode
by Vladislav Bogdanov 22 Aug '09

22 Aug '09

Hi, I'm just subscribed, so first thanks to all devs for all efforts on making RC really great. I noticed that threaded view support is planned for 0.4-beta1, so I attach a reworked patch for a threaded mailbox view mode. It is not fully perfect, but is a good (re)starting point for that anyway. Changes comparing to roundcubemail-threading-20090706.patch from http://www.atomice.com/blog/?page_id=34: 1. Ported to 0.3-SVN-r2863 2. Implemented auto expand of threads with unread messages only. 3. Added GUI configuration option for autoexpand control (on, off, unread). 4. Autoexpansion works in both static and JS message lists. 5. Automatically change between 'unread children' and message icons in a list (in parent message rows) when child message is marked read/unread. 6. Count messages, not threads in a message view pane. 7. Fixed navigation in a message view pane when threading is enabled. 8. Fixed setting folders with non-ASCII named to threaded mode. 9. Fixed incorrectly displayed rows (children of collapsed row) after multi-level expand/collapse. Simplified expand logic. 10. Fixed expand indicator is not changing when expanding/collapsing with keyboard. 11. Fixed plus key on a numeric keypad is not working (at least on linux Fedora 11 + Firefox 3.5.2). 12. Added support for whole thread expand/collapse with clicking/pressing hotkeys while holding the Control key. 13. Save expand state in env everywhere (after keypresses too). 14. Added russian translation. 15. Fixed indentation and braces style in JS to comply with RC coding style. Known issues: 1. Messages from a threaded folder are sorted not in a thread-aware order but rather in a natural order when browsing with GUI controls at the bottom of a message view pane. This is probably a minor issue because it is more convenient anyway to browse through threaded discussions with a preview pane enabled. Maybe we need to explicitly enable a preview pane for a threaded folders. 2. Last selected message is neither focused nor centered in a list when returning to a list from a message view pane. I think it is minor issue too. This patch (and original one too) is sometimes too intrusive, so it needs to be checked at least twice just not to break things. Thanks for your time, comments are welcome. Best, Vladislav --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/X6/LiAx90cn/roundcubemail-SVN-28.patch http://detached.gigo.com/rc/X6/LiAx90cn/unread_children.png Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

An updated Hebrew translation
by Moish 19 Aug '09

19 Aug '09

-- Moish --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/RJ/6AfXTAfM/messages.inc http://detached.gigo.com/rc/RJ/6AfXTAfM/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

plugins updated slovenian translation
by Barbara Krasovec 18 Aug '09

18 Aug '09

Hello! I'm sending the updated slovenian translation of managesieve and password plugins. I named the files incorrectly the last time, si.SI instead of sl.SI. Please delete those files and commit the ones in the attachment. Thanks. Barbara --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/FU/3GKw654x/managesieve_passwd_s.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Forward as Attachment Plugin
by Roland Liebl 15 Aug '09

15 Aug '09

Hi all, before I release my __forward_as_attachment__ plugin any code review is appreciated! Sandro, thanks again for the images. Regards, Roland --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/a3/u3MrjBJm/forward_as_attachmen.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Password plugin
by Andrea Cappelli 14 Aug '09

14 Aug '09

Hi all I have configured the password plugin and I have created the file it_IT.inc under localization, you can find it attached if you want to include it in the main distribution I have a problem, after i change the password i get the green box with the success message, but also another message with a "SERVICE NOT AVAILABLE" error with code 500, in the middle of the page. Seems to me that the IMAP server is refusing the connection, and the only thing that can be broken is the password, so i suppose the error is in the password update in $_SESSION, but i couldn't make it work For me the solution is to add the line header("Location: index.php?_task=logout"); in password.php, on line 96, that force the user to re autenticate, but this is very dirty in my opinion Can anyone point me to a solution or give me some tip to accomplish the task? Thanks --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/YD/TiwiIPYm/it_IT.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 4

Images for "Forward as Attachment" Plugin
by Roland Liebl 14 Aug '09

14 Aug '09

Hello, can someone help to get suitable icons for a "forward as attachment" plugin. The icons (_act.png, _pas.png) should look like the default forward icon overlapped by a small clip. Many thanks to any volunteer! Roland _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

Pending hook requests
by Roland Liebl 14 Aug '09

14 Aug '09

Hello Thomas, it would be great if you could catch the time to add the following pending hook requests: #1- logout_hook http://trac.roundcube.net/ticket/1486042 [1] #2- new_message http://trac.roundcube.net/ticket/1486005 [2] #3- html_editor http://lists.roundcube.net/mail-archive/dev/2009-08/0000081.html [3] If you accept hook request #3 it would be great to have a patch for rcube_html_page.php ::: include_script. to make it possible to change the script_path (default ./program/js) to something else. The reason is, that I have to include an alternative editor.js file by my TinyMCE plugin (coding in progress). But if I use $rcmail->api->output->include_script the file is included to late and I get javascript errors. Many thanks and best regards, Roland Links: ------ [1] http://trac.roundcube.net/ticket/1486042 [2] http://trac.roundcube.net/ticket/1486005 [3] http://lists.roundcube.net/mail-archive/dev/2009-08/0000081.html _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Response to holding the delete key in the message list
by None 13 Aug '09

13 Aug '09

Hello, The following pertains only to message deleting with the config option 'display_next' set to true. When I hold the delete/backspace key down with a message selected for a couple seconds and messages are loaded from the next page, some will come back more than once. For example, say this is my message list: uid = 1 uid = 2 uid = 3 uid = 4 uid = 5 ... now if i delete the first three by holding the delete key down for a second, my message list might look like this: uid = 4 uid = 5 uid = 6 uid = 6 uid = 7 This also brings up the question as to how fast messages should be deleted while holding the delete or backspace key down, in my tests it must be 15-25 messages per second which is quicker than my reflexes are able to accurately stop deleting at a certain point. What do you guys think? Would it be best to set a timer so we can only delete 'x message per second' or maybe wait until the previous message has been deleted and the new message has come from the next page before deleting another?... Thanks! Ryan Ostrander _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

php 5.2.9 and Fileinfo
by jgeertsma＠home.nl 12 Aug '09

12 Aug '09

ok I Upped my system with PHP 5.2.9. But now I have issues with Fileinfo. Yes may it should be asked at Centos etc I know, but maybe users here can help me faster.php -v PHP Warning: PHP Startup: fileinfo: Unable to initialize module Module compiled with module API=20050922, debug=0, thread-safety=0 PHP compiled with module API=20060613, debug=0, thread-safety=0 These options need to match in Unknown on line 0 PHP 5.2.9 (cli) (built: Mar 10 2009 16:42:52) Copyright (c) 1997-2009 The PHP Group Zend Engine v2.2.0, Copyright (c) 1998-2009 Zend Technologies For now I removed the Fileinfo package. What is done with this package by RoundCube?And most important...how can I fix this issue?Thanks! _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

patches
by Terminal Addict 11 Aug '09

11 Aug '09

search.inc.patch is for program/steps/addressbook/search.inc This patch is a workaround for what appears to be a PHP bug that prevents the setting of multi-dimension associative arrays in $_SESSION (more specifically, the value of $_SESSION['search'][$search_request]). The bug causes issues with multiple LDAP searches, and "Contact not found" error messages. rcube_ldap.php.patch is for program/include/rcube_ldap.php This patch allows the user to specify multiple base DN values for searching. It will not affect users that only have a 'base_dn' value specified. With this patch, the main.inc.php file can include 'search_base_dn' => array() in an LDAP configuration. This can be helpful for people dealing with a poorly implemented LDAP structure. This patch also returns empty results for searches conducted with only the default filter (as is done when the LDAP address book is first selected). These essentially empty searches will return inconsistent results anyway. Finally, this patch will check for both case-sensitive and all lowercase fieldmap values to ensure consistent results are displayed in search lists and contact details. Both patches were made against 0.3 RC1. Kyle --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/PB/tUxKCfdd/search.inc.patch http://detached.gigo.com/rc/PB/tUxKCfdd/rcube_ldap.php.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Configurable TinyMCE Toolbar
by Roland Liebl 11 Aug '09

11 Aug '09

Hi devs, I'm working on a plugin which allows the Admin to configure the TinyMCE toolbar without hacking in editor.js. It also allows to enable/disable features domain/user based. The reasons why I need this plugin are: #1 Editor width is too large when RoundCube is embedded in frameset. #2 I'd like to restrict some features (media, spellchecker) domein/user based I don't get it working without patching two files: #1 ,/program/include/main.inc ... see function rcube_html_editor #2 ./porgram/js/editor.js ... see function rcmail_editor_init Attached files are based on trunk r2852. Hope you will commit them to trunk. Regards, Roland --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/4C/jhUOCkvG/program.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 3

Re: [RCD] Error in SMTP over SSL
by Julien Vehent 10 Aug '09

10 Aug '09

On Thu, 06 Aug 2009 12:34:30 +0200, "A.L.E.C" <alec(a)alec.pl> wrote: > Julien Vehent wrote: > >> OK, so to use STARTTLS with roundcube, the postfix server must be >> configured with the option smtpd_enforce_tls = yes, right ? > > No, it is must not. As I see in the code, STARTTLS is called when > authentication > is requested (when smtp_user and smtp_pass options in Roundcube config are > set) and > (from Net_SMTP): > > version_compare(PHP_VERSION, '5.1.0', '>=') > && extension_loaded('openssl') > && isset($this->_esmtp['STARTTLS']) > && strncasecmp($this->host, 'ssl://', 6) != 0 OK, It confirms what I read in the postfix doc, that the server must not enforce STARTTLS (RFC 2487). So, I have the following roundcube configuration : ------ // use this host for sending mails. // to use SSL connection, set ssl://smtp.host.com // if left blank, the PHP mail() function is used $rcmail_config['smtp_server'] = 'ssl://localhost'; // SMTP port (default is 25; 465 for SSL) $rcmail_config['smtp_port'] = 25; // SMTP username (if required) if you use %u as the username RoundCube // will use the current username for login $rcmail_config['smtp_user'] = '%u'; // SMTP password (if required) if you use %p as the password RoundCube // will use the current user's password for login $rcmail_config['smtp_pass'] = '%p'; // SMTP AUTH type (DIGEST-MD5, CRAM-MD5, LOGIN, PLAIN or empty to use // best server supported one) $rcmail_config['smtp_auth_type'] = ''; ------ The following postfix configuration : ------ # TLS server options smtpd_use_tls = yes smtpd_tls_auth_only = yes smtpd_tls_security_level = may smtpd_tls_key_file = [keyfile] smtpd_tls_cert_file = [pemcert] smtpd_tls_CAfile = [cafile] smtpd_tls_loglevel = 2 smtpd_tls_received_header = yes smtpd_tls_session_cache_timeout = 3600s tls_random_source = dev:/dev/urandom smtpd_tls_ask_ccert = yes smtpd_tls_req_ccert = no ------ and the following trace when I try to send an email from roundcube to my gmail account : http://www.linuxwall.info/files/starttlsroundcubetrace.pcap.txt Postfix sends its banner in packet '12:43:23.225014' and then roundcube ACK it and does nothing more. It doesn't send any more data. My understanding is that roundcube should then announce itself through a 'EHLO' command, and postfix would returns its capabilities. But instead, postfix then announce that the command has not been recognized (but what command ? ack number didn't change between '12:43:23.209554' and '12:43:23.225096' so no data have been transmitted...) It's weird, and I don't know how to debug it further... The only thing I'm sure of, is that this postfix configuration works fine with thunderbird in TLS mode. Julien _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

PHP 5.1.6
by jgeertsma＠home.nl 10 Aug '09

10 Aug '09

I have CentOS 5.3 running with only BASE repo. So it runs with PHP 5.1.6. And at the moment I am not going to upgrade tp 5.2 with an other repo.Anyway, I installed RoundCube, changed check.php so it installed with 5.1.6. And so far it runs fine. Only problem I had, was the check mail/frefresh page issue. Fixed that with the RECENT / UNSEEN replacement.So why is PHP 5.2 needed? What goes wrong with 5.1.6? Thanks _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Contact groups - 3.0
by Tiago Gomes 09 Aug '09

09 Aug '09

Hi, friends I adapted the patch to group of contacts in version 3.0 and the biggest problem is to convert the changes in program/steps/mail/compose.inc as you can see in http://trac.roundcube .net/attachment/ticket/1485657/contact_groups.diff could tell me how can set these variables ? would be in autocomplete.inc? canyou help me for alter the patch ? -- ---------------------------------------------------------------- Tiago Gomes Pereira http://www.tiagogomes.eti.br LPI Certified LPI ID - LPI000129445 IT Service Management - ITIL FOUNDATION V2 ID - SR341901 algodas(a)gmail.com _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Example code for list_prefs_sections hook?
by Robert King 08 Aug '09

08 Aug '09

I'm trying to wrap my head around how the hook for list_prefs_sections works. I don't think my brain is up to the task today, so I was wondering if anyone has a small example to show? I'm assuming: ... $this->add_hook('list_prefs_sections', array($this, 'opt_block')); ... function opt_block($args) { $args['cols'] = 'optlabel'; $args['list']['optlabel'] = array( 'id' => 'optlabel', 'section' => 'Option Label'); return $args; } Digging through the program/steps/settings/func.inc I can see that list is a copy of $SECTIONS and I have no idea what cols is used for. Anyone have a quickie example? _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Updated Swedish localizations for plug-ins
by Jonas Nasholm 08 Aug '09

08 Aug '09

Hi, I’ve attached updated Swedish localizations for the following plug-ins: - help - markasjunk - new_user_dialog - subsc------ns_option - userinfo Regards, Jonas Nasholm Bitfuse Network --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/NR/T0ipnVir/plugins-sv_SE.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev