- Dev - Roundcube mailing lists

New Plugin "taskbar"
by Roland Liebl 11 Jun '09

11 Jun '09

Hi, this plugin adds a configurable taskbar to login page. It is useful if RoundCube is embedded into another web app to provide a nav out link, a link to tocs or to inject buttons to navigate into plugins from the login page, f.e. self-registration, forgot password, etc. I plan to extend the plugin to manipulate the regular taskbar to inject buttons for plugin navigation as well (f.e. nav into calendar). Nothing fancy, because all those modifications could be done by editing the skin aswell. But I like it. It makes it easy to update and it is useful for users without any coding skills to provide default hooks for future plugins. Any comments are welcome! Regards, Roland --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Qw/WQGWpIdf/taskbar.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

RoundCube Online Demo
by Roland Liebl 11 Jun '09

11 Jun '09

Hi Devs, is there any interest to have a online roundcube demo? If so, I'd be glad to host one based on recent trunk. Regards, Roland _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

expand folder on drag'n'drop
by Andre Rodier 09 Jun '09

09 Jun '09

Hello everybody, I have wanted to add a small feature to roundcube. When I drag and drop messages, I wanted to automatically expand folders when possible. * First, I have read the developments guidelines, and saw this: Indentation consists of _4 spaces_ per level and no tabs! * Second, I have opened apps.js to add the functionality, and saw a lot of tabs. I have replaced them with spaces, so, you are not obliged to accept my patch... Anyway, in this patch, I restart the drag & drop process just after expanding a collapsed folder when possible. However, to avoid any interference with current existing code, I have copied the drag_start function to a drag_restart function. I am not familiar with this JavaScript code, so, feel free to remove everything not needed into the function drag_restart. I'm sure we can also use a timeout, but I try to keep things as simple as possible for the moment. The next step, if possible, is to scroll the folders list when reaching the bottom or the top of the folders list, when dragging messages. I think it will be useful for all people who have an interminable folder's list like me... ATB. --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/9G/bPX8oCbj/apps.js.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

list_identities()
by Cor Bosman 08 Jun '09

08 Jun '09

Hi, the function list_identities() confuses me a little. The description claims it returns an array with identities (which would be what id like), but it's actually returning an sql result, which you have to pull through an sql fetch yourself. Looking through the code for the use of list_identities() all instances are indeed calling their own fetch_assoc on it. Why isnt the sql fetching done inside list_identities() so that function actually returns an array? Regards, Cor _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

message body prefetching (proof of concept)
by A.L.E.C 08 Jun '09

08 Jun '09

Attached patch is a body prefetching proof of concept. Currently to display a message at least two FETCHes are called. The first for headers and bodystructure and the second for message body. In most cases we can skip second call and fetch message body in first call adding "BODY.PEEK[1]<0.2048>" to the list. On my server I've got a negligible gain, because of very quick FETCH (dovecot 1.1) and not havy load, but I like to know how about yours. We could apply this as an option. p.s. you can increase prefetch size changing 2048 to e.g. 4096 in the patch. Currently it's hardcoded. -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/1L/8jKjt4zs/prefetch.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 1

facility to enable sending via local MTA
by Borg³ 07 Jun '09

07 Jun '09

Hi. I installed roundcube 0.2.1 today and I'm quite fond of it. Only problem I see, i can't use my local MTA (currently esmtp) to send my mails. So I decided to hack a bit around. Should be quite quick, as roundcube incorporates most of the hard work already. If there is interest in it I can provide the result as a patch against 0.2.2? If I've overlooked a feature enabling me to do it more simply (using mail() is not an option for me), I'd be grateful for a hint. With kind regards, Borg³ _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

LDAP Address Book patch.
by Andre Rodier 06 Jun '09

06 Jun '09

Hello everybody, This is a simple patch for the LDAP address book implementation, for roundcube. The patch extract first name and last name to create new entry into the address book. Some email addresses are written using the notation * First Name Last Name * Last Name, First Name This simple patch create defaults values for first name and last name, and use them when not specified, instead of using email for default first name/last name. ---------------------------------------------------------------------------- 421,437d420 < // Create a default value for first name and last name < // if the cn field contains ',' or ' ' < $defValues = array() ; < if ( strpos($newentry['cn'],',') !== false ) { < list($lastName,$firstName) = array_filter(explode(',',$newentry['cn'])); < $defValues['sn'] = trim($lastName) ; < $defValues['givenName'] = trim($firstName) ; < < # Reorder first and last name < $newentry['cn'] = "$firstName $lastName" ; < } < elseif ( strpos($newentry['cn'],' ') !== false ) { < list($firstName,$lastName) = array_filter(explode(' ',$newentry['cn'], 2)); < $defValues['sn'] = trim($lastName) ; < $defValues['givenName'] = trim($firstName) ; < } < 443,446c426 < if ( isset($defValues[$fld]) ) < $newentry[$fld] = $defValues[$fld] ; < else < $newentry[$fld] = $newentry[$this->_map_field("email")]; --- > $newentry[$fld] = $newentry[$this->_map_field("email")] ---------------------------------------------------------------------------- I hope it will be useful for somebody as it is for me. André. _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

roundcube / ldap address book...
by Andre Rodier 05 Jun '09

05 Jun '09

Hello everybody, First, many thanks for your work, it seems to be promising... I'm currently uses two versions of Roundcube on the same machine : 0.2 and the svn branch as test. Both versions uses the same config file. If it's better to have two different config files, I can. Since I have updated to the last SVN branch three days ago, something is broken into my LDAP config. The LDAP autocomplete and add address is working as usually, and the list of contact still appear into the address book page. However, when I click on a contact, I have an error message "The requested contact was not found". Here my LDAP configuration: $rcmail_config['ldap_public']['shared'] = array( 'name' => 'Red2 Shared', 'writable' => true, 'LDAP_Object_Classes' => array("top", "inetOrgPerson"), 'LDAP_rdn' => 'mail', 'sort' => 'cn', 'hosts' => array('ldap.red2.co.uk'), 'port' => 389, 'base_dn' => 'ou=addressbook,dc=red2,dc=co,dc=uk', 'bind_dn' => 'cn=Red2 Team,ou=people,dc=red2,dc=co,dc=uk', 'bind_pass' => '*****', 'ldap_version' => 3, // using LDAPv3 'search_fields' => array('cn', 'sn', 'givenName', 'mail'), // fields to search in 'required_fields' => array('cn', 'sn', 'mail'), 'name_field' => 'cn', // this field represents the contact's name 'email_field' => 'mail', // this field represents the contact's e-mail 'surname_field' => 'sn', // this field represents the contact's last name 'firstname_field' => 'givenName', // this field represents the contact's first name 'scope' => 'sub', // search mode: sub|base|list 'filter' => '(mail=*)', 'fuzzy_search' => true, 'user_specific' => false ); // server allows wildcard search Also, I'd like to add some fields into the address book. I know roundcube use an abstract base class for the address book, but the implementation seems to be very flexible. Is it possible to use this implementation to add new fields in r/w mode, like phone numbers, postal address, etc? In this case, can I modify the rcube_ldap.php file and send you a patch, or it's better to write a plugin ? Thanks again. PS for Alec : Спасибо ! André Rodier. _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

reduce network requests by consolidating icon images
by Nathan Kinkade 05 Jun '09

05 Jun '09

I've been spending a lot of time in Firebug with RoundCube the past few weeks. One thing I've noticed is that there are quite a lot of network requests to freshly load the front page. With the default theme there are around 45 separate requests for a little less than 250K. I was asking myself how to reduce the number of requests and was reminded of something interesting that I had noticed Gmail doing, and that is to consolidate many icons into a single image and then use CSS to position the image as the background of a fixed width/height block-level element. As I went to implement this, I began to realize that not only does this approach reduce the number of network requests, but it also seems to simplify the code a bit. With this method the code doesn't have to worry at all about images or file names, but becomes somewhat image-agnostic by only specifying the *type* of behavior it would like to see in a given location. How that bahavior is implemented then becomes a simple matter of CSS. Here is the consolidated image with not all but most of the usual icons: https://natha.nkinka.de/devmail/skins/default/images/icons/rc_icons.png And here are the patches to implement this: http://code.nkinka.de/gitweb?p=roundcube.git;a=commitdiff;h=84a7acd0f42e3c3… I found that doing this reduced the number of requests on a clean load of the main mailbox view from 45 to 35, which is fairly significant. It does add about 5K to the page size because it brings along a number of unneeded icons for that page. 10 less requests may not be perceptible for many people running on a fast machine with broadband Internet to a server that isn't very loaded. However, for a busy machine, perhaps an installation of RoundCube serving webmail for a university, for example, 10 less requests per fresh page load could make a noticeable difference. 10 less requests will probably also make a noticeable difference for those on a high latency connection, where 5K extra is less of a problem than 10 more network requests. I have no idea whether this is of any use or interest to anyone else, but I thought I'd share my experiment with the list. Nathan _______________________________________________ List info: http://lists.roundcube.net/dev/

7 15

Skins Location of plugins
by Roland Liebl 04 Jun '09

04 Jun '09

I send this message again, because it was sorted into a wrong thread. ----- Original Message ----- From: Roland Liebl To: dev(a)lists.roundcube.net Sent: Sunday, May 17, 2009 6:16 AM Subject: Load skins templates from plugin directory Hello Devs, the attached patch is very usefull, IMO. It loads plugin templates from the plugin folder. It is similar to what you are already doing by the localization. E.g.: $rcmail->output->send("settings.account") ... will parse the template from ./[conf:plugins_dir]/settings/skins/[conf:skin]/templates/account.html. So we could use a "Domain Prefix" for plugin templates. It would make it easier to install a plugin, because the user does not have to copy things into the main skin folder. Please let me know, if you will incorporate the patch. I'm in process to update MyRoundCube to use the new Plugin API and have to know if I can rely on this method. Regards, Roland _______________________________________________ List info: http://lists.roundcube.net/dev/

4 5

Get rid of skip_deleted
by A.L.E.C 04 Jun '09

04 Jun '09

This option causes many problems. I like to get rid of it. What you think? There are related issues here and there, and it will be hard to fix them all if we need to live with this option. Removing this option will be of course a fine performance improvement. E.g. next/prev buttons in message page are not skip_deleted aware. Fixing this will require to add SEARCH/SORT ALL UNDELETED call with result sorting. There are related issues in searching and caching: http://trac.roundcube.net/ticket/1485634 -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

SEARCH
by Sandro Pazzi 04 Jun '09

04 Jun '09

Hi all, It seems that the search don't search the email but only the object and the body. Are right or was a bug? Thanks -- Sandro Pazzi IdWeb s.r.l. Viale Romagna 69/A - 06012 Citta' di Castello (PG) Tel. 075 851 97 28 Fax 075 851 97 30 _______________________________________________ List info: http://lists.roundcube.net/dev/

4 7

Updated galician translation
by David Garabana Barro 03 Jun '09

03 Jun '09

-- David Garabana Barro jabber & google talk ID: david(a)garabana.com Clave pública PGP/GPG: http://davide.garabana.com/pgp.html --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/yM/N5TIvYXQ/labels.inc http://detached.gigo.com/rc/yM/N5TIvYXQ/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Spanish Argentina (es_AR) translation update
by Javier Smaldone 03 Jun '09

03 Jun '09

Hi. This is the updated es_AR (Español, Argentina) translation. Regards, -- Javier Smaldone javier(a)smaldone.com.ar http://www.smaldone.com.ar/ - http://blog.smaldone.com.ar --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/TH/j6pQgXwQ/labels.inc http://detached.gigo.com/rc/TH/j6pQgXwQ/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Spanish (es_ES) translation update
by Javier Smaldone 03 Jun '09

03 Jun '09

Hi. This is the updated es_ES (Español, España) translation. Regards, -- Javier Smaldone javier(a)smaldone.com.ar http://www.smaldone.com.ar/ - http://blog.smaldone.com.ar --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/WN/jGkEHmus/labels.inc http://detached.gigo.com/rc/WN/jGkEHmus/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Encoding issue, possible workaround
by Eric Stadtherr 03 Jun '09

03 Jun '09

Devs, I recently received a bulk e-mail from an event organizer that displayed in RoundCube (using Firefox 3) with the little square hex-code glyphs in place of some of the punctuation marks. I researched why this was happening, and tracked it down to an encoding issue. The text/html message part in the e-mail source specified iso-8859-1 encoding. After RoundCube converted the message part to UTF-8, there were still non-UTF8 characters in the resulting text. One such character was 0x92, which is not even a valid iso-8859-1 character. It turns out that the message originator must have been using Windows-1252 encoding (in which 0x92 is a single-quote character, which was correct in the context in which it appeared), but incorrectly specified iso-8859-1 encoding in the MIME message. The Windows-1252 character set is effectively a superset of the iso-8859-1 character set, replacing some of the seldom-used control character code points with additional punctuation and accent characters. Some mail agents incorrectly blur the line between these two encodings, and send Windows-1252 characters in iso-8859-1 messages. The following workaround (in rcube_charset_convert()) corrects the issue (at least for my one test case): // Workaround for mail agents that include Windows-1252 characters // in text advertised as ISO-8859-1 if ($from == "ISO-8859-1" && preg_match("/[\x80-\x9F]/", $str)) $from = "WINDOWS-1252"; What does everyone think of including a workaround like this? I'm generally reluctant to work around improper behavior from other software, but this particular kind of relaxed interpretation seems common (check out the ISO-8859-1 page on Wikipedia). -- Eric Stadtherr estadtherr(a)gmail.com _______________________________________________ List info: http://lists.roundcube.net/dev/

5 9

[Plugin API] request response event
by A.L.E.C 03 Jun '09

03 Jun '09

In http_response() we have: if (response.action == 'list') this.triggerEvent('listupdate', { folder:this.env.source, rowcount:this.contact_list.rowcount }); I think we should add (instead) a "global" event at the end of http_response function: this.triggerEvent('http_response', { action:response.action }); So, plugins could bind to one (http_response) event and there just check for which action it's executed. Am I right? -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

3 9

Re: [RCD] Plugin WIKI page
by Roland Liebl 02 Jun '09

02 Jun '09

----- Original Message ----- From: "Cor Bosman" <cor(a)xs4all.nl> To: "Roland Liebl" <roland(a)roland-liebl.de> Sent: Monday, June 01, 2009 9:31 AM Subject: Re: [RCD] Plugin WIKI page > Hi Roland, a tip concerning your limit recipients plugin. Check out > function imap->decode_address_list(). > You can feed it a ['header']['from'] and it will return an array of valid > recipients. Much cleaner than what you do now. > > I had to find that myself as well..unfortunately the docs dont mention > such handy functions. > > Cor > > > Thanks for the hint. Next update of limit_recipients will do the check by ... function check_recipients($args){ $rcmail = rcmail::get_instance(); $recipients = count($rcmail->imap->decode_address_list($args['headers']['To'])) + count($rcmail->imap->decode_address_list($args['headers']['Cc'])) + count($rcmail->imap->decode_address_list($args['headers']['Bcc'])); if($recipients > $rcmail->config->get('limit_recipients')){ if($rcmail->config->get('limit_recipients_log')){ $this->log("Limit Recipients: " . $recipients . " > " . $rcmail->config->get('limit_recipients') . " --> " . $_SESSION['username'] . " --> IP: " . $this->getVisitorIP()); } $this->add_texts('localization/'); $rcmail->output->command('display_message',sprintf(rcube_label('limit_recipients_msg','limit_recipients'),$rcmail->config->get('limit_recipients')),'error'); $rcmail->output->send('iframe'); } return $args; } _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

SVN 2558 Changelog
by Roland Liebl 02 Jun '09

02 Jun '09

Hi, 158 Apache: 159 ------- 160 To enable these features in apache the following modules need to be enabled: 161 * mod_compress 162 * mod_expire 163 * mod_headers I thought mod_compress is part of Lighttpd only. Isn't it mod_deflate for apache? I can't find mod_compress in my apache 2.2 installation. Regards, Roland _______________________________________________ List info: http://lists.roundcube.net/dev/

4 5

[Plugin API] few thoughts
by A.L.E.C 01 Jun '09

01 Jun '09

1. Shouldn't 'create_identity' hook be called after 'create_user' (in rcube_user::create)? 2. E.g. in rcube_user::create() we have: $data = $rcmail->plugins->exec_hook('create_user', array('user'=>$user, 'user_name'=>$user_name, 'user_email'=>$user_email)); Do you plan to add possibility to stop function execution after executing a hook inside of it? 3. In mail/compose.inc we have now in rcmail_save_attachment function: 'data' => $message->get_part_content($pid), I think attachments could and should be handled via file pointer. -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

2 4

plugin doc
by Cor Bosman 01 Jun '09

01 Jun '09

I made some changes to the plugin doc to reflect recent changes. Hope everyone is ok with them. Cor _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Loading plugin config problem
by Oliver Martin 01 Jun '09

01 Jun '09

Hi, I've a problem with loading the plugin local config file. My config (config.inc.php) in the root dir of my plugin: <?php // enable / disable yubikey authentication $rcmail_config['yubikey'] = TRUE; // yubikey API key & ID needed to access the web service API // can be had at: https://api.yubico.com/get-api-key/ $rcmail_config['yubikey_api_id'] = ''; $rcmail_config['yubikey_api_key'] = ''; ?> When I'm calling $this->load_config('config.inc.php') or $this- >load_config(), the function always returns false and I found the following error message in the error log ... [01-Jun-2009 11:26:44 +0200] PHP Error: Failed to load config from / Users/oliver/Sites/trunk/roundcubemail/plugins//yubikey_auth/ config.inc.php (GET /~oliver/trunk/roundcubemail/? _task=settings&_action=keep- alive&_t=1243848404670&_remote=1&_=1243848404671&_unlock=0) I first tought that the double slash in the path was wrong and so I changed the code in rcube_plugin.php to .... //$this->home = $api->dir . DIRECTORY_SEPARATOR . $this->ID; $this->home = $api->dir . $this->ID; ... but now I'm getting the same error message with the correct path ... Error message: [01-Jun-2009 11:35:55 +0200] PHP Error: Failed to load config from / Users/oliver/Sites/trunk/roundcubemail/plugins/yubikey_auth/ config.inc.php (GET /~oliver/trunk/roundcubemail/? _task=settings&_action=logout) Does anybody has some idea about this issue? Regards, Oliver _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Feature Discussion
by Roland Liebl 01 Jun '09

01 Jun '09

Hi Devs, do you plan to implement the following (IMO standard) features during v0.3 development or should they better be implemented as a plugin? #1 - Forward message as attachment #2 - Copy message to folder (currently only "move" is available) #3 - Attach vCard according to identity #4 - Select Range/Invert Selection in message list (I like it and am used to that feature from Squirrel) #5 - Expand/Collapse all folders in folder list I'm in process to update MyRoundCube - which has all those features - to use your fantastic plugin API. I have to take care about my ressources and won't spend time on things which might be already on your ToDo's. Thank you. Regards, Roland _______________________________________________ List info: http://lists.roundcube.net/dev/

4 11

Plugin WIKI page
by Roland Liebl 01 Jun '09

01 Jun '09

Plugin WIKI page is great. Thanks a lot! People already started to add their plugins there! Regards, Roland _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] Yubikey authentification plugin
by Oliver Martin 31 May '09

31 May '09

Hi Cor, thanks for your advise ... i will change my plugin tomorrow. When I add my plugin to repo, where should I store the plugin code? Regards, Oliver Am 31.05.2009 um 23:31 schrieb Cor Bosman: > Only thing id change is use your own config.inc.php file and call > $this->load_config(). That way the central config.inc.php doesnt get > cluttered with plugin config settings. > > I just changed the plugin doc to reflect this recent addition to the > API. > > Cor _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev