- Dev - Roundcube mailing lists

Yubikey authentification plugin
by Oliver Martin 31 May '09

31 May '09

Hi, I've ported the Yubikey authentication plugin by dirkm to the new plugin api. Please have a look at my code and give me some advice for improvement. Regards, Oliver --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/eu/OPlltg5z/yubikey_auth.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 1

repository for plugins using the API
by Cor Bosman 31 May '09

31 May '09

Hi all, there doesnt seem to be a repository yet for plugins using the API. Right now there are the example plugins in SVN, and i know of a few plugins made by others, but id like to see a central spot where one can find API plugins. What ideas are floating around for this? The moment 0.2.2 comes out, I hope a lot of people will start making proper plugins.. Regards, Cor _______________________________________________ List info: http://lists.roundcube.net/dev/

6 10

including JS files from the core in plugins
by Phil Weir 31 May '09

31 May '09

Hi, First, apologise if this is already possible. I had a look at the include_script function in the API and I don't think it is. I am wondering what everyone thinks about allowing plugins to include scripts from the core (like list.js) rather than having to copy them into the plugin dir? The possible problem with this is that if something changes in one of the core JS files then its possible the plugin might need to be updated to work with it. The advantage is that plugin maintainers would have one less file to worry about. Any one got any thoughts? Thanks Phil _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

Updated Swedish localization of labels.inc and messages.inc
by Jonas Nasholm 31 May '09

31 May '09

Hi, I’ve attached an updated Swedish localization of labels.inc and messages.inc. Regards, Jonas Nasholm Bitfuse Network --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/vj/EtxJSybT/sv_SE.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

api / caching
by Cor Bosman 31 May '09

31 May '09

Hi all, i probably want to do something that isnt going to work well anyways, but maybe someone has a good idea. Through the api (message_headers_output) im adding a button next to the address-add button on the From line. This second button adds the sender to a centralized whitelist. To be nice, I want to remove the button immediately after clicking, and thats all working fine. Just a bit of JS to remove the button. If a user is already in the whitelist (which i load on login_after), i dont add the button, and if you click on the button I make sure the whitelist is reloaded so future emails of this same sender dont get the button either. Im running into a little problem. message_headers_output is not always called. If I read the next email, then go back to the previous email where I just clicked the button (which was removed), the button re- appears. This is not due to anything wrong with the plugin code, but because RC sends Etags and If-Modified headers which my browser happily uses to show me a cached version of the previous header. Im assuming this is wanted behavior. The more caching the better I guess, but in this case its biting me. Is there anyway I can prevent this from happening? Or should I just give up on trying to show the right thing? (the same can be said for the addressbook-add button.. why show it if you're already in the addressbook). Any tips appreciated, Cor _______________________________________________ List info: http://lists.roundcube.net/dev/

4 6

Plugin Developement Mailing list
by Roland Liebl 31 May '09

31 May '09

Hi all, I'm not sure if you like it, if I mail to devs list regarding plugin developement. It might be a good idea to have a separate list to discuss plugin developement. I don't mean the disussion about the api itself. I'm thinking about plugin projects. Regards, Roland _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

RoundCube User Object
by Roland Liebl 28 May '09

28 May '09

Hi Devs, I would need a simple patch for rcube_user.php. My thought is to introduce ... /** * Return a list of all (incl. deleted) identities linked with this user * * @return array List of identities */ function list_identities_history($sql_add = '') { // get contacts from DB $sql_result = $this->db->query( "SELECT * FROM ".get_table_name('identities')." WHERE user_id=? $sql_add ORDER BY ".$this->db->quoteIdentifier('standard')." DESC, name ASC, identity_id ASC", $this->ID); return $sql_result; } Or is there a way to get all identities including those with "deleted" flag by a plugin in another easy way? I'm coding an hMail plugin to allow aliased login which adds the alias automatically to user's identites list. I want to avoid that the identity is added again and again even if the user has decided to delete the automatically added identitiy previously. Thanks for any advice. Regards, Roland _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Patch: Fix localized language files
by Christian Iversen 28 May '09

28 May '09

Hi RoundCube devs (Please CC, not on the list) I've discovered an error in the 0.2.2-stable release, which makes it impossible to use certain language files. In the end of certain language files, there's a ^M (0x0D), which makes PHP output a newline on inclusion, which makes the whole app break, because there's a call to header() after the inclusion. I've inlined the very simple patch to fix up the danish files: {{{ Index: src/program/localization/da_DK/messages.inc =================================================================== --- src/program/localization/da_DK/messages.inc (revision 689) +++ src/program/localization/da_DK/messages.inc (working copy) @@ -97,4 +97,3 @@ $messages['editorwarning'] = 'Al formatering af teksten forsvinder, hvis der skiftes til ren tekst. Vil du fortsætte?'; ?> - Index: src/program/localization/da_DK/labels.inc =================================================================== --- src/program/localization/da_DK/labels.inc (revision 689) +++ src/program/localization/da_DK/labels.inc (working copy) @@ -264,4 +264,3 @@ $labels['GB'] = 'GB'; ?> - }}} However, a few more files show symptoms of problems, but I haven't checked them out by hand: $ grep -rl '^M' src/program/localization src/program/localization/sr_CS/messages.inc src/program/localization/sr_CS/labels.inc src/program/localization/vi_VN/messages.inc src/program/localization/vi_VN/labels.inc src/program/localization/si_LK/messages.inc src/program/localization/si_LK/labels.inc src/program/localization/ne_NP/messages.inc src/program/localization/ne_NP/labels.inc I hope this fix can be included in the next stable release. In the meantime, I'm making a private debian package with this patch in it. P.S: Is there any plan to make an official Debian package -- or at least support for compiling a Debian package from source? I'd be happy to contribute the work I've done so far. -- Med venlig hilsen / Best regards Christian Iversen Sikkerhed.org ApS Fuglebakkevej 88 E-mail: support(a)sikkerhed.org 1. sal Web: www.sikkerhed.org DK-2000 Frederiksberg Direkte: ci(a)sikkerhed.org _______________________________________________ List info: http://lists.roundcube.net/dev/

3 3

Russian translation updated
by Artur Smolkin 27 May '09

27 May '09

Hello everybody. In attached files. -- Best regards, Artur D Smolkin. www.roundcube.ru www.almatek.ru Telephone: +7 (913) 957-49-57 E-mail: artsmolkin(a)ya.ru --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/HY/tUPNNWV3/labels.inc http://detached.gigo.com/rc/HY/tUPNNWV3/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

plugin api/ajax question
by Cor Bosman 26 May '09

26 May '09

Hi all, im working on a plugin that needs to do some ajax calls. It's all working, but im wondering if this is the right way to do it.. I create a button (in a template inside the plugin dir, so that recent addition is working great): <roundcube:button command="plugin.xs4all_greenlist-add" type="input" class="button" label="xs4all_greenlist.xs4all_greenlist_add" /> In JS: rcmail.register_command('plugin.xs4all_greenlist-add', 'xs4all_greenlist_add' , true); function xs4all_greenlist_add() { rcmail.http_post('plugin.xs4all_greenlist-add', '_greenlist_entry='+entry, true); } And in PHP: $this->register_action('plugin.xs4all_greenlist-add', array($this, 'xs4all_greenlist_add')); function xs4all_greenlist_add($args) { global $OUTPUT; .... $OUTPUT->command('xs4all_greenlist_add_greenlist_row'); } Up to here it was pretty straightforward. But i was fiddling a bit to get the ajax return correct. It's returning a JSON reply with an exec field that can execute a JS function. I ended up doing this in my js file, otherwise the function couldnt be found: rcube_webmail.prototype.xs4all_greenlist_add_greenlist_row = function() { ..... } This seems to be working, but i just want to make sure this is the correct way to handle this, before I end up having to change this plugin later on. Thanks, Cor _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

Resply message
by Sandro Pazzi 26 May '09

26 May '09

Hi all, it's possible to set a property for set signature and cursor before the message in a reply? When we replay many times to an email your new text is in the bottom and not good for reading. Thanks -- Sandro Pazzi IdWeb s.r.l. Viale Romagna 69/A - 06012 Citta' di Castello (PG) Tel. 075 851 97 28 Fax 075 851 97 30 _______________________________________________ List info: http://lists.roundcube.net/dev/

5 8

Re: [RCD] Message Highlighting Plugin - Initial comments
by Eric Appelt 25 May '09

25 May '09

Hello Chris, your message highlight plugin works great and is really good, now i have update to current SVN and the message highlignt plugin dosn't work can you patch this thats works with the current SVN. Many Thanks _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

message menu button
by A.L.E.C 24 May '09

24 May '09

I'm working on a new button in toolbar (mail.html and message.html templates). This will be a popup menu like markmenu, will contains container for plugins and three actions (for start): - open message in new window - show source (in new window) - Download as .eml file The button will be enabled in message view or in mailbox view when one message is selected. I'll remove current viewsource button. So, now I need your opinion about: 1. Should I add 'print' action to message menu, and remove print button from toolbar? It's reasonable, print is a one-message-action (and we need more place for plugin buttons). 2. I've got no image for the button, any ideas? -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

3 5

Stable 0.2 forward attachment problem
by airween＠damson.hu 23 May '09

23 May '09

Hello Developers, I have checked on google, but didn't find any relevant info from past near... So, a few days ago I have upgraded from first 0.2 to current stable version, and users said if somebody forward an email which contains attachment, it doesn't arrive to recipient. I've checked, and it's true. When I forward an email which contains attachment (eg: a zipfile), it visible in "attachments" block on left top of display - but when I send it, and read at other address, the attachment isn't there. Could anybody help me? Thanks: a. _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Re: [RCD] [Svn] r2515 - trunk/roundcubemail/program/include
by Thomas Bruederli 22 May '09

22 May '09

A.L.E.C wrote: > BTW, plugins directory name is still hardcoded in rcube_plugin_api > as $url, which is used in ressource_url (two ss!) and to build rcube_plugin::$urlbase. > Yes, you're right. I forgot about that. I'm not sure whether we should introduce another config parameter which specifies the plugin directory URL. This is not necessarily the same as the real 'plugins_dir' setting. ~Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

[PATCH] PHP 4 fixes for lib/html2text.php
by Francois Marier 21 May '09

21 May '09

Hi, Here's a 2-line patch for the html2text class which is part of RoundCube. I'm not sure whether or not you'll be interested in it because it's just about making that class compatible with PHP 4. I had to fix this specific problem because we (the Moodle project -- http://www.moodle.org) use your code to do HTML to text conversion when mailing out forum posts to users and unfortunately we still have to support PHP 4 in the latest stable version of Moodle. Cheers, Francois --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/7X/2Iskptr6/roundcube_html2text_.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Updated Hebrew Translation
by Moish 21 May '09

21 May '09

-- Moish --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/5q/DXEOjpYA/messages.inc http://detached.gigo.com/rc/5q/DXEOjpYA/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] Load plugin config from plugin folder
by Roland Liebl 21 May '09

21 May '09

Resolved like inspired by Robert King. Thanks! Patch is not required anymore. I would just need your opinion about: http://lists.roundcube.net/mail-archive/dev/2009-05/0000053.html Regards, Roland _______________ function _load_config($plugin) { $rcmail = rcmail::get_instance(); $config = $rcmail->config->get('plugins_dir') . "/" . $plugin . "/config/config.inc.php"; if(file_exists($config)) include $config; else if(file_exists($config . ".dist")) include $config . ".dist"; if(is_array($rcmail_config)){ $rcmail->config->merge($rcmail_config); } } > ----- Original Message ----- > From: "Robert King" <robk(a)mun.ca> > To: "RoundCube Dev" <dev(a)lists.roundcube.net> > Sent: Sunday, May 17, 2009 5:42 PM > Subject: Re: [RCD] Load plugin config from plugin folder > > >> On Sun, 17 May 2009 13:03:37 -0230, Robert King <robk(a)mun.ca> wrote: >>> In my plugins I've been calling a function in the plugin init of: >>> >>> class plugin_name extends rcube_plugin >>> { >>> >>> public function init() >>> { >>> _load_config(); >>> } >>> >>> private function _load_config() >>> { >>> include('config.inc.php'); >>> $this->config = (array) $_config; >>> } >>> >>> } >> >> Forgot this important detail: >> >> class plugin_name extends rcube_plugin >> { >> private $config; >> ... >> } >> >> -- >> Robert King >> System Administrator >> Computing & Communications >> Memorial University >> _______________________________________________ >> List info: http://lists.roundcube.net/dev/ >> > > _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

Plugin question
by Cor Bosman 21 May '09

21 May '09

Hi all, a plugin question ive been wondering about. What is the recommended way for a plugin to save longterm non-user configurable data? Just an example, lets say I want to keep track on if ive shown a MOTD page to a user, id have to save that information. But some plugins may have much more extensive needs here. Basically any data you want to save immediately without going through a save preferences click. It might be nice to have some api functions that allow a plugin to save this kind of data without having to construct your own SQL. Any ideas about this? Maybe it exists already and I just couldnt find. Also, looking at the code it seems as if plugins through save_preferences hook can add saved prefs, but this has a potential for unintentional overlap. If 2 plugins decide to use the same name, you'll override a previous config with the same name. Maybe RC should add the plugin name or something to the prefs key? Regards, Cor _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

[Plugin API] TODO
by A.L.E.C 21 May '09

21 May '09

I've rewritten my managesieve patch using plugin api and I've found a few issues: 1. Templates from plugin directory. I've commited patch from Roland Liebl and it's possible now, but... images path is hardcoded to "plugins/plugin_name/...", and will not work if someone will change plugins_dir. 2. include_script() includes script after rcmail variable initialization. That's ok, but there's a one situation when it's a problem. For 'html' output I must write: $this->rc->output->add_script(sprintf("rcmail.managesieve_updatelist('%s', '%s', %d);", isset($new) ? 'add' : 'update', $this->form['name'], $fid), 'foot'); instead of more unified form: $this->rc->output->command('managesieve_updatelist', isset($new) ? 'add' : 'update', $this->form['name'], $fid); 3. Localization folder name should be constant for all plugins (hardcoded in api). Creating plugins translator will be simpler then. -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Updated Swedish localization of messages.inc
by Jonas Nasholm 19 May '09

19 May '09

Hi, I’ve attached an updated Swedish localization of messages.inc. Regards, Jonas Nasholm Bitfuse Network --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Y7/DpA6h7k5/sv_SE.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

roundcubeforum.net DOWN
by Michael Crumm 19 May '09

19 May '09

Does anyone know why http://roundcubeforum.net is unresponsive? I seem to get redirected to some gaming website. I tried asking in the IRC channel last night, but I think everyone was asleep :-) Is the forum site run by the roundcube admins? Does anyone know if it will be coming back? -- Michael Crumm mcrumm(a)gmail.com _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

Cache buster? (Re: Trunk 2501 error javascript in osx)
by Gokdeniz Karadag 19 May '09

19 May '09

> Message: 10 Date: Tue, 19 May 2009 15:10:26 +0200 From: till <klimpong(a)gmail.com> > Subject: [RCD] Cache buster? (Re: Trunk 2501 error javascript in osx) >> > On Tue, 19 May 2009 14:11:13 +0200, "A.L.E.C" <alec(a)alec.pl> wrote: >>> >> Sandro Pazzi wrote: >>> >> >>>> >>> I've installed the last version and I find this errors in osx firefox >> > and >>>> >>> safari. >>>> >>> >>>> >>> All works fine in firefox and safari on windows. >>> >> >>> >> Css cache issue. Clear browser's cache. > > Do we need a cache buster? E.g. skins/default/css/main.css?v=RCVERSION > > Or we include the version in the filename for releases? > > Thoughts anyone? > I think version in the filename is better, that way browsers can cache the css. The same can be done for js files. When I patched a js file to solve a bug, that required full refresh in clients; you don't know when the cache will be invalidated, somehow file mtime is not very reliable (?) -- Gokdeniz Karadag _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

New versions 0.2.2 and 0.3-beta released
by Thomas Bruederli 19 May '09

19 May '09

Hi RoundCube users and list lurkers We've recently published two new releases of the RoundCube Webmail package. Version 0.2.2 is a minor update to the stable 0.2 branch. Beside some bug fixes this version now supports STARTTLS for IMAP connections. A bit further down the road we have the 0.3-beta version which now includes the long awaited plugin API. This version is still under development and we don't recommend to replace a productive version with 0.3-beta. Nevertheless we'd like you to install and test it and get the idea of how to write plugins. Read http://trac.roundcube.net/wiki/Doc_Plugins to get started and find some sample plugins within the package or more by browsing the SVN repository: http://trac.roundcube.net/browser/trunk/roundcubemail/plugins You can download both releases from http://roundcube.net/downloads and as usual you're kindly requested to submit your reports to our bug tracker: http://trac.roundcube.net/report Have a lot of fun! Thomas _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] forum
by Roland Liebl 19 May '09

19 May '09

I dropped a note to brett [at] ... I'm just a moderator and can't do anything. But it looks like some kind of database injection: <META HTTP-EQUIV="Refresh" CONTENT="0; URL=http://xsaimex.mybrute.com/"><br /> <b>Warning</b>: include_once(includes/VBSEO_VB_CONFIG) [<a href='function.include-once'>function.include-once</a>]: failed to open stream: No such file or directory in <b>/var/www/vhosts/roundcubeforum.net/httpdocs/vbseo.php ........... _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev