For most of plain text messages we have two FETCH commands now:
C: FH12 UID FETCH 4790 (UID RFC822.SIZE FLAGS INTERNALDATE BODYSTRUCTURE
BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC
BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCES
DISPOSITION-NOTIFICATION-TO X-PRIORITY)])
[08-Jan-2009 15:21:29 +0100]: C: ftch FETCH 640 (BODY.PEEK[1])
We can prefetch a small part of message body (first part) using
BODY.PEEK[1]<0.4096> in first FETCH. Then we should check if message is
realy a plain text and if body size (from BODYSTRUCTURE) is not bigger
than 4096 bytes. If so we can skip the second FETCH.
--
Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252
LAN Management System Developer http://lms.org.pl
Roundcube Webmail Project Developer http://roundcube.net
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi! I have another great patch from my performance fixes set ;) I've
observed that when message is displayed (with disabled cache) we have:
1. FETCH for headers
2. FETCH for message (body) structure
3. one FETCH for each message/attachment part (it really sucks when
message contains several attachments)
4. FETCH for body
So, here's the patch which joins 1. and 2. into one command call and
joins all fetches from 3. into one command call. Speed up is significant
for all messages, specially for those having many attachments. Imagine a
message with ten attachments. Previously there was ca.10 + 3 fetches *
0.2 sec. (in my mailbox with ca.800 messages) = 2.6 sec. Now, only 3
fetches * 0.2 = 0.6 sec.
I'm posting this here, because it's too late to commit such changes (not
tested well) before 0.2-stable release. So, enjoy and test in your
environments.
ps. Thomas, maybe you can wait a few days and review this patch to
include in 0.2-stable? It would be nice.
--
Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252
LAN Management System Developer http://lms.org.pl
Roundcube Webmail Developer http://roundcube.net
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/Wr/HvaAQAVp/perf.patch
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hello everybody !
So ! 0.2 stable is here, I see 0.2.1 is planned for bug fixes, so 0.3 is
almost here, and in 0.3 plugin api is planned so.. when we will able to
begin to code a plugin (maybe with a different branch ? )? :]
Regards,
--
Maximilien Cuony [The_Glu]
http://theglu.org
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
Does any one know what was used to minimise the JS files in the 0.2stable
tarball? Also why the tarball is different from the 0.2stable branch/tag? I
generated some patches against 0.2stable from the SVN and then they don’t
work with the other version :/.
Thanks
Phil
_______________________________________________
List info: http://lists.roundcube.net/dev/
Thunderbird has a very cool feature called "Edit as new". What it does
is simple. It takes the message "as is" without quoting it like replying
or forwarding, so I can reuse my messages as templates and don't have to
painfully copy/paste the message every time I want to duplicate it. For
example: one of my customers has to send a password mail "by hand" to
his newly registered customers and uses an old send message as template
(changing the private data) using the "Edit as new" feature in
Thunderbird. When he is not at his computer he wants to send this
message using the webmailer (my RoundCube installation of course).
I already implemented this in my installation with minimal effort using
the forward command as template. I don't have a patch for the newest svn
trunk but can provide it if this is going to be implemented. I can
provide the patch and translation files for German. What I need is a
picture for the button that appears next to the forward button maybe on
of you has an idea?
Could you please add your thoughts about this?
Regards
Christian
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi Devs,
I was hoping someone would have the time to look at
http://trac.roundcube.net/ticket/1485634
It's a bug patch I posted a few weeks ago which details how turning on
skip deleted and caching at the same time can cause serious
misbehavior. It's been a real pain for us in our environment. I think
it's serious enough that, until its fixed, it at least warrants
something like a warning in the config file that those options are
incompatible.
Thanks.
Ziba
Webmaster Team
University of Michigan
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
Trying to fix #1485659, which hurts me too, I noticed a number of
raise_error() calls missing required parameters.
Attached patch fixes three of those. Not sure though if type in
utf8.class.php and spell_pspell.inc should be 'php', so I'm not
committing this yet.
There are two other occurances in rcube_ldap.php, but I have no clue
what error code to put there.
Robin
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/Vp/NN6EXh1a/raise_error.patch
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
Here is the updated Korean Localization files.
Hanjo Kim
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/Kw/WvhG8XA3/ko_KR.zip
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Could I just poke you devs to please include STARTTLS support sooner
rather than later? I just lost a few hours writing a patch to add this
(I don't know PHP) and later discovered that someone had already done
the same:
http://trac.roundcube.net/ticket/1485284
The implementation isn't that complex and I've found more than a few
messages online involving people trying to get roundcube to use TLS. I
believe STARTTLS is considered the standard way to do both encrypted
IMAP and SMTP (STARTTLS in SMTP is already supported) and it's quite
irritating to have to open up an extra port for IMAP over SSL.
Regards,
Francis
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
I would like to propose a modification of "iniset.php" to eliminate
possible "Undefined index: HTTPS" notices in the error log.
The existence of $_SERVER['HTTPS'] should be tested before any attempt
to retrieve its value. We currently use the following solution:
isset($_SERVER['HTTPS']) ? ini_set('session.cookie_secure',
($_SERVER['HTTPS'] && ($_SERVER['HTTPS'] != 'off')))
: ini_set('session.cookie_secure', 0);
The proposed modification is attached as a patch file.
Regards,
Jonas Nasholm
Bitfuse Network
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/j3/EflQHdK2/program_include_inis.patch
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
I’ve attached an updated Swedish localization for version
trunk-r2162-20081216. We currently use this translation in our systems.
Keep up the excellent work!
Regards,
Jonas Nasholm
Bitfuse Network
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/CD/yInFDl6e/sv_SE.tgz
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
While it is still unclear whether or not there is a problem with
bin/html2text.php (http://trac.roundcube.net/ticket/1485618), maybe it's worth
considering adding session checking to all of the utilities in the bin
directory. If a vulnerability exists in a utility, then having a session check
will limit or complicate its exploitation.
The way quotaimg.php was doing session checking could be used in the other
utilities. (quotaimg.php's session checking was removed in October:
http://trac.roundcube.net/changeset/2012).
-kris
--
Kris Steinhoff
ITCS Web/DB Production Team
The University of Michigan
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi RC Devs,
I'm looking at the cache in the messages table regarding ticket #1485634.
It looks to me like this is what the caching is currently doing:
In _list_headers, if it is determined that the cache is more than 10%
out of sync, it fetches the headers for the page you are currently on
and puts them in the cache.
Then it erases all the cache entries with an id higher than the page you
are on.
Cache validity checking is per mailbox, not per page, this means that if
I have 20 pages of mail and I delete something on page 18, the cache
will "miss" on every visit to pages 1-17 until I revisit all 17 pages.
Also consider the case where an imap user with dozens of pages of mail
first accesses roundcube. Their cache will always miss until they visit
every page at least once.
Am I missing something?
Is it too costly for a cache miss to trigger populating the cache with
more than just the page they are on?
Maybe a cache miss could populate the current page plus some set amount
more to keep the time down, but eventually populate the user's whole
cache. Or maybe it could be adjusted so that the whole mailbox doesn't
have to be represented in the cache for the user to get some benefits
from it.
Thanks for your time,
Ziba
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
I just added a patch to #1484883, which enables TLS support in Net_SMTP.
Do we have a policy about modifying 3rd-party libraries?
Robin
_______________________________________________
List info: http://lists.roundcube.net/dev/
Missing strings were added in a previous message, see;
http://lists.roundcube.net/mail-archive/dev/2008-12/0000036.html
Regards
- Gokdeniz
> Message: 5
> Date: Wed, 17 Dec 2008 13:52:02 +0800
> From: "Aykut Kara" <aykut.kara(a)gmail.com>
> Subject: [RCD] turkish translation updated
> To: <dev(a)lists.roundcube.net>
> Message-ID: <494893a0.15528c0a.4509.5ff6(a)mx.google.com>
> Content-Type: text/plain; charset="us-ascii"
>
> Hi,
>
>
>
> Some of new variables translations were missing for Turkish. I added missing
> ones and attached to this email.
>
>
>
> Regards
>
> -- Aykut Kara --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/8t/yYS4rCj5/messages.inchttp://detached.gigo.com/rc/8t/yYS4rCj5/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi, all.
I use RC 0.1.1-stable, but the filename after download attachment with
Chinese characters is incorrect, so i created this patch to fix this
issue. (I submitted another patch to fix incorrect attachment filename
display before, and was fixed in svn version in another way.)
Note: I havn't test this issue in RC svn version, but i will do it
later.
--
Best regards.
Zhang Huangbin
- Open Source Mail Server Solution for RHEL/CentOS 5.x:
http://code.google.com/p/iredmail/
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/pN/VvmkCwqf/roundcubemail-0.1.1_.patch
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
Some of new variables translations were missing for Turkish. I added missing
ones and attached to this email.
Regards
--
Aykut Kara
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/8t/yYS4rCj5/messages.inchttp://detached.gigo.com/rc/8t/yYS4rCj5/labels.inc
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
I would like to discuss one feature, which I consider a bug. When doing a
"reply to all" operation, I get included on the recipient list. In my
opinion, this is not correct behavior: mail should be send to everyone
_except_ the person who sends it.
What do you think?
Sincerely,
Ondrej Zara
_______________________________________________
List info: http://lists.roundcube.net/dev/
Dear subscribers
There were two security issues reported which are now fixed. The first
was as possible code injection using the html2text conversion script
[1]. The other exploit used the unchecked size parameters of the quota
image to let PHP create huge images eating up all the server memory.
Thanks to Stephan for reporting this.
The two vulnerable scripts were updated in the current 0.2-beta
package and for existing RoundCube installations we recommend to
download the update [2] and to replace all the files with the new
versions found in the archive.
Regards,
Thomas
[1] http://trac.roundcube.net/ticket/1485618
[2] http://downloads.sourceforge.net/roundcubemail/roundcubemail-0.2-beta-patch…
_______________________________________________
List info: http://lists.roundcube.net/dev/
Updated Turkish translation is attached as a patch file.
This patch is against svn Trunk
--
Gokdeniz Karadag
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/Em/kDtESn5y/turkish_update.patch
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hello,
we are looking to use Roundcube mail with a new mail system that we are developing for a client. Being able to extend Roundcube
with some additional options and functionality will be important to us.
We are willing to use some of our development time to help implement the Plugin API in Roundcube. Doing this will help us reach
our goals and also help the Roundcube project. Doing this work with the Roundcube team and hopfully feeding into the Roundcube
tree will also allow us to use a relatively pure Roundcube distribution with our extensions, future-proofing our work.
Having checked-out the latest SVN Trunk and also looking at the development timeline and roadmap, it seems that the plugin API
is next up for implementation. We have also checked-out the branches/devel-api. SNV says this has not been touched for 4 months,
is this the latest work and the best starting place for further development?
If we wish to work on this, how and where can we best start?
What work has the development team done in this area? (devel-api branch / other)?
Is there any design and/or documentation existing for the API?
Regards
Chris Moules
Global Media Systems
_______________________________________________
List info: http://lists.roundcube.net/dev/