> I hope I could provide a small patch on monday for testing.
I made it. The Patch is made with SVN Version 1626. I implemented it
slightly different. I'll describe it here:
Changes:
1 Config: optional you can set a plugin directory, default is as follows:
$rcmail_config['plugin_dir'] = 'plugins/';
2 At the points where different plugin-actions should raise:
rcube_plugins::get_instance()->actionUserLoggedIn();
Currently only this action is defined - other follow if the code is proved.
As not really needed to implement a own function for each plugin-action it
gives us a good documentation.
3 As rcube_plugins is a singleton class it is initialized when first needed.
Then:
... the constructor calls registerPlugins()
which loops thru the plugin-directory and searches for plugin classes and
initiates them:
This defaults to ./plugins/Pluginname/Pluginname.php which includes 'class
Pluginname'
4 on the call to actionUserLoggedIn() in 2. the rcube_plugins singleton
tries to find a matching method actionUserLoggedIn() in any plugin class.
5 demoEventLogger is an very small example plugin which should write a log
to the temp folder.
-------------------
Why I implemented it this way:
* there is no need for configuration in RC
* there is no need for an extra hook registration in the plugins
* because you may have a better way to do it?
You will find the patch-file and a complete 7zip file including the whole
roundcubemail folder here:
http://www.lagg.at/temp
The patch file is also included in this mail.
As I am not the greatest php programmer it would be great if someone can
review it.
Thanks, yours
--
Florian Lagg
-
Florian Lagg - IT-Komplettlösungen
Juch 7, 6631 Lermoos
tel +43 (699) 10 20 10 24
www.lagg.at - info(a)lagg.at
-
Xing: http://www.xing.com/go/invite/7372113.3da562
-
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/BG/FeBAgRCc/plugin-architecture.patch
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
Updated Arabic language translation attached.
regards,
Ossama Khayat
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/Xa/p397ZeZq/roundcube-ar.zip
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hello there.
I am new in this list and my english is almost enough to comunicate.
Recently I donloaded the 0.2-alpha version of RC. In the older version
with this guide:
http://blog.julienwadin.be/index.php/2007/05/26/72-modification-du-password…
A little (very little) of Frenh knowledge and a lot of patience in PHP
coding I barely configure the Change-Password feature in 0.1 version.
Now, finding where this code is in the new version (line numbers and
syntax changes make it more difficult) I put again the modifications
into this version.
But, there is no preferences redirect to the passwd script, leading me
to User Preferences default page, not to ?_task=settings&_action=passwd
where it has to go to. I suspect it is in the JS code, but my knoledge
is not so complete.
I am using a MySQL database and the passwd.inc script included in the
URL is properly set. The thing that is not working is the redirect to
the script itself in preferences box, but JS is not one of my prefered
languages.
I am interesed on help in development of RC, maybe helping on make a
good password-change plugin or section. I have a pair of ideas of how to
make it, taking care of SQL/LDAP/PAM possibilities. I know of PHP (not
OOP but I consider myself a good procedural coder) and I have my skils
on GNU/linux system administration (at least postfix related things)
Any clue?
--
--
|
| Octavio Rossell Tabet
| http://octavio.unplug.org.ve
| irc.unplug.org.ve #unplug
| Usuario de GNU/Linux: 278860
| Huella de clave = 2BD5081C
|
_______________________________________________
List info: http://lists.roundcube.net/dev/
Kaixo (Hi!)!
Here translates to Euskara (Basque)
Thanks
--
Bihar
Gaur da Bihar
Aurreztu papera. E-posta hau inprimatu beharra daukazu?
Ahorra papel. ¿Necesitas imprimir este correo?
Mezu honek eta eranskinek informazio konfidentziala eduki dezakete.
Igorri zaion pertsonari bakarrik zuzendua da. Legeak mezuak daukan
informazioa zabaltzea, kopiatzea edo hirugarren bati helaraztea debekatzen
du.
Internet bidez bidalitako posta elektronikoak ez du konfidentzialtasuna
bermatzen, ezta transmisio zuzena ere.
Este mensaje y sus anexos pueden contener información confidencial y están
exclusivamente dirigidos a sus destinatarios, quedando prohibida su
divulgación, copia o distribución a terceros.
Si ha recibido este mensaje por error, por favor, notifíquelo inmediatamente
al remitente y bórrelo de su sistema.
El correo electrónico vía Internet no permite garantizar ni la
confidencialidad de los mensajes ni su correcta transmisión.
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/tW/qzgJbtub/labels.inchttp://detached.gigo.com/rc/tW/qzgJbtub/messages.inc
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hallo,
my question is why in RC the display (logging) of Notice-Warnings are
disabled. Okey, Notices are often nothing important, but sometimes they
show some rare problematic cases, which are not an error but a
program-failure. For example: I got those Notices:
[18-Aug-2008 15:23:54] PHP Notice: Undefined offset: 1 in
/var/www/web231/files/site1/webmail/lib/imap.inc on line 630
[18-Aug-2008 15:23:54] PHP Notice: Undefined index: in
/var/www/web231/files/site1/webmail/lib/imap.inc on line 631
[18-Aug-2008 15:23:54] PHP Notice: Undefined offset: 2 in
/var/www/web231/files/site1/webmail/lib/imap.inc on line 633
[18-Aug-2008 15:23:54] PHP Notice: Undefined offset: 3 in
/var/www/web231/files/site1/webmail/lib/imap.inc on line 634
[18-Aug-2008 15:23:54] PHP Notice: Undefined offset: 4 in
/var/www/web231/files/site1/webmail/lib/imap.inc on line 635
[18-Aug-2008 15:23:54] PHP Notice: Undefined offset: 1 in
/var/www/web231/files/site1/webmail/lib/imap.inc on line 639
[18-Aug-2008 15:23:54] PHP Notice: Undefined offset: 2 in
/var/www/web231/files/site1/webmail/lib/imap.inc on line 640
I have to say, that i use RC-0.1 stable. This warning are from the
Function "iil_StrToTime" and all undefined offsets point to the variable
$a. Since this notice is logged in a working environment (so this happen
to some of the user, who used RC) i can't reproduce the problem. But
there must be a case where the Time-String is not right so this function
does work right on it. When does it happen?
I had several other problematic cases which i could repair by myself, so
my suggestion is to enable also the Notice-Warnings. What do you think
about this?
_______________________________________________
List info: http://lists.roundcube.net/dev/
When checking for new messages RoundCube displays a loading message. This
feedback is useful when the user has click the "Check for new message"
button, but it is also displayed when RoundCube automatically checks for
new mail. I think RoundCube should only display the message when the user
has manually initiated a check.
What do others think about this behavior?
I've created a feature request, and submitted a patch:
http://trac.roundcube.net/ticket/1485276
thanks
-kris
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/N7/k9ZkERfB/UTF-8_27_27idle_ch.pat
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
I developed a low cost authentication usb dongle (the swekey).
I want to add swekey support to roundcube so user's will be able to
authenticated using a hardware device.
I'm currently doing the job but I need somebody to validate then
commit my changes.
If some of you are interested please send me your mail address, so I
will be able to send you swekey prototypes.
Regards,
luc
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
I'm wondering what the purpose(s) of dblclick_time are as used in
program/js/app.js:this.msglist_select
It seems clear that it will prevent the message preview from loading
while the user is about to hit their second click to open the full
message screen. There is some nice economy there. However, if they
are just single clicking with the intent to see the preview it adds
0.51 seconds before the preview is shown.
Are there other reasons for waiting dblclick_time + 10 after a single
click to show the preview? If not, I'd side with the faster preview
time over the economy of not loading the preview before loading the
whole message.
Thanks,
Ziba
--
Ziba Scott
Web Application Developer
Web/DB Team, Information Technology Central Services
The University of Michigan
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi devs and list lurkers
After having a hard discussion about the plugin architecture I decided
to start with an implementation which is supposed to be a basis for
more discussion and design decisions. You can fetch it from
https://svn.roundcube.net/branches/devel-api.
I also updated the wiki page to summarize the current state of the
plugin API development: http://trac.roundcube.net/wiki/Plugin_API
Feel free to contribute to that page or to this thread. There's still
a lot of work to be done!
Regards,
Thomas
_______________________________________________
List info: http://lists.roundcube.net/dev/
Greetings,
I asked this question some months ago, but haven't noticed any changes.
Question being; will it be possible (in the relatively near future) to _flag_ messages.
ie; important, so that it will have a different color to reflect that flag in the message list view.
Or spam, so that a different color/background-color will reflect (can be assigned) its "flagged" state.
Thank you for all your time and consideration.
--Chris
RC - 2alpha (checked out of SVN on 2008-08-10)
MySQL - 5
PHP - (4 && 5)
Apache - (1 && 2)
.
/////////////////////////////////////////////////////
Service provided by hitOmeter.NET internet messaging!
.
_______________________________________________
List info: http://lists.roundcube.net/dev/
hi all,
today i just stumbled upon a limitation of RDC - if you add way too much
recipient, then a single very long line will be generated. RDC does not
seem to break it at any size, and when the line length exceeds the SMTP
server's configured max. line length, it rejects the message.
Is there a way to make RDC wrap the "To:" (and even possibly the CC, BCC )
headers in a composed message?
RFC 2821 (found on http://www.ietf.org/rfc/rfc2821.txt) says, the max. text
line length is 1k chars, so if i am right, the correct remedy would be to
implement the change in RDC.
What do you think? Have i missed something?
best,
--
Péter
Serial is up, protocol is up --- everything connected!
(c) Anthony Panda www.anthonypanda.com
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi
I'm running fc 8, I had a manual install of roundcube 0.1.0 but there
was a problem with the attachments so I tried to upgrade to 0.1.1
which is supposed to fix it ..
Now when the attachments just don't display at all in Roundcube or in
Thunderbird, the mail list shows there is an attachment in both but on
opening the email there is nothing .. If I view the source The
attachment is there . So what is roundcube doing to break the mail
that te attachments disapear when the mail is viewed ?
Thanks
_______________________________________________
List info: http://lists.roundcube.net/dev/
Is there a way to use the name of the current mailbox in a template? It
would be nice to have something like:
<roundcube:object name="mailbox_name" />
I've opened a feature request ticket on this
(http://trac.roundcube.net/ticket/1485256) and will implement it, unless
there's already a way to do this.
thanks
-kris
_______________________________________________
List info: http://lists.roundcube.net/dev/
Dear Developers,
I'm not sure if this belongs to the bug tracker or here.
On my mail server i use users like: user.domain.nl instead of
user(a)domain.nl
But becaus i want to login with the e-mail addres i had to make small
changes to the smtp and imap authentication.
Would it be a feature if the person installing could chose this?
With kindest regards
Richard Pijnenburg
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
corrected one typo and changed one sentence.
Bye,
Philipp.
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/sp/06ZV6gE2/de_DE.zip
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi all devs,
I've been trying to get RC running on an MS Exchange Server 2003 (not my
imap preference, but at least better than needing 2 exchange servers to
get webmail access!!!).
However, I've run across a few issues.
1. Only the inbox folder is subscribed to initially, all others are not.
See http://trac.roundcube.net/ticket/1485263
If you view the list of folders however, they can all be seen.
I've played around around with a few settings for imap_root, but to no
avail. ("INBOX/","/","INBOX", etc.)
As a side note, Thunderbird also has the same issue.
I'm willing to test and help develop a patch for this issue, I just need
some help figuring out what exactly exchange wants, and where in the RC
code I can play with it. I can only play with it a couple of times a
week, so my apologies if it's a bit slow to complete.
2. Not able to send email via local smtp server (exchange 2003 again)
Not sure on this one - but I haven't really tried yet....
Although I'm not a fan of Exchange in any form, I think it would be good
to get some basic compatibility (i.e. folder subscribing) to allow
others to later build plugins for the other functionality. If memory
serves we had a similar issue with Courier-IMAP that was resolved.
I know it's been a while since I've been on (see RoundCube RSS Reader),
but I have been watching the progress made (particularly on the recent
plugin work), and I have to say a HUGE congratulations and thanks to all
the devs (particularly to Till & Thomas) for all the work that's been
put in.
I admit I am really looking forward to eventually getting into the
plugin arch for developing a calendar & rss reader. :)
Sam Bailey
Wiki: wiki.cyprix.com.au
Web: www.cyprix.com.au
Blog: blog.cyprix.com.au
_______________________________________________
List info: http://lists.roundcube.net/dev/
> -----Ursprüngliche Nachricht-----
> Von: Cor Bosman [mailto:cor@xs4all.nl]
> Gesendet: Donnerstag, 7. August 2008 23:30
> An: Florian Lagg
> Betreff: Re: [RCD] Plugin-Architecture
>
> > Currently I have plans implementing it this way (OVERVIEW):
> > * There's a directory with plugins, e.g. ./plugins/*
> > * Each plugin resides in a own directory, let's call it
> "foo_plugin"
> > for now.
> > This assumes that there is a file called foo_plugin.inc
> which includes
> > a class foo_plugin
> > * In the configuration, we have a simple array list of
> enabled plugins
> > $rcmail_config['plugins_enabled'] = array('foo_plugin',
> 'bar_plugin');
> > * on the first called hook we initiate the rcube_plugins
> class which
> > is a singleton this class initalizes every plugin and - in the
> > constructor of these - the plugins itself register to some hooks.
> > this is done only once every request (because rcube_plugins is a
> > singleton)
> > * if registered hooks are called...
##### here's a small mistake:
> > every plugin is called - one after another - in the order
> given in the
> > config above.
##### naturally we call only plugins registered to the specific hook - not
all
> > therefore an array of data is passed to each plugin - and at last -
> > returned to the roundcube code.
> >
> > Have I missed someting?
> >
>
> Look good! Thanks for doing this.
>
> Cor
>
_______________________________________________
List info: http://lists.roundcube.net/dev/
Dear Developers!
I am using RC in my hosting offers and I want to implement two things:
* a kind of plugin-mechanism: It should be possible to "register" some
external plugins to events (User login, handling contact data, ...)
* a Funambol-Plugin (as seperate open source project): Funambol is a server
capable of syncing contacts/calendar items between native Clients (Outlook,
Thunderbird), various Devices (many mobile phones, PDA's, ...) and other
webmail-applications and groupwares.
I talked to A.L.E.C. some days ago because he had plans for the plugin
infrastructure. According to his mails he has no time to develop this in the
near future and I asked him if I can do the work. He answered it would be
ok, so I'll ask you how it should be done:
So here are my questions:
* How should a plugin-architecture be implemented in RoundCube?
Maybe my approach is completely wrong, just tell me if you think so...
I'm thinking of a PluginHooks singleton class which is called from various
points in the existing source code. This class reads a config file if there
is a plugin registered for the specific event. This config contains a line
for each event like this:
$rcmail_config['pluginevent_userlogin'] = array('Funambol');
//registers a single plugin called "funambol" for the event "userlogin"
$rcmail_config['pluginevent_nextEvent'] = array('Funambol', 'AnotherPlugin);
//call two plugins in the given order
PluginHooks then initates a class Funambol (located in
RC_Home/plugins/Funambol) and calls a method pluginevent_userlogin. Because
PluginHooks is a singleton, it could provide methods to the plugins to get
or manipulate data from the rest of RC. so anything is handled over this
class.
I hope I discribed it well. Please bring your own ideas if you have better
once.
* Is anyone interested in teaming up?
* Is anyone willing to implement plugins in near future? If so - please talk
to me to discuss your requirements to make this project as useful as
possible.
You can send me a CC so I can answer your mails quicker.
Thanks in advance,
Greetings
--
Florian Lagg
-
Florian Lagg - IT-Komplettlösungen
Juch 7, 6631 Lermoos
tel +43 (699) 10 20 10 24
<http://www.lagg.at/> www.lagg.at - <mailto:info@lagg.at> info(a)lagg.at
-
Xing: <http://www.xing.com/go/invite/7372113.3da562>
http://www.xing.com/go/invite/7372113.3da562
-
_______________________________________________
List info: http://lists.roundcube.net/dev/
> Michael Baierl wrote:
> > There is a convention - an parameter array for receiving data ("named
> > parameters") and returning data as an array. Done. Never touch the input
> > array.
> > This rule is relatively easy to check during QA and it is easy to use
> > and developers are used to that.
> >
> > Every class you create has to be understood and makes stuff more
> > complicated. KISS.
> >
> Amen!
I only belief to RFC! But I am convinced.
Thanks for all comments. I'll go on with arrays.
Again: because of lot work I will be able to show a second prototype in 2
weeks or so.
I have one important point left we should discuss:
(I know, I can be annoying)
What do we need to implement the plugin-arch in the frontend part, such like
in A.L.E.C.'s list:
> Typical plugin needs are e.g. adding a button in tasklist, adding a tab
> in Settings interface, adding a configuration option in User Preferences
> (simple tasks, just for start).
I have no insight of the frontend in RC and I do not want to develop these
things right now.
But I need to know how they work that anyone can implement these things
later without rewriting my code.
I asked jeroen for his sieve patch (to find it out myself) but I havn't got
it so far.
Anyone?
--
Florian Lagg
-
Florian Lagg - IT-Komplettlösungen
Juch 7, 6631 Lermoos
tel +43 (699) 10 20 10 24
www.lagg.at - info(a)lagg.at
-
Xing: http://www.xing.com/go/invite/7372113.3da562
-
_______________________________________________
List info: http://lists.roundcube.net/dev/
I'm curious about the behavior of the spell checker. If HTML is set as the
default editor, then when the compose screen is first opened the spell
check controls don't appear. When editor type is switched to plain text,
the controls appear, but when the editor type is switched back to HTML, the
controls stay put and behave in peculiar ways.
Should the spell checker be active while using the HTML editor?
thanks
-kris
--
Kris Steinhoff
Web/DB Team, Information Technology Central Services
The University of Michigan
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi Raoul,
Thanks for the feedback. At least in svn,
rcmail::get_instance()->config->get('imap_root') will return null if there
is no imap_root configuration variable. So roundcube keeps on ticking.
I'm also uncomfortable using globals the way iloha uses $my_prefs.
However, from what I could see, that's just how iloha works. It looks like
a choice between using some undesirable global variable "action at a
distance" or modifying the iloha's imap library. Modifying iloha wouldn't
be hard, but it looks like developers have avoided putting roundcube
configuration specific code into iloha so far.
Cheers,
Ziba
--
Ziba Scott
Web Application Developer
Web/DB Team, Information Technology Central Services
The University of Michigan
On Tue, 05 Aug 2008 11:21:59 +0200, "Raoul Bhatia [IPAX]"
<r.bhatia(a)ipax.at> wrote:
> hi ziba,
>
> Ziba Scott wrote:
>> Hi,
>> We're testing roundcube in a fairly large environment (80K users, 900K
>> mailboxes) with a cyrus imap backend. In our environment,
>> roundcube/iloha imap's namespace discovery phase takes about 1.5 seconds
>> on an unloaded machine. This happens on every email view.
>>
>> Iloha has the ability to skip the namespace discovery phase if a
>> imap_root is configured and roundcube has a configuration option for
>> imap_root. But the two aren't connected! By handing off the imap_root
>> variable to iloha mail sooner rather than later we cut our time to view
>> a message from 1.7 seconds to 0.2 seconds.
>>
>> I've submitted a patch with this ticket:
>> http://trac.roundcube.net/ticket/1485172
>
> thank you for your patch. i would like to add two things:
>
> 1) if rcmail::get_instance()->config->get('imap_root') gives an empty
> string, the patch renders roundcube unusable.
> (ok, i internally ported the patch back to 0.1.1 - maybe
> rcmail::get_instance()->config->get('imap_root') takes care of that)
>
> 2) normally i am against the usage of globals in such a way. but this is
> better than nothing :) (note: i did not check the iil sourcecode if
> there is a better way to achieve that)
>
> cheers,
> raoul
>
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi A.L.E.C., hi all.
For planning the plugin-architecture I created a todo-list here:
http://www.lagg.at/temp/todo-rc-plugin
You can view and edit the list after login:
Login Name: roundcube
Password: developer
I think this step is necessary to get any needed information (such as: which
actions/hooks should we implement?)
Please do not delete comments of other people, if you dis-like them just add
a note.
I will work out an up-to-date site from time to time.
Because I got some more work this week I will not be able to provide code
this weekend.
I think I can work on the project in two weeks again, so let's define the
19th of August as a deadline for this todo list. Bring in all your ideas
until then.
Read the welcome message on top of the page.
Thanks
--
Florian Lagg
-
Florian Lagg - IT-Komplettlösungen
Juch 7, 6631 Lermoos
tel +43 (699) 10 20 10 24
www.lagg.at - info(a)lagg.at
-
Xing: http://www.xing.com/go/invite/7372113.3da562
-
_______________________________________________
List info: http://lists.roundcube.net/dev/