Hi devs,
I keep having log file polluted by these errors
[03-Jun-2011 15:21:44 +0200]: PHP Error: Could not convert string from GBK
to UTF-8. Make sure iconv/mbstring is
installed or lib/utf8.class is available. in
/var/www/roundcubemail/program/include/main.inc on line 309 (GET
/?_task=mail&_action=show&_mbox=test&_uid=26)
After a long tracking I could identify the mail which is causing this behavior.
I'd prefer to send this mail privately to a dev who can help me to spot
which sequence is triggering these errors.
I'm using RoundCube 0.5.3 base version right now. Thank you.
Mirko
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hello,
this is the updated translation for Lithuanian (lt) language. Please
commit it to the repository.
Regards,
Rimas
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/hg/8FA7pyEr/labels.inchttp://detached.gigo.com/rc/hg/8FA7pyEr/messages.inc
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hi,
I’ve attached updated Swedish localizations of labels.inc and messages.inc.
Regards,
Jonas Nasholm
Bitfuse Network
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/Cq/P0q3DP9T/sv_SE.zip
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
The new spellcheck before send is nice!
Could it be modified to
only check your newly added response on replies-- instead of the entire
thread?
Also, can you make it check the subject?
Thanks!
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hello folks,
We just published a new bugfix release that fixes two important issues
in the IMAP communication which prevented sent messages from being
saved in version 0.5.2.
It's recommended to update all productive installations of Roundcube
with this new release. See http://trac.roundcube.net/wiki/Changelog
for details.
Best regards,
Thomas
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hi,
I've completed translation of the program/localization/hu_HU.
The attached files are made with the translation tool.
Best regards,
Sandor
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/rH/dAj+r3zS/hu_HU.zip
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Dear technical
After searching for a solution so they can read the email without problems
from different samrtphone (iphone, ipad, etc. ..), I developed a small
solution basing on the previous.
I refer to Tricket # 1484680, which appears open a ticket asking for a
solution to the current version.
A larger question, I would join the development team Roundcube, and I've
been working with this application since version 0.2 and I find it amazing
the work they are doing and I can contribute something in their development.
Yours sincerely
Barbara Vergara
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/dx/3TKk15kd/rc_iphone.diff
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hello,
i've found the on last release of the stable 0.5.2 there is a file
corrupted.
The file is program/include/rcmail.php
As you can see, that file is marked as:
$Id: rcmail.php 4626 2011-03-31 12:32:44Z alec $
But in the trac/svn, on the changeset 4626, that file is different.
http://trac.roundcube.net/browser/trunk/roundcubemail/program/include/rcmai…
In the specific two line of code 1077-1078 are shifted to the lines
1196-1197.
That lines was:
if (is_object($this->imap))
$this->imap->close();
That should be inside the "shutdown" function, but instead is inside the
"encrypt"function.
I haven't checked if there is any other file with this problem, but i
hope not.
Best Regards,
--
Andrea Ruisi
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Translation update for European Portuguese (pt_PT).
- labels.inc
Regards,
DC
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/Cx/xsdr9vNv/labels.inc
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hello
Until now the only SASL mechanisms that were available for SMTP
authentication were the one Net-SMTP provided. I just had a patch
accepted in Net-SMTP SVN so that new mechanisms can be added on the fly.
One do this by calling the new method:
$conn->setAuthMethod('METHOD_NAME', array($object, $method));
or, without using object programming:
$conn->setAuthMethod('METHOD_NAME', $callback);
In order to use that in RouncCube, we need a new hook so that plugins
have the opportunity to register their method using
Net_SMTP::setAuthMethod()
Here is the patch that does just that:
http://ftp.espci.fr/shadow/manu/rcube.diff
--
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu(a)netbsd.org
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
I can see a lot of people have been downloading the plugin. There
have been daily changes being made to this so you may want to stay
current on the latest version.
http://roundcubegoogle.sourceforge.net/
[1]
As of rc svn version 4804, no modifications to RoundCube core are
necessary
The latest version just uploaded no longer requires change
to the Zend code.
Drag and drop support is now fully functional.
Only one problem left and anyone able to offer suggestions please
email me at rc [AT] deltatechnicalservices.com
The one known
remaining problem is that if you attempt to drag and drop a large number
of contacts to or from the google_contacts to another database, it can
take some time and there is no notification on screen to let you know
that is in progress.. Just wait until you see the notice on top saying
it is complete. The same is true if you attempt to delete a large number
at one time like 30 or more.
So download, and enjoy and please let me
know if you have any problems or questions.
Links:
------
[1]
http://roundcubegoogle.sourceforge.net/
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Can someone tell me how I can put up a Loading message? I have
tried to do this in a plugin callback but, it doesn't happen until it is
too late.
Specifically, in my google_contacts plugin. If someone
selects a lot of contact like 50 and either clicks delete or drags them
from personal contacts to google contacts this can take some time to
complete like sometimes up to 30 seconds. I need something to indicate
to the user that rc is busy and to wait.
Doing this inside the
contact_create hook or the contact_delete hook causes the loading
message to popup AFTER the job is done and the time has passed.
Does
anyone know how to throw up this loading message at the beginning of the
create or delete action?
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
When doing a drag and drop from one address book to another, the
record value is NULL.
This may be a problem with my code, what I am
doing is fairly simple..
in my init I do this.
$this->add_hook('contact_create', array($this, 'contact_create'));
in my contact_create function I am doing this...
function
contact_create($a){
if( is_null($a['record']) ){
write_log('mylog',$a);
$a['abort'] = true;
return $a;
}
if($a['source'] == $this->abook_id){
$this->put_contact($a);
$a['record']['edit']=$this->results->google_id;
$a['abort'] = false;
}
return $a;
}
And the result I see in the log is...
[May/23/2011
14:18:10 -0700]: array (
'record' => NULL,
'source' =>
'google_contacts',
'group' => NULL,
'abort' => true,
)
I am dragging
from the personal address book to google_contacts when this happens.
Just creating a contact the normal way works fine, it is just when
dragging and dropping.
Can anyone tell me what I might be doing wrong?
Or is there a bug in the drag and drop not passing a record to the
hook?
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
This applies to beta 0.6
For the sake of the plugins that want to
use as much of rcube core as possible and want to sync address books
with other sources, this mod is really needed. I see that plaxo_contacts
also uses this field.
Anyone syncing with an external source needs a
way of keeping track of the id field on the other system. I realize that
kolab_contacts has found a way around this but they also have heavily
modified the way contacts works. We are trying to stay consistent with
the core addressbook by keeping the format exactly the same. We store
the contact data in a separate table which is exactly like the contacts
table. And we let rc core do all the reading and writing to that table
by simply changing the table name for the plugin.
Here is the problem
and the proposed solution...
When using
$CONTACTS->insert($a_record,false); where $a_record['edit'] contains a
value, it works great. rcube core actually puts in X-AB-EDIT into the
vcard and stores that value.
When using the hooks for contact_create
and contact_update, then modifying the $a['record']['edit'] value, it
does NOT work. This is easily fixed by adding one element to the
fieldmap array in rcube_vcard.php
The requested change is to add
'edit' => 'X-AB-EDIT'
This change will not only make it simpler for
the google_contacts plugin, but any future plugin that attempts to sync
with an outside source.
I currently have this plugin working perfectly
and finished, however it is based on the mod that I made in
rcube_vcard.php and I am hoping that you will be willing to make this
change so that everyone else can use this plugin without having to
modify core to make it work.
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
-------- Original Message --------
Hello,
I'm working on a CalDAV backend for my calendar plugin
(http://myroundcube.googlecode.com).
It works quite good with Google's CalDAV but is not tested with other
backends.
So, I'd like to ask if I could get some test accounts on your CalDAV
servers.
Thanks in advance!
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Dear All,
I have installed roundcube with courier-imap. But when I login via email account it shows the blank page.... I have check the error logs which shows the following:
[22-May-2011 15:51:20] PHP Warning: setcookie() expects at most 6 parameters, 7 given in /var/www/html/roundcubemail/program/include/rcmail.php on line 1321
[22-May-2011 15:51:20] PHP Parse error: syntax error, unexpected T_VARIABLE in /var/www/html/roundcubemail/program/lib/Net/IDNA2.php on line 3354
Please help....
Regards,
Salman...
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hello friends of Roundcube
One of our busiest plugin developers, Roland Liebl, is asking for your
help. His bundle of Roundcube plugins at
http://code.google.com/p/myroundcube/ meanwhile contains more than 30
useful extensions and some of them are now seeking new maintainers,
namely the google_contacts and the plaxo_contacts plugins. Both of
them extend the Roundcube address book with additional backends and if
you're familiar with either the Google or Plaxo API and interested in
contributing to our free software please contact him over
http://code.google.com/p/myroundcube/
Have a good one,
Thomas
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
I am new to the list, and new to developing for roundcube so sorry
if I am asking a stupid question.
I am working on the google_contacts
plugin for the 0.6 version. I am having trouble getting all the fields
in the Vcard to save. Specifically I am trying to save the X-AB-EDIT:
field and it never saves yet the rest of the data in my vcard saves just
fine. Here is my code.
First of all, the $vcard variable holds the
entire vcard including the X-AB-EDIT
$vc =
rcube_vcard::import($vcard);
$email = $vc[0]->email[0];
$a_record =
$vc[0]->get_assoc();
$a_record['ab-edit']=$val->edit;
$a_record['vcard']
= $vc[0]->export();
$CONTACTS->update($insert_id[0],$a_record);
it
saves the contents of $vcard perfectly, just not my field X-AB-EDIT: Any
clues why?
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Translation update for European Portuguese (pt_PT).
- labels.inc
Regards,
DC
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/gt/KdRRQP1D/labels.inc
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hello,
I have the following issue:
- I have multiple unread threads
- I select them all
- mark messages as read
- the last thread that's selected will not be marked as read...
This is with roundcube 5.2. Can anyone confirm this?
Kind regards,
Laurens
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hi,
Please update Russian messages.inc
--
Regards,
Nikolay.
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/qg/uEYyxpPt/messages.inc
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Translation update for European Portuguese (pt_PT).
- messages.inc
Regards,
DC
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/b3/WumxRQrd/messages.inc
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hello!
Attached file contains translations for managesieve and
kolab_addressbook plugins.
WBR, Sergey Dukachev mailto:admin@mfitness.ru
---------------------------
IT dept
MFitness
+7 (495) 974 1234 (add. 106)
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/Un/gUwuSH1m/plugins.tar.bz2
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
No change on the users list, maybe the Dev list can help me here ?
Or should I fill a ticket directly ?
Thanks,
Julien
-------- Original Message --------
Subject: [RCU] Corrupted attached PDF files
Date: Mon, 02 May 2011 10:14:56 -0400
From: Julien Vehent <julien(a)linuxwall.info>
To: Users <users(a)lists.roundcube.net>
Hi list,
I have a 0.5.2 running in a small company and users have been
complaining that attached PDF files don't open properly.
I tried to open one of those emails with thunderbird, the PDFs display
properly. But with roundcube, I get a blank page.
I saved both PDFs (from tbird and roundcube) and it appears that the
one from Roundcube is slightly bigger (by 118 bytes):
$ ls -al
-rw-r--r-- 1 jvehent jvehent 11392 May 2 2011 MicroGate chges avril
2011 -rcube.pdf
-rw------- 1 jvehent jvehent 11274 May 2 09:52 MicroGate chges avril
2011 -tbrid.pdf
$ md5sum *
bfb27d3a439fd4d38a2b6d9bcd827582 MicroGate chges avril 2011.pdf
2fd9859443dfa3696b6e86de9fc0b2d2 MicroGate chges avril 2011 -tbrid.pdf
I opened both documents in Vim, and noticed that the one coming from
Roundcube contains trailing "^M" that don't exist in the PDF coming from
Thunderbird (see attached screenshot, the document from roundcube is on
the right).
I observed this behavior in 0.5.1 and upgraded to 0.5.2 without any
change. I tried deactivated ALL the plugins on my instalation, without
any change. So before feeling a bug ticket, I'd like to confirm there is
not already a solution for this.
Thanks,
Julien
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for
viewing.
http://detached.gigo.com/rc/Gq/QXVz95UJ/roundcube_pdf_bugs.png
Only click these links if you trust the sender, as well as this
message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hi, all
here is the translation update for Bahasa Indonesia and
happy weekend for all.
Sincerely,
Sabda
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/r6/muc533TF/messages.inc
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
dear Les
thanks for your feedback!
In RC5.x and below, the addressbook fields are static coded and can not
be changed easily (SQL and LDAP).
The next major release of Roundcube (RC6, I hope soon) will contain the
posibility of configuring a plenty of fileds as you need it.
If you like to test it allready, please check out the SVN code as
described on the RC homepage.
Andreas
On Thu, 05 May 2011 16:33:18 -0800, Les Fenison wrote:
> Thanks for your very helpful howto article on setting up LDAP for
> roundcube.
>
> I have one question.. Currently roundcube is able to see the ldap
> server however, the only addressbook fields are Display-name,
> firstname, lastname, and email. What has to happen to get the
> extended
> fields to show up?
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hi! Here http://194.150.197.210/rc/test.html I'm testing an idea to
provide simpler/faster method for attachments uploading. The idea is to
get rid of our attachment-form popup. The logic is working. The only
issue I have is the cursor style on the button in FF<4 and webkit. Any
ideas what we can do about this?
--
Aleksander 'A.L.E.C' Machniak
LAN Management System Developer [http://lms.org.pl]
Roundcube Webmail Developer [http://roundcube.net]
---------------------------------------------------
PGP: 19359DC1 @@ GG: 2275252 @@ WWW: http://alec.pl
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hello!
Sending an updated slovene translation.
Cheers,
Barbara
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/qr/dVYIlLJH/sl_SI.zip
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hi,
There is a problem with Password plugin's password encryption in Debian
Squeeze. Because of a known bug in Debian's PHP (CRYPT_SALT_LENGTH is
not set*), the password is currently being encrypted with an empty salt
in SQL driver (but I think this might apply to the LDAP driver too,
because it too uses crypt()).
The simple fix is to replace this block of code in drivers/sql.php
(https://svn.roundcube.net/trunk/plugins/password/drivers/sql.php):
$salt = '';
if (CRYPT_MD5) {
$len = rand(3, CRYPT_SALT_LENGTH);
} else if (CRYPT_STD_DES) {
$len = 2;
} else {
return PASSWORD_CRYPT_ERROR;
}
for ($i = 0; $i < $len ; $i++) {
$salt .= chr(rand(ord('.'), ord('z')));
}
$sql = str_replace('%c', $db->quote(crypt($passwd, CRYPT_MD5 ?
'$1$'.$salt.'$' : $salt)), $sql);
with a single line:
$sql = str_replace('%c', $db->quote(crypt($passwd)), $sql);
When called without the second parameter, crypt() will automatically
generate the salt itself. Which makes me wonder: why does the plugin try
to generate this random salt instead of simply relying on PHP to do
that? As far as I know, crypt($text, $salt) is useful when you actually
want to check whether the password is correct, but there's absolutely no
need to use your own random salt when setting user's password – PHP will
take care.
May I suggest to apply this change in SVN? I really don't see why the
plugin should use 12 lines of code to achieve what can be achieved in
one line.
* http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=603012
Regards,
Rimas
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hello list,
I have a patch for the http_authentication plugin. I use http
authentication mainly as protection because I have set
$rcmail_config['default_host'] to '' (host can be chosen
arbitrarily). But with this setting the plugin is not usable! I have
added a configuration option ($rcmail_config['http_authentication_host'])
to make the default host configurable! What do you think?
Greetings,
Johannes Weißl
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/VJ/LNPb0hUc/0001-add-host-config.patch
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hi Devs!
Currently the mail editing area captures the mouse right click and display
options such as
CUT, COPY, PASTE, CREATE TABLE (tinymce cut/copy/paste just works in IE).
I'm planning to remove this right click context menu and move the CREATE
TABLE option
to the toolbar area.
With this change the user would not lose any function and can use the
browser's native
functions which is more user-friendly, such browser spelling checker (the
googiespell used
in RC has few languages) and so on.
By eliminating the tinyMCE plugin CONTEXTMENU we also reduce the size of the
loaded code.
Speaking in codes:
editor.js
- plugins:
'paste,emotions,media,nonbreaking,table,searchreplace,visualchars,directionality,tabfocus,
contextmenu' + ...
+ plugins:
'paste,emotions,media,nonbreaking,table,searchreplace,visualchars,directionality,tabfocus'
+ ...
- theme_advanced_buttons2:
'link,unlink,code,|,emotions,charmap,image,media,|,search' + ...
+ theme_advanced_buttons2: 'link,unlink,code,|,emotions,charmap,image,media,
table,|,search' + ...
Does anyone have any objection about this change?
--
Victor Benincasa
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hi RC Devs,
I'm planning to move the file *roundcube/program/js/*editor.js to the skin
folder
(*roundcube/skins/default/*editor.js) because this file contains several
options
that can be used as skin basis, like the location and order of buttons, the
theme
and skin of TinyMCE editor and so on.
I'm currently developing a skin and missed some control over TinyMCE.
Does anyone have any objection?
--
Victor Benincasa
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hi,
I use (and develop) the skin Groupvice4. I've just upgraded to v0.5.2
and noticed that the buttons for the plugins Archive and MarkAsJunk
have code in the plugin which is skin unaware:
'width' => 32,
'height' => 32,
The cause of the problem are these width and the height values. why
are they added? Can this be fixed?
For now I've removed these values and the buttons show fine.
--
Kees de Keizer
kees(a)de-keizer.net
http://www.de-keizer.net/
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Roundcube developers,
Hi, I'm Jason Ramsey, I've been working with large php applications
for about 10 years now. I currently work as a consultant, and use/have
clients that use Roundcube. I also use Thunderbird extensively with
syncKolab to sync my contacts between multiple systems. I'm interested
in adding syncKolab support to roundcube. So I figured I would
introduce myself and see if anyone on the team is currently working on
such a thing that I could help or collaborate with.
Regards,
Jason Ramsey
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hello everybody,
I created a small plugin, called IdentiTeam.
I post this on these lists because I think it will be very useful for
any company that uses roundcube and an LDAP server for their users'
database.
IdentiTeam automatically creates new users' identities and signatures on
first login, using LDAP entries.
Features:
- Fully customizable HTML or text signatures.
- Read alternate email addresses, from a customisable ldap entry (useful
with eg. Gosa, etc.).
- Automatically detect signatures types (HTML or text) when created.
- You can use custom signatures per domain.
- You can use custom signatures per user.
- Templates folder location is customisable, for instance
'/etc/roundcube/templates'
The license is GPL v3.
Regards,
André Rodier.
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Hi,
I found a little problem with the web interface in program/js/app.js.src:4877
When I use "WebKit Nightly Builds" on "mac os x" the indicator of quota appear in a wrong position. I changed the code and now it's works to me.
I post it in the forum: http://www.roundcubeforum.net/5-release-support/17-pending-issues/8300-prob…
If someone can put it inside the core I'll appreciate.
Tk's
Marcio Trindade
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Thanks for fixing this imediately and for not using
the mailing list.
Your fix http://trac.roundcube.net/changeset/4692
solves the issue.
Nethertheless, I think the script is not too bad.
It saves one useless request to the server.
_________
Maybe that's MySQL related.
I'm faced with 'errorsaving' when I submit
prefs saving request twice and no properties have changed.
The problem is in rcube_user.php ::: line 157 ff.
Looks like ...
$this->db->affected_rows()
... returns false.
Well, I have not investigated why the request
is taken when saving prefs on inialial load while
same request throws the error when hitting save
button without changes of prefs in the same session.
Here is a tiny javascript function to prevent users
saving prefs when there is nothing to save:
var request_saver_form_str = null;
var request_saver_form_initial_str = false;
var request_saver_initial_load = true;
$(document).ready(function(){
function request_saver_form_values(){
var str = $("form").serialize();
if(str != request_saver_form_str){
request_saver_form_str = str;
if(!request_saver_initial_load){
$('#formfooter').show();
}
else{
request_saver_form_initial_str = str;
}
if(str == request_saver_form_initial_str){
$("#formfooter").hide();
}
request_saver_initial_load = false;
}
}
if(rcmail.env.task == 'settings' && rcmail.env.action ==
'edit-prefs'){
$(":checkbox, :radio").click(request_saver_form_values);
$("textarea, input").keypress(request_saver_form_values);
$("select").change(request_saver_form_values);
$("#formfooter").hide();
request_saver_form_values();
}
});
As far as I can see, it works well.
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80
Dear Roundcube users and lovers,
We're happy to announce another release of the Roundcube webmail
suite. This service update brings some more bug fixes and stability
improvements and it includes an updated version of the TinyMCE editor
which is now supposed to work correctly in IE9.
It is considered stable and we recommend to update all existing
Roundcube installation with this release. For a complete list of
changes see http://trac.roundcube.net/wiki/Changelog. Packages can be
downloaded from the usual place: http://roundcube.net/download
Have fun and happy easter,
Thomas
_______________________________________________
List info: http://lists.roundcube.net/dev/
BT/aba52c80