- Dev - Roundcube mailing lists

Re: Resize Preview pane .. With the diff
by David Glick 18 Dec '06

18 Dec '06

Thanks for throwing this up here Ryan. Here's an updated patch (for svn 410) that also works in IE and Opera in addition to Firefox. (Can someone test Safari?) This one also resizes the splitter bar when the window is resized. The setting still isn't saved in user_prefs but I'm sure Ryan will have that working soon... peace, David Glick > I really am batting 1000 today. Here's the diff. Going to bed. > Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 410) +++ program/include/main.inc (working copy) @@ -1277,6 +1277,7 @@ // GENERAL 'loginform' => 'rcmail_login_form', 'username' => 'rcmail_current_username', + 'splitter' => 'rcube_splitter', // MAIL 'mailboxlist' => 'rcmail_mailbox_list', @@ -1912,7 +1913,19 @@ return $select->show($set); } +function rcube_splitter($attrib) + { + global $OUTPUT, $JS_OBJECT_NAME; + + // register splitter in the system + $OUTPUT->add_script(sprintf("%s.register_splitter('%s', '%s', '%s');", + $JS_OBJECT_NAME, + $attrib['first'], + $attrib['second'], + $attrib['orientation'])); + } + /****** debugging functions ********/ Index: program/js/common.js =================================================================== --- program/js/common.js (revision 410) +++ program/js/common.js (working copy) @@ -380,6 +380,187 @@ } +/** + * RoundCube splitter GUI class + * + * @constructor + */ +function rcube_splitter(attrib) + { + this.p1id = attrib.p1; + this.p2id = attrib.p2; + this.id = this.p1id + '_' + this.p2id + '_splitter'; + this.orientation = attrib.orientation; + this.horizontal = (this.orientation == 'horizontal'); + + this.init = function() + { + this.p1 = document.getElementById(this.p1id); + this.p2 = document.getElementById(this.p2id); + + // create and position the handle for this splitter + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + var top = this.p1pos.y + this.p1.offsetHeight; + var height = this.p2pos.y - this.p1pos.y - this.p1.offsetHeight; + var left = this.p1pos.x + this.p1.offsetWidth; + var width = this.p2pos.x - this.p1pos.x - this.p1.offsetWidth; + if (this.horizontal) + this.layer = new rcube_layer(this.id, {x: this.p1pos.x, y: top, height: height, zindex: 1, vis: 1}); + else + this.layer = new rcube_layer(this.id, {x: left, y: this.p1pos.y, width: width, zindex: 1, vis: 1}); + this.elm = this.layer.elm; + this.elm.className = 'splitter'; + if (this.horizontal) + this.elm.style.paddingTop = Math.floor(height / 2) + 'px'; + else + this.elm.style.paddingLeft = Math.floor(width / 2) + 'px'; + + this.line = document.createElement('DIV'); + this.line.className = 'splitterLine'; + if (this.horizontal) + { + this.line.style.borderTopWidth = '1px'; + this.line.style.width = '100%'; + this.line.style.height = '1px'; + } + else + { + this.line.style.borderLeftWidth = '1px'; + this.line.style.width = '1px'; + this.line.style.height = '100%'; + } + + this.elm.appendChild(this.line); + rcube_event.add_listener({element: this.elm, event:'mouseover', object:this, method:'onMouseOver'}); + rcube_event.add_listener({element: this.elm, event:'mouseout', object:this, method:'onMouseOut'}); + + // add the event to start dragging when the handle is pressed + var s = this; + this.elm.onmousedown = function(e){ return s.onDragStart(e); }; + } + + this.onDragStart = function(e) + { + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + + // start listening to mousemove events + rcube_event.add_listener({element:document, event:'mousemove', object:this, method:'onDrag'}); + rcube_event.add_listener({element:document, event:'mouseup', object:this, method:'onDragStop'}); + + // need to listen in any iframe documents too, b/c otherwise the splitter stops moving when we move over an iframe + var iframes = document.getElementsByTagName('IFRAME'); + this.iframe_events = Object(); + for (var n in iframes) + { + var iframedoc = null; + if (iframes[n].contentDocument) + iframedoc = iframes[n].contentDocument; + else if (iframes[n].contentWindow) + iframedoc = iframes[n].contentWindow.document; + else if (iframes[n].document) + iframedoc = iframes[n].document; + if (iframedoc) + { + // I don't use the add_listener function for this one because I need to create closures to fetch + // the position of each iframe when the event is received + var s = this; + var id = iframes[n].id; + this.iframe_events[n] = function(e){ e._rc_pos_offset = rcube_get_object_pos(document.getElementById(id)); return s.onDrag(e); } + if (iframedoc.addEventListener) + iframedoc.addEventListener('mousemove', this.iframe_events[n], false); + else if (iframes[n].attachEvent) + iframedoc.attachEvent('onmousemove', this.iframe_events[n]); + else + iframedoc['onmousemove'] = this.iframe_events[n]; + + rcube_event.add_listener({element:iframedoc, event:'mouseup', object:this, method:'onDragStop'}); + } + } + } + + this.onDrag = function(e) + { + var pos = rcube_event.get_mouse_pos(e); + if (e._rc_pos_offset) + { + pos.x += e._rc_pos_offset.x; + pos.y += e._rc_pos_offset.y; + } + + if (this.horizontal) + { + if (((pos.y - this.layer.height * 1.5) > this.p1pos.y) && ((pos.y + this.layer.height * 1.5) < (this.p2pos.y + this.p2.offsetHeight))) + { + // resize the panels + this.p2.style.top = Math.round(pos.y + this.layer.height / 2 + 1 - (bw.ie ? 10 : 0)) + 'px'; + this.p1.style.height = Math.round(pos.y - this.p1pos.y - this.layer.height / 2 - 1) + 'px'; + + // move the splitter handle + this.layer.move(this.layer.x, Math.round(pos.y - this.layer.height / 2 + 1)); + } + } + else + { + if (((pos.x - this.layer.width * 1.5) > this.p1pos.x) && ((pos.x + this.layer.width * 1.5) < (this.p2pos.x + this.p2.offsetWidth))) + { + this.p1.style.width = Math.round(pos.x - this.p1pos.x - this.layer.width / 2 - 1) + 'px'; + this.p2.style.left = Math.round(pos.x + this.layer.width / 2 + 1) + 'px'; + + this.layer.move(Math.round(pos.x - this.layer.width / 2 + 1), this.layer.y); + } + } + + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + return false; + } + + this.onDragStop = function(e) + { + // cancel the listening for drag events + rcube_event.remove_listener({element:document, event:'mousemove', object:this, method:'onDrag'}); + rcube_event.remove_listener({element:document, event:'mouseup', object:this, method:'onDragStop'}); + var iframes = document.getElementsByTagName('IFRAME'); + for (var n in iframes) + { + var iframedoc; + if (iframes[n].contentDocument) + iframedoc = iframes[n].contentDocument; + else if (iframes[n].contentWindow) + iframedoc = iframes[n].contentWindow.document; + else if (iframes[n].document) + iframedoc = iframes[n].document; + if (iframedoc) + { + if (this.iframe_events[n]) { + if (iframedoc.removeEventListener) + iframedoc.removeEventListener('mousemove', this.iframe_events[n], false); + else if (iframedoc.detachEvent) + iframedoc.detachEvent('onmousemove', this.iframe_events[n]); + else + iframedoc['onmousemove'] = null; + } + + rcube_event.remove_listener({element:iframedoc, event:'mouseup', object:this, method:'onDragStop'}); + } + } + return rcube_event.cancel(e); + } + + // events to make the handle appear when the mouse hovers over it + // (pure CSS doesn't work b/c IE only applies :hover classes to links) + this.onMouseOver = function(e) + { + this.line.style.visibility = 'visible'; + } + this.onMouseOut = function(e) + { + this.line.style.visibility = 'hidden'; + } + } + // check if input is a valid email address // By Cal Henderson <cal(a)iamcal.com> // http://code.iamcal.com/php/rfc822/ Index: program/js/app.js =================================================================== --- program/js/app.js (revision 410) +++ program/js/app.js (working copy) @@ -24,6 +24,7 @@ this.env = new Object(); this.labels = new Object(); this.buttons = new Object(); + this.splitters = new Object(); this.gui_objects = new Object(); this.commands = new Object(); @@ -78,6 +79,13 @@ }; + // add a splitter to the splitter list + this.register_splitter = function(p1, p2, orientation) + { + this.splitters[p1 + '_' + p2] = new rcube_splitter({p1: p1, p2: p2, orientation: orientation}); + } + + // register a specific gui object this.gui_object = function(name, id) { @@ -108,6 +116,10 @@ // enable general commands this.enable_command('logout', 'mail', 'addressbook', 'settings', true); + + // initialize splitters + for (var n in this.splitters) + this.splitters[n].init(); switch (this.task) { Index: skins/default/common.css =================================================================== --- skins/default/common.css (revision 410) +++ skins/default/common.css (working copy) @@ -213,7 +213,21 @@ border: 1px solid #CCCCCC; } +.splitter +{ + position: absolute; + cursor: move; + background: url(images/cleardot.png); +} +.splitterLine +{ + visibility: hidden; + border-color: #ff0000; + border-style: solid; + border-width: 0; +} + /***** common table settings ******/ table.records-table thead tr td Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 410) +++ skins/default/templates/mail.html (working copy) @@ -55,6 +55,7 @@ </div> <roundcube:if condition="config:preview_pane == true" /> +<roundcube:object name="splitter" first="mailcontframe" second="mailpreviewframe" orientation="horizontal" /> <div id="mailpreviewframe"> <roundcube:object name="messagecontentframe" id="messagecontframe" width="100%" height="100%" frameborder="0" src="/watermark.html" /> </div> Index: skins/default/templates/addressbook.html =================================================================== --- skins/default/templates/addressbook.html (revision 410) +++ skins/default/templates/addressbook.html (working copy) @@ -31,6 +31,8 @@ <roundcube:object name="addresslist" id="contacts-table" class="records-table" cellspacing="0" summary="Contacts list" /> </div> +<roundcube:object name="splitter" first="addresslist" second="contacts-box" orientation="vertical" /> + <div id="contacts-box"> <roundcube:object name="addressframe" id="contact-frame" width="100%" height="100%" frameborder="0" src="/watermark.html" /> </div> Index: skins/default/addresses.css =================================================================== --- skins/default/addresses.css (revision 410) +++ skins/default/addresses.css (working copy) @@ -70,10 +70,19 @@ border: 1px solid #999999; overflow: hidden; /* css hack for IE */ - width: expression((parseInt(document.documentElement.clientWidth)-530)+'px'); + width: expression((parseInt(document.documentElement.clientWidth)-80-document.getElementById('addresslist').offsetWidth)+'px'); height: expression((parseInt(document.documentElement.clientHeight)-135)+'px'); } + +#addresslist_contacts-box_splitter +{ + bottom: 40px; + /* css hack for IE */ + height: expression((parseInt(document.documentElement.clientHeight)-135)+'px'); +} + + body.iframe, #contact-frame { Index: skins/default/mail.css =================================================================== --- skins/default/mail.css (revision 410) +++ skins/default/mail.css (working copy) @@ -131,9 +131,16 @@ background-color: #F9F9F9; /* css hack for IE */ width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); - height: expression((parseInt(document.documentElement.clientHeight)-340)+'px'); + height: expression((parseInt(document.documentElement.clientHeight)-130-document.getElementById('mailcontframe').offsetHeight)+'px'); } +#mailcontframe_mailpreviewframe_splitter +{ + right: 40px; + /* css hack for IE */ + width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); +} + #messagecontframe { width: 100%;

4 3

Two patches submitted to trac, kudos on resizable preview pane
by Doug Mandell 18 Dec '06

18 Dec '06

Hi, First, I wanted to say the resizable preview pane works very well in Firefox, thanks for the additional functionality. Second, I've submitted two patches to Trac that I hope one of you would take a look at, they're the patches I previously submitted to the list. One allows a 12 hour clock for emails received today, the other allows tabbing from the message body to the Send button. If I'm doing something wrong please let me know. Thanks, Doug Mandell

1 0

Re: Tool for translations
by Szalma László 18 Dec '06

18 Dec '06

http://translator.roundcube.net/ on the result: ... $messages = array(); $messages[loginfailed] = 'blabla'; ... should be: ... $messages = array(); $messages['loginfailed'] = 'blabla'; ... It doesn't work without the '-s, or at least not in every cases. DB

1 0

Re: Resize Preview pane .. With the diff
by davidig 17 Dec '06

17 Dec '06

Doh ...and here is the same patch, but without it being garbled by newlines. This patch seems to be cursed by poor e-mailing attempts...and/or Ryan and I are dolts. You decide. :) I got smart and sent this one using Roundcube... peace, David > Thanks for throwing this up here Ryan. Here's an updated patch (for > svn 410) that also works in IE and Opera in addition to Firefox. (Can > someone test Safari?) This one also resizes the splitter bar when the > window is resized. The setting still isn't saved in user_prefs but > I'm sure Ryan will have that working soon... > peace, > David Glick Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 410) +++ program/include/main.inc (working copy) @@ -1277,6 +1277,7 @@ // GENERAL 'loginform' => 'rcmail_login_form', 'username' => 'rcmail_current_username', + 'splitter' => 'rcube_splitter', // MAIL 'mailboxlist' => 'rcmail_mailbox_list', @@ -1912,7 +1913,19 @@ return $select->show($set); } +function rcube_splitter($attrib) + { + global $OUTPUT, $JS_OBJECT_NAME; + + // register splitter in the system + $OUTPUT->add_script(sprintf("%s.register_splitter('%s', '%s', '%s');", + $JS_OBJECT_NAME, + $attrib['first'], + $attrib['second'], + $attrib['orientation'])); + } + /****** debugging functions ********/ Index: program/js/common.js =================================================================== --- program/js/common.js (revision 410) +++ program/js/common.js (working copy) @@ -380,6 +380,187 @@ } +/** + * RoundCube splitter GUI class + * + * @constructor + */ +function rcube_splitter(attrib) + { + this.p1id = attrib.p1; + this.p2id = attrib.p2; + this.id = this.p1id + '_' + this.p2id + '_splitter'; + this.orientation = attrib.orientation; + this.horizontal = (this.orientation == 'horizontal'); + + this.init = function() + { + this.p1 = document.getElementById(this.p1id); + this.p2 = document.getElementById(this.p2id); + + // create and position the handle for this splitter + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + var top = this.p1pos.y + this.p1.offsetHeight; + var height = this.p2pos.y - this.p1pos.y - this.p1.offsetHeight; + var left = this.p1pos.x + this.p1.offsetWidth; + var width = this.p2pos.x - this.p1pos.x - this.p1.offsetWidth; + if (this.horizontal) + this.layer = new rcube_layer(this.id, {x: this.p1pos.x, y: top, height: height, zindex: 1, vis: 1}); + else + this.layer = new rcube_layer(this.id, {x: left, y: this.p1pos.y, width: width, zindex: 1, vis: 1}); + this.elm = this.layer.elm; + this.elm.className = 'splitter'; + if (this.horizontal) + this.elm.style.paddingTop = Math.floor(height / 2) + 'px'; + else + this.elm.style.paddingLeft = Math.floor(width / 2) + 'px'; + + this.line = document.createElement('DIV'); + this.line.className = 'splitterLine'; + if (this.horizontal) + { + this.line.style.borderTopWidth = '1px'; + this.line.style.width = '100%'; + this.line.style.height = '1px'; + } + else + { + this.line.style.borderLeftWidth = '1px'; + this.line.style.width = '1px'; + this.line.style.height = '100%'; + } + + this.elm.appendChild(this.line); + rcube_event.add_listener({element: this.elm, event:'mouseover', object:this, method:'onMouseOver'}); + rcube_event.add_listener({element: this.elm, event:'mouseout', object:this, method:'onMouseOut'}); + + // add the event to start dragging when the handle is pressed + var s = this; + this.elm.onmousedown = function(e){ return s.onDragStart(e); }; + } + + this.onDragStart = function(e) + { + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + + // start listening to mousemove events + rcube_event.add_listener({element:document, event:'mousemove', object:this, method:'onDrag'}); + rcube_event.add_listener({element:document, event:'mouseup', object:this, method:'onDragStop'}); + + // need to listen in any iframe documents too, b/c otherwise the splitter stops moving when we move over an iframe + var iframes = document.getElementsByTagName('IFRAME'); + this.iframe_events = Object(); + for (var n in iframes) + { + var iframedoc = null; + if (iframes[n].contentDocument) + iframedoc = iframes[n].contentDocument; + else if (iframes[n].contentWindow) + iframedoc = iframes[n].contentWindow.document; + else if (iframes[n].document) + iframedoc = iframes[n].document; + if (iframedoc) + { + // I don't use the add_listener function for this one because I need to create closures to fetch + // the position of each iframe when the event is received + var s = this; + var id = iframes[n].id; + this.iframe_events[n] = function(e){ e._rc_pos_offset = rcube_get_object_pos(document.getElementById(id)); return s.onDrag(e); } + if (iframedoc.addEventListener) + iframedoc.addEventListener('mousemove', this.iframe_events[n], false); + else if (iframes[n].attachEvent) + iframedoc.attachEvent('onmousemove', this.iframe_events[n]); + else + iframedoc['onmousemove'] = this.iframe_events[n]; + + rcube_event.add_listener({element:iframedoc, event:'mouseup', object:this, method:'onDragStop'}); + } + } + } + + this.onDrag = function(e) + { + var pos = rcube_event.get_mouse_pos(e); + if (e._rc_pos_offset) + { + pos.x += e._rc_pos_offset.x; + pos.y += e._rc_pos_offset.y; + } + + if (this.horizontal) + { + if (((pos.y - this.layer.height * 1.5) > this.p1pos.y) && ((pos.y + this.layer.height * 1.5) < (this.p2pos.y + this.p2.offsetHeight))) + { + // resize the panels + this.p2.style.top = Math.round(pos.y + this.layer.height / 2 + 1 - (bw.ie ? 10 : 0)) + 'px'; + this.p1.style.height = Math.round(pos.y - this.p1pos.y - this.layer.height / 2 - 1) + 'px'; + + // move the splitter handle + this.layer.move(this.layer.x, Math.round(pos.y - this.layer.height / 2 + 1)); + } + } + else + { + if (((pos.x - this.layer.width * 1.5) > this.p1pos.x) && ((pos.x + this.layer.width * 1.5) < (this.p2pos.x + this.p2.offsetWidth))) + { + this.p1.style.width = Math.round(pos.x - this.p1pos.x - this.layer.width / 2 - 1) + 'px'; + this.p2.style.left = Math.round(pos.x + this.layer.width / 2 + 1) + 'px'; + + this.layer.move(Math.round(pos.x - this.layer.width / 2 + 1), this.layer.y); + } + } + + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + return false; + } + + this.onDragStop = function(e) + { + // cancel the listening for drag events + rcube_event.remove_listener({element:document, event:'mousemove', object:this, method:'onDrag'}); + rcube_event.remove_listener({element:document, event:'mouseup', object:this, method:'onDragStop'}); + var iframes = document.getElementsByTagName('IFRAME'); + for (var n in iframes) + { + var iframedoc; + if (iframes[n].contentDocument) + iframedoc = iframes[n].contentDocument; + else if (iframes[n].contentWindow) + iframedoc = iframes[n].contentWindow.document; + else if (iframes[n].document) + iframedoc = iframes[n].document; + if (iframedoc) + { + if (this.iframe_events[n]) { + if (iframedoc.removeEventListener) + iframedoc.removeEventListener('mousemove', this.iframe_events[n], false); + else if (iframedoc.detachEvent) + iframedoc.detachEvent('onmousemove', this.iframe_events[n]); + else + iframedoc['onmousemove'] = null; + } + + rcube_event.remove_listener({element:iframedoc, event:'mouseup', object:this, method:'onDragStop'}); + } + } + return rcube_event.cancel(e); + } + + // events to make the handle appear when the mouse hovers over it + // (pure CSS doesn't work b/c IE only applies :hover classes to links) + this.onMouseOver = function(e) + { + this.line.style.visibility = 'visible'; + } + this.onMouseOut = function(e) + { + this.line.style.visibility = 'hidden'; + } + } + // check if input is a valid email address // By Cal Henderson <cal(a)iamcal.com> // http://code.iamcal.com/php/rfc822/ Index: program/js/app.js =================================================================== --- program/js/app.js (revision 410) +++ program/js/app.js (working copy) @@ -24,6 +24,7 @@ this.env = new Object(); this.labels = new Object(); this.buttons = new Object(); + this.splitters = new Object(); this.gui_objects = new Object(); this.commands = new Object(); @@ -78,6 +79,13 @@ }; + // add a splitter to the splitter list + this.register_splitter = function(p1, p2, orientation) + { + this.splitters[p1 + '_' + p2] = new rcube_splitter({p1: p1, p2: p2, orientation: orientation}); + } + + // register a specific gui object this.gui_object = function(name, id) { @@ -108,6 +116,10 @@ // enable general commands this.enable_command('logout', 'mail', 'addressbook', 'settings', true); + + // initialize splitters + for (var n in this.splitters) + this.splitters[n].init(); switch (this.task) { Index: skins/default/common.css =================================================================== --- skins/default/common.css (revision 410) +++ skins/default/common.css (working copy) @@ -213,7 +213,21 @@ border: 1px solid #CCCCCC; } +.splitter +{ + position: absolute; + cursor: move; + background: url(images/cleardot.png); +} +.splitterLine +{ + visibility: hidden; + border-color: #ff0000; + border-style: solid; + border-width: 0; +} + /***** common table settings ******/ table.records-table thead tr td Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 410) +++ skins/default/templates/mail.html (working copy) @@ -55,6 +55,7 @@ </div> <roundcube:if condition="config:preview_pane == true" /> +<roundcube:object name="splitter" first="mailcontframe" second="mailpreviewframe" orientation="horizontal" /> <div id="mailpreviewframe"> <roundcube:object name="messagecontentframe" id="messagecontframe" width="100%" height="100%" frameborder="0" src="/watermark.html" /> </div> Index: skins/default/templates/addressbook.html =================================================================== --- skins/default/templates/addressbook.html (revision 410) +++ skins/default/templates/addressbook.html (working copy) @@ -31,6 +31,8 @@ <roundcube:object name="addresslist" id="contacts-table" class="records-table" cellspacing="0" summary="Contacts list" /> </div> +<roundcube:object name="splitter" first="addresslist" second="contacts-box" orientation="vertical" /> + <div id="contacts-box"> <roundcube:object name="addressframe" id="contact-frame" width="100%" height="100%" frameborder="0" src="/watermark.html" /> </div> Index: skins/default/addresses.css =================================================================== --- skins/default/addresses.css (revision 410) +++ skins/default/addresses.css (working copy) @@ -70,10 +70,19 @@ border: 1px solid #999999; overflow: hidden; /* css hack for IE */ - width: expression((parseInt(document.documentElement.clientWidth)-530)+'px'); + width: expression((parseInt(document.documentElement.clientWidth)-80-document.getElementById('addresslist').offsetWidth)+'px'); height: expression((parseInt(document.documentElement.clientHeight)-135)+'px'); } + +#addresslist_contacts-box_splitter +{ + bottom: 40px; + /* css hack for IE */ + height: expression((parseInt(document.documentElement.clientHeight)-135)+'px'); +} + + body.iframe, #contact-frame { Index: skins/default/mail.css =================================================================== --- skins/default/mail.css (revision 410) +++ skins/default/mail.css (working copy) @@ -131,9 +131,16 @@ background-color: #F9F9F9; /* css hack for IE */ width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); - height: expression((parseInt(document.documentElement.clientHeight)-340)+'px'); + height: expression((parseInt(document.documentElement.clientHeight)-130-document.getElementById('mailcontframe').offsetHeight)+'px'); } +#mailcontframe_mailpreviewframe_splitter +{ + right: 40px; + /* css hack for IE */ + width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); +} + #messagecontframe { width: 100%;

1 0

Re: Can't double click on address in ldap results (snv)
by Pierre Mauduit 17 Dec '06

17 Dec '06

Hi, > After having taken a look to the sources, it seems to be a difficult > functionality to add : it is working for MySQL addressbook using the id > row, which obviously doesn't have sense with LDAP searches. Finally, RC offers some facilities, and I found a way to code the functionality ; since some people around here are interested in the LDAP search, here is the patch : http://pedrov.kwain.net/~pedrov/rcube/ldapsearchform_410_wcpy.diff Anyway this probably is a temporary patch, since some things are going to change with the rewrite of the LDAP module (no more iframe, etc ...), and it does not really comply with the RC code (must be a better way to do this). -- Pierre

1 0

Can't double click on address in ldap results (snv)
by Ryan Rittenhouse 17 Dec '06

17 Dec '06

Hey all, just noticed that in the svn version after you do an ldap search your can't double click on a result to jump to to compose screen w/ the email address entered. In the current beta release you can. Was this intentionally removed? Any idea how to put it back? -Ryan -- Network Administrator Goshen College (574) 535-7004

2 2

Resize Preview pane .. With the diff
by Ryan Rittenhouse 17 Dec '06

17 Dec '06

I really am batting 1000 today. Here's the diff. Going to bed. -Ryan -- Network Administrator Goshen College (574) 535-7004 =================================================================== --- program/include/main.inc (revision 408) +++ program/include/main.inc (working copy) @@ -1277,6 +1277,7 @@ // GENERAL 'loginform' => 'rcmail_login_form', 'username' => 'rcmail_current_username', + 'splitter' => 'rcube_splitter', // MAIL 'mailboxlist' => 'rcmail_mailbox_list', @@ -1912,7 +1913,19 @@ return $select->show($set); } +function rcube_splitter($attrib) + { + global $OUTPUT, $JS_OBJECT_NAME; + + // register splitter in the system + $OUTPUT->add_script(sprintf("%s.register_splitter('%s', '%s', '%s');", + $JS_OBJECT_NAME, + $attrib['first'], + $attrib['second'], + $attrib['orientation'])); + } + /****** debugging functions ********/ Index: program/js/common.js =================================================================== --- program/js/common.js (revision 408) +++ program/js/common.js (working copy) @@ -380,6 +380,170 @@ } +/** + * RoundCube splitter GUI class + * + * @constructor + */ +function rcube_splitter(attrib) + { + this.p1id = attrib.p1; + this.p2id = attrib.p2; + this.id = this.p1id + '_' + this.p2id + '_splitter'; + this.orientation = attrib.orientation; + this.horizontal = (this.orientation == 'horizontal'); + + this.init = function() + { + this.p1 = document.getElementById(this.p1id); + this.p2 = document.getElementById(this.p2id); + + // create and position the handle for this splitter + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + var top = this.p1pos.y + this.p1.offsetHeight; + var height = this.p2pos.y - this.p1pos.y - this.p1.offsetHeight; + var left = this.p1pos.x + this.p1.offsetWidth; + var width = this.p2pos.x - this.p1pos.x - this.p1.offsetWidth; + if (this.horizontal) + this.layer = new rcube_layer(this.id, {x: this.p1pos.x, y: top, width: this.p1.offsetWidth, height: height, zindex: 1, vis: 1}); + else + this.layer = new rcube_layer(this.id, {x: left, y: this.p1pos.y, width: width, height: this.p1.offsetHeight, zindex: 1, vis: 1}); + this.elm = this.layer.elm; + this.elm.className = 'splitter'; + if (this.horizontal) + this.elm.style.paddingTop = Math.floor(height / 2) + 'px'; + else + this.elm.style.paddingLeft = Math.floor(width / 2) + 'px'; + this.line = document.createElement('DIV'); + this.line.className = 'splitterLine'; + if (this.horizontal) + { + this.line.style.borderTopWidth = '1px'; + this.line.style.width = '100%'; + this.line.style.height = '1px'; + } + else + { + this.line.style.borderLeftWidth = '1px'; + this.line.style.width = '1px'; + this.line.style.height = '100%'; + } + + this.elm.appendChild(this.line); + rcube_event.add_listener({element: this.elm, event:'mouseover', object:this, method:'onMouseOver'}); + rcube_event.add_listener({element: this.elm, event:'mouseout', object:this, method:'onMouseOut'}); + + // add the event to start dragging when the handle is pressed + var s = this; + this.elm.onmousedown = function(e){ return s.onDragStart(e); }; + } + + this.onDragStart = function(e) + { + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + + // start listening to mousemove events + rcube_event.add_listener({element:document, event:'mousemove', object:this, method:'onDrag'}); + rcube_event.add_listener({element:document, event:'mouseup', object:this, method:'onDragStop'}); + + // need to listen in any iframe documents too, b/c otherwise the splitter stops moving when we move over an iframe + var iframes = document.getElementsByTagName('IFRAME'); + this.iframe_events = Object(); + for (var n in iframes) + { + if (iframes[n].contentDocument) + { + // I don't use the add_listener function for this one because I need to create closures to fetch + // the position of each iframe when the event is received + var s = this; + var id = iframes[n].id; + this.iframe_events[n] = function(e){ e._rc_pos_offset = rcube_get_object_pos(document.getElementById(id)); return s.onDrag(e); } + if (iframes[n].contentDocument.addEventListener) + iframes[n].contentDocument.addEventListener('mousemove', this.iframe_events[n], false); + else if (p.element.attachEvent) + iframes[n].contentDocument.attachEvent('onmousemove', this.iframe_events[n]); + else + iframes[n].contentDocument['onmousemove'] = this.iframe_events[n]; + + rcube_event.add_listener({element:iframes[n].contentDocument, event:'mouseup', object:this, method:'onDragStop'}); + } + } + } + + this.onDrag = function(e) + { + var pos = rcube_event.get_mouse_pos(e); + if (e._rc_pos_offset) + { + pos.x += e._rc_pos_offset.x; + pos.y += e._rc_pos_offset.y; + } + + if (this.horizontal) + { + // resize the panels + if (pos.y > this.p1pos.y && pos.y < this.p2pos.y + this.p2.offsetHeight) + { + this.p1.style.height = Math.round(pos.y - this.p1pos.y - this.layer.height / 2 - 1) + 'px'; + this.p2.style.top = Math.round(pos.y + this.layer.height / 2 + 1) + 'px'; + } + // move the splitter handle + this.layer.move(this.layer.x, Math.round(pos.y - this.layer.height / 2 + 1)); + } + else + { + if (pos.x > this.p1pos.x && pos.x < this.p2pos.x + this.p2.offsetWidth) + { + this.p1.style.width = Math.round(pos.x - this.p1pos.x - this.layer.width / 2 - 1) + 'px'; + this.p2.style.left = Math.round(pos.x + this.layer.width / 2 + 1) + 'px'; + } + this.layer.move(Math.round(pos.x - this.layer.width / 2 + 1), this.layer.y); + } + + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + return false; + } + + this.onDragStop = function(e) + { + // cancel the listening for drag events + rcube_event.remove_listener({element:document, event:'mousemove', object:this, method:'onDrag'}); + rcube_event.remove_listener({element:document, event:'mouseup', object:this, method:'onDragStop'}); + var iframes = document.getElementsByTagName('IFRAME'); + for (var n in iframes) + { + if (iframes[n].contentDocument) + { + if (this.iframe_events[n]) { + if (iframes[n].contentDocument.removeEventListener) + iframes[n].contentDocument.removeEventListener('mousemove', this.iframe_events[n], false); + else if (iframes[n].contentDocument.detachEvent) + iframes[n].contentDocument.detachEvent('onmousemove', this.iframe_events[n]); + else + iframes[n].contentDocument['onmousemove'] = null; + } + + rcube_event.remove_listener({element:iframes[n].contentDocument, event:'mouseup', object:this, method:'onDragStop'}); + } + } + return rcube_event.cancel(e); + } + + // events to make the handle appear when the mouse hovers over it + // (pure CSS doesn't work b/c IE only applies :hover classes to links) + this.onMouseOver = function(e) + { + this.line.style.visibility = 'visible'; + } + this.onMouseOut = function(e) + { + this.line.style.visibility = 'hidden'; + } + } + // check if input is a valid email address // By Cal Henderson <cal(a)iamcal.com> // http://code.iamcal.com/php/rfc822/ Index: program/js/app.js =================================================================== --- program/js/app.js (revision 408) +++ program/js/app.js (working copy) @@ -24,6 +24,7 @@ this.env = new Object(); this.labels = new Object(); this.buttons = new Object(); + this.splitters = new Object(); this.gui_objects = new Object(); this.commands = new Object(); @@ -78,6 +79,13 @@ }; + // add a splitter to the splitter list + this.register_splitter = function(p1, p2, orientation) + { + this.splitters[p1 + '_' + p2] = new rcube_splitter({p1: p1, p2: p2, orientation: orientation}); + } + + // register a specific gui object this.gui_object = function(name, id) { @@ -108,6 +116,10 @@ // enable general commands this.enable_command('logout', 'mail', 'addressbook', 'settings', true); + + // initialize splitters + for (var n in this.splitters) + this.splitters[n].init(); switch (this.task) { Index: skins/default/common.css =================================================================== --- skins/default/common.css (revision 408) +++ skins/default/common.css (working copy) @@ -213,7 +213,20 @@ border: 1px solid #CCCCCC; } +.splitter +{ + position: absolute; + cursor: move; +} +.splitterLine +{ + visibility: hidden; + border-color: #ff0000; + border-style: solid; + border-width: 0; +} + /***** common table settings ******/ table.records-table thead tr td Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 408) +++ skins/default/templates/mail.html (working copy) @@ -55,6 +55,7 @@ </div> <roundcube:if condition="config:preview_pane == true" /> +<roundcube:object name="splitter" first="mailcontframe" second="mailpreviewframe" orientation="horizontal" /> <div id="mailpreviewframe"> <roundcube:object name="messagecontentframe" id="messagecontframe" width="100%" height="100%" frameborder="0" src="/watermark.html" /> </div> Index: skins/default/templates/addressbook.html =================================================================== --- skins/default/templates/addressbook.html (revision 408) +++ skins/default/templates/addressbook.html (working copy) @@ -31,6 +31,8 @@ <roundcube:object name="addresslist" id="contacts-table" class="records-table" cellspacing="0" summary="Contacts list" /> </div> +<roundcube:object name="splitter" first="addresslist" second="contacts-box" orientation="vertical" />

2 1

Resize Preview pane .. for real this time
by Ryan Rittenhouse 17 Dec '06

17 Dec '06

For whatever reason, svn diff didnt spit out the diff correctly. Here's the one that works I swear :p -Ryan -- Network Administrator Goshen College (574) 535-7004

1 0

Resizable preview pane!
by Ryan Rittenhouse 17 Dec '06

17 Dec '06

A friend of mine who does development for the Caravel CMS got interested in roundcube yesterday when I was showing him the latest svn. Since I can't program my way out of a soggy paper bag with javascript I asked if he'd take a shot at making the preview pane resize able. A few hour later he threw me this diff that I've just installed and tested. Nifty stuff. I'm working on saving the size of the pane in user preferences but I wanted to get his unmodified code out here for anyone else to use/see. So here's the code to resize the preview pane courtesy of David Glick from the Caravel CMS crew. -Ryan -- Network Administrator Goshen College (574) 535-7004 Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 408) +++ program/include/main.inc (working copy) @@ -1277,6 +1277,7 @@ // GENERAL 'loginform' => 'rcmail_login_form', 'username' => 'rcmail_current_username', + 'splitter' => 'rcube_splitter', // MAIL 'mailboxlist' => 'rcmail_mailbox_list', @@ -1912,7 +1913,19 @@ return $select->show($set); } +function rcube_splitter($attrib) + { + global $OUTPUT, $JS_OBJECT_NAME; + + // register splitter in the system + $OUTPUT->add_script(sprintf("%s.register_splitter('%s', '%s', '%s');", + $JS_OBJECT_NAME, + $attrib['first'], + $attrib['second'], + $attrib['orientation'])); + } + /****** debugging functions ********/ Index: program/js/common.js =================================================================== --- program/js/common.js (revision 408) +++ program/js/common.js (working copy) } +/** + * RoundCube splitter GUI class + * + * @constructor + */ +function rcube_splitter(attrib) + { + this.p1id = attrib.p1; + this.p2id = attrib.p2; + this.id = this.p1id + '_' + this.p2id + '_splitter'; + this.orientation = attrib.orientation; + this.horizontal = (this.orientation == 'horizontal'); + + this.init = function() + { + this.p1 = document.getElementById(this.p1id); + this.p2 = document.getElementById(this.p2id); + + // create and position the handle for this splitter + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + var top = this.p1pos.y + this.p1.offsetHeight; + var height = this.p2pos.y - this.p1pos.y - this.p1.offsetHeight; + var left = this.p1pos.x + this.p1.offsetWidth; + var width = this.p2pos.x - this.p1pos.x - this.p1.offsetWidth; + if (this.horizontal) + this.layer = new rcube_layer(this.id, {x: this.p1pos.x, y: top, width: this.p1.offsetWidth, height: height, zindex: 1, vis: 1}); + else + this.layer = new rcube_layer(this.id, {x: left, y: this.p1pos.y, width: width, height: this.p1.offsetHeight, zindex: 1, vis: 1}); + this.elm = this.layer.elm; + this.elm.className = 'splitter'; + if (this.horizontal) + this.elm.style.paddingTop = Math.floor(height / 2) + 'px'; + else + this.elm.style.paddingLeft = Math.floor(width / 2) + 'px'; + this.line = document.createElement('DIV'); + this.line.className = 'splitterLine'; + if (this.horizontal) + { + this.line.style.borderTopWidth = '1px'; + this.line.style.width = '100%'; + this.line.style.height = '1px'; + } + else + { + this.line.style.borderLeftWidth = '1px'; + this.line.style.width = '1px'; + this.line.style.height = '100%'; + } + + this.elm.appendChild(this.line); + rcube_event.add_listener({element: this.elm, event:'mouseover', object:this, method:'onMouseOver'}); + rcube_event.add_listener({element: this.elm, event:'mouseout', object:this, method:'onMouseOut'}); + + // add the event to start dragging when the handle is pressed + var s = this; + this.elm.onmousedown = function(e){ return s.onDragStart(e); }; + } + + this.onDragStart = function(e) + { + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + + // start listening to mousemove events + rcube_event.add_listener({element:document, event:'mousemove', object:this, method:'onDrag'}); + rcube_event.add_listener({element:document, event:'mouseup', object:this, method:'onDragStop'}); + + // need to listen in any iframe documents too, b/c otherwise the splitter stops moving when we move over an iframe + var iframes = document.getElementsByTagName('IFRAME'); + this.iframe_events = Object(); + for (var n in iframes) + { + if (iframes[n].contentDocument) + { + // I don't use the add_listener function for this one because I need to create closures to fetch + // the position of each iframe when the event is received + var s = this; + var id = iframes[n].id; + this.iframe_events[n] = function(e){ e._rc_pos_offset = rcube_get_object_pos(document.getElementById(id)); return s.onDrag(e); } + if (iframes[n].contentDocument.addEventListener) + iframes[n].contentDocument.addEventListener('mousemove', this.iframe_events[n], false); + else if (p.element.attachEvent) + iframes[n].contentDocument.attachEvent('onmousemove', this.iframe_events[n]); + else + iframes[n].contentDocument['onmousemove'] = this.iframe_events[n]; + + rcube_event.add_listener({element:iframes[n].contentDocument, event:'mouseup', object:this, method:'onDragStop'}); + } + } + } + + this.onDrag = function(e) + { + var pos = rcube_event.get_mouse_pos(e); + if (e._rc_pos_offset) + { + pos.x += e._rc_pos_offset.x; + pos.y += e._rc_pos_offset.y; + } + + if (this.horizontal) + { + // resize the panels + if (pos.y > this.p1pos.y && pos.y < this.p2pos.y + this.p2.offsetHeight) + { + this.p1.style.height = Math.round(pos.y - this.p1pos.y - this.layer.height / 2 - 1) + 'px'; + this.p2.style.top = Math.round(pos.y + this.layer.height / 2 + 1) + 'px'; + } + // move the splitter handle + this.layer.move(this.layer.x, Math.round(pos.y - this.layer.height / 2 + 1)); + } + else + { + if (pos.x > this.p1pos.x && pos.x < this.p2pos.x + this.p2.offsetWidth) + { + this.p1.style.width = Math.round(pos.x - this.p1pos.x - this.layer.width / 2 - 1) + 'px'; + this.p2.style.left = Math.round(pos.x + this.layer.width / 2 + 1) + 'px'; + } + this.layer.move(Math.round(pos.x - this.layer.width / 2 + 1), this.layer.y); + } + + this.p1pos = rcube_get_object_pos(this.p1); + this.p2pos = rcube_get_object_pos(this.p2); + return false; + } + + this.onDragStop = function(e) + { + // cancel the listening for drag events + rcube_event.remove_listener({element:document, event:'mousemove', object:this, method:'onDrag'}); + rcube_event.remove_listener({element:document, event:'mouseup', object:this, method:'onDragStop'}); + var iframes = document.getElementsByTagName('IFRAME'); + for (var n in iframes) + { + if (iframes[n].contentDocument) + { + if (this.iframe_events[n]) { + if (iframes[n].contentDocument.removeEventListener) + iframes[n].contentDocument.removeEventListener('mousemove', this.iframe_events[n], false); + else if (iframes[n].contentDocument.detachEvent) + iframes[n].contentDocument.detachEvent('onmousemove', this.iframe_events[n]); + else + iframes[n].contentDocument['onmousemove'] = null; + } + + rcube_event.remove_listener({element:iframes[n].contentDocument, event:'mouseup', object:this, method:'onDragStop'}); + } + } + return rcube_event.cancel(e); + } + + // events to make the handle appear when the mouse hovers over it + // (pure CSS doesn't work b/c IE only applies :hover classes to links) + this.onMouseOver = function(e) + { + this.line.style.visibility = 'visible'; + } + this.onMouseOut = function(e) + { + this.line.style.visibility = 'hidden'; + } + } + // check if input is a valid email address // By Cal Henderson <cal(a)iamcal.com> // http://code.iamcal.com/php/rfc822/ Index: program/js/app.js =================================================================== --- program/js/app.js (revision 408) +++ program/js/app.js (working copy) @@ -24,6 +24,7 @@ this.env = new Object(); this.labels = new Object(); this.buttons = new Object(); + this.splitters = new Object(); this.gui_objects = new Object(); this.commands = new Object(); @@ -78,6 +79,13 @@ }; + // add a splitter to the splitter list + this.register_splitter = function(p1, p2, orientation) + { + this.splitters[p1 + '_' + p2] = new rcube_splitter({p1: p1, p2: p2, orientation: orientation}); + } + + // register a specific gui object this.gui_object = function(name, id) { @@ -108,6 +116,10 @@ // enable general commands this.enable_command('logout', 'mail', 'addressbook', 'settings', true); + + // initialize splitters + for (var n in this.splitters) + this.splitters[n].init(); switch (this.task) { Index: skins/default/common.css =================================================================== --- skins/default/common.css (revision 408) +++ skins/default/common.css (working copy) @@ -213,7 +213,20 @@ border: 1px solid #CCCCCC; } +.splitter +{ + position: absolute; + cursor: move; +} +.splitterLine +{ + visibility: hidden; + border-color: #ff0000; + border-style: solid; + border-width: 0; +} + /***** common table settings ******/ table.records-table thead tr td Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 408) +++ skins/default/templates/mail.html (working copy) @@ -55,6 +55,7 @@ </div> <roundcube:if condition="config:preview_pane == true" /> +<roundcube:object name="splitter" first="mailcontframe" second="mailpreviewframe" orientation="horizontal" /> <div id="mailpreviewframe"> <roundcube:object name="messagecontentframe" id="messagecontframe" width="100%" height="100%" frameborder="0" src="/watermark.html" /> </div> Index: skins/default/templates/addressbook.html =================================================================== --- skins/default/templates/addressbook.html (revision 408) +++ skins/default/templates/addressbook.html (working copy) @@ -31,6 +31,8 @@ <roundcube:object name="addresslist" id="contacts-table" class="records-table" cellspacing="0" summary="Contacts list" /> </div> +<roundcube:object name="splitter" first="addresslist" second="contacts-box" orientation="vertical" /> + <div id="contacts-box"> <roundcube:object name="addressframe" id="contact-frame" width="100%" height="100%" frameborder="0" src="/watermark.html" /> </div>

1 1

Quota display
by Robin Elfrink 16 Dec '06

16 Dec '06

Hi, When a message is deleted in the main page, the quota display does not get updated correctly. This patch fixes that. It's a fairly large patch for such a small problem, but that's because the object gets created by the php code on page retrieval. Please comment, and see if I overlooked something. Robin Index: program/js/app.js =================================================================== --- program/js/app.js (revision 408) +++ program/js/app.js (working copy) @@ -3025,10 +3025,14 @@ }; // replace content of quota display - this.set_quota = function(text) + this.set_quota = function() { - if (this.gui_objects.quotadisplay) - this.gui_objects.quotadisplay.innerHTML = text; + if (this.gui_objects.quotadisplay && + this.gui_objects.quotadisplay.attributes.getNamedItem('display') && + this.gui_objects.quotadisplay.attributes.getNamedItem('id')) + this.http_request('quotadisplay', '_display='+ + this.gui_objects.quotadisplay.attributes.getNamedItem('display').nodeValue+ + '&_id='+this.gui_objects.quotadisplay.attributes.getNamedItem('id').nodeValue, false); }; Index: program/steps/mail/quotadisplay.inc =================================================================== --- program/steps/mail/quotadisplay.inc (revision 0) +++ program/steps/mail/quotadisplay.inc (revision 0) @@ -0,0 +1,29 @@ +<?php + +/* + +-----------------------------------------------------------------------+ + | program/steps/mail/quotadisplay.inc | + | | + | This file is part of the RoundCube Webmail client | + | Copyright (C) 2005, RoundCube Dev. - Switzerland | + | Licensed under the GNU GPL | + | | + | PURPOSE: | + | Remote call to return the quota image or text | + | | + +-----------------------------------------------------------------------+ + | Author: Robin Elfrink <robin(a)15augustus.nl> | + +-----------------------------------------------------------------------+ + + $Id: $ + +*/ + +$display = isset($_GET['_display']) ? $_GET['_display'] : 'text'; +$id = isset($_GET['_id']) ? $_GET['_id'] : 'rcmquotadisplay'; +$quota = rcmail_quota_content($display); +$command = sprintf("this.gui_objects.%s.innerHTML = '%s';\n", $id, $quota); +rcube_remote_response($command); + +exit; +?> Index: program/steps/mail/func.inc =================================================================== --- program/steps/mail/func.inc (revision 408) +++ program/steps/mail/func.inc (working copy) @@ -634,7 +634,7 @@ function rcmail_quota_display($attrib) { - global $IMAP, $OUTPUT, $JS_OBJECT_NAME, $COMM_PATH; + global $OUTPUT, $JS_OBJECT_NAME, $COMM_PATH; if (!$attrib['id']) $attrib['id'] = 'rcmquotadisplay'; @@ -642,8 +642,19 @@ $OUTPUT->add_script(sprintf("%s.gui_object('quotadisplay', '%s');", $JS_OBJECT_NAME, $attrib['id'])); // allow the following attributes to be added to the <span> tag - $attrib_str = create_attrib_string($attrib, array('style', 'class', 'id')); + $attrib_str = create_attrib_string($attrib, array('style', 'class', 'id', 'display')); + $out = '<span' . $attrib_str . '>'; + $out .= rcmail_quota_content($attrib['display']); + $out .= '</span>'; + return $out; + } + + +function rcmail_quota_content($display) + { + global $IMAP, $COMM_PATH; + if (!$IMAP->get_capability('QUOTA')) $quota_text = rcube_label('unknown'); else if ($quota = $IMAP->get_quota()) @@ -654,9 +665,9 @@ $quota["percent"]); // show quota as image (by Brett Patterson) - if ($attrib['display'] == 'image' && function_exists('imagegif')) + if ($display == 'image' && function_exists('imagegif')) { - $attrib += array('width' => 100, 'height' => 14); + $attrib = array('width' => 100, 'height' => 14); $quota_text = sprintf('<img src="%s&_action=quotaimg&u=%s&q=%d&w=%d&h=%d" width="%d" height="%d" alt="%s" title="%s / %s" />', $COMM_PATH, $quota['used'], $quota['total'], @@ -669,12 +680,8 @@ } else $quota_text = rcube_label('unlimited'); - - $out = '<span' . $attrib_str . '>'; - $out .= $quota_text; - $out .= '</span>'; - return $out; + return $quota_text; } Index: index.php =================================================================== --- index.php (revision 408) +++ index.php (working copy) @@ -314,7 +314,10 @@ if ($_action=='quotaimg') include('program/steps/mail/quotaimg.inc'); + if ($_action=='quotadisplay') + include('program/steps/mail/quotadisplay.inc'); + // make sure the message count is refreshed $IMAP->messagecount($_SESSION['mbox'], 'ALL', TRUE); }

1 0

Next release
by Robin Elfrink 15 Dec '06

15 Dec '06

Thomas, Do you have a list with tickets that you want closed before the next release? Robin

4 4

Changing the size of the preview pane...
by Ryan Rittenhouse 14 Dec '06

14 Dec '06

Hey all, I've been bumbling around in the source for roundcube most of the day, tweaking bits of it to work with our crazy setup and people here, but I haven't been able to find where the size of the preview pane gets set. Back when it was patched in it was fairly easy to locate but now I just seem to be wondering around in circles. Is anyone able to tell me where I can change it at? Ideally to make it user configurable but either way I'd like to know :p. -Ryan -- Network Administrator Goshen College (574) 535-7004

1 1

Launched new Mailserver wit Roundcube als Webmail Client
by Stefan Novak 14 Dec '06

14 Dec '06

We have launched a mail cluster system for about 20,000 customers with Roundcube as webmail client. I want to thank all of the delevopers for the great stuff you made. Roundcube Webmail is one of the best I found, because it's fast, does not have millions of options and is very very user friendly... It is running at the Internet Service Provider Bnet in Austria (http://www.bnet.at). greetings, Stefan

1 0

HTML composition windows Ticket #1484158
by Ryan Rittenhouse 14 Dec '06

14 Dec '06

Dont know if anyone else has had this problem but if you click on the HTML radio button in the lower right of the compose window a few times you'll get a bunch of (smaller) compose windows. Changing the button attribute from onclick to onchange fixes it. Dinky diff attached. -Ryan -- Network Administrator Goshen College (574) 535-7004 Index: program/steps/mail/compose.inc =================================================================== --- program/steps/mail/compose.inc (revision 404) +++ program/steps/mail/compose.inc (working copy) @@ -814,7 +815,7 @@ $selector = ''; $attrib['name'] = '_editorSelect'; - $attrib['onclick'] = 'return rcmail_toggle_editor(this)'; + $attrib['onchange'] = 'return rcmail_toggle_editor(this)'; foreach ($choices as $value => $text) { $checked = '';

1 0

LDAP auto-completion tweaks ...
by Ryan Rittenhouse 14 Dec '06

14 Dec '06

I've got a bunch of students that opt to use the svn of roundcube (after I make sure there are not huge bugs) and was threatened with certain death if I didn't patch it to use LDAP auto-completion. Since I've parked it in a pseudo-production environment and it has the potential to annoy people, I've added an option on the user settings to enable/disable this. I also discovered that it will not auto-complete unless you have at least one entry in your address book so I changed that as well. I've included the diff that has the original additions as well as my own as a rough and ready patch for anyone wanting to run this. -Ryan Rittenhouse -- Network Administrator Goshen College (574) 535-7004 Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 404) +++ program/localization/en_US/labels.inc (working copy) @@ -216,6 +216,7 @@ $labels['htmleditor'] = 'Compose HTML messages'; $labels['htmlsignature'] = 'HTML signature'; $labels['previewpane'] = 'Show preview pane'; +$labels['ldapcomplete'] = 'Auto-Complete Addresses from Ldap (directory)'; $labels['autosavedraft'] = 'Automatically save draft'; $labels['everynminutes'] = 'every $n minutes'; Index: program/steps/settings/func.inc =================================================================== --- program/steps/settings/func.inc (revision 404) +++ program/steps/settings/func.inc (working copy) @@ -178,6 +178,14 @@ rep_specialchars_output(rcube_label('previewpane')), $input_preview->show($CONFIG['preview_pane']?1:0)); } + + //show config for ldap auto completion + $field_id = 'rcmfd_ldapcomplete'; + $input_preview = new checkbox(array('name' => '_ldap_complete', 'id' => $field_id, 'value' => 1)); + $out .= sprintf("<tr><td class=\"title\"><label for=\"%s\">%s</label></td><td>%s</td></tr>\n", + $field_id, + rep_specialchars_output(rcube_label('ldapcomplete')), + $input_preview->show($CONFIG['ldap_complete']?1:0)); if (!empty($CONFIG['drafts_mbox']) && !isset($no_override['preview_pane'])) { Index: program/steps/settings/save_prefs.inc =================================================================== --- program/steps/settings/save_prefs.inc (revision 404) +++ program/steps/settings/save_prefs.inc (working copy) @@ -27,6 +27,7 @@ 'prefer_html' => isset($_POST['_prefer_html']) ? TRUE : FALSE, 'htmleditor' => isset($_POST['_htmleditor']) ? TRUE : FALSE, 'preview_pane' => isset($_POST['_preview_pane']) ? TRUE : FALSE, + 'ldap_complete' => isset($_POST['_ldap_complete']) ? TRUE : FALSE, 'draft_autosave' => isset($_POST['_draft_autosave']) ? intval($_POST['_draft_autosave']) : 0 ); Index: program/steps/mail/compose.inc =================================================================== --- program/steps/mail/compose.inc (revision 404) +++ program/steps/mail/compose.inc (working copy) @@ -20,6 +20,7 @@ */ require_once('Mail/mimeDecode.php'); +require_once('include/rcube_ldap.inc'); require_once('lib/html2text.inc'); // define constants for message compose mode @@ -887,16 +888,53 @@ FROM ".get_table_name('contacts')." WHERE user_id=? AND del<>1",$_SESSION['user_id']); -if ($DB->num_rows($sql_result)) +if ($DB->num_rows($sql_result) || $CONFIG['ldap_complete']) { $a_contacts = array(); while ($sql_arr = $DB->fetch_assoc($sql_result)) if ($sql_arr['email']) $a_contacts[] = format_email_recipient($sql_arr['email'], rep_specialchars_output($sql_arr['name'], 'js')); - - $OUTPUT->add_script(sprintf("$JS_OBJECT_NAME.set_env('contacts', %s);", array2js($a_contacts))); + + /* LDAP autocompletion */ + if($CONFIG['ldap_complete']) foreach ($CONFIG['ldap_public'] as $ldapserv_config) + { + /* we need fuzzy search enabled */ + if ($ldapserv_config['fuzzy_search'] != 1) + continue; + + $mail_field = $ldapserv_config['mail_field']; + $name_field = $ldapserv_config['name_field']; + + $cLdap = new rcube_ldap(); + + $cLdap->connect ($ldapserv_config['hosts'], + $ldapserv_config['port'], + 3, + $ldapserv_config['dn'], + $ldapserv_config['password']); + + + + $results = $cLdap->search ($ldapserv_config['base_dn'], + $name_field."=*", + array($mail_field, $name_field), + $ldapserv_config['scope']); + + for ($i = 0 ; $i < $results['count'] ; $i++) + { + $mail = $results[$i][$mail_field]; + $name = $results[$i][$name_field][0]; + + for ($j = 0 ; $j < $mail['count'] ; $j++) + $a_contacts[] = format_email_recipient($mail[$j], + $name); + } + $cLdap->close (); } + $OUTPUT->add_script(sprintf("$JS_OBJECT_NAME.set_env('contacts', %s);", array2js($a_contacts))); +} + parse_template('compose'); ?>

1 0

LDAP auto-completion (ticket #1483899)
by Pierre Mauduit 14 Dec '06

14 Dec '06

Hi, Since some people seem to be interested in LDAP autocompletion feature, (http://trac.roundcube.net/trac.cgi/ticket/1483899) I coded it on my RC copy. I tried it, and it looks like working ; (I permit myself to join the patch to this mail, because it is not really huge). By the way, my current RC copy begins to be slightly different from the svn copy. So it will be great if some LDAP users could give some feedbacks. In addition, a main problem of this code is that it could certainly slow the generations of the pages in some cases. (I have less than 20 contacts on my LDAP, but what if there was more than a thousand ?). best regards, -- Pierre

4 4

About some features / enhancements
by Pierre Mauduit 13 Dec '06

13 Dec '06

Hello, As far as I dive into the RC code, i have been trying to add some features to my RC copy, and I'd like to give some remarks about this great webmail project. - Autocompletion : When I worked on LDAP autocompletion support (around 1st of december), I figured out that all contacts were added to a big javascript array. Why not making XMLHttpRequests to a page that returns the autocompletion, when 4 ou more / less caracters are given ? I think it could improve performances in case of users handling thousands of contacts into their addressbook. I did'nt look the code toroughly, and don't know if it is really possible. - Message threads : For my personal javascript culture, I began to code something like threaded mails view (ticket #1424907). It's just a begin for the moment, see here if you're curious enough : http://pedrov.kwain.net/~pedrov/rcube/mail_toggle/toggle.html Anyway, I'm not sure that it's RC compliant (I could not use a table to show messages), and I'm still a beginner in Javascript language. Does anybody here has begun to code anything about this ticket ? (I'd like to know if i'm wrong) - French translation : Thanks Thomas, for having commited french language modifications ! just one remark : we (Aurélien and I) prefer to translate "junk" into "indésirables" ;-) - LDAP support : I read in the list archives, that the public ldap search has to be rewritten completely (http://lists.roundcube.net/mail-archive/roundcube.dev/2006/09/136/) Does anyone has more info about it ? Can I help ? best regards, -- pierre

2 1

"Sender" field empty
by Michael Bueker 13 Dec '06

13 Dec '06

Hi, in the latest SVN of roundcube, I can't send any mail because the "Sender" selection box in the Write Mail dialog is empty. I have tried re-creating my identity, but that didn't help. I am using a config file that worked a few SVN revisions back, and I have properly adjusted it to the latest .dist config file. I would hate to have to re-create my roundcube user (in fact, I don't even know how to delete my old one). ~Mik -- Blessed are the geek.

3 3

Tool for translations
by Robin Elfrink 12 Dec '06

12 Dec '06

Hi, I wrote a small thingy to help in translating RoundCube. This is not intended to be added to RoundCube, just a little helpful tool. Place the attached translate.php in ./program/localization, and point your browser to '<your-RC-URL>/program/localization/translate.php?language=<your-language>' . Example in my case: http://eddy.introweb.nl/roundcubemail/program/localization/translate.php?la… The output is copy&pasteable to the files labels.inc and messages.inc, and untranslated labels and messages will show in red. Robin

5 8

Printed message
by Robin Elfrink 11 Dec '06

11 Dec '06

Hi, Quoted text is not shown on a printed message, except for a bit of padding on the left. This small patch adds a grey border to the left. I'm not quite sure about the grey-levels, but if nobody objects I'll commit this today. Robin Index: skins/default/print.css =================================================================== --- skins/default/print.css (revision 392) +++ skins/default/print.css (working copy) @@ -109,3 +109,23 @@ padding: 0; font-size: 9pt; } + +div.message-part blockquote +{ + color: #444; + border-left: 2px solid #444; + margin: 0.5em 0px 0.5em 0px; + padding: 0px 0px 0px 1em; +} + +div.message-part blockquote blockquote +{ + color: #666; + border-left: 2px solid #666; +} + +div.message-part blockquote blockquote blockquote +{ + color: #888; + border-left: 2px solid #888; +}

2 7

Patch to allow 12 hour date to display for emails sent today.
by dmandell 09 Dec '06

09 Dec '06

Hi again, I'm an American and prefer to use a 12 hour time display (i.e. 1:05pm) rather than a 24 hour clock (13:05). Currently Roundcube allows 12 hour time displays for messages older than one day, but for messages received today it still uses the 24 hour display. The following patch creates a preference for today's date (called date_today) in main.php.inc and then edits main.inc to use it. Again, if I'm doing this wrong please let me know. Thanks, Doug Index: roundcubemail/config/main.inc.php.dist =================================================================== --- roundcubemail/config/main.inc.php.dist (revision 400) +++ roundcubemail/config/main.inc.php.dist (working copy) @@ -107,6 +107,9 @@ // the default locale setting $rcmail_config['locale_string'] = 'en'; +// use this format for today's date display +$rcmail_config['date_today'] = 'H:i'; + // use this format for short date display $rcmail_config['date_short'] = 'D H:i'; Index: roundcubemail/program/include/main.inc =================================================================== --- roundcubemail/program/include/main.inc (revision 400) +++ roundcubemail/program/include/main.inc (working copy) @@ -1687,7 +1687,7 @@ // define date format depending on current time if ($CONFIG['prettydate'] && !$format && $timestamp > $today_limit) - return sprintf('%s %s', rcube_label('today'), date('H:i', $timestamp)); + return sprintf('%s %s', rcube_label('today'), date($CONFIG['date_short'] ? $CONFIG['date_today'] : 'H:i', $timestamp)); else if ($CONFIG['prettydate'] && !$format && $timestamp > $week_limit) $format = $CONFIG['date_short'] ? $CONFIG['date_short'] : 'D H:i'; else if (!$format)

1 0

patch for tabindex on send button (compose email page)
by dmandell 09 Dec '06

09 Dec '06

Hi all, I prefer to use keyboard navigation whenever possible. RC currently allows tabbing between recipient, subject and body, but the send button doesn't allow tabindex. In other webmail applications (yahoo, gmail, etc) send is next after tab, and it's quite convenient that way. I'm assuming you didn't purposely make it difficult to tab to the Send button, so I've created a patch for your approval. Below is a patch that allows tabindex in buttons and makes "Send" and "Cancel" next in the tab order after the email body. Please let me know if I'm not submitting the patch right or if you have any issues. Thanks a bunch, Doug Index: roundcubemail/program/include/main.inc =================================================================== --- roundcubemail/program/include/main.inc (revision 400) +++ roundcubemail/program/include/main.inc (working copy) @@ -1501,7 +1501,7 @@ if ($attrib['label']) $attrib['value'] = $attrib['label']; - $attrib_str = create_attrib_string($attrib, array('type', 'value', 'onclick', 'id', 'class', '$ + $attrib_str = create_attrib_string($attrib, array('type', 'value', 'onclick', 'id', 'class', '$ $out = sprintf('<input%s disabled />', $attrib_str); } Index: roundcubemail/skins/default/templates/compose.html =================================================================== --- roundcubemail/skins/default/templates/compose.html (revision 400) +++ roundcubemail/skins/default/templates/compose.html (working copy) @@ -100,15 +100,15 @@ <table border="0" cellspacing="0" width="100%" summary=""><tbody><tr> <td> -<roundcube:button type="input" command="send" class="button" label="sendmessage" /> -<roundcube:button type="input" command="list" class="button" label="cancel" /> +<roundcube:button type="input" command="send" class="button" label="sendmessage" tabindex="8" /> +<roundcube:button type="input" command="list" class="button" label="cancel" tabindex="9" /> </td> <td align="right"> -<roundcube:label name="charset" />: <roundcube:object name="charsetSelector" tabindex="8" /> +<roundcube:label name="charset" />: <roundcube:object name="charsetSelector" tabindex="10" /> </td> <td align="right"> <roundcube:label name="editortype" />: </td> -<roundcube:object name="editorSelector" tabindex="9" /> +<roundcube:object name="editorSelector" tabindex="11" /> </tr></tbody></table> </td>

1 0

[Fwd: Re: Printed message]
by Robin Elfrink 08 Dec '06

08 Dec '06

Ryan: Please reply to the lest next time, while I'll try to instruct my mail-client. -------- Original Message -------- Subject: Re: Printed message Date: Thu, 07 Dec 2006 10:41:59 -0500 From: Ryan Rittenhouse <ryanmr(a)goshen.edu> To: Robin Elfrink <elfrink(a)introweb.nl> References: <4573FC24.3050400(a)introweb.nl> <4573FFF6.8090205(a)gmail.com> <457401F3.4050601(a)introweb.nl> <457404FC.4000302(a)gmail.com> <4576AFC5.3080703(a)introweb.nl> <4576B620.1020902(a)gmail.com> <45782497.9000401(a)introweb.nl> <45782C43.7000208(a)cantella.com> <45782ECF.7050306(a)introweb.nl> Robin Elfrink wrote: > How about a user-configurable option then? Or would the settings get > cluttered too much? I like the idea of user-configurable. I think it'll be a while before the settings list starts getting cluttered. Ever see the one for Ilohamail? ;p -Ryan Rittenhouse Network Administrator Goshen College ryanmr(a)goshen.edu (574) 535-7004

1 0

[Fwd: Re: Printed message]
by Robin Elfrink 08 Dec '06

08 Dec '06

Pierre: Please reply to the lest next time, while I'll try to instruct my mail-client. -------- Original Message -------- Subject: Re: Printed message Date: Thu, 7 Dec 2006 16:30:54 +0100 From: Pierre Mauduit <pierre.mauduit(a)gmail.com> To: Robin Elfrink <elfrink(a)introweb.nl> References: <45782ECF.7050306(a)introweb.nl> Hi, > How about a user-configurable option then? > I think it is the best solution to get everybody happy with this :-) -- pierre

1 0

Re: Printed message
by Robin Elfrink 08 Dec '06

08 Dec '06

Chris Richardson wrote: > personally i prefer greyscale of print screens for the simple fact that > a lot of office brand printers are not color and faxes are not color. How about a user-configurable option then? Or would the settings get cluttered too much? Robin

1 0

French translation [Was Re: Tool for translations]
by Pierre Mauduit 07 Dec '06

07 Dec '06

Hi, nice work on the translation tool ! I tried it with the french language, so here's my result : http://pedrov.kwain.net/~pedrov/rcube/rcube_trans.txt By the way, I think - and all french folks would probably agree - that a better translation for "Junk mail" is the french term "Pourriel", since "A trier" means "to sort" in french. best regards, -- pierre

2 2

Problem when loging in.
by Tommy Lindström 06 Dec '06

06 Dec '06

Hi! I have a problem when I want to login from the web with roundcube. Everything looks fine in the imaplog and no errors are reported in the logdir of roundcube. I have set full debugging on. And my imapserver is cyrus. And both cyrus and roundcube are on the same server. When I login i get this message. "* CAPABILITY IMAP4 IMAP4rev1 ACL QUOTA LITERAL+ NAMESPACE UIDPLUS X-NON-HIERARCHICAL-RENAME NO_ATOMIC_RENAME UNSELECT X-NETSCAPE cp01 OK Completed Tried PLAIN: Resource id #32" Followed by a "Login Failed". Any help is appriciated.. thanks! PS. My setup works fine with ex. outlook. // Tommy

2 1

Security: Why is user password stored in session?
by Stefan Rompf 06 Dec '06

06 Dec '06

Hi, I've just installed Roundcubemail on my server to replace another webmail package. First impression: Very nice work! However, I'm one of those who at least try to review the software they use, and there is one thing that really caught my eye: The user password is stored in the PHP session. I think authentication data should be end to end data, especially if you're running Roundcubemail over https as you should. The attached, slightly tested patch moves the password from the session into a browser cookie. Thoughts? Stefan

8 10

dragging messages while checking for new messages broken
by Jason 05 Dec '06

05 Dec '06

I was having this problem, then finially upgraded to revision 361, but I'm still seeing it. If I'm in my inbox, and I try to click and drag a message over to another folder it works normally, but not while the periodic "checking for new messages" message is at the top of the page. I searched the trac tickets and the mailing list and didn't find anything. Is anyone else having this problem? Is there a way to fix it?

1 1

conditional objects in templates
by Edgar Bueltemeyer 03 Dec '06

03 Dec '06

Hello, i would like to make following proposal to the conditional objects in templates: Its rather flexible and supports normal variables and Session-vars..... in the template file: <roundcube:button command="print" imageSel="/images/buttons/ print_sel.png" imageAct="/images/buttons/print_act.png" imagePas="/ images/buttons/print_pas.png" width="32" height="32" title="printmessage" condition="session:username:test"/> </div> in main.inc: function rcube_xml_command($command, $str_attrib, $add_attrib=array()) { global $IMAP, $CONFIG, $OUTPUT; $command = strtolower($command); $attrib = parse_attrib_string($str_attrib) + $add_attrib; //check if tag is conditional if($attrib['condition']) { $condition=explode(':',$attrib['condition']); $logmesg="condition:".$condition[0].'='.print_array($condition); //console($logmesg); if(strpos($condition[2],',')) $condition_array=explode(',', $condition[2]); else $condition_array=array(0=>$condition[2]); switch ($condition[0]) { case 'session': // if sesion var is not set -> switch off command if(!in_array($_SESSION[$condition[1]],$condition_array)) $command='none'; break; default: if(!$condition[0]==$condition[1])) $command='none'; // condition is not handled -> switch off command break; } } Regards!

3 5

A bug to report, and roundcubeforums down?
by Doug Mandell 03 Dec '06

03 Dec '06

Hi all, I wanted to log a bug on roundcubeforums.net but it looks like there's some sort of database error (it's been this way all day), so I'm going to report it here while I'm letting you know that that site's down. The bug: If I reply to an HTML email in plain text the quoted text doesn't get wrapped properly; occasionally a word will appear on a line by itself when there wasn't a line break. If I reply to an html email in HTML the text gets wrapped properly, and if I reply to a plain text email in plain text it works too. If necessary I can supply you with a snippet of text that causes the problem. I'm currently using revision 380, I'm pretty sure I noticed this in 361 also. If you need any more info from me please let me know, and if there's somewhere else I should be submitting bugs you can let me know that too. Thanks, Doug

3 2

Re: Conditional HTML and preview pane
by dmandell 29 Nov '06

29 Nov '06

I thought Robin and everybody else would like to know that I've been using the preview pane for the last few days in R380 in Firefox, and to a lesser extent IE7, with great results. Hopefully Robin will consider checking this code in so that it will get included with the next release. Thanks, Doug Mandell

2 1

(no subject)
by Kiril Dimeski 29 Nov '06

29 Nov '06

Hello, First > Sorry about my language, maybe I will make some mistakes in my e-mail. I'm web developer and I've heard about your webmail project, I've seen the screens and I've loved in it. But the main problem is, in your localisation packs there isn't Macedonian. I like to help you and change the language in Macedonian. Can you help me? Just send me the name of the software, with I can change the language. Thanks ----------------------------------- Kiril Dimeski Prilep WWW.SKORPION.ORG.MK WWW.TARATUR.COM WWW.FAUNA-SHOP.TK ------------------------------------

5 8

Time off by one hour
by Jason Dixon 27 Nov '06

27 Nov '06

RC is showing all messages with timestamps one hour fast. If I change my timezone to GMT -0600, it looks correct. I've tried turning the various main.inc.php knobs (timezone, dst_active), but they have no effect. I see this behavior on three different versions of RC, all on (mostly) different platforms: svn-373, OpenBSD 4.0 -stable svn-297, OpenBSD 3.7 svn-297, CentOS 3.8 It's entirely possible this is a sysadmin error, but I can't duplicate with Squirrelmail. Any ideas? Thanks, -- Jason Dixon DixonGroup Consulting http://www.dixongroup.net

2 3

Re: Delete open email button in svn 380
by Martin Marques 24 Nov '06

24 Nov '06

On Wed, 22 Nov 2006 08:17:45 -0600, Matt Kaatman <roundcube-dev(a)matt.kaatman.com> wrote: > Do we have any goals before we release the next beta? > > Maybe a feature freeze is in order to get a newer beta out? > > Grabbing the head from SVN will probably never be bug free but I know I > and many others are using it in a "production" environment which is > never a great idea. If you are doing it this way, probably the best > thing you can do is constantly grab the latest source. > > Robin and any other devs are impressively responsive to fixing problems > we find and discuss on here. > > Maybe we should make a list of features that need to be finished before > the next beta and once those are knocked out set a bug-scrub day or two > where everyone combs over everything to find any remaining issues. Like, when I click on an html link that's attached to my mail RC opens a new window with RC (the folder list). Very odd. Another one is that the behavior when deleting a mail in the message list changed again. Before, when you deleted a message, the next one got selected, which doesn't happen now. Trash and spam folders can't get emptied (empty botton is grey). Configuration (at least sone things) don't get applied. Example, changing the interval in which drafts get saved. It's always in a default of 5 minutes (could this be realted to DB changes I haven't applied yet?) -- --------------------------------------------------------- Lic. Martín Marqués | SELECT 'mmarques' || Centro de Telemática | '@' || 'unl.edu.ar'; Universidad Nacional | DBA, Programador, del Litoral | Administrador --------------------------------------------------------- -- --------------------------------------------------------- Lic. Martín Marqués | SELECT 'mmarques' || Centro de Telemática | '@' || 'unl.edu.ar'; Universidad Nacional | DBA, Programador, del Litoral | Administrador ---------------------------------------------------------

3 6

First & last buttons
by Robin Elfrink 23 Nov '06

23 Nov '06

Hi, I added first and last buttons to the main page, the single-email page and the address book. If it's OK I'll commit this. Robin Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 371) +++ program/localization/en_US/labels.inc (working copy) @@ -98,7 +98,9 @@ $labels['deletemessage'] = 'Move message to trash'; $labels['printmessage'] = 'Print this message'; $labels['previousmessages'] = 'Show previous set of messages'; +$labels['firstmessages'] = 'Show first set of messages'; $labels['nextmessages'] = 'Show next set of messages'; +$labels['lastmessages'] = 'Show last set of messages'; $labels['backtolist'] = 'Back to message list'; $labels['viewsource'] = 'Show source'; @@ -171,7 +173,9 @@ $labels['export'] = 'Export'; $labels['previouspage'] = 'Show previous set'; +$labels['firstpage'] = 'Show first set'; $labels['nextpage'] = 'Show next set'; +$labels['lastpage'] = 'Show last set'; // LDAP search Index: program/js/app.js =================================================================== --- program/js/app.js (revision 371) +++ program/js/app.js (working copy) @@ -141,9 +141,15 @@ { this.enable_command('show', 'reply', 'reply-all', 'forward', 'moveto', 'delete', 'viewsource', 'print', 'load-attachment', true); if (this.env.next_uid) + { this.enable_command('nextmessage', true); + this.enable_command('lastmessage', true); + } if (this.env.prev_uid) + { this.enable_command('previousmessage', true); + this.enable_command('firstmessage', true); + } } if (this.env.action=='show' && this.env.blockedobjects) @@ -478,10 +484,18 @@ this.list_page('next'); break; + case 'lastpage': + this.list_page('last'); + break; + case 'previouspage': this.list_page('prev'); break; + case 'firstpage': + this.list_page('first'); + break; + case 'expunge': if (this.env.messagecount) this.expunge_mailbox(this.env.mailbox); @@ -656,10 +670,20 @@ this.show_message(this.env.next_uid); break; + case 'lastmessage': + if (this.env.last_uid) + this.show_message(this.env.last_uid); + break; + case 'previousmessage': if (this.env.prev_uid) this.show_message(this.env.prev_uid); break; + + case 'firstmessage': + if (this.env.first_uid) + this.show_message(this.env.first_uid); + break; case 'checkmail': this.check_for_recent(); @@ -1095,8 +1119,12 @@ { if (page=='next') page = this.env.current_page+1; + if (page=='last') + page = this.env.pagecount; if (page=='prev' && this.env.current_page>1) page = this.env.current_page-1; + if (page=='first' && this.env.current_page>1) + page = 1; if (page > 0 && page <= this.env.pagecount) { @@ -2634,7 +2662,9 @@ this.set_page_buttons = function() { this.enable_command('nextpage', (this.env.pagecount > this.env.current_page)); + this.enable_command('lastpage', (this.env.pagecount > this.env.current_page)); this.enable_command('previouspage', (this.env.current_page > 1)); + this.enable_command('firstpage', (this.env.current_page > 1)); } Index: program/steps/mail/show.inc =================================================================== --- program/steps/mail/show.inc (revision 371) +++ program/steps/mail/show.inc (working copy) @@ -60,7 +60,7 @@ $javascript .= sprintf("%s.set_env('safemode', '%b');", $JS_OBJECT_NAME, $_GET['_safe']); $next = $prev = -1; - // get previous and next message UID + // get previous, first, next and last message UID if (!($_SESSION['sort_col'] == 'date' && $_SESSION['sort_order'] == 'DESC') && $IMAP->get_capability('sort')) { @@ -69,21 +69,29 @@ $MESSAGE['index'] = array_search((string)$MESSAGE['UID'], $a_msg_index, TRUE); $prev = isset($a_msg_index[$MESSAGE['index']-1]) ? $a_msg_index[$MESSAGE['index']-1] : -1 ; + $first = count($a_msg_index)>0 ? $a_msg_index[0] : -1; $next = isset($a_msg_index[$MESSAGE['index']+1]) ? $a_msg_index[$MESSAGE['index']+1] : -1 ; + $last = count($a_msg_index)>0 ? $a_msg_index[count($a_msg_index)-1] : -1; } else { // this assumes that we are sorted by date_DESC $seq = $IMAP->get_id($MESSAGE['UID']); $prev = $IMAP->get_uid($seq + 1); + $first = $IMAP->get_uid($IMAP->messagecount()); $next = $IMAP->get_uid($seq - 1); + $last = $IMAP->get_uid(1); $MESSAGE['index'] = $IMAP->messagecount() - $seq; } if ($prev > 0) $javascript .= sprintf("\n%s.set_env('prev_uid', '%s');", $JS_OBJECT_NAME, $prev); + if ($first >0) + $javascript .= sprintf("\n%s.set_env('first_uid', '%s');", $JS_OBJECT_NAME, $first); if ($next > 0) $javascript .= sprintf("\n%s.set_env('next_uid', '%s');", $JS_OBJECT_NAME, $next); + if ($last >0) + $javascript .= sprintf("\n%s.set_env('last_uid', '%s');", $JS_OBJECT_NAME, $last); $OUTPUT->add_script($javascript); } @@ -173,4 +181,4 @@ parse_template('printmessage'); else parse_template('message'); -?> \ No newline at end of file +?> Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 371) +++ skins/default/templates/mail.html (working copy) @@ -25,9 +25,11 @@ </div> <div id="messagecountbar"> +<roundcube:button command="firstpage" imageSel="/images/buttons/first_sel.png" imageAct="/images/buttons/first_act.png" imagePas="/images/buttons/first_pas.png" width="11" height="11" title="firstmessages" /> <roundcube:button command="previouspage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previousmessages" />  <roundcube:object name="messageCountDisplay" />  <roundcube:button command="nextpage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextmessages" /> +<roundcube:button command="lastpage" imageSel="/images/buttons/last_sel.png" imageAct="/images/buttons/last_act.png" imagePas="/images/buttons/last_pas.png" width="11" height="11" title="lastmessages" /> </div> <div id="mailboxlist-header"><roundcube:label name="mailboxlist" /></div> Index: skins/default/templates/message.html =================================================================== --- skins/default/templates/message.html (revision 371) +++ skins/default/templates/message.html (working copy) @@ -11,9 +11,11 @@ <roundcube:include file="/includes/header.html" /> <div id="messagecountbar"> +<roundcube:button command="firstmessage" imageSel="/images/buttons/first_sel.png" imageAct="/images/buttons/first_act.png" imagePas="/images/buttons/first_pas.png" width="11" height="11" title="firstmessages" /> <roundcube:button command="previousmessage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previousmessages" />  <roundcube:object name="messageCountDisplay" />  <roundcube:button command="nextmessage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextmessages" /> +<roundcube:button command="lastmessage" imageSel="/images/buttons/last_sel.png" imageAct="/images/buttons/last_act.png" imagePas="/images/buttons/last_pas.png" width="11" height="11" title="lastmessages" /> </div> <div id="messagetoolbar"> Index: skins/default/templates/addressbook.html =================================================================== --- skins/default/templates/addressbook.html (revision 371) +++ skins/default/templates/addressbook.html (working copy) @@ -20,9 +20,11 @@ </div> <div id="abookcountbar"> +<roundcube:button command="firstpage" imageSel="/images/buttons/first_sel.png" imageAct="/images/buttons/first_act.png" imagePas="/images/buttons/first_pas.png" width="11" height="11" title="firstpage" /> <roundcube:button command="previouspage" imageSel="/images/buttons/previous_sel.png" imageAct="/images/buttons/previous_act.png" imagePas="/images/buttons/previous_pas.png" width="11" height="11" title="previouspage" />  <roundcube:object name="recordsCountDisplay" />  <roundcube:button command="nextpage" imageSel="/images/buttons/next_sel.png" imageAct="/images/buttons/next_act.png" imagePas="/images/buttons/next_pas.png" width="11" height="11" title="nextpage" /> +<roundcube:button command="lastpage" imageSel="/images/buttons/last_sel.png" imageAct="/images/buttons/last_act.png" imagePas="/images/buttons/last_pas.png" width="11" height="11" title="lastpage" /> </div> <div id="addresslist">

2 1

Re: Delete open email button in svn 380
by Mark Bucciarelli 23 Nov '06

23 Nov '06

On Wed, Nov 22, 2006 at 08:17:45AM -0600, Matt Kaatman wrote: > Maybe we should make a list of features that need to be > finished before the next beta and once those are knocked out > set a bug-scrub day or two where everyone combs over everything > to find any remaining issues. There is still one issue open on the 0.1-beta2 milestone list (ticket #1349473). Not sure if this is still current, but I don't remember a more recent post on the same topic: Date: Fri, 14 Jul 2006 11:28:12 +0200 From: Thomas Bruederli <roundcube(a)gmail.com> Subject: Final round for 0.1beta2 Hi everybody I finally made it to go through the most tickets and assigned a set of bugs that IMO need to be fixed for the next milestone. There are now 16 pending tickets assigned to milestone 0.1beta2: http://trac.roundcube.net/trac.cgi/query?status=new&status=assigned&status=… It looks like I will have some time again to work on the project for the next couple of weeks. Let's try to get rid of those 16 tix and we're ready to publish a new release. This will also be the first release that is "planned" with the Trac system and a proof of success of that platform. Please catch yourself some unassigned tickets and help finish this milestone. Thanks! Thomas m

2 1

Patch for imap.inc: Fixes #1483977 and #1483886
by Alexander Griesser 23 Nov '06

23 Nov '06

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi folks! I'm new to roundcubemail (just using it since yesterday) and today I found out, that passwords that contain german umlauts don't get authenticated correctly. After having a look at the sourcecode I found the file that contained the bug and it is located in imap.inc (iil_C_Login). Attached to this mail is a patch that fixes this issue, as well as the bugs #1483977 and #1483886. I know, that the imap library was taken from ilohamail and therefore I also informed the ilohamail mailing list about this issue and asked them to apply this patch too. The patch can also be downloaded here: http://tuxx-home.at/projects/roundcubemail/roundcubemail-loginumlauts.diff PS.: Please reply to me directly as I am not subscribed to the list. best regards, - -- | .-. | Alexander Griesser -- <private(a)tuxx-home.at> | .''`. | | /v\ \ http://www.tuxx-home.at/ / : :' : | | /( )\ | GPG-KeyID: 0xA2949B5A | `. `' | | ^^ ^^ `-------------------------------------------------' `- | -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFFGkNn66HVD6KUm1oRAvn/AJ0alB0K3Dc2kbW9s1Q3Pw2P9oczAACgnUYn mp4nD4FwqVEhwPilFMJZZhc= =sBPk -----END PGP SIGNATURE----- --- imap.inc.orig 2006-09-27 10:51:22.408713456 +0200 +++ imap.inc 2006-09-27 10:50:26.982139576 +0200 @@ -225,7 +225,9 @@ function iil_C_Login(&$conn, $user, $password){ - fputs($conn->fp, "a001 LOGIN $user \"$password\"\r\n"); + // $passwords needs to be utf8_decode'd so that the german umlauts don't + // get corrupted. Updated by php(a)tuxx-home.at, ag + fputs($conn->fp, "a001 LOGIN $user \"" . utf8_decode($password) . "\"\r\n"); do{ $line = iil_ReadReply($conn->fp);

10 15

Delete open email button in svn 380
by Marco Balmer 23 Nov '06

23 Nov '06

Hello In svn380 of roundcube I can not delete an open email message with firefox 2. Is that a bug or problem with my client? Thx /maba

4 7

Single mime part email
by Robin Elfrink 23 Nov '06

23 Nov '06

Hi, I have an email with a single mime part which looks like this (irrelevant headers removed): =========================================== Content-class: urn:content-classes:message X-MS-Has-Attach: yes MIME-Version: 1.0 Content-Type: application/vnd.ms-excel; name="Bureau CVL 06-10.xls" Content-Transfer-Encoding: base64 Content-Description: Bureau CVL 06-10.xls Content-Disposition: attachment; filename="Bureau CVL 06-10.xls" X-MS-TNEF-Correlator: X-MimeOLE: Produced By Microsoft Exchange V6.5.7226.0 0M8R4KGxGuEAAAAAAAAAAAAAAAAAAAAAPgADAP7/CQAGAAAAAAAAAAAAAAABAAAAAQAAAAAAAAAA EAAAEgAAAAEAAAD+////AAAAAAAAAAD///////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////// etc... =========================================== So basically it's a single mime part email. This usually does not happen with _normal_ MUA's, but MS Exchange seems not to care what the world thinks. Anyway, I fixed this one with attached patch, but I am not sure about any impact with other emails with or without attachments. I looked at about 50 different emails with and without attachments, from normal users and MS users, and I found no error so far. Would you people please take a look and see if this is fine? Robin Index: program/lib/mime.inc =================================================================== --- program/lib/mime.inc (revision 382) +++ program/lib/mime.inc (working copy) @@ -108,7 +108,7 @@ } //echo "s - part: $part rest: $rest array: ".implode(" ", $a)."<br>\n"; if (is_array($a[$part-1])) return $a[$part-1]; - else return false; + else return $a; }else if (($part==0) || (empty($part))){ return $a; } Index: program/steps/mail/func.inc =================================================================== --- program/steps/mail/func.inc (revision 382) +++ program/steps/mail/func.inc (working copy) @@ -983,6 +983,18 @@ } } + // message is single part non-text + else + { + if (($fname = $structure->d_parameters['filename']) || + ($fname = $structure->ctype_parameters['name']) || + ($fname = $structure->headers['content-description'])) + { + $structure->filename = rcube_imap::decode_mime_string($fname); + $a_attachments[] = $structure; + } + } + return array($a_return_parts, $a_attachments); }

1 0

Fw: [Full-disclosure] XSS in roundcube.com and users of it
by Chris Largret 22 Nov '06

22 Nov '06

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey, I'm sure others have seen this as it's a couple days old now, but I'm just passing it along. It should have been sent to you guys first, but I don't see a reference on the dev list and it still works. - -Chris Begin forwarded message: Date: Sat, 11 Nov 2006 10:51:00 -0800 From: RSnake <h(a)ckers.org> To: full-disclosure(a)lists.grok.org.uk Subject: [Full-disclosure] XSS in roundcube.com and users of it There is an XSS vulnerability in roundcube webmail: http://demo.roundcube.net/?_task=');alert(%22XSS%22)// Btw, we've been posting 0-day XSS vulnerabilities at http://sla.ckers.org/forum/list.php?3 to take it out of the full disclosure list since lots of people don't want to see the sheer volume of reports. We've got close to a thousand companies and counting. We're just trying to cut down on the noise to people's inboxes. That is all. - -RSnake http://ha.ckers.org http://sla.ckers.org _______________________________________________ Full-Disclosure - We believe in it. Charter: http://lists.grok.org.uk/full-disclosure-charter.html Hosted and sponsored by Secunia - http://secunia.com/ - -- Chris Largret <http://www.largret.com> -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQFFYqBuyBrDZUqad5ERAnXiAJ0Tg2JFCHj2EDXfV+5O94HBQiqaEwCfWcSl Pk1XfZ72hbyNh1twaJI7Fec= =N4Z8 -----END PGP SIGNATURE-----

7 6

Database error (1f4)
by Jason Dixon 21 Nov '06

21 Nov '06

Sorry, I know this is a FAQ but I've checked everything four times and am starting to wonder if something else is amiss. I've checked that the credentials work fine from the command line. The configs are very similar to prior installations on different servers. This server is running MySQL-5.x, so I made sure to use mysql5.initial.sql, and used the proper CREATE DATABASE statement as listed in the INSTALL file. This server hosts a number of other applications using PHP5 and MySQL-5.x, so it shouldn't be a dependencies issue. [Mon Nov 20 19:42:08 2006] [error] PHP Notice: DB Error: extension not found in /home/www/roundcube-svn-373/program/include/bugs.inc on line 80 Any ideas? Thanks, -- Jason Dixon DixonGroup Consulting http://www.dixongroup.net

1 1

Dupe bugs
by techlist 21 Nov '06

21 Nov '06

These seem to be dupes: Tickets #1456834 & #1483822 Tickets #1483926 & </trac.cgi/ticket/1483926>#1484015 </trac.cgi/ticket/1484015> -- Jay Lanstein Vice President Cantella & Co., Inc. 2 Oliver Street, 11th Floor Boston, MA 02109 (617)224-1426 - direct (617)521-8630 - office (617)521-8604 - fax The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete this material from any computer. In accordance with industry regulations, all messages are retained and are subject to monitoring. This message has been scanned for viruses and dangerous content and is believed to be clean. Securities offered through Cantella & Co., Inc., Member NASD/SIPC. Home Office: 2 Oliver Street, 11th Floor, Boston, MA 02109 Telephone: (617)521-8630

2 1

Preview Pane
by Geoff Hasz 21 Nov '06

21 Nov '06

I applied your patch for the preview pane according to: http://lists.roundcube.net/mail-archive/roundcube.dev/2006/10/51/ When I view an email in the preview pane that has images. the images don't show and there is no options to view images as in the single email window. Is that known issue or is it my configuration? Also is there a way to resize the the pane so the pane is bigger than the email list even if its hard coded? Thanks Geoff

3 4

(no subject)
by Alexander Kravcenuk 20 Nov '06

20 Nov '06

unsubscribe

1 0

Ticket #1396158
by techlist 20 Nov '06

20 Nov '06

This bug seems like it should be closed out as it works fine in SVN 368. -- Jay Lanstein Vice President Cantella & Co., Inc. 2 Oliver Street, 11th Floor Boston, MA 02109 (617)224-1426 - direct (617)521-8630 - office (617)521-8604 - fax The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete this material from any computer. In accordance with industry regulations, all messages are retained and are subject to monitoring. This message has been scanned for viruses and dangerous content and is believed to be clean. Securities offered through Cantella & Co., Inc., Member NASD/SIPC. Home Office: 2 Oliver Street, 11th Floor, Boston, MA 02109 Telephone: (617)521-8630

1 0

dev+unsubscribe@lists.roundcube.net
by Jurgen Koster 18 Nov '06

18 Nov '06

unsubscribe

1 0

need help to getting started
by Sebastian Heyden 17 Nov '06

17 Nov '06

hello, i try to write a plugin for roundcube so that the users of or mail-service can alter the settings of theire account out of roundcube. so im in search for a plugin-interface or the framework that was used to write roundcube. can you point me the direction? greetz, sebastian

1 0

Purge Junk folder
by Robin Elfrink 17 Nov '06

17 Nov '06

Enable the 'purge' command on the Junk folder. Applying this patch results in a interface change to the user (though it's a very very small change) so I would like feedback on this first. Robin Index: program/js/app.js =================================================================== --- program/js/app.js (revision 371) +++ program/js/app.js (working copy) @@ -3118,7 +3118,7 @@ case 'list': if (this.env.messagecount) - this.enable_command('purge', (this.env.mailbox==this.env.trash_mailbox)); + this.enable_command('purge', (this.env.mailbox==this.env.trash_mailbox || this.env.mailbox==this.env.junk_mailbox)); case 'expunge': this.enable_command('select-all', 'select-none', 'expunge', this.env.messagecount ? true : false);

2 2

Bug #1484109
by Robin Elfrink 17 Nov '06

17 Nov '06

Hi, Bug #1484109 has been added tonight, mentioning a cross site security vulnerability. The poster refers to http://www.securityfocus.com/bid/21042/info. Apart from the fact that I cannot reproduce the given proof-of- concept, I fail to see how this is supposed to be a vulnerability. Robin

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev