- Dev - Roundcube mailing lists

Conditional objects in templates
by Robin Elfrink 16 Nov '06

16 Nov '06

Hi, I have a first rough implementation of conditional objects in templates. An object in a template file can have an extra attribute called 'conditional', which holds a condition like 'varname==value'. '==' can be '!=', or '<=' or any other expression. 'varname' is any $CONFIG variable. In the example the messagelist is only shown if the mailbox-name is 'INBOX'. Am I going in the right direction? Robin Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 369) +++ program/include/main.inc (working copy) @@ -1225,7 +1225,18 @@ // execute object handler function if ($object_handlers[$object] && function_exists($object_handlers[$object])) - return call_user_func($object_handlers[$object], $attrib); + { + if (isset($attrib['conditional']) && + preg_match('/^([a-z0-9_]+)([=<>!]+)([a-z0-9_]+)$/', $attrib['conditional'], $condition)) + { + if (eval("return $" . $condition[1] . $condition[2] . "'" . $condition[3] . "'")) + return call_user_func($object_handlers[$object], $attrib); + else + return ''; + } + else + return call_user_func($object_handlers[$object], $attrib); + } else if ($object=='productname') { Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 369) +++ skins/default/templates/mail.html (working copy) @@ -45,6 +45,7 @@ id="messagelist" cellspacing="0" summary="Message list" + conditional="mailbox==INBOX" messageIcon="/images/icons/dot.png" unreadIcon="/images/icons/unread.png" deletedIcon="/images/icons/deleted.png"

1 1

shift-delete: Delete immediately
by Robin Elfrink 16 Nov '06

16 Nov '06

Hi, I made a small patch that implements 'shift-delete': Delete messages immediately without moving them to the Trash folder. This helps people who are over quota and therefore cannot copy any messages to the Trash folder. The key_press method of rcube_list_widget simply sets the shiftkey property whenever a key is pressed. It works only with the shift key and the del key, not with the delete button. I haven't looked at that yet, don't even know if it's possible because my browser seems to handle shift-click it's own way. Please comment. Robin

4 5

LDAP authentication
by Pierre Mauduit 16 Nov '06

16 Nov '06

Hello, since my patch about the LDAP JpegPhoto support, someone contacted me off-list, because he needed LDAP authentication. It seems that it was hardly implemented into the file "rcube_ldap.inc", but the member function bind() is never called. So I merged the member functions connect() and bind(). Here is my diff between svn ver. 367 and my working copy : http://pedrov.kwain.net/~pedrov/rcube/rcube_367_wkcpy.diff I'm interested in developing some LDAP aspects in roundcube, but did not get any feedback, so if you think it is useful (or useless, or whatever), let me know ;-) See you, -- Pierre Mauduit

2 2

Attachments of pdfs
by Chris Richardson 16 Nov '06

16 Nov '06

Hey guys i wrote a little while back about this and I was wondering if anyone had any ideas on this we are working on it but haven't found a decent solution. Has anyone else ran into this and found a solution? problem is when there is an attachment of a pdf when you click on the link next to the paper clip it opens a new window but it si the content of your inbox and only way you can open it is by right clicking and saving target as. our env is php5, roundcube svn 367and IE 6 thanks guys The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete this material from any computer. In accordance with industry regulations, all messages are retained and are subject to monitoring. This message has been scanned for viruses and dangerous content and is believed to be clean. Securities offered through Cantella & Co., Inc., Member NASD/SIPC. Home Office: 2 Oliver Street, 11th Floor, Boston, MA 02109 Telephone: (617)521-8630

3 2

shift-del
by Robin Elfrink 16 Nov '06

16 Nov '06

Darn, I left a 'shiftKey' which should've been a 'shiftkey' (lower case k). Sorry again. Robin Index: program/localization/en_US/messages.inc =================================================================== --- program/localization/en_US/messages.inc (revision 368) +++ program/localization/en_US/messages.inc (working copy) @@ -68,6 +68,8 @@ $messages['deletecontactconfirm'] = 'Do you really want to delete the selected contact(s)?'; +$messages['deletemessagesconfirm'] = 'Do you really want to delete the selected message(s)?'; + $messages['deletefolderconfirm'] = 'Do you really want to delete this folder?'; $messages['purgefolderconfirm'] = 'Do you really want to delete all messages in this folder?'; Index: program/js/list.js =================================================================== --- program/js/list.js (revision 368) +++ program/js/list.js (working copy) @@ -32,6 +32,8 @@ this.rows = []; this.selection = []; + this.shiftkey = false; + this.multiselect = false; this.draggable = false; this.keyboard = false; @@ -504,6 +506,8 @@ if (this.focused != true) return true; + this.shiftkey = e.shiftKey; + var keyCode = document.layers ? e.which : document.all ? event.keyCode : document.getElementById ? e.keyCode : 0; var mod_key = rcube_event.get_modifier(e); switch (keyCode) Index: program/js/app.js =================================================================== --- program/js/app.js (revision 368) +++ program/js/app.js (working copy) @@ -1314,7 +1314,14 @@ // if there is a trash mailbox defined and we're not currently in it: if (this.env.trash_mailbox && String(this.env.mailbox).toLowerCase()!=String(this.env.trash_mailbox).toLowerCase()) - this.move_messages(this.env.trash_mailbox); + // if shift was pressed delete it immediately + if (this.message_list.shiftkey) + { + if (confirm(this.get_label('deletemessagesconfirm'))) + this.permanently_remove_messages(); + } + else + this.move_messages(this.env.trash_mailbox); // if there is a trash mailbox defined but we *are* in it: else if (this.env.trash_mailbox && String(this.env.mailbox).toLowerCase() == String(this.env.trash_mailbox).toLowerCase()) this.permanently_remove_messages();

1 0

Question: Patches for SVN
by Robin Elfrink 15 Nov '06

15 Nov '06

I have a simple question: If I have (small) patches for current SVN, of which I'm fairly certain that they should be applied, do I post them here or do I create a ticket? Robin

2 1

Serbian Translation
by Viktor Varga 15 Nov '06

15 Nov '06

Hi! The Serbian translation is available on http://vile.on.neobee.net/roundcube_serbian-0.1-beta2.tar.gz Please include it on the download section. Cheers, Viktor

3 2

file attachment handling..
by Darrel O'Pry 14 Nov '06

14 Nov '06

Hi all. I'd like to request comments on a patch I wrote that saves creating a few new copies of the mime body of messages in memory when sending an email. http://trac.roundcube.net/trac.cgi/ticket/1484098 As an aside I was wondering if there was a good place to find developer documentation, code style guidelines, security guidelines, architecture overview, etc. darrel.

1 0

roundcube
by Philip Matthewson 14 Nov '06

14 Nov '06

How can I install roundcube I try'd but nofing :'(. http://www.boxmail.fr/mymail/beta2/ ??????? THX

4 4

Re: Preview pane for SVN 361
by Robin Elfrink 14 Nov '06

14 Nov '06

On 24-okt-2006, at 14:33, Ryan Rittenhouse wrote: > I got a seperate pane this way but it had the RC start page with > "SERVICE CURRENTLY NOT > AVAILABLE!". Oops, sorry. I forgot to add skins/default/templates/previewmessage.html to the patch: <roundcube:object name="messageHeaders" class="headers-table" cellspacing="0" cellpadding="2" addicon="/images/icons/plus.gif" summary="Message headers" /> <roundcube:object name="messageAttachments" id="attachment-list" /> <roundcube:object name="blockedObjects" id="remote-objects-message" /> <pre><roundcube:object name="messageBody" id="messagebody" showImages="true" /></pre> I think RoundCube could more gracefully tell the user that it's just a simple missing template file. Robin

11 12

selection is not defined
by Robin Elfrink 14 Nov '06

14 Nov '06

I'm getting errors when deleting messages from the main list. This patch fixes that. --- program/js/app.js (revision 367) +++ program/js/app.js (working copy) @@ -1246,6 +1246,7 @@ else { var id; + var selection = this.message_list.get_selection(); for (var n=0; n<selection.length; n++) { id = selection[n]; Robin

2 1

Documentation for Plug-in Dev
by Radu Bighiu 14 Nov '06

14 Nov '06

Hi to all, There is a place where can I find documentation regarding plug-in development for roundcube? Regards, Radu Bighiu

1 0

Purge Junk folder
by Robin Elfrink 14 Nov '06

14 Nov '06

Small patch to enable the Junk folder to be purged (emptied). Index: program/js/app.js =================================================================== --- program/js/app.js (revision 367) +++ program/js/app.js (working copy) @@ -3116,7 +3116,7 @@ case 'list': if (this.env.messagecount) - this.enable_command('purge', (this.env.mailbox==this.env.trash_mailbox)); + this.enable_command('purge', (this.env.mailbox==this.env.trash_mailbox || this.env.mailbox==this.env.junk_mailbox)); case 'expunge': this.enable_command('select-all', 'select-none', 'expunge', this.env.messagecount ? true : false); Robin

1 0

Last SVN seems to be broken
by Stefan Novak 14 Nov '06

14 Nov '06

3 2

Email ordering
by Sam Bailey 12 Nov '06

12 Nov '06

Hey, I was thinking about adding a new ordering sequence for mail in folders. I wanted to order by read (if not read then read) then by date. However my skills are haven't been up to getting this done. Any chance for a hand or at least some advice? Cyprix

1 0

Css problem?
by Nils Olofsson 11 Nov '06

11 Nov '06

Hi, I'm using latest version of roundcube from svn, I enabled ldap search but I'm coming up against a very weird css problem. Doesn't work on: windows 2000 (IE6, Firefox 1.5.0.8, Firefox 2.0 ) Windows XP IE6 No problem on... Windows XP (firefox 2.0) ubuntu 6.06 (firefox 2.0) The Problem... when I do an ldap search,like the address book on the left hand side I should be able to either double click on the name of the entry and it should allow me to write a mail to that person. When i use windows 2000 with either firefox 2.0 or firefox 1.5.0.8 i do not get the option to be able to double click on the entry to write mail. It look to me like some weird CSS bug ? Nils

1 0

Replying to message deletes original message??
by Richard Green 10 Nov '06

10 Nov '06

Hey guys (again), I have been losing e-mails as a result of using the 'reply-to' button, the original message seems to be being deleted? Anyone encountered this? They seem to be being permanently deleted and are not being moved to trash and I can't even access them using Thunderbird, so it doesn't appear to be a RCW message display error, they are really being deleted! Hope you can help! Richard

5 4

Openning Attachments problem
by Chris Richardson 10 Nov '06

10 Nov '06

Hi guys i have been noticing a big issue with my install here i am using the current trunk. when one of my users get an attachment espicaly something like a pdf and they try to open it it causes a new window to load of there inbox. it they open in a new window the knows there is a known attachment but when it goes to open it says that the path can not be found. it does work if you right click and do save as. this is all through IE 6 and up. any help would be appreciated -Chris The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any review, retransmission, dissemination or other use of, or taking of any action in reliance upon, this information by persons or entities other than the intended recipient is prohibited. If you received this in error, please contact the sender and delete this material from any computer. In accordance with industry regulations, all messages are retained and are subject to monitoring. This message has been scanned for viruses and dangerous content and is believed to be clean. Securities offered through Cantella & Co., Inc., Member NASD/SIPC. Home Office: 2 Oliver Street, 11th Floor, Boston, MA 02109 Telephone: (617)521-8630

3 3

STARTTLS Service Extension
by tintax＠tintax.net 09 Nov '06

09 Nov '06

All, To scratch an itch, I\'ve written some code against the SVN codebase (rev 362) to connect to SMTP servers that use STARTTLS. This ought to resolve ticket #1483813 (or at least it does for me). Briefly, I\'ve: Added main.inc.php::$rcmail_config[\'smtp_starttls\'] to control use of STARTTLS Modified rcube_smtp.inc::smtp_mail() to check configuration variable and try STARTTLS if set Modified Net_SMTP::Net_SMTP() to accept an optional param indicating if STARTTLS should be used. Modified Net_SMTP::connect() to establish and negotiate TLS session if using STARTTLS. Added Net_SMTP::_starttls() to attempt TLS handshake and establish secure connection. Added Net_Socket::enableCrypto() to turn encryption on/off on the socket. Caveats: This relies on functionality only available in PHP 5.1.0rc1 (with OpenSSL support) and higher. The code checks for a suitable environment but I appreciate that this is higher than the minimum PHP requirements listed on your wiki. It\'s been a little while (about two years) since I last wrote any php code so it isn\'t as polished as I\'d like. If a developer is interested in the code, please let me know how to get it to you. Oh, and thanks for such great software. It says a lot that it was worth my while to roll up my sleeves and add support for a personal show stopper rather than switch to a different webmail client! Regards, Matt

1 0

Patch fixing newline-in-From:-bug
by Øystein Steimler 08 Nov '06

08 Nov '06

Hi! I'm not subscribed to the list, so I can't read replies without a cc: Also, please accept my apologies if this issue has already been discussed. After checking out rc to a new site from svn some days ago (rev 631), I found an odd bug in the mail-header-list. Some of my contacts send mails containing an newline or carriage return in the From: header, thus breaking the _parse_address_list() in rcube_imap.inc. I'm not quite sure exactly which method is failing, but the result is that quotes are not removed, and the newline is converted to a html break inside the html anchor's href attribute, thus breaking the HTML validity. I'm not sure if this newline is allowed in the From: header according to the RFCs, but it appeared. Anyway: adding this single line patch to rcube_imap the problem disappeared from my installation. Hopefully someone can use this knowledge to make RoundCube even better! Thanks! .øs Index: roundcubemail/program/include/rcube_imap.inc =================================================================== --- roundcubemail/program/include/rcube_imap.inc (revision 361) +++ roundcubemail/program/include/rcube_imap.inc (working copy) @@ -2377,6 +2377,10 @@ function _parse_address_list($str) { + + // Remove any newlines and carriage returns from address list + $str = preg_replace( "/[\r\n]/", " ", $str ); + $a = $this->_explode_quoted_string(',', $str); $result = array(); -- Øystein Steimler - EasyConnect AS - Opplysning1890 oystein.steimler(a)easyconnect.no - GPG: 0x784a7dea

2 1

Just Praise
by Shem Valentine 30 Oct '06

30 Oct '06

Hello devs, I just wanted to say how great I think this project is. It's a breath of fresh air in the world of open source webmail clients. I love how clean and intuitive the interface is. So simple that even my technologically impaired family can use it. It was a snap to install (the sendmail AUTH feature was the hardest part about it, but still fairly simple). Thanks for a wonderful web 2.0 app! -Shem Valentine

1 0

Roundcube Date Handling Error
by Rob Smith 29 Oct '06

29 Oct '06

I was showing a friend roundcube and discovered an interested error. He had received some quota warnings in the past, but when he logged into roundcube, they were all at the top of his email list. I'm assuming the email doesn't comply to some date specification, but other email programs are handling it correctly, so we might want to include it. The email headers are at the bottom of this email. They are so short because this email isn't actually sent, but it is inserted in the users mailbox directly when they are over quota. Rob -------- Original Message -------- Subject: Quota warning Date: Mon Aug 7 05:00:00 CDT 2006 From: root(a)ruf.rice.edu To: cwshep(a)ruf.rice.edu

1 0

A test framework for Webmail systems
by Rajesh Dorairajan 27 Oct '06

27 Oct '06

Greetings Roundcube devs, I'm doing a Master's project with three team-mates in San Jose State University, California and we're trying to develop an "Integrated Test framework" for Webmail systems. We're trying to achieve a generic web-based framework (using LAMP architecture) that will act as a single source of validation for a Webmail system such as Roundcube including the IMAP/POP3 server, SMTP server, LDAP/Database, and the front-end PHP layer. I wanted to see if you could share your thoughts on this issue. Being developers of the roundcube project you must've undergone some painful experience devising a test setup for your system. Do you think you could help us a little bit by telling us some of the difficulties that we might atrempt to solve by developing such as a framework? Any feedback would be deeply appreciated. Thank you very much for your time. Rajesh Dorairajan E-Mail:- rajeshd(a)tekzon.com http://tekzon.blogspot.com

3 2

Delete/move bug fixed
by NetOne - Doichin Dokov 26 Oct '06

26 Oct '06

Hi guys, I belive i've fixed bug #1484044 <http://trac.roundcube.net/trac.cgi/ticket/1484044>, please review it and and to SVN if the fix is OK. Regards, Doichin

5 7

Patch for having transparent server selection for multiple domains
by Clément Moulin 25 Oct '06

25 Oct '06

Hi I've already proposed this patch (in April), but you'd asked me to update it for current release. http://209.85.129.104/search?q=cache:HCto6VkAqNIJ:www.roundcubeforum.net/ind ex.php%3Ftopic%3D122.msg2162+round+cube+simplerezo&hl=fr&gl=fr&ct=clnk&cd=1 So here the patch for the current SVN version: --- index.php.old Tue Oct 17 17:18:46 2006 +++ index.php Tue Oct 17 17:19:28 2006 @@ -166,6 +166,23 @@ if ($_action=='login' && $_task=='mail') { $host = $_POST['_host'] ? $_POST['_host'] : $CONFIG['default_host']; + + // auto host + if (is_array($host) && is_array(reset($host))) + { + if (isset($_POST['_user'])) + { + $tmp = split('@', $_POST['_user']); + if (sizeof($tmp) > 1) + foreach ($host as $cur_host => $domains) + if (in_array($tmp[1], $domains)) + { + $host_ok = $cur_host; + break;; + } + $host = isset($host_ok) ? $host_ok : ''; + } + } // check if client supports cookies if (empty($_COOKIE)) --- config/main.inc.php.dist.old Tue Oct 17 17:20:09 2006 +++ config/main.inc.php.dist Tue Oct 17 17:21:39 2006 @@ -35,6 +35,12 @@ // leave blank to show a textbox at login, give a list of hosts // to display a pulldown menu or set one host as string. // To use SSL connection, enter ssl://hostname:993 +// auto-selection of host depending on domain specified can +// be enabled using a value like this: +// $rcmail_config['default_host'] = array( +// 'mail.server.com' = array('domaine1.com', 'domaine2.net'), +// 'mail.server2.com' = array('my.otherdomain.net'), +// 'host.hosting.com' = array('a.net', 'b.org', 'c.com')); $rcmail_config['default_host'] = ''; // TCP port used for IMAP connections --- program/include/main.inc.old Tue Oct 17 17:22:14 2006 +++ program/include/main.inc Tue Oct 17 17:23:10 2006 @@ -1717,10 +1717,13 @@ { $select_host = new select(array('name' => '_host', 'id' => 'rcmloginhost')); - foreach ($CONFIG['default_host'] as $key => $value) - $select_host->add($value, (is_numeric($key) ? $value : $key)); + if (!(is_array($CONFIG['default_host']) && is_array(reset($CONFIG['default_host'])))) + { + foreach ($CONFIG['default_host'] as $key => $value) + $select_host->add($value, (is_numeric($key) ? $value : $key)); - $fields['host'] = $select_host->show($_POST['_host']); + $fields['host'] = $select_host->show($_POST['_host']); + } } else if (!strlen($CONFIG['default_host'])) { I quote myself: [ Note: you can use in main.inc.php something like: $rcmail_config['default_host'] = include('mystuff.inc.php'); And in mystuff.inc.php doing whatever you like for building and returning the associative arrays (retrieving informations from a database for an example, like we do). Just be aware that this file is called for every HTTP request (so if you are using database as I said, it could have some performance issues....). ] I hope this will be committed soon. -- Clement Moulin SimpleRezo

2 1

Preview pane for SVN 361
by Robin Elfrink 24 Oct '06

24 Oct '06

Hi, I managed to spend some time on my preview pane, to make it work in the current SVN revision 361. Two options were added to config/main.inc.php: // Enable preview pane $rcmail_config['enable_preview'] = FALSE; // display preview pane if enabled $rcmail_config['preview'] = FALSE; Some issues that I have: - Attachment filenames are gone, even though the preview pane displays them correctly. - There should be a 'view source' button if a message is previewed. Robin Index: config/main.inc.php.dist =================================================================== --- config/main.inc.php.dist (revision 361) +++ config/main.inc.php.dist (working copy) @@ -171,6 +171,9 @@ // Leave empty for default set of Google spell check languages $rcmail_config['spellcheck_languages'] = NULL; +// Enable preview pane +$rcmail_config['enable_preview'] = FALSE; + // path to a text file which will be added to each sent message // paths are relative to the RoundCube root folder $rcmail_config['generic_message_footer'] = ''; @@ -216,6 +219,9 @@ // prefer displaying HTML messages $rcmail_config['prefer_html'] = TRUE; +// display preview pane if enabled +$rcmail_config['preview'] = FALSE; + // show pretty dates as standard $rcmail_config['prettydate'] = TRUE; Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 361) +++ program/include/main.inc (working copy) @@ -1200,6 +1200,7 @@ 'editorselector' => 'rcmail_editor_selector', 'searchform' => 'rcmail_search_form', 'receiptcheckbox' => 'rcmail_receipt_checkbox', + 'preview' => 'rcmail_message_preview', // ADDRESS BOOK 'addresslist' => 'rcmail_contacts_list', Index: program/localization/nl_NL/labels.inc =================================================================== --- program/localization/nl_NL/labels.inc (revision 361) +++ program/localization/nl_NL/labels.inc (working copy) @@ -202,6 +202,7 @@ $labels['pagesize'] = 'Rijen per pagina'; $labels['signature'] = 'Onderschrift'; $labels['dstactive'] = 'Zomertijd'; +$labels['preview'] = 'Voorbeeldvenster'; $labels['folder'] = 'Map'; $labels['folders'] = 'Mappen'; Index: program/localization/en_US/labels.inc =================================================================== --- program/localization/en_US/labels.inc (revision 361) +++ program/localization/en_US/labels.inc (working copy) @@ -207,6 +207,7 @@ $labels['dstactive'] = 'Daylight savings'; $labels['htmleditor'] = 'Compose HTML messages'; $labels['htmlsignature'] = 'HTML signature'; +$labels['preview'] = 'Preview message'; $labels['autosavedraft'] = 'Automatically save draft'; $labels['everynminutes'] = 'every $n minutes'; Index: program/js/app.js =================================================================== --- program/js/app.js (revision 361) +++ program/js/app.js (working copy) @@ -135,7 +135,7 @@ } // enable mail commands - this.enable_command('list', 'checkmail', 'compose', 'add-contact', 'search', 'reset-search', true); + this.enable_command('list', 'checkmail', 'compose', 'add-contact', 'search', 'reset-search', 'load-attachment', true); if (this.env.action=='show') { @@ -552,6 +552,7 @@ var input_pagesize = rcube_find_object('_pagesize'); var input_name = rcube_find_object('_name'); var input_email = rcube_find_object('_email'); + var input_preview = rcube_find_object('_preview'); // user prefs if (input_pagesize && isNaN(input_pagesize.value)) @@ -1039,6 +1040,8 @@ this.enable_command('show', 'reply', 'reply-all', 'forward', 'print', selected); this.enable_command('delete', 'moveto', list.selection.length>0 ? true : false); } + if (selected && this.env.enable_preview && this.env.preview) + this.show_preview(list.selection[0]); }; @@ -1067,6 +1070,30 @@ /*********************************************************/ + this.show_preview = function(id, safe) + { + var add_url = ''; + var target = window; + var contentframe = rcube_find_object('mailcontframe'); + var previewpane = rcube_find_object('previewpane'); + + if (id && contentframe && previewpane) + { + rcmail.set_busy(true, 'loading'); + if (previewpane.style.display=='none') + { + contentframe.style.height = (contentframe.offsetHeight/2) + 'px'; + previewpane.style.top = (contentframe.offsetTop+contentframe.offsetHeight) + 'px'; + previewpane.style.display = 'block'; + var message = rcube_find_object('rcmrow' + id); + message.scrollIntoView(); + } + var url = '_action=preview&_uid='+id; + rcmail.http_request('preview', url, true); + } + }; + + // when user doble-clicks on a row this.show_message = function(id, safe) { @@ -3115,6 +3142,12 @@ case 'expunge': this.enable_command('select-all', 'select-none', 'expunge', this.env.messagecount ? true : false); break; + + case 'preview': + var previewpane = rcube_find_object('previewpane'); + previewpane.innerHTML = request_obj.get_text(); + previewpane.scrollTop = 0; + break; } request_obj.reset(); Index: program/steps/settings/func.inc =================================================================== --- program/steps/settings/func.inc (revision 361) +++ program/steps/settings/func.inc (working copy) @@ -155,6 +155,17 @@ rep_specialchars_output(rcube_label('htmleditor')), $input_htmleditor->show($CONFIG['htmleditor']?1:0)); + // Show option for preview pane + if ($CONFIG['enable_preview']) + { + $field_id = 'rcmfd_preview'; + $input_preview = new checkbox(array('name' => '_preview', 'id' => $field_id, 'value' => 1)); + $out .= sprintf("<tr><td class=\"title\"><label for=\"%s\">%s</label></td><td>%s</td></tr>\n", + $field_id, + rep_specialchars_output(rcube_label('preview')), + $input_preview->show($CONFIG['preview']?1:0)); + } + if (!empty($CONFIG['drafts_mbox'])) { $field_id = 'rcmfd_autosave'; @@ -242,4 +253,4 @@ } -?> \ No newline at end of file +?> Index: program/steps/settings/save_prefs.inc =================================================================== --- program/steps/settings/save_prefs.inc (revision 361) +++ program/steps/settings/save_prefs.inc (working copy) @@ -29,8 +29,11 @@ $a_user_prefs['pagesize'] = is_numeric($_POST['_pagesize']) ? (int)$_POST['_pagesize'] : $CONFIG['pagesize']; $a_user_prefs['prefer_html'] = isset($_POST['_prefer_html']) ? TRUE : FALSE; $a_user_prefs['htmleditor'] = isset($_POST['_htmleditor']) ? TRUE : FALSE; +if ($CONFIG['enable_preview']) + $a_user_prefs['preview'] = isset($_POST['_preview']) ? TRUE : FALSE; $a_user_prefs['draft_autosave'] = isset($_POST['_draft_autosave']) ? intval($_POST['_draft_autosave']) : 0; + // MM: Date format toggle (Pretty / Standard) $a_user_prefs['prettydate'] = isset($_POST['_pretty_date']) ? TRUE : FALSE; Index: program/steps/mail/show.inc =================================================================== --- program/steps/mail/show.inc (revision 361) +++ program/steps/mail/show.inc (working copy) @@ -171,6 +171,8 @@ if ($_action=='print') parse_template('printmessage'); +else if ($_action=='preview') + parse_template('previewmessage'); else parse_template('message'); -?> \ No newline at end of file +?> Index: program/steps/mail/func.inc =================================================================== --- program/steps/mail/func.inc (revision 361) +++ program/steps/mail/func.inc (working copy) @@ -480,6 +480,8 @@ $javascript .= sprintf("%s.set_env('pagecount', %d);\n", $JS_OBJECT_NAME, ceil($message_count/$IMAP->page_size)); $javascript .= sprintf("%s.set_env('sort_col', '%s');\n", $JS_OBJECT_NAME, $sort_col); $javascript .= sprintf("%s.set_env('sort_order', '%s');\n", $JS_OBJECT_NAME, $sort_order); + if ($CONFIG['enable_preview']) + $javascript .= sprintf("%s.set_env('preview', '%s');\n", $JS_OBJECT_NAME, $CONFIG['preview']); if ($attrib['messageicon']) $javascript .= sprintf("%s.set_env('messageicon', '%s%s');\n", $JS_OBJECT_NAME, $skin_path, $attrib['messageicon']); Index: skins/default/templates/mail.html =================================================================== --- skins/default/templates/mail.html (revision 361) +++ skins/default/templates/mail.html (working copy) @@ -52,6 +52,8 @@ attachmentIcon="/images/icons/attachment.png" /> </div> +<div id="previewpane" style="display: none;"></div> + <div id="listcontrols"> <roundcube:label name="select" />:  <roundcube:button command="select-all" label="all" classAct="active" />  Index: skins/default/mail.css =================================================================== --- skins/default/mail.css (revision 361) +++ skins/default/mail.css (working copy) @@ -120,7 +120,30 @@ height: expression((parseInt(document.documentElement.clientHeight)-125)+'px'); } +#previewpane +{ + position: absolute; + display: none; + top: 85px; + left: 200px; + right: 40px; + bottom: 40px; + border: 1px solid #999999; + border-top: none; + background-color: #F9F9F9; + overflow: auto; + /* css hack for IE */ + width: expression((parseInt(document.documentElement.clientWidth)-240)+'px'); + height: expression(( + parseInt(document.documentElement.clientHeight) - + parseInt(document.getElementById('mailcontframe').clientHeight) - 125)+'px'); +} +body > div#previewpane +{ + height: auto; +} + #messagepartframe { border: 1px solid #999999; Index: index.php =================================================================== --- index.php (revision 361) +++ index.php (working copy) @@ -262,7 +262,7 @@ { include_once('program/steps/mail/func.inc'); - if ($_action=='show' || $_action=='print') + if ($_action=='show' || $_action=='print' || $_action=='preview') include('program/steps/mail/show.inc'); if ($_action=='get')

2 1

Bug report: invalid header modification
by Morten Mertner 24 Oct '06

24 Oct '06

Hi All, I'm seeing errors like this in my error_log: .. PHP Warning: Cannot modify header information - headers already sent in Unknown on line 0 .. PHP Stack trace: .. PHP 1. {main}() /var/www/localhost/htdocs/roundcube-svn/index.php:0 .. PHP 2. include() /var/www/localhost/htdocs/roundcube-svn/index.php:299 I hope this is useful - and do let me know if I should rather post this somewhere else. Yours, Morten

5 5

Problema
by brilo＠brilo.net.ar 24 Oct '06

24 Oct '06

Estoy teniendo problemas con este webmail y lamentablemente no se inglés, no se como expresarme y como entender lo que dicen los foros. Paso a explicar mi problema por aqui, espero puedan entenderme. El Webmail "funciona bien"... puedo enviar mensajes, guarda las preferencias, etc. Pero el problema es que cuando lista los mensajes no me muestra ni el asunto ni la fecha, no muestra nada, solo el tamaño y tampoco me deja abrirlos. Les adjunto un screen de la pantalla para que me entiendan mejor. Espero que puedan ayudarme. Desde ya, muchas gracias. Atte. Fernando R. Briloni

2 1

SMTP Error: SMTP error: Failed to add recipient
by Robin Elfrink 18 Oct '06

18 Oct '06

Hi, I have (had) some users getting the following error: SMTP Error: SMTP error: Failed to add recipient 'random(a)email.address' It happens with the same users continuously. So I tried adding some debugging to the function that caused this error, and changed this: // set mail recipients foreach ($recipients as $recipient) { if (PEAR::isError($SMTP_CONN->rcptTo($recipient))) { smtp_reset(); $SMTP_ERROR .= "Failed to add recipient '$recipient'\n"; return FALSE; } } into this: // set mail recipients foreach ($recipients as $recipient) { $error = $SMTP_CONN->rcptTo($recipient); if (PEAR::isError($error)) { smtp_reset(); $SMTP_ERROR .= "Failed to add recipient '$recipient'\n"; $SMTP_ERROR .= "SMTP error: '".$error->getMessage()."'\n"; return FALSE; } } and all of a sudden the problem is gone for the users. Is my pear install broken? Does PEAR::isError() have a problem with $SMTP_CONN->rcptTo() somehow? Robin

1 0

problem sending email
by jrivera＠igraficaestudio.com 17 Oct '06

17 Oct '06

i just install round cube, after having some problems with the erro 1f4 jajaja i read many have bump in to it, but now wend i try to send and emal it just wont send, can anybody help me please i have no clue what to no next

4 4

Developer required?
by Hans-Christian Otto 15 Oct '06

15 Oct '06

Hi, do you still 'need' help by a developer who wants to contribute to an opensource project? ;-) I'm using roundcube by myself, and I really like it. Due to this and to the fact that I'm coding php for a few years now, I decided to ask whether the roundcube projects wants my the help. :) I'm waiting for your reply, greetings, Christian -- Hans-Christian Otto www: http://muh-die-kuh.de mail: c.otto(a)lab9.de jabber: muh-die-kuh(a)jabber.ccc.de icq: 127751895 gpg: 0xE5004DA3

2 1

Adressbook done , almost - heres a patch
by shane＠gnative.com 14 Oct '06

14 Oct '06

Someone pointed out that the link on the dev list isn't working for the patch/diff So i have put up a link on my site of anyone wants to grab it.. www.gnative.com/dev/ also i have send an email of the initial one containing the attachment and the list of TODO the the demo site as well use the same link above. I also realized that not all the contacts would load the first time (if you have more than 40) as i forgot to remove the "page limit" in func.inc on the limitquery for the DB. yes there are still bugs to be swatted.. wish i had a couple more days then i could have all these done for you. Glad to get the response that i have gotten so far. Thank you ---------------------------------------------------------------------- Variety is the spice of life .. except in Thailand where the spice makes your life slip out your arsehole. ----------------------------------------------------------------------

1 0

Adressbook done , almost - heres a patch
by shane＠gnative.com 14 Oct '06

14 Oct '06

Address-book development is almost done if someone wants to have a play at finishing it Unfortunately i have to head up to China and beyond tomorrow and will be off the beaten track for a few months till i get back to Europe sometime in the snow covered months. I hope someone is willing to pick up where i have left off Added support to Addressbook is : 1. vCard upload/importing to v3.0 standard 2. Contact grouping 3. Contact searching.. Yes it works and its bloody fantastic. You can even search for a birth-date or phone number. 4. Multiple emails and clicking on these links will take you to compose (thanks Phil) You can demo at : www.gnative.com/dev/rcdev/ I've attached a diff here of what i have done. Below is where i was up to Hope you can all find a use for this Happy Xmas and a Merry Halloween Shane shane(a)gnative.com TODO: ===================================================================================== 1. Enable other forms of import/export -cvs -xsl -output to PDF / HTML - print 2. Include image support thumbnailing if GD or Imagemagic present, i like this idea but some might not.. worth a discussion or as a plugin ?? 3. It was mentioned to add support for selecting folder that could become global As in all users of the app could have access to it.. I have left support in the contactsgrouping SQL tables for this as i thought this was a good idea. Just needs to be set in preferences 4. Something seems to be up with trying to move large amounts of contacts to a group folder. It seems to be clearing the group. 5. The buttons for group folder display funny in IE they float over the groupbox listing area instead of staying below 6. Language support so far i have only done EN_GB and EN_US. 7. Add a warning message of "duplicate upload" on vcard loaded frame Small bugs to fix. ------------------------------------------------------------------------------------- 1. Hitting enter on the add group when in the input field returns the page to mail 2. Need to sort out the page numbering.. i have been removing this and had the thought of making this click through the contacts in the row column that is currently listed 3. Check to see how LDAP support is working as i don't have a LDAP account so haven't been able to do this 4. Change how the folders get reloaded at the moment its just document write instead of off the DOM (lazy ha). I figured I'd get this fixed once i have a look at the other main changes i want to look (see below). This looked like it would go with what was happening in the functions for settings and its folders. It could become a generic object for all folder directories blah blah blah. 5. Do the database thing for initial and upgrade. I have only worked off the mysql.initial at the mo. Note: altered "contacts" table and added "contactgroup" table (unavoidable). Main fixes to be done (Mainly just tiding up). ------------------------------------------------------------------------------------- 1. Many of the functions that i use have been regurgitated from the mail's set of functions for listing mail. These can be made reusable across the entire board I.E made into common functions. - Prime example is the simply the row functions in app.js 2. Javascript needs revisiting and done the same to as above. I was think of how to make this more object orientated as in a mail object and address-book object - this would make things better for a plug-in styled API as the plugins could extend on those objects. For now the functions just need to be made so that they can be used by both mail and address-book side to decrease file size and make scripting easier. Don't fancy working with large files like this 3. Check for better error catchment.

2 1

[LDAP jpegPhoto support]
by Pierre Mauduit 13 Oct '06

13 Oct '06

Hi folks, First of all, thanks very much for the efforts on roundcube, i love this webmail and use it everyday :-) Since I'm a LDAP user, I was interested in having the JpegPhoto support, so I coded it on my svn copy of roundcube. I give you my patch, hoping that it will be useful. (PS : I generated the patch using "svn diff" command, but it did not attach the file "./program/steps/addressbook/ldapjpegphoto.inc", so I joined it to this mail too, and sorry for my bad english, i'm french). See you -- Pierre Mauduit

1 1

Groups in Addressbook
by Fredrik Håkansson 09 Oct '06

09 Oct '06

Hi! I'm new to this project. I have a question about the addressbook and yes I searched the archived, but couldn't find anything about groups of contacts - is there plans on support this? (To be very clear: I mean a address-card can contain multiple e-mail addresses?) /Fredrik

2 1

Message with only one non-text part
by Robin Elfrink 09 Oct '06

09 Oct '06

Hello, I have a message here, generated by some random Exchange server, with only one mime-part, which is not of type text/* but application/* (excel in this case). RoundCube fails to display it, because it assumes that messages with only one part should have that part as type text/*. Of course I agree with RoundCube, and I wouldn't be surprised if some RFC does as well, but my customers don't so I try to have RoundCube show that part as an attachment. I have modified the following in program/steps/mail/func.inc: @@ -981,6 +982,17 @@ } } } + else + { + if (($fname = $structure->d_parameters['filename']) || + ($fname = $structure->ctype_parameters['name']) || + ($fname = $structure->headers['content-description'])) + { + $structure->filename = rcube_imap::decode_mime_string($fname); + $structure->mimetype = $message_ctype_primary . '/' . $message_ctype_secondary; + $a_attachments[] = $structure; + } + } return array($a_return_parts, $a_attachments); } The single non-text part is now shown as attachment, and can be retrieved by the client, but the content-decoding still needs to be done. Two questions: 1. Is this the right thing, the right place and the right solution? 2. How do I get RoundCube to use the proper decoding for the part? Robin

1 0

Message with only one non-text part
by Robin Elfrink 09 Oct '06

09 Oct '06

Hello, I have a message here, generated by some random Exchange server, with only one mime-part, which is not of type text/* but application/* (excel in this case). RoundCube fails to display it, because it assumes that messages with only one part should have that part as type text/*. Of course I agree with RoundCube, and I wouldn't be surprised if some RFC does as well, but my customers don't so I try to have RoundCube show that part as an attachment. I have modified the following in program/steps/mail/func.inc: @@ -981,6 +982,17 @@ } } } + else + { + if (($fname = $structure->d_parameters['filename']) || + ($fname = $structure->ctype_parameters['name']) || + ($fname = $structure->headers['content-description'])) + { + $structure->filename = rcube_imap::decode_mime_string($fname); + $structure->mimetype = $message_ctype_primary . '/' . $message_ctype_secondary; + $a_attachments[] = $structure; + } + } return array($a_return_parts, $a_attachments); } The single non-text part is now shown as attachment, and can be retrieved by the client, but the content-decoding still needs to be done. Two questions: 1. Is this the right thing, the right place and the right solution? 2. How do I get RoundCube to use the proper decoding for the part? Robin

1 0

Re: Addressbook improvements, first shot
by shane＠gnative.com 09 Oct '06

09 Oct '06

Hi again.. I'll give you a demo link so that you can see what i mean ni regard to group management of contacts. www.gnative.com/dev/rc/ Warning that this is still under development and i have a few things to sort out before it is fully functional. I'm also using my server as a testing environment as i am currently traveling through Thailand then to china and have only access to Internet cafes so you may find at times it's not fully functional due to testing. No extra tables needed as I'm just adding onto the end of the contact row. Though i think this might conflict with your global contacts idea. I'll have to have a look at what you have done. As for uploading an image. I think the Keep It Simple Stupid approach might be the upload image one . We need to be able to cater for persons not to savvy on link to external images etc and just want to be able to click upload. Not to hard to introduce a thumb nailing script that runs if there is an image module on the php server. I do agree with the "KISS" rule wholeheartedly. Don't know of anyone working on the birthday idea or if there is a need for it. I have just started working on this as well and haven't tried for developer access to svn yet Be good to get some thoughts back Shane > On 10/4/06, shane(a)gnative.com <shane(a)gnative.com> wrote: > > > Paul and dev's. > > Funny i should get this email now, i have just spent the day starting > redeveloping of address book for my personal use (and hopefully others) by > adding the function of grouping contacts. This is using drag and drop, the > same > as mail section and is using the same functions thou i need to sit back > and > address the javascript to make some of the functions universal as i can > see > them being used elsewhere ( actually the javascript is a completely > different > topic and one i would like to bring up once i have the architecture in my > head > more). The functionality will be almost idential to that of apples > addressbook > app. > > > Hello, > I don't know the apples addressbook (I am a linux user) so could you > describe > shortly what this grouping functionality is? Does it allow to share > contacts > (with other users) or is it only a way to display/sort/order your contacts > within the contact list? > > What kind of new db attributes or tables do you need? > > > I'll post a link when i get it near complete just a few things to > finish > off (almost there). > > I'm also implementing vCard support for import and export ( in a > variety of > formats ) i have the scripts handy just need to plug them in.. > > > Great, so I won't develop it on my side (it was my proposal number 3). > > > > Would also like to add the support of upcoming birthday alerts that > can be > turned off in "options". > > > Yes! I had the same idea when I included the birthdate attribute in the > contact profile. Is someone else already working on it? > > > As for the contact image if this is going to be added the we would > need to > look at GD/imagemagik for resizing of uploaded images to be added to the > database when creating a contacts. > > > This depends on how we want to manage images: > - the KISS solution (keep it simple stupid) is to use a link to an image > already hosted on the internet. > Pros: no need for a graphic library, really simple (actually already > supported by the patch I proposed), my contacts can update their image > without > resending me the image > Cons: cross-linking, stability not guaranted (if the image vanishes or > is > renamed, it doesn't work anymore) > - the full solution is to load the image in the db, resize/convert it > Pros: stable > Cons: lots of dev, copyright issues (are you allowed to store these > images?), if you want to update your image you have to send it to your > contacts > and have it reloaded in the db > > I prefer the first solution : simple and more manageable > > > Any other thoughts would be great as I'm fully enjoying getting into > the > redesign of this. > > Shane > > On Wed, 4 Oct 2006 10:29:09 +0200, "Paul Carrasco" > <paul.carrasco(a)gmail.com >> wrote: > > Hello everybody, > > > > I use roundcube for my emails but I think the adressbook is lacking > a lot > > of > > interesting features. > > 1) Ability to store multiple email adresses, phones numbers, > pictures > and > > other info about my contacts > > 2) Ability to share contacts (eg : my contacts could be seen by my > wife, > > since we have some friends in common ;) > > 3) Ability to import/export from csv files or other adequate format > > 4) Ability to display pictures of my contacts when I receive mail > from > > them > > (can anyone remember of the "picons" idea? see > > http://www.cs.indiana.edu/picons/ftp/faq.html#what) > > > > > > So I propose the following: > > 1) see the code below to implement an extended version of the > contacts. > > At the moment it can : > > - eidt, save and display multiple info about your contacts > > - mailto links working with the various emails of the contact > > - I chose not to store the image in the db itself but only a link to > it, > > since it was simpler; but it means cross-linking between your > roudcube > web > > site and the site hosting the image > > Todo : > > - when auto-completing recipient address only the first email of the > > contacts can be matched > > - when adding a new contact, only the first email address is checked > for > > redundancy > > > > 2) Not implemented yet > > To share contacts, I have included a "global" attribute in the > contact > > profile. When set to True this will make the contact visible to > everybody, > > but editable only by the user who created it. > > There will be a config attribute to disable this behaviour. > > > > 3) Not implemented yet, but should'nt be hard > > > > 4) I really like this idea (try gmail to see how it could work). I > think > I > > will add : > > - mouse-over info box that displays the contact profile when the > mouse is > > over a mail > > - when displaying a message, show at the top the picture and some > info > > from > > the addressbook > > > > > > > > Please tell me if you think this can be included in roundcube > 'official' > > version, and in that case I will send you the future updates. > > > > If you find bugs, please send them to me. It seems to work ok for > me. If > > you > > prefer to work with cvs, I can do so, but on the web site it is said > to > > propose code by mail. > > > > Bye > > Paul > > > > > > > > Code to implement feature 1) > > > > A/ DB modification (I use mysql, so this is the code to update the > db > > scheme). > > > > ALTER TABLE `contacts` ADD `email2` VARCHAR( 128 ) NOT NULL , > > ADD `email3` VARCHAR( 128 ) NOT NULL , > > ADD `email4` VARCHAR( 128 ) NOT NULL , > > ADD `im` VARCHAR( 128 ) NOT NULL , > > ADD `homephone` VARCHAR( 128 ) NOT NULL , > > ADD `mobilephone` VARCHAR( 128 ) NOT NULL , > > ADD `workphone` VARCHAR( 128 ) NOT NULL , > > ADD `sip` VARCHAR( 128 ) NOT NULL , > > ADD `webpage` VARCHAR( 256 ) NOT NULL , > > ADD `birthdate` DATE NOT NULL , > > ADD `pgppublickey` TEXT NOT NULL , > > ADD `homeaddress` TEXT NOT NULL , > > ADD `workaddress` TEXT NOT NULL , > > ADD `company` VARCHAR( 128 ) NOT NULL , > > ADD `comments` TEXT NOT NULL , > > ADD `picture` VARCHAR( 256 ) NOT NULL , > > ADD `globalcontact` BOOL NOT NULL ; > > > > > > > > > > B/ Localization files updates (done only for US and fr files) > > US file: program/localization/en_US/labels.inc.php > > // address boook > > $labels['name'] = 'Display name'; > > $labels['firstname'] = 'First name'; > > $labels['surname'] = 'Last name'; > > $labels['email'] = 'E-Mail'; > > //new labels > > $labels[email2] = 'E-Mail 2'; > > $labels[email3] = 'E-Mail 3'; > > $labels[email4] = 'E-Mail 4'; > > $labels[im] = 'Instant messaging'; > > $labels[homephone] = 'Home phone'; > > $labels[mobilephone] = 'Mobile phone'; > > $labels[workphone] = 'Work phone'; > > $labels[sip] = 'SIP'; > > $labels[webpage] = 'Web page'; > > $labels[birthdate] = 'Birth date'; > > $labels[pgppublickey]= 'PGP public key'; > > $labels[homeaddress] = 'Home address'; > > $labels[workaddress] = 'Work address'; > > $labels[company] = 'Company'; > > $labels[comments] = 'Comments'; > > $labels[picture] = 'Picture'; > > $labels[globalcontact]= 'Global contact'; > > > > > > > > fr file: program/localization/fr/labels.inc.php > > // address boook > > $labels['name'] = 'Nom à afficher'; > > $labels['firstname'] = 'Prénom'; > > $labels['surname'] = 'Nom'; > > $labels['email'] = 'e-Mail'; > > //new labels > > $labels[email2] = 'e-Mail 2'; > > $labels[email3] = 'e-Mail 3'; > > $labels[email4] = 'e-Mail 4'; > > $labels[im] = 'Messagerie instantanée'; > > $labels[homephone] = 'Téléphone domicile'; > > $labels[mobilephone] = 'Téléphone mobile'; > > $labels[workphone] = 'Téléphone professionnel'; > > $labels[sip] = 'SIP'; > > $labels[webpage] = 'Page web'; > > $labels[birthdate] = 'Date de naissance'; > > $labels[pgppublickey]= 'Clé publique PGP'; > > $labels[homeaddress] = 'Adresse domicile'; > > $labels[workaddress] = 'Adresse professionnelle'; > > $labels[company] = 'Société'; > > $labels[comments] = 'Commentaires'; > > $labels[picture] = 'Image'; > > $labels[globalcontact]= 'Contact global'; > > > > > > > > > > C/ New config options > > To be appended at the end of the file: config/main.inc.php > > // addressbook configuration > > // chose which columns in the addressbook to enable, the columns are > > displayed in the specified order > > $rcmail_config['addressbook_show_cols'] = array('picture', 'name', > > 'firstname', 'surname', 'email', 'email2', 'email3', 'email4', 'im', > > 'homephone', 'mobilephone', 'workphone', 'sip', 'webpage', > 'birthdate', > > 'pgppublickey', 'homeaddress', 'workaddress', 'company', 'comments', > > 'globalcontact'); > > > > // image size in address book > > $rcmail_config['addressbook_image_width'] = '100'; > > $rcmail_config['addressbook_image_height'] = '100'; > > > > // enable global contacts > > $rcmail_config['adressbook_enable_global_contacts'] = 'true'; > > > > > > > > > > > > D/ Show contact update > > Update the rcmail_contact_details function in the file: > > program/steps/addressbook/show.inc > > function rcmail_contact_details($attrib) > > { > > global $CONFIG, $CONTACT_RECORD, $JS_OBJECT_NAME; > > > > if (!$CONTACT_RECORD) > > return show_message('contactnotfound'); > > > > // a specific part is requested > > if ($attrib['part']) > > return > rep_specialchars_output($CONTACT_RECORD[$attrib['part']]); > > > > > > // return the complete address record as table > > $out = "<table>\n\n"; > > > > $a_show_cols = $CONFIG['addressbook_show_cols']; > > foreach ($a_show_cols as $col) > > { > > if (substr($col,0,5)=='email' && $CONTACT_RECORD[$col]) > > $value = sprintf('<a href="#compose" > > __removed="%s.command(\'compose\', > > \'%d_%s\')" title="%s">%s</a>', > > $JS_OBJECT_NAME, > > $CONTACT_RECORD['contact_id'], > > $col, > > rcube_label('composeto'), > > $CONTACT_RECORD[$col]); > > elseif ($col=="picture" && $CONTACT_RECORD[$col]) > > $value = sprintf('<img height="%s" width="%s" src="%s" />', > > $CONFIG['addressbook_image_height'], > > $CONFIG['addressbook_image_width'], > > $CONTACT_RECORD[$col]); > > else > > $value = rep_specialchars_output($CONTACT_RECORD[$col]); > > > > $title = rcube_label($col); > > $out .= sprintf("<tr><td > class=\"title\">%s</td><td>%s</td></tr>\n", > > $title, $value); > > } > > > > > > $out .= "\n</table>"; > > > > return $out; > > } > > > > > > > > > > E/ Edit contact update > > Update the rcmail_contact_editform function in the file: > > program/steps/addressbook/edit.inc > > function rcmail_contact_editform($attrib) > > { > > global $CONFIG, $CONTACT_RECORD, $JS_OBJECT_NAME; > > > > if (!$CONTACT_RECORD && $GLOBALS['_action']!='add') > > return rcube_label('contactnotfound'); > > > > // add some labels to client > > rcube_add_label('noemailwarning'); > > rcube_add_label('nonamewarning'); > > > > list($form_start, $form_end) = get_form_tags($attrib); > > unset($attrib['form']); > > > > > > // a specific part is requested > > if ($attrib['part']) > > { > > $out = $form_start; > > $out .= rcmail_get_edit_field($attrib['part'], > > $CONTACT_RECORD[$attrib['part']], $attrib); > > return $out; > > } > > > > > > // return the complete address edit form as table > > $out = "$form_start<table>\n\n"; > > > > #$a_show_cols = array('name', 'firstname', 'surname', 'email'); > > $a_show_cols = $CONFIG['addressbook_show_cols']; > > foreach ($a_show_cols as $col) > > { > > $attrib['id'] = 'rcmfd_'.$col; > > $title = rcube_label($col); > > if (($col=='homeaddress' || $col=='workaddress' || > $col=='comments') > > && > > $CONTACT_RECORD[$col]) > > $value = rcmail_get_edit_field($col, $CONTACT_RECORD[$col], > $attrib, > > 'textarea'); > > else > > $value = rcmail_get_edit_field($col, $CONTACT_RECORD[$col], > > $attrib); > > > > $out .= sprintf("<tr><td class=\"title\"><label > > for=\"%s\">%s</label></td><td>%s</td></tr>\n", > > $attrib['id'], > > $title, > > $value); > > } > > > > $out .= "\n</table>$form_end"; > > > > return $out; > > } > > > > > > > > F/ Save contact update > > Replace the line > > $a_save_cols = array('name', 'firstname', 'surname', 'email'); > > by > > $a_save_cols = $CONFIG['addressbook_show_cols']; > > in the file: program/steps/addressbook/save.inc > > > > > > > > > > G/ Compose mail update (to to chose not only the first email, but > also > one > > of the others depending on which link was clicked in the contact > profile) > > Update the "case 'to'" in the compose action, in the file: > > program/steps/mail/compose.inc > > case 'to': > > $fname = '_to'; > > $header = 'to'; > > > > // we have contact id's as get parameters > > if (!empty($_GET['_to']) && preg_match('/^[0-9]+(,[0-9]+)*$/', > > $_GET['_to'])) > > { > > $a_recipients = array(); > > $sql_result = $DB->query("SELECT name, email > > FROM > ".get_table_name('contacts')." > > WHERE user_id=? > > AND del<>1 > > AND contact_id IN > > (".$_GET['_to'].")", > > $_SESSION['user_id']); > > > > while ($sql_arr = $DB->fetch_assoc($sql_result)) > > $a_recipients[] = > format_email_recipient($sql_arr['email'], > > $sql_arr['name']); > > > > if (sizeof($a_recipients)) > > $fvalue = join(', ', $a_recipients); > > } > > else if (!empty($_GET['_to']) && > > preg_match('/^[0-9]+_email[0-9]*$/', > > $_GET['_to'])) > > { > > $a_recipients = array(); > > preg_match('/^([0-9])+_(email[0-9]*)$/', $_GET['_to'], > $matches); > > $sql_result = $DB->query("SELECT name, ".$matches[2]." > > FROM > ".get_table_name('contacts')." > > WHERE user_id=? > > AND del<>1 > > AND contact_id IN > (".$matches[1].")", > > $_SESSION['user_id']); > > > > while ($sql_arr = $DB->fetch_assoc($sql_result)) > > $a_recipients[] = > format_email_recipient($sql_arr[$matches[2]], > > $sql_arr['name']); > > > > if (sizeof($a_recipients)) > > $fvalue = join(', ', $a_recipients); > > } > > > > else if (!empty($_GET['_to'])) > > $fvalue = $_GET['_to']; > > > > > > > > ---------------------------------------------------------------------------------------------------- > Variety is the spice of life .. except in Thailand where the > spice > makes > your life slip out your arsehole. > > ---------------------------------------------------------------------- ---------------------------------------------------------------------------------------------------- Variety is the spice of life .. except in Thailand where the spice makes your life slip out your arsehole. ----------------------------------------------------------------------------------------------------

2 1

Encoding question & BG lang update
by NetOne - Doichin Dokov 07 Oct '06

07 Oct '06

Hi all, There's a minor change in BG localization files, fixing a problem which prevented the Empty link from showing up. The latest files are published at http://mirror.net1.cc/projects/roundcubemail%20-%20bg%20language/ I would also like to drive your attention to bug #1483839 <http://trac.roundcube.net/trac.cgi/ticket/1483839> , I see a lot of other bugs posted to the tracker, related to this one - encoding problems. Bugs related - 1424900, 1473561, may be some others too. I think something should be decided about default encoding, it's a general issue for non-english users / testers. Regards, Doichin

1 0

Access keys
by Chris Hembrow 07 Oct '06

07 Oct '06

Hi I've created a patch for SVN to add accesskeys to some of the main functions. This means that you can compose, reply, delete, select etc... from the keyboard. I wasn't sure about the best way to do this, and this is the first time I've contributed to an oss project, so I've attached a gzip with a diff file for each of the affected files. If I've c0cked anything up, I apologise in advance :p Chris

1 0

Re: Ticket #1332930 (Feature Requests)
by Tobias 'tri' Richter 05 Oct '06

05 Oct '06

Hi guys, I found roundcubemail a few weeks ago and found it really great. I was a long time Horde-Imp User but roundecubemail is much faster, nicer and easier. But the first thing i miss was a "better" adressbook. I talked about this to thomas and he pointed me to the Ticket #1332930. Then i have included a lot fields into the database table and made this fields available under the adressbook. The fields i added now are all fields with are needed for vcard 2.1 support (export and import can then be done easier). But the problem now is, that the "right side" for each contact is a long list and maybe not everybody needs the field "tel work 2" for example. i will put my updates tomorrow to svn - but then i have to think about a nice and fast solution for users that they can change what fields they what to see for here contacts and which fields should be faded out. maybe this can be done like the folder settings under settings or maybe there is a better solution... i hope you can follow me - my english is not the best ;) - you can see it in svn tomorrow. roundecubemail is really good - thank you all. -- Best regards Tobias 'tri' Richter Visit me at: http://tobias.datenwerkstatt-richter.de/

18 56

Plaxo sync [was: Re: Addressbook improvements, first shot]
by Paul Carrasco 05 Oct '06

05 Oct '06

I agree with Chris. I would not like an API for plaxo in my webmail software. Basically roundcube is a GPL-based-contribution software, whereas plaxo (and plaxo-like services) are everything but GPL or open-source minded. They have very special ways of licencing your data and your privacy which can have annoying effects. See http://review.zdnet.com/4520-7297-5111563.html Or you can google 'plaxo is evil' Paul On 10/4/06, Chris Hembrow <chris.hembrow+mail-rc(a)pixelseventy2.net> wrote: > > Speaking personally, I would not want this. Part of the reason I moved > from using a gmail account as my primary account was so that I had complete > control of MY emails. I'm sure google would not do anything bad with my > data, but it's MY data, and I want it where only I have access to it. > Implementing an external address book system would be opening that > information up for abuse. Can you really guarantee that plaxo aren't going > to sell that data to spammers or have it stolen by crackers? > > Besides, what happens if their service goes down? You might lose access to > your address book, even temporarily this could be a royal PITA. > > Just by tuppence worth > > pixel > > On Wed, 04 Oct 2006 10:26:22 -0400, Randy Noval <randy(a)sermo.net> wrote: > > yay for addressbook management! > > > > as a thought though, rather than re-work stuff that's already been > > created, why not use existing tools. in particular, plaxo. i've been > > using it for a while as a sync tool between my treo, thunderbird, & > > outlook and by-and-large, it's been great! and they have an API: > > http://www.plaxo.com/api/ > > > > and a really nifty widget demo (access address lists from other apps): > > http://www.plaxo.com/api/widget_demo > > > > but using their (already well-thought out) field set as a guideline > > might be a good way to go. > > > > just a couple of thoughts. i love the enthusiasm in this community! > > > > thanks, > > randy >

3 2

Addressbook improvements, first shot
by shane＠gnative.com 05 Oct '06

05 Oct '06

Paul and dev's. Funny i should get this email now, i have just spent the day starting redeveloping of address book for my personal use (and hopefully others) by adding the function of grouping contacts. This is using drag and drop, the same as mail section and is using the same functions thou i need to sit back and address the javascript to make some of the functions universal as i can see them being used elsewhere ( actually the javascript is a completely different topic and one i would like to bring up once i have the architecture in my head more). The functionality will be almost idential to that of apples addressbook app. I'll post a link when i get it near complete just a few things to finish off (almost there). I'm also implementing vCard support for import and export ( in a variety of formats ) i have the scripts handy just need to plug them in.. Would also like to add the support of upcoming birthday alerts that can be turned off in "options". As for the contact image if this is going to be added the we would need to look at GD/imagemagik for resizing of uploaded images to be added to the database when creating a contacts. Any other thoughts would be great as I'm fully enjoying getting into the redesign of this. Shane On Wed, 4 Oct 2006 10:29:09 +0200, "Paul Carrasco" <paul.carrasco(a)gmail.com> wrote: > Hello everybody, > > I use roundcube for my emails but I think the adressbook is lacking a lot > of > interesting features. > 1) Ability to store multiple email adresses, phones numbers, pictures and > other info about my contacts > 2) Ability to share contacts (eg : my contacts could be seen by my wife, > since we have some friends in common ;) > 3) Ability to import/export from csv files or other adequate format > 4) Ability to display pictures of my contacts when I receive mail from > them > (can anyone remember of the "picons" idea? see > http://www.cs.indiana.edu/picons/ftp/faq.html#what) > > > So I propose the following: > 1) see the code below to implement an extended version of the contacts. > At the moment it can : > - eidt, save and display multiple info about your contacts > - mailto links working with the various emails of the contact > - I chose not to store the image in the db itself but only a link to it, > since it was simpler; but it means cross-linking between your roudcube web > site and the site hosting the image > Todo : > - when auto-completing recipient address only the first email of the > contacts can be matched > - when adding a new contact, only the first email address is checked for > redundancy > > 2) Not implemented yet > To share contacts, I have included a "global" attribute in the contact > profile. When set to True this will make the contact visible to everybody, > but editable only by the user who created it. > There will be a config attribute to disable this behaviour. > > 3) Not implemented yet, but should'nt be hard > > 4) I really like this idea (try gmail to see how it could work). I think I > will add : > - mouse-over info box that displays the contact profile when the mouse is > over a mail > - when displaying a message, show at the top the picture and some info > from > the addressbook > > > > Please tell me if you think this can be included in roundcube 'official' > version, and in that case I will send you the future updates. > > If you find bugs, please send them to me. It seems to work ok for me. If > you > prefer to work with cvs, I can do so, but on the web site it is said to > propose code by mail. > > Bye > Paul > > > > Code to implement feature 1) > > A/ DB modification (I use mysql, so this is the code to update the db > scheme). > > ALTER TABLE `contacts` ADD `email2` VARCHAR( 128 ) NOT NULL , > ADD `email3` VARCHAR( 128 ) NOT NULL , > ADD `email4` VARCHAR( 128 ) NOT NULL , > ADD `im` VARCHAR( 128 ) NOT NULL , > ADD `homephone` VARCHAR( 128 ) NOT NULL , > ADD `mobilephone` VARCHAR( 128 ) NOT NULL , > ADD `workphone` VARCHAR( 128 ) NOT NULL , > ADD `sip` VARCHAR( 128 ) NOT NULL , > ADD `webpage` VARCHAR( 256 ) NOT NULL , > ADD `birthdate` DATE NOT NULL , > ADD `pgppublickey` TEXT NOT NULL , > ADD `homeaddress` TEXT NOT NULL , > ADD `workaddress` TEXT NOT NULL , > ADD `company` VARCHAR( 128 ) NOT NULL , > ADD `comments` TEXT NOT NULL , > ADD `picture` VARCHAR( 256 ) NOT NULL , > ADD `globalcontact` BOOL NOT NULL ; > > > > > B/ Localization files updates (done only for US and fr files) > US file: program/localization/en_US/labels.inc.php > // address boook > $labels['name'] = 'Display name'; > $labels['firstname'] = 'First name'; > $labels['surname'] = 'Last name'; > $labels['email'] = 'E-Mail'; > //new labels > $labels[email2] = 'E-Mail 2'; > $labels[email3] = 'E-Mail 3'; > $labels[email4] = 'E-Mail 4'; > $labels[im] = 'Instant messaging'; > $labels[homephone] = 'Home phone'; > $labels[mobilephone] = 'Mobile phone'; > $labels[workphone] = 'Work phone'; > $labels[sip] = 'SIP'; > $labels[webpage] = 'Web page'; > $labels[birthdate] = 'Birth date'; > $labels[pgppublickey]= 'PGP public key'; > $labels[homeaddress] = 'Home address'; > $labels[workaddress] = 'Work address'; > $labels[company] = 'Company'; > $labels[comments] = 'Comments'; > $labels[picture] = 'Picture'; > $labels[globalcontact]= 'Global contact'; > > > > fr file: program/localization/fr/labels.inc.php > // address boook > $labels['name'] = 'Nom à afficher'; > $labels['firstname'] = 'Prénom'; > $labels['surname'] = 'Nom'; > $labels['email'] = 'e-Mail'; > //new labels > $labels[email2] = 'e-Mail 2'; > $labels[email3] = 'e-Mail 3'; > $labels[email4] = 'e-Mail 4'; > $labels[im] = 'Messagerie instantanée'; > $labels[homephone] = 'Téléphone domicile'; > $labels[mobilephone] = 'Téléphone mobile'; > $labels[workphone] = 'Téléphone professionnel'; > $labels[sip] = 'SIP'; > $labels[webpage] = 'Page web'; > $labels[birthdate] = 'Date de naissance'; > $labels[pgppublickey]= 'Clé publique PGP'; > $labels[homeaddress] = 'Adresse domicile'; > $labels[workaddress] = 'Adresse professionnelle'; > $labels[company] = 'Société'; > $labels[comments] = 'Commentaires'; > $labels[picture] = 'Image'; > $labels[globalcontact]= 'Contact global'; > > > > > C/ New config options > To be appended at the end of the file: config/main.inc.php > // addressbook configuration > // chose which columns in the addressbook to enable, the columns are > displayed in the specified order > $rcmail_config['addressbook_show_cols'] = array('picture', 'name', > 'firstname', 'surname', 'email', 'email2', 'email3', 'email4', 'im', > 'homephone', 'mobilephone', 'workphone', 'sip', 'webpage', 'birthdate', > 'pgppublickey', 'homeaddress', 'workaddress', 'company', 'comments', > 'globalcontact'); > > // image size in address book > $rcmail_config['addressbook_image_width'] = '100'; > $rcmail_config['addressbook_image_height'] = '100'; > > // enable global contacts > $rcmail_config['adressbook_enable_global_contacts'] = 'true'; > > > > > > D/ Show contact update > Update the rcmail_contact_details function in the file: > program/steps/addressbook/show.inc > function rcmail_contact_details($attrib) > { > global $CONFIG, $CONTACT_RECORD, $JS_OBJECT_NAME; > > if (!$CONTACT_RECORD) > return show_message('contactnotfound'); > > // a specific part is requested > if ($attrib['part']) > return rep_specialchars_output($CONTACT_RECORD[$attrib['part']]); > > > // return the complete address record as table > $out = "<table>\n\n"; > > $a_show_cols = $CONFIG['addressbook_show_cols']; > foreach ($a_show_cols as $col) > { > if (substr($col,0,5)=='email' && $CONTACT_RECORD[$col]) > $value = sprintf('<a href="#compose" > onclick="%s.command(\'compose\', > \'%d_%s\')" title="%s">%s</a>', > $JS_OBJECT_NAME, > $CONTACT_RECORD['contact_id'], > $col, > rcube_label('composeto'), > $CONTACT_RECORD[$col]); > elseif ($col=="picture" && $CONTACT_RECORD[$col]) > $value = sprintf('<img height="%s" width="%s" src="%s" />', > $CONFIG['addressbook_image_height'], > $CONFIG['addressbook_image_width'], > $CONTACT_RECORD[$col]); > else > $value = rep_specialchars_output($CONTACT_RECORD[$col]); > > $title = rcube_label($col); > $out .= sprintf("<tr><td class=\"title\">%s</td><td>%s</td></tr>\n", > $title, $value); > } > > > $out .= "\n</table>"; > > return $out; > } > > > > > E/ Edit contact update > Update the rcmail_contact_editform function in the file: > program/steps/addressbook/edit.inc > function rcmail_contact_editform($attrib) > { > global $CONFIG, $CONTACT_RECORD, $JS_OBJECT_NAME; > > if (!$CONTACT_RECORD && $GLOBALS['_action']!='add') > return rcube_label('contactnotfound'); > > // add some labels to client > rcube_add_label('noemailwarning'); > rcube_add_label('nonamewarning'); > > list($form_start, $form_end) = get_form_tags($attrib); > unset($attrib['form']); > > > // a specific part is requested > if ($attrib['part']) > { > $out = $form_start; > $out .= rcmail_get_edit_field($attrib['part'], > $CONTACT_RECORD[$attrib['part']], $attrib); > return $out; > } > > > // return the complete address edit form as table > $out = "$form_start<table>\n\n"; > > #$a_show_cols = array('name', 'firstname', 'surname', 'email'); > $a_show_cols = $CONFIG['addressbook_show_cols']; > foreach ($a_show_cols as $col) > { > $attrib['id'] = 'rcmfd_'.$col; > $title = rcube_label($col); > if (($col=='homeaddress' || $col=='workaddress' || $col=='comments') > && > $CONTACT_RECORD[$col]) > $value = rcmail_get_edit_field($col, $CONTACT_RECORD[$col], $attrib, > 'textarea'); > else > $value = rcmail_get_edit_field($col, $CONTACT_RECORD[$col], > $attrib); > > $out .= sprintf("<tr><td class=\"title\"><label > for=\"%s\">%s</label></td><td>%s</td></tr>\n", > $attrib['id'], > $title, > $value); > } > > $out .= "\n</table>$form_end"; > > return $out; > } > > > > F/ Save contact update > Replace the line > $a_save_cols = array('name', 'firstname', 'surname', 'email'); > by > $a_save_cols = $CONFIG['addressbook_show_cols']; > in the file: program/steps/addressbook/save.inc > > > > > G/ Compose mail update (to to chose not only the first email, but also one > of the others depending on which link was clicked in the contact profile) > Update the "case 'to'" in the compose action, in the file: > program/steps/mail/compose.inc > case 'to': > $fname = '_to'; > $header = 'to'; > > // we have contact id's as get parameters > if (!empty($_GET['_to']) && preg_match('/^[0-9]+(,[0-9]+)*$/', > $_GET['_to'])) > { > $a_recipients = array(); > $sql_result = $DB->query("SELECT name, email > FROM ".get_table_name('contacts')." > WHERE user_id=? > AND del<>1 > AND contact_id IN > (".$_GET['_to'].")", > $_SESSION['user_id']); > > while ($sql_arr = $DB->fetch_assoc($sql_result)) > $a_recipients[] = format_email_recipient($sql_arr['email'], > $sql_arr['name']); > > if (sizeof($a_recipients)) > $fvalue = join(', ', $a_recipients); > } > else if (!empty($_GET['_to']) && > preg_match('/^[0-9]+_email[0-9]*$/', > $_GET['_to'])) > { > $a_recipients = array(); > preg_match('/^([0-9])+_(email[0-9]*)$/', $_GET['_to'], $matches); > $sql_result = $DB->query("SELECT name, ".$matches[2]." > FROM ".get_table_name('contacts')." > WHERE user_id=? > AND del<>1 > AND contact_id IN (".$matches[1].")", > $_SESSION['user_id']); > > while ($sql_arr = $DB->fetch_assoc($sql_result)) > $a_recipients[] = format_email_recipient($sql_arr[$matches[2]], > $sql_arr['name']); > > if (sizeof($a_recipients)) > $fvalue = join(', ', $a_recipients); > } > > else if (!empty($_GET['_to'])) > $fvalue = $_GET['_to']; > > ---------------------------------------------------------------------------------------------------- Variety is the spice of life .. except in Thailand where the spice makes your life slip out your arsehole. ----------------------------------------------------------------------------------------------------

5 4

Addressbook improvements, first shot
by Paul Carrasco 04 Oct '06

04 Oct '06

Hello everybody, I use roundcube for my emails but I think the adressbook is lacking a lot of interesting features. 1) Ability to store multiple email adresses, phones numbers, pictures and other info about my contacts 2) Ability to share contacts (eg : my contacts could be seen by my wife, since we have some friends in common ;) 3) Ability to import/export from csv files or other adequate format 4) Ability to display pictures of my contacts when I receive mail from them (can anyone remember of the "picons" idea? see http://www.cs.indiana.edu/picons/ftp/faq.html#what) So I propose the following: 1) see the code below to implement an extended version of the contacts. At the moment it can : - eidt, save and display multiple info about your contacts - mailto links working with the various emails of the contact - I chose not to store the image in the db itself but only a link to it, since it was simpler; but it means cross-linking between your roudcube web site and the site hosting the image Todo : - when auto-completing recipient address only the first email of the contacts can be matched - when adding a new contact, only the first email address is checked for redundancy 2) Not implemented yet To share contacts, I have included a "global" attribute in the contact profile. When set to True this will make the contact visible to everybody, but editable only by the user who created it. There will be a config attribute to disable this behaviour. 3) Not implemented yet, but should'nt be hard 4) I really like this idea (try gmail to see how it could work). I think I will add : - mouse-over info box that displays the contact profile when the mouse is over a mail - when displaying a message, show at the top the picture and some info from the addressbook Please tell me if you think this can be included in roundcube 'official' version, and in that case I will send you the future updates. If you find bugs, please send them to me. It seems to work ok for me. If you prefer to work with cvs, I can do so, but on the web site it is said to propose code by mail. Bye Paul Code to implement feature 1) A/ DB modification (I use mysql, so this is the code to update the db scheme). ALTER TABLE `contacts` ADD `email2` VARCHAR( 128 ) NOT NULL , ADD `email3` VARCHAR( 128 ) NOT NULL , ADD `email4` VARCHAR( 128 ) NOT NULL , ADD `im` VARCHAR( 128 ) NOT NULL , ADD `homephone` VARCHAR( 128 ) NOT NULL , ADD `mobilephone` VARCHAR( 128 ) NOT NULL , ADD `workphone` VARCHAR( 128 ) NOT NULL , ADD `sip` VARCHAR( 128 ) NOT NULL , ADD `webpage` VARCHAR( 256 ) NOT NULL , ADD `birthdate` DATE NOT NULL , ADD `pgppublickey` TEXT NOT NULL , ADD `homeaddress` TEXT NOT NULL , ADD `workaddress` TEXT NOT NULL , ADD `company` VARCHAR( 128 ) NOT NULL , ADD `comments` TEXT NOT NULL , ADD `picture` VARCHAR( 256 ) NOT NULL , ADD `globalcontact` BOOL NOT NULL ; B/ Localization files updates (done only for US and fr files) US file: program/localization/en_US/labels.inc.php // address boook $labels['name'] = 'Display name'; $labels['firstname'] = 'First name'; $labels['surname'] = 'Last name'; $labels['email'] = 'E-Mail'; //new labels $labels[email2] = 'E-Mail 2'; $labels[email3] = 'E-Mail 3'; $labels[email4] = 'E-Mail 4'; $labels[im] = 'Instant messaging'; $labels[homephone] = 'Home phone'; $labels[mobilephone] = 'Mobile phone'; $labels[workphone] = 'Work phone'; $labels[sip] = 'SIP'; $labels[webpage] = 'Web page'; $labels[birthdate] = 'Birth date'; $labels[pgppublickey]= 'PGP public key'; $labels[homeaddress] = 'Home address'; $labels[workaddress] = 'Work address'; $labels[company] = 'Company'; $labels[comments] = 'Comments'; $labels[picture] = 'Picture'; $labels[globalcontact]= 'Global contact'; fr file: program/localization/fr/labels.inc.php // address boook $labels['name'] = 'Nom à afficher'; $labels['firstname'] = 'Prénom'; $labels['surname'] = 'Nom'; $labels['email'] = 'e-Mail'; //new labels $labels[email2] = 'e-Mail 2'; $labels[email3] = 'e-Mail 3'; $labels[email4] = 'e-Mail 4'; $labels[im] = 'Messagerie instantanée'; $labels[homephone] = 'Téléphone domicile'; $labels[mobilephone] = 'Téléphone mobile'; $labels[workphone] = 'Téléphone professionnel'; $labels[sip] = 'SIP'; $labels[webpage] = 'Page web'; $labels[birthdate] = 'Date de naissance'; $labels[pgppublickey]= 'Clé publique PGP'; $labels[homeaddress] = 'Adresse domicile'; $labels[workaddress] = 'Adresse professionnelle'; $labels[company] = 'Société'; $labels[comments] = 'Commentaires'; $labels[picture] = 'Image'; $labels[globalcontact]= 'Contact global'; C/ New config options To be appended at the end of the file: config/main.inc.php // addressbook configuration // chose which columns in the addressbook to enable, the columns are displayed in the specified order $rcmail_config['addressbook_show_cols'] = array('picture', 'name', 'firstname', 'surname', 'email', 'email2', 'email3', 'email4', 'im', 'homephone', 'mobilephone', 'workphone', 'sip', 'webpage', 'birthdate', 'pgppublickey', 'homeaddress', 'workaddress', 'company', 'comments', 'globalcontact'); // image size in address book $rcmail_config['addressbook_image_width'] = '100'; $rcmail_config['addressbook_image_height'] = '100'; // enable global contacts $rcmail_config['adressbook_enable_global_contacts'] = 'true'; D/ Show contact update Update the rcmail_contact_details function in the file: program/steps/addressbook/show.inc function rcmail_contact_details($attrib) { global $CONFIG, $CONTACT_RECORD, $JS_OBJECT_NAME; if (!$CONTACT_RECORD) return show_message('contactnotfound'); // a specific part is requested if ($attrib['part']) return rep_specialchars_output($CONTACT_RECORD[$attrib['part']]); // return the complete address record as table $out = "<table>\n\n"; $a_show_cols = $CONFIG['addressbook_show_cols']; foreach ($a_show_cols as $col) { if (substr($col,0,5)=='email' && $CONTACT_RECORD[$col]) $value = sprintf('<a href="#compose" onclick="%s.command(\'compose\', \'%d_%s\')" title="%s">%s</a>', $JS_OBJECT_NAME, $CONTACT_RECORD['contact_id'], $col, rcube_label('composeto'), $CONTACT_RECORD[$col]); elseif ($col=="picture" && $CONTACT_RECORD[$col]) $value = sprintf('<img height="%s" width="%s" src="%s" />', $CONFIG['addressbook_image_height'], $CONFIG['addressbook_image_width'], $CONTACT_RECORD[$col]); else $value = rep_specialchars_output($CONTACT_RECORD[$col]); $title = rcube_label($col); $out .= sprintf("<tr><td class=\"title\">%s</td><td>%s</td></tr>\n", $title, $value); } $out .= "\n</table>"; return $out; } E/ Edit contact update Update the rcmail_contact_editform function in the file: program/steps/addressbook/edit.inc function rcmail_contact_editform($attrib) { global $CONFIG, $CONTACT_RECORD, $JS_OBJECT_NAME; if (!$CONTACT_RECORD && $GLOBALS['_action']!='add') return rcube_label('contactnotfound'); // add some labels to client rcube_add_label('noemailwarning'); rcube_add_label('nonamewarning'); list($form_start, $form_end) = get_form_tags($attrib); unset($attrib['form']); // a specific part is requested if ($attrib['part']) { $out = $form_start; $out .= rcmail_get_edit_field($attrib['part'], $CONTACT_RECORD[$attrib['part']], $attrib); return $out; } // return the complete address edit form as table $out = "$form_start<table>\n\n"; #$a_show_cols = array('name', 'firstname', 'surname', 'email'); $a_show_cols = $CONFIG['addressbook_show_cols']; foreach ($a_show_cols as $col) { $attrib['id'] = 'rcmfd_'.$col; $title = rcube_label($col); if (($col=='homeaddress' || $col=='workaddress' || $col=='comments') && $CONTACT_RECORD[$col]) $value = rcmail_get_edit_field($col, $CONTACT_RECORD[$col], $attrib, 'textarea'); else $value = rcmail_get_edit_field($col, $CONTACT_RECORD[$col], $attrib); $out .= sprintf("<tr><td class=\"title\"><label for=\"%s\">%s</label></td><td>%s</td></tr>\n", $attrib['id'], $title, $value); } $out .= "\n</table>$form_end"; return $out; } F/ Save contact update Replace the line $a_save_cols = array('name', 'firstname', 'surname', 'email'); by $a_save_cols = $CONFIG['addressbook_show_cols']; in the file: program/steps/addressbook/save.inc G/ Compose mail update (to to chose not only the first email, but also one of the others depending on which link was clicked in the contact profile) Update the "case 'to'" in the compose action, in the file: program/steps/mail/compose.inc case 'to': $fname = '_to'; $header = 'to'; // we have contact id's as get parameters if (!empty($_GET['_to']) && preg_match('/^[0-9]+(,[0-9]+)*$/', $_GET['_to'])) { $a_recipients = array(); $sql_result = $DB->query("SELECT name, email FROM ".get_table_name('contacts')." WHERE user_id=? AND del<>1 AND contact_id IN (".$_GET['_to'].")", $_SESSION['user_id']); while ($sql_arr = $DB->fetch_assoc($sql_result)) $a_recipients[] = format_email_recipient($sql_arr['email'], $sql_arr['name']); if (sizeof($a_recipients)) $fvalue = join(', ', $a_recipients); } else if (!empty($_GET['_to']) && preg_match('/^[0-9]+_email[0-9]*$/', $_GET['_to'])) { $a_recipients = array(); preg_match('/^([0-9])+_(email[0-9]*)$/', $_GET['_to'], $matches); $sql_result = $DB->query("SELECT name, ".$matches[2]." FROM ".get_table_name('contacts')." WHERE user_id=? AND del<>1 AND contact_id IN (".$matches[1].")", $_SESSION['user_id']); while ($sql_arr = $DB->fetch_assoc($sql_result)) $a_recipients[] = format_email_recipient($sql_arr[$matches[2]], $sql_arr['name']); if (sizeof($a_recipients)) $fvalue = join(', ', $a_recipients); } else if (!empty($_GET['_to'])) $fvalue = $_GET['_to'];

1 0

Default encoding proposal
by NetOne - Doichin Dokov 29 Sep '06

29 Sep '06

Hi, I've uploaded a patch to make default encoding depend on current language file (I think that's better than blindly reverting to latin1/ISO-8859-1). Here it is : http://trac.roundcube.net/trac.cgi/ticket/1483839 Regards, Doichin

1 0

Better username-Handling
by Martin Eitzenberger 28 Sep '06

28 Sep '06

Hi! I somehow "improved" the way how roundcubes handles virtual users... This is, because my server panel (ispconfig) somehow creates an ugly virtual user table, therefore i want strictly the real mail username as common-name for accounts, so I moved the email2user BEFORE the first mysql-query // PART OF main.inc / rcmail_login(...) // $imap_port = $CONFIG['default_port']; // try to resolve email address from virtuser table if (!empty($CONFIG['virtuser_file']) && strstr($user, '@')) $user = rcmail_email2user($user); // query if user already registered $sql_result = $DB->query("SELECT user_id, username, language, preferences FROM ".get_table_name('users')." WHERE mail_host=? AND (username=? OR alias=?)", // END OF PART // This way, the database is forced to be on a real-username basis and doesn't create different addressbooks and settings by logging in with the different aliases of the same mailbox (wich makes no sense at all...) Another thing is, that I created faster mail2user and user2mail functions, use them if you like, GPL Code as usual ;-), mention me in some author/history/changelog if you like, I'm not one of these Super-EGO people who need to be mentioned anywhere, but I'm not against it either ;-) The functions are currently named "rcmail_getvlist", "rcmail_email2user" and "rcmail_user2email": // SNIPPET for main.inc // function rcmail_getvlist() { global $CONFIG,$x_listcache; if(!is_array($x_listcache)) { if(!is_file($CONFIG['virtuser_file']))return(array()); $f=file($CONFIG['virtuser_file']); while(list(,$t)=each($f))if(($t=trim($t))&&$t[0]!="#") { $t=str_replace("\t"," ",$t); while(strstr($t," "))$t=str_replace(" "," ",$t); list($x,$y)=explode(" ",$t); $e[$x]=$y; $u[$y]=$x; } $x_listcache=array($e,$u); } return($x_listcache); } function rcmail_email2user($email) { $l=rcmail_getvlist(); $x=$l[0][$email] return((($x)?$x:$email)); } function rcmail_user2email($user) { $l=rcmail_getvlist(); $x=$l[1][$user] return((($x)?$x:$user)); } // END OF SNIPPED // Basically, the getvlist returns (cached run, for future usage in sessions and/or multiple usage) a multi-dimensional array, value 0 contains an assoc-list with mail2user and 1 a list of user2mail. so you easily get the user: $user=$l[0][$email] ... the vlist basically works stable on all sendmail-style mailtab files, space or tab seperated (postfix, sendmail, exim, etc.) with single user to alias associations. Yeah, one other thing: I strongly recommend that you don't rely on any user2email functions, because often there are many aliases for the same user, and there is no rule to tell wich is the prefered one... Okay, hope I could help you, thanx for the only free webmailer I >want< to use ;-) And if anyone of you speaks german, please visit my RPG: http://pb.exw.at/ Have Fun! Martin alias PSIplus

1 0

BG localization - SVN r357
by NetOne - Doichin Dokov 28 Sep '06

28 Sep '06

Hi guys, I've published an svn-r357 BG localization at http://mirror.net1.cc/projects/roundcubemail%20-%20bg%20language/ Also, the wiki translation page doesn't say about some new strings: $messages['converting'] = 'Removing formatting from message...'; $labels['htmltoggle'] = 'HTML'; $labels['plaintoggle'] = 'Plain text'; $labels['htmleditor'] = 'Compose HTML messages'; $labels['htmlsignature'] = 'HTML signature'; $labels['autosavedraft'] = 'Automatically save draft'; $labels['everynminutes'] = 'every $n minutes'; $labels['never'] = 'never'; $labels['renamefolder'] = 'Rename folder'; Regards, Doichin

2 1

Bulgarian translation
by NetOne - Doichin Dokov 28 Sep '06

28 Sep '06

This is another Bulgarian translation, done by myself. I now see there's already a Bulgarian translation in svn, so maybe someone should decide which one is better. This is what I feel it should be, and is complete as of 0.1-beta2. I will soon publish current svn version compatible localization. Files are at http://mirror.net1.cc/projects/roundcubemail%20-%20bg%20language/ Regards, Doichin

1 0

DIMP
by till 25 Sep '06

25 Sep '06

Hi list, I just found "DIMP" (an Ajax interface to the wellknown IMP). Demo and screenshots are here: http://wiki.horde.org/DimpModule It looks pretty interesting in terms of what it can do and of course development development, so I thought I share the links. By the way, talking about horde/IMP. I remember that when we used it, they recommended running a proxy for imap. Is anyone running a similar setup to speed up RoundCube? Cheers, -- Till Klampaeckel e: mailto:klimpong@gmail.com p: +491704018676 l: http://beta.plazes.com/whereis/till

2 1

Traditional Chinese Language Pack
by SmallSea 25 Sep '06

25 Sep '06

Dear all, I have translated language file form english to traditional Chinese. Please download it from following link. http://www.mmlab.cse.yzu.edu.tw/~frei/dl/roundcube_zhtw-0.1-beta2.tar.gz Please tried it and see if it it okay. Thanks. :) SmallSea

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev