Dev

dev@lists.roundcube.net

1 participants
4313 discussions

Re: [RCD] Persistent messages
by Marcus Don 28 Jun '10

28 Jun '10

Hi I¹ve just taken a look at app.js and realised the alternative fix I mentioned in my previous email below (ie to always use the first value passed to display_message) is much easier. All we need to do is modify line 4321 like this: Replace this... if (!this.loaded) { ...with this... if (!this.loaded && this.pending_message instanceof Array == false) { Does anyone have any objection to this? If not, please could someone update the repository? Thanks Marcus > Hi > > I've got another small modification request... > > When using hooks to modify the behaviour of an existing action, there is > currently no way to generate an error message other than the default "An error > occurred while saving", which is shown if you set the abort flag. This is a > problem for us because we need to perform additional validation, such as > ensuring the user owns the domain for which he is trying to create an email > address (ie in create_identity). > > My suggestion is simply to add an "abort_message" element to the $args array, > which can be checked by each of the action scripts. For example, in > save_identity.inc we just need to replace each occurrence of this... > > else if ($plugin['abort'] || $DB->is_error()) > $OUTPUT->show_message('errorsaving', 'error', null, false); > > ...with this... > > } else if ($plugin['abort'] || $DB->is_error()) { > if (isset($plugin['abort_message']) && $plugin['abort_message'] != '') { > $OUTPUT->command('display_message', $plugin['abort_message'], 'error', > false); > } else { > $OUTPUT->show_message('errorsaving', 'error', null, false); > } > } > > However, this still has the problem that error messages can¹t be made > persistent (which I don¹t need, but which should be included for consistency). > So, a better method would be to only display the default message if the > messages array is empty - but I haven¹t looked into this yet. > > If there¹s another way to achieve this, I¹d be very grateful if someone could > let me know. I¹d also be grateful if someone could make the change to the > javascript functions requested in my previous email below. > > Thanks > > Marcus > > > >> Hi >> >> I'd like to suggest a small alteration to app.js in order to allow persistent >> messages to be generated when using rcmail::output::command() within a >> page-generating callback function. >> >> The rcube_webmail::display_message() function already accepts a "hold" >> parameter, but this doesn't get stored in $pending_message if the page hasn't >> yet loaded, so it gets lost. My suggestion is simply to add this extra >> parameter to $pending_message and then pass it back to display_message() >> within init(). >> >> So, on line 4323, I'd like to replace this... >> >> this.pending_message = new Array(msg, type); >> >> ...with this... >> >> this.pending_message = new Array(msg, type, hold); >> >> And, on line 385, I'd like to replace this... >> >> this.display_message(this.pending_message[0], this.pending_message[1]); >> >> ..with this... >> >> this.display_message(this.pending_message[0], this.pending_message[1], >> this.pending_message[2]); >> >> As a result of this change, I can now make messages persistent by calling >> rcmail::output::command() like this: >> >> $this->rcmail->output->command( >> 'display_message', >> '[message_text]', >> '[message_type]', >> true >> ); >> >> Thanks >> >> Marcus >> -- >> Marcus Don >> Senior Manager >> Research and Development >> DadaPro >> >> Main Line: +44 (0)845 363 3630 >> Main Fax: +44 (0)845 363 3631 >> Tech Support: +44 (0)845 363 3634 >> Email: mdon(a)names.co.uk >> Website: http://www.names.co.uk >> Address: Acton House, Perdiswell Park, Worcester WR3 7GD >> >> This email and any files transmitted with it are confidential and intended >> solely for the use of the individual or entity to whom they are addressed. >> >> If you have received this email in error please notify the sender >> immediately. If you are not the intended recipient you are notified that >> disclosing, copying, distributing or taking any action in reliance on the >> contents of this information is strictly prohibited. Please note that any >> views or opinions presented in this email are solely those of the author and >> do not necessarily represent those of the company. >> >> Finally, the recipient should check this email and any attachments for the >> presence of viruses. The company accepts no liability for any damage caused >> by any virus transmitted by this email. >> _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

New compose screen?
by A.L.E.C 26 Jun '10

26 Jun '10

I've prepared a screen for a new compose window and I've got various opinions abut this. What's your opinion? Question is for svn-trunk users, because the idea was to make compose look more unified with the rest of the current UI. -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Developer http://roundcube.net --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/vr/DD18yrED/compose.png Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

14 21

Updated Welsh translation
by Dafydd Tomos 25 Jun '10

25 Jun '10

Updated labels file for cy --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/ds/MjQp+Wco/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Re: [RCD] [Project: 137] Dev Digest, Vol 36, Issue 7
by Ross Pointon 25 Jun '10

25 Jun '10

test? On Thu, 24 Jun 2010 22:50:28 -0700, dev-request(a)lists.roundcube.net wrote: > Send Dev mailing list submissions to > dev(a)lists.roundcube.net > > To subscribe or unsubscribe via the World Wide Web, visit > http://lists.roundcube.net/mailman/listinfo/dev > or, via email, send a message with subject or body 'help' to > dev-request(a)lists.roundcube.net > > You can reach the person managing the list at > dev-owner(a)lists.roundcube.net > > When replying, please edit your Subject line so it is more specific > than "Re: Contents of Dev digest..." > > > Today's Topics: > > 1. Re: New compose screen? (liu liu) > 2. Re: New compose screen? (Patrick Nagel) > 3. Re: New compose screen? (Vladislav Bogdanov) > 4. 0.4 non-beta? (Rimas Kudelis) > 5. PHP version survey (till) > 6. Message List and Preview Pane (vertical) (S c o t t K r a m e r) > 7. Re: Message List and Preview Pane (vertical) (Cor Bosman) > 8. Re: Message List and Preview Pane (vertical) > (S c o t t K r a m e r) > 9. Re: New compose screen? (Brandon Davidson) > 10. Re: New compose screen? (Doug Mandell) > 11. Re: PHP version survey (Philip Iezzi) > > > ---------------------------------------------------------------------- > > Message: 1 > Date: Thu, 24 Jun 2010 21:46:10 +0800 > From: liu liu <nckuhuahua(a)gmail.com> > Subject: Re: [RCD] New compose screen? > To: dev(a)lists.roundcube.net > Message-ID: > <AANLkTilUYifPzpH2WoyLBW4ZZbYDPH5JV5xozmlxMLen(a)mail.gmail.com> > Content-Type: text/plain; charset=ISO-8859-1 > > That's great ! :-) > > 2010/6/24 A.L.E.C <alec(a)alec.pl>: >> I've prepared a screen for a new compose window and I've got various >> opinions abut this. What's your opinion? Question is for svn-trunk users, >> because the idea was to make compose look more unified with the rest of >> the >> current UI. >> >> -- >> Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 >> LAN Management System Developer http://lms.org.pl >> Roundcube Webmail Developer http://roundcube.net >> >> >> >> --- 8< --- detachments --- 8< --- >> The following attachments have been detached and are available for >> viewing. >> ?http://detached.gigo.com/rc/vr/DD18yrED/compose.png >> Only click these links if you trust the sender, as well as this message. >> --- 8< --- detachments --- 8< --- >> >> >> _______________________________________________ >> List info: http://lists.roundcube.net/dev/ >> >> > > > ------------------------------ > > Message: 2 > Date: Thu, 24 Jun 2010 22:40:46 +0800 > From: Patrick Nagel <mail(a)patrick-nagel.net> > Subject: Re: [RCD] New compose screen? > To: dev(a)lists.roundcube.net > Message-ID: <201006242240.50059.mail(a)patrick-nagel.net> > Content-Type: text/plain; charset="iso-8859-15" > > Hi, > > On 2010-06-24 12:14 UTC A.L.E.C wrote: >> I've prepared a screen for a new compose window and I've got various >> opinions abut this. What's your opinion? Question is for svn-trunk >> users, because the idea was to make compose look more unified with the >> rest of the current UI. > > Well done! The only thing that looks a bit awkward to me, is the huge > "Attachments" place. But I don't have an idea how to change it. > > Patrick. > > -- > Key ID: 0x86E346D4 http://patrick-nagel.net/key.asc > Fingerprint: 7745 E1BE FA8B FBAD 76AB 2BFC C981 E686 86E3 46D4 > > > > --- 8< --- detachments --- 8< --- > The following attachments have been detached and are available for > viewing. > http://detached.gigo.com/rc/sV/WyWvlSUK/signature.asc > Only click these links if you trust the sender, as well as this message. > --- 8< --- detachments --- 8< --- > > > ------------------------------ > > Message: 3 > Date: Thu, 24 Jun 2010 17:58:18 +0300 > From: Vladislav Bogdanov <bubble(a)hoster-ok.com> > Subject: Re: [RCD] New compose screen? > To: "A.L.E.C" <alec(a)alec.pl> > Cc: RoundCube Dev <dev(a)lists.roundcube.net> > Message-ID: <4C23728A.2070606(a)hoster-ok.com> > Content-Type: text/plain; charset=ISO-8859-1 > > Nice. > I'd only make "Send now" button centered relative to compose area and > some-how separated it from the "Cancel" button. > Attachment area can be smaller, but I think we should preserve space for > GPG/SMIME staff so it can push attachment area up when will be ready. > > Best, > bubble > > > > ------------------------------ > > Message: 4 > Date: Thu, 24 Jun 2010 18:12:45 +0300 > From: Rimas Kudelis <rq(a)akl.lt> > Subject: [RCD] 0.4 non-beta? > To: RoundCube Dev <dev(a)lists.roundcube.net> > Message-ID: <4C2375ED.3040307(a)akl.lt> > Content-Type: text/plain; charset=windows-1257 > > Hello, > > it's been two months since 0.4-beta was released. What are the plans > regarding non-beta releases? > > thanks, > Rimas > > > ------------------------------ > > Message: 5 > Date: Thu, 24 Jun 2010 19:08:04 +0200 > From: till <klimpong(a)gmail.com> > Subject: [RCD] PHP version survey > To: RoundCube Dev <dev(a)lists.roundcube.net> > Message-ID: > <AANLkTikm7OVc4pB__4jFJhb0BqG6Eo0IMrz47JhWLW-Y(a)mail.gmail.com> > Content-Type: text/plain; charset=ISO-8859-1 > > Could everyone reply with which PHP version they currently use in > production? Off-list is ok too. > > Thanks, > Till > > > ------------------------------ > > Message: 6 > Date: Thu, 24 Jun 2010 14:38:57 -0400 > From: S c o t t K r a m e r <scott_list(a)clevelanddata.com> > Subject: [RCD] Message List and Preview Pane (vertical) > To: RoundCube Dev <dev(a)lists.roundcube.net> > Message-ID: <d25ee445fd4dece24eb724ad1e814fc5(a)clevelanddata.com> > Content-Type: text/plain; charset="utf-8" > > > > I like the new design-- and was thinking, is it time to do a vertical > layout? > > It seems like now would be a good time to do it. Shouldn't > this be a core feature? So many people have wide screens now. > What do > you guys think! > Thanks, > Scott >

1 0

0.4 non-beta?
by Rimas Kudelis 24 Jun '10

24 Jun '10

Hello, it's been two months since 0.4-beta was released. What are the plans regarding non-beta releases? thanks, Rimas _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Hungarian translation update
by pete 24 Jun '10

24 Jun '10

Hi, attached the missing text for labels.inc. -- Péter XMPP, MSN: peter.laszlo.szabo(a)gmail.com --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/U3/cVClS1lV/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Update Hebrew translation
by Moish 23 Jun '10

23 Jun '10

-- Moish --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/xJ/tvcdDjrO/messages.inc http://detached.gigo.com/rc/xJ/tvcdDjrO/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Updated zh_TW localization of labels.inc
by liu liu 23 Jun '10

23 Jun '10

I’ve attached an updated Chinese (Traditional) localization of labels.inc. Regards, YS Liu Thomas --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Fe/lXD+Tv5R/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Updated zh_TW localization of messages.inc
by liu liu 23 Jun '10

23 Jun '10

I’ve attached an updated Chinese (Traditional) localization of messages.inc. Best Regards, YS Liu Thomas --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/fx/ys3PSUDc/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

update for Czech and Slovak translation
by Aleš Pospíchal 22 Jun '10

22 Jun '10

Hello, This is update to get better translations for some texts. Ales Pospichal --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/wb/Xt7tPDkG/labels-cz.inc http://detached.gigo.com/rc/wb/Xt7tPDkG/labels-sk.inc http://detached.gigo.com/rc/wb/Xt7tPDkG/messages-cz.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev