Dev

dev@lists.roundcube.net

2 participants
4301 discussions

File naming conventions
by Dirk Rennen 09 Jan '09

09 Jan '09

I was looking into the development guidelines File Naming conventions and I have a suggestion: I should mention that certain extentions output plain text from standard browsers which can be easily fixed. Secondly the fix open an opportunity to expand and clarify the intention of the files by adding the intention in front of the file Screen output files: filename.php Process files: filename.php => process/filename.php or process.filename.php (with filename same as calling or pulling filename so you know what it relates to) Includeble script block: filename.inc => inc.filename.php Includeble functions: filenmame.inc => fie.filename.php or lib.filename.php (personally prefer the first) Includeble classes: filename.class.php => class.filename.php That way output is always empty + you know what's in the file without opening it. You basically can do the same for javascript: Basic js file: filename.js Included js file: filename.js.src => src.filename.js You should also consider putting html comment tags around the javascript code (<!-code //-->) so it wont output if javascript is turned off. To make sure javascript is turned on, you should consider disabling all process buttons and turning them on at runtime. I haven't looked at the database conventions, but what I personally always do is the following: SELECT field FROM Table WHERE otherfield LIKE 'value' LIMIT 0,1; As you can see sql-specific parts are in uppercase, fields in lowercase and table in ucfirst. This way you can separate what they are by simply looking how it's written. PS the LIMIT 0,1 (mysql) is a faster query then without, even when you know there can only be one value returned, as it stops looking after it's found one which it wont if the limit is not there. Note that it's just a suggestion, which I've used myself for a few years now. Especially in complicated applications it's proven to be very useful to me as it reduces time when searching for the wright file, even after some time has passed working on the application. ----------------------- Wkr, Dirk Rennen KPN Belgium N.V. Koningin Astridlaan 166 1780 Wemmel Belgium _______________________________________________ List info: http://lists.roundcube.net/dev/

2 2

Updated russian translation
by Artur Smolkin 08 Jan '09

08 Jan '09

Hi all. Happy new year! There is updated russian translation. Hope to see it in next release :) -- Artur Smolkin Manager of Russian RoundCube Webmail Project www.roundcube.ru --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/5p/zygr152V/messages.inc http://detached.gigo.com/rc/5p/zygr152V/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Next idea for message display speed up
by A.L.E.C 08 Jan '09

08 Jan '09

For most of plain text messages we have two FETCH commands now: C: FH12 UID FETCH 4790 (UID RFC822.SIZE FLAGS INTERNALDATE BODYSTRUCTURE BODY.PEEK[HEADER.FIELDS (DATE FROM TO SUBJECT REPLY-TO IN-REPLY-TO CC BCC CONTENT-TRANSFER-ENCODING CONTENT-TYPE MESSAGE-ID REFERENCES DISPOSITION-NOTIFICATION-TO X-PRIORITY)]) [08-Jan-2009 15:21:29 +0100]: C: ftch FETCH 640 (BODY.PEEK[1]) We can prefetch a small part of message body (first part) using BODY.PEEK[1]<0.4096> in first FETCH. Then we should check if message is realy a plain text and if body size (from BODYSTRUCTURE) is not bigger than 4096 bytes. If so we can skip the second FETCH. -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Project Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/

1 1

Next performance improvement
by A.L.E.C 08 Jan '09

08 Jan '09

Hi! I have another great patch from my performance fixes set ;) I've observed that when message is displayed (with disabled cache) we have: 1. FETCH for headers 2. FETCH for message (body) structure 3. one FETCH for each message/attachment part (it really sucks when message contains several attachments) 4. FETCH for body So, here's the patch which joins 1. and 2. into one command call and joins all fetches from 3. into one command call. Speed up is significant for all messages, specially for those having many attachments. Imagine a message with ten attachments. Previously there was ca.10 + 3 fetches * 0.2 sec. (in my mailbox with ca.800 messages) = 2.6 sec. Now, only 3 fetches * 0.2 = 0.6 sec. I'm posting this here, because it's too late to commit such changes (not tested well) before 0.2-stable release. So, enjoy and test in your environments. ps. Thomas, maybe you can wait a few days and review this patch to include in 0.2-stable? It would be nice. -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Developer http://roundcube.net --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Wr/HvaAQAVp/perf.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

4 12

Roundcube api !
by Maximilien Cuony [The_Glu] 08 Jan '09

08 Jan '09

Hello everybody ! So ! 0.2 stable is here, I see 0.2.1 is planned for bug fixes, so 0.3 is almost here, and in 0.3 plugin api is planned so.. when we will able to begin to code a plugin (maybe with a different branch ? )? :] Regards, -- Maximilien Cuony [The_Glu] http://theglu.org _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

compacted js files
by Phil Weir 08 Jan '09

08 Jan '09

Hi, Does any one know what was used to minimise the JS files in the 0.2stable tarball? Also why the tarball is different from the 0.2stable branch/tag? I generated some patches against 0.2stable from the SVN and then they don’t work with the other version :/. Thanks Phil _______________________________________________ List info: http://lists.roundcube.net/dev/

2 1

RFC: Add "edit as new" function to roundcube
by Christian Beer 05 Jan '09

05 Jan '09

Thunderbird has a very cool feature called "Edit as new". What it does is simple. It takes the message "as is" without quoting it like replying or forwarding, so I can reuse my messages as templates and don't have to painfully copy/paste the message every time I want to duplicate it. For example: one of my customers has to send a password mail "by hand" to his newly registered customers and uses an old send message as template (changing the private data) using the "Edit as new" feature in Thunderbird. When he is not at his computer he wants to send this message using the webmailer (my RoundCube installation of course). I already implemented this in my installation with minimal effort using the forward command as template. I don't have a patch for the newest svn trunk but can provide it if this is going to be implemented. I can provide the patch and translation files for German. What I need is a picture for the button that appears next to the forward button maybe on of you has an idea? Could you please add your thoughts about this? Regards Christian _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

skip deleted and caching conflict
by Ziba Scott 05 Jan '09

05 Jan '09

Hi Devs, I was hoping someone would have the time to look at http://trac.roundcube.net/ticket/1485634 It's a bug patch I posted a few weeks ago which details how turning on skip deleted and caching at the same time can cause serious misbehavior. It's been a real pain for us in our environment. I think it's serious enough that, until its fixed, it at least warrants something like a warning in the config file that those options are incompatible. Thanks. Ziba Webmaster Team University of Michigan _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

raise_error() calls
by Robin Elfrink 05 Jan '09

05 Jan '09

Hi, Trying to fix #1485659, which hurts me too, I noticed a number of raise_error() calls missing required parameters. Attached patch fixes three of those. Not sure though if type in utf8.class.php and spell_pspell.inc should be 'php', so I'm not committing this yet. There are two other occurances in rcube_ldap.php, but I have no clue what error code to put there. Robin --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Vp/NN6EXh1a/raise_error.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

2 3

Updated Korean Localization
by Kim Hanjo 05 Jan '09

05 Jan '09

Hi, Here is the updated Korean Localization files. Hanjo Kim --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Kw/WvhG8XA3/ko_KR.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev