Hello everybody, this is my first post in this list.
As soon as I installed roundcubemail, I really appreciated the virtuser_file/virtuser_query config options to
automatically fill-in the email address when auto_create_user is set to true, but I was a little disappointed to see
that there is no way to automatically set the user's real name.
Moreover silently setting the login name as the sender's real name reveals to mail recipients an information that should
be usually kept secret.
For these two reasons I wrote this very little patch to add some more automation.
you can apply it to svn 1452 directly, with "patch -p1 <this_message"
or you can apply it to release 0.1.1 tweaking a file name:
"sed 's/rcube_user\.php/rcube_user.inc/g' <this_message | patch -p1"
there are two new config entries, leaving both empty preserves the actual behavior.
"passwd_query" works exactly as "virtuser_query", a example query may be:
select real_name from some_table where login_name="%u"
"passwd_file" will extract the "gecos" field from a passwd-like file, a example line may be:
unixname:x:1000:100:John Doe:/usr/share/empty:/bin/false
I hope that this very little unintrusive patch will be included in the next release :)
diff -Naubr roundcubemail.old/config/main.inc.php.dist roundcubemail.new/config/main.inc.php.dist
--- roundcubemail.old/config/main.inc.php.dist 2008-05-29 17:21:51.000000000 +0200
+++ roundcubemail.new/config/main.inc.php.dist 2008-05-29 17:19:21.000000000 +0200
@@ -61,6 +61,14 @@
// The query should select the user's e-mail address as first col
$rcmail_config['virtuser_query'] = '';
+// Path to a passwd-like file to get real name from user name
+$rcmail_config['passwd_file'] = '';
+
+// Query to get real name from user name
+// %u will be replaced with the current username for login.
+// The query should select the user's real name as first col
+$rcmail_config['passwd_query'] = '';
+
// use this host for sending mails.
// to use SSL connection, set ssl://smtp.host.com
// if left blank, the PHP mail() function is used
diff -Naubr roundcubemail.old/program/include/rcube_user.php roundcubemail.new/program/include/rcube_user.php
--- roundcubemail.old/program/include/rcube_user.php 2008-05-29 17:21:54.000000000 +0200
+++ roundcubemail.new/program/include/rcube_user.php 2008-05-29 17:39:45.000000000 +0200
@@ -368,6 +368,25 @@
$user_email = strpos($user, '@') ? $user : sprintf('%s@%s', $user, $mail_domain);
$user_name = $user != $user_email ? $user : '';
+ if (!empty($CONFIG['passwd_file'])) {
+ if ($fp = fopen ($CONFIG['passwd_file'], 'r')) {
+ do {
+ $line = explode (':', fgets ($fp));
+ if ((count ($line) >= 5) && ($line[0] == $user)) {
+ $user_name = $line[4];
+ break;
+ }
+ } while (feof ($fp) == FALSE);
+ fclose ($fp);
+ }
+ }
+ if (!empty($CONFIG['passwd_query'])) {
+ if ($sql_result = $DB->query (preg_replace('/%u/', $DB->escapeSimple($user), $CONFIG['passwd_query']))) {
+ while ($sql_arr = $DB->fetch_array($sql_result)) {
+ $user_name = $sql_arr[0];
+ }
+ }
+ }
// try to resolve the e-mail address from the virtuser table
if ($virtuser_query = $rcmail->config->get('virtuser_query') &&
_______________________________________________
List info: http://lists.roundcube.net/dev/
Currently I'm working on folders list sorting and see locale issue. In
roundcube we've got setlocale(LC_ALL, 'xx') where 'xx' is a selected
language. For Polish it's 'pl', but we need 'pl_PL.UTF-8' for proper
sorting. I propose to add locale.inc file with that definition in
localization folders or just add label 'localename' with specified
value. Not sure what will be better.
--
Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252
LAN Management System Developer http://lms.org.pl
Roundcube Webmail Project Developer http://roundcube.net
_______________________________________________
List info: http://lists.roundcube.net/dev/
HTML composer:
Did you consider using Fckeditor? I checked the archives
and I saw that there was a discussion about that in Oct 2005, and the
conclusion was that the goal is to support plugging any editor with plugins
API, what's being developped. What's the status of this?
I used both TinyMCE and FCKeditor and I prefer FCK.
JS interface:
Did you consider using a JS framework? I've been working quite much with
prototype
and after that JQuery. My personal preference is JQuery, based on
experiences.
Rewriting would be a big job, but could be done continuously, during the
process
both packages would exist.
There are some benefits, I think even the code would become smaller, and
pre-created interface plugins could be used. (And the packed version is
just 16k.)
What do you think?
balázs
--
*Horváth Balázs* *Balázs Horváth*
Fejlesztési vezető Development Manager
WG Informatika Kft. WG Informatics Ltd.
H-1123 Budapest, Alkotás utca 53. (MOM Park, "D torony" II.em)
Mobil: +36/20-971-2904
E-mail: horvath.balazs(a)wgi.hu <mailto:horvath.balazs@wgi.hu>
Web: http://wgi.hu <http://wgi.hu?adid=145>
_______________________________________________
List info: http://lists.roundcube.net/dev/
labels.inc attached.
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/5X/zYuA4UmT/labels.inc
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
This is Bahasa Melayu translation (ms_MY) for messages.inc
--
zamri
Linux System Administrator
Kolej ShahPutra Kuantan
Pahang Malaysia
Tel : 609.573.777.7 ext 119
web : http://muhdzamri.blogspot.com
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/HU/slSyHyD5/messages.inc
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
This is Bahasa Melayu (ms_MY) translation for labels.inc
--
zamri
Linux System Administrator
Kolej ShahPutra Kuantan
Pahang Malaysia
Tel : 609.573.777.7 ext 119
web : http://muhdzamri.blogspot.com
--- 8< --- detachments --- 8< ---
The following attachments have been detached and are available for viewing.
http://detached.gigo.com/rc/6z/I2HghUjJ/labels.inc
Only click these links if you trust the sender, as well as this message.
--- 8< --- detachments --- 8< ---
_______________________________________________
List info: http://lists.roundcube.net/dev/
hi,
i just experienced that if a message is larger than the php memory limit,
then RCD simply fails to open it.
The msg was 85Mb (a large attachment), i set a 64Mb limit on php and i'm
using the latest release version v0.1.1 and it was viewed in the preview
mode.
Can anybody confirm this?
--
Péter
Serial is up, protocol is up --- everything connected!
(c) Anthony Panda www.anthonypanda.com
_______________________________________________
List info: http://lists.roundcube.net/dev/
Hi,
My name is Anthony COGLIANDRO working in COGLIANDRO sa in France.
We keep up with Roundcube project for 6/7 monthes since we expect to find
the best open source webmail.
We just have one question ... is Roundcube able or will be able to manage
the multitab window for outgoing e-mails ?
I mean : will it be possible when writting a new message, to open it in
another tab ?
Best regards,
Anthony COGLIANDRO
COGLIANDRO sa / Second-hand textile machinery
29 rue du Lieutenant colonel Duchâtelet
59200 TOURCOING
FRANCE
Tel : 0033 3 20 25 49 49
Fax : 0033 3 20 25 00 21
email : marco(a)cogliandro.com
web site : http://www.cogliandro.com
_______________________________________________
List info: http://lists.roundcube.net/dev/
I think it would be nice to have Help item in taskbar. We can add there
tabs: About, License. I also plan to add there Help tab with user manual
(for RC or my plugins) or other info (e.g. supported browsers list).
What do you think?
--
Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252
LAN Management System Developer http://lms.org.pl
Roundcube Webmail Project Developer http://roundcube.net
_______________________________________________
List info: http://lists.roundcube.net/dev/