Dev

dev@lists.roundcube.net

1 participants
4293 discussions

Start a nNew thread

Email checking improvements
by Sean N. Heukels 30 Mar '07

30 Mar '07

2 1

[Fwd: Ticket - message list not updating
by Sean N. Heukels 30 Mar '07

30 Mar '07

1 0

Localization si correction
by PChot 29 Mar '07

29 Mar '07

Hi, there is some mistakes in Slovenian Localization in labels.inc. Here is correct lines: Line 22: $labels['welcome'] = 'Dobrodošel v $product'; Line 107: $labels['editortype'] = 'Vrsta urejevalnika'; Could someone with svn acces correct this. Thx PChott -- Macs are for those who don't want to know why their computer works. Linux is for those who want to know why their computer works. DOS is for those who want to know why their computer doesn't work. Windowsis for those who don't want to know why their computer doesn't work.

1 0

Re: Quoted text not wrapping properly when converted from HTML to plain text
by Doug Mandell 28 Mar '07

28 Mar '07

Sorry about that, I sent the last message before I was done editing it. I guess all I have left to say is that I can regularly reproduce the problem by sending the following text from my Gmail account (in HTML) to my home email address: You'd be amazed what happens to me when you're not with me! I woke up this morning with 8 minutes until the bus came, and I would have made it had the bus been on time. But no, the bus was 2 minutes early, so I missed it and had to take the next one. It was okay because I've already worked extra time this week, so it evens out. Compose HTML emails is turned off in Personal Settings, so when I hit reply I'm replying in plain text. When I reply to the above message one of the lines is exactly equal to 75 characters, and on that line the last word is knocked down to its own line, so that it looks like this: morning with 8 minutes until the bus came, and I would have made it had the bus been on time. But no, the bus was 2 minutes early, so I missed it I hope in some small way I've contributed. Thanks for your time and sorry if I've gone about this the wrong way. Thanks, Doug

1 0

Quoted text not wrapping properly when converted from HTML to plain text
by Doug Mandell 28 Mar '07

28 Mar '07

Hi all, Some time ago I wrote to the list and reported a bug with regards to how quoted text was wrapping when the original email was HTML and the reply was in plain text (http://trac.roundcube.net/trac.cgi/ticket/1484141). With further investigation I discovered that this only seemed to happen when the line being wrapped was exactly equal to the maximum line length (75 characters, in compose.inc ($body = wordwrap($body, 75);)). To reproduce the I am *not* a programmer, so I know I'm not going to be able to do this the right way, but I do have Ilohamail kicking around and was able to look at how they do line wrapping, use their functions and get Roundcube wrapping HTML quoted text properly in plain text. I'm not sure how to contribute this because I know I've *totally* done this wrong, but I'm hoping someone can see what I've done, do it the right way and get it in SVN. Here's what I did: Prior to function rcmail_create_reply_body($body, $bodyIsHtml) in compose.inc (line 484) I added the following: function LangWrapLine($line, $width){ $line_len = strlen($line); $i = 0; //if line is less than width, we're good if ($line_len <= $width) return $line; for ($prev_i=0,$i=$width;$i<$line_len;$prev_i=$i,$i+=$width){ //extract last segment that is $width wide $chunk = substr($line, $prev_i, ($i-$prev_i))."\n"; //find last space in this chunk $last_space = strrpos($chunk, " "); $last_space = $prev_i + $last_space; if ($last_space==$prev_i){ //no space found in this chunk $next_space = strpos($line, " ", $i); if ($next_space!==false){ $i = $next_space; $line[$next_space] = "\n"; } }else{ //replace last space before width with newline $line[$last_space]="\n"; $i = $last_space; } } return $line; } function LangSmartWrap($body, $len){ $lines = explode("\n", $body); if (!is_array($lines)) return ""; while ( list($i,$line)=each($lines) ){ if (!ereg("^>", $line)) $lines[$i] = LangWrapLine(chop($line), $len); } return implode("\n", $lines); } which is almost an exact copy of the relevant functions out of Ilohamail. I then changed: $body = wordwrap($body, 75); on line 491 to: LangSmartWrap($body, 75); As I said, I know this isn't how it should be, but using the above functions everything works as it is supposed to.

1 0

Can roundcube support pop3?
by ding jianting 28 Mar '07

28 Mar '07

Hi, Can roundcube support pop3? Thanks for your great work. Tim -- ________________________________________ 中国开源客户关系管理系统: http://www.c3crm.com -----------------------------------------------------------------------

2 1

28 Mar '07

Hi, Attached patch shifts focus to the password field if 'enter' was pressed inside the username field. I would commit this without asking if I weren't concerned about wether I placed the new 'login form methods' block in the right place, and using the proper reference vars etc. Thomas, is this OK? Robin Index: program/js/app.js =================================================================== --- program/js/app.js (revision 521) +++ program/js/app.js (working copy) @@ -274,6 +274,8 @@ case 'login': var input_user = rcube_find_object('_user'); var input_pass = rcube_find_object('_pass'); + if (input_user) + input_user.onkeypress = function(e){ return rcmail.login_user_keypress(e); }; if (input_user && input_user.value=='') input_user.focus(); else if (input_pass) @@ -1627,6 +1629,34 @@ return null; }; + + + /*********************************************************/ + /********* login form methods *********/ + /*********************************************************/ + + this.init_login_form_events = function(obj) + { + var handler = function(e){ return ref.login_user_keypress(e,this); }; + + if (obj.addEventListener) + obj.addEventListener(bw.safari ? 'keydown' : 'keypress', handler, false); + else + obj.onkeydown = handler; + }; + + // handler for keyboard events on the _user field + this.login_user_keypress = function(e) + { + var key = document.all ? event.keyCode : document.getElementById ? e.keyCode : 0; + + // enter + if ((key==13) && (document.form._pass)) + { + document.form._pass.focus(); + return false; + } + }; /*********************************************************/

2 4

Does Roundcube support OpenLDAP
by Anita Chan 27 Mar '07

27 Mar '07

Dear Roundcube Dev, As subject, does it support OpenLDAP for address book look up. Thanks, ac

2 1

Reply and Reply To will not quote
by Steffen Torp 21 Mar '07

21 Mar '07

RC build 503, Opera 9.10, Linux 2.6.17: When using Reply or Reply all, original message is not quoted anymore, after checking out revision 503 of RC. Forward will still quote. Can anyone confirm whether this is a bug, or if it's just me? Regards, Steffen

3 2

Sanity check on main.inc
by Colin Alston 21 Mar '07

21 Mar '07

I used a generic config file for our hosts to read in the default domain portion automatically. However this lead to a fun time of getting \n characters in the domain added to the database. These things should probably be sanity checked for arb escape chars before being inserted, such as... patch main.inc 539,541c539,541 < $user, < $host, < $user_email, --- > str_replace("\n", '', $user), > str_replace("\n", '', $host), > str_replace("\n", '', $user_email), -- Colin Alston ~ http://www.karnaugh.za.net/ "There have been forums where, out of some misguided sense of hyper-courtesy, participants are banned from posting any fault-finding with another's posts, and told 'Don't say anything if you're unwilling to help the user.' The resulting departure of clueful participants to elsewhere causes them to descend into meaningless babble and become useless as technical forums." - Eric Steven Raymond

2 1

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev