Dev

dev@lists.roundcube.net

1 participants
4297 discussions

"Remember my user name" add-on for RoundCube
by Michael J. Phillips 16 Jan '07

16 Jan '07

Hello Everyone. I was originally going to implement this feature using pure php, but then decided to go with a pure javascript implementation, and glad I did. It's minimally invasive, since the code that does the work is isolated in a js file. I have included all you need to get a "Remember my login" check box on your login screen. If the INSTALL file is hard to follow, sorry, I have a horrible cold today! Just email me and I gladly help will help. I checked out the trunk today, from which this code was written for, but it will probably work on many older versions. There is some robustness and verbosity in the javascript, if you click save with no user name entered a error will be presented to the user. It requires no submit to save the cookie, the instant the check box is checked it will store a cookie, likewise once its unchecked the cookie is deleted. I tested it on Firefox 2.0 only, although it should work on all javascript enabled browsers. For a quick demo visit http://mail.mphill.org *Please send me any feedback you might have!* I attached a screen shot and the files needed, if you need help email me Michael Phillips

2 1

[RC-Dev] What is your platform?
by Brennan Stehling 16 Jan '07

16 Jan '07

In preparation for having a meeting I would like to know the platforms everyone is using. It seems that IRC may be the text messaging approach we use beyond voice calls over Skype. Whatever we use, I want to make sure everyone can get into the discussion if they want. So please reply to all for this email and tell us what your choice platform is for daily use. And include your preferences for web browser, IM and IRC clients. I have used Windows, Mac and Linux over the years and I know it has been difficult to find a good IRC client when using a different platform. Once we know the platforms and IRC clients people feel work best I will get some basic instructions on the wiki explaining how to get those programs and how to get into the RC channel. Also, for those SysAdmin types out there. Do any you have a good way to capture the IRC discussion and publish it afterward? We will want to archive these meetings and highlight the major points and decisions of the meetings. And while some may choose not to use Skype anyone who would like to take part in a voice discussion and save yourself from typing, I will be happy to have any join a conference call with me. Remember that Skype is free and runs on Windows, MacOS X and Linux. http://www.skype.com/download/ Brennan Stehling brennan(a)offwhite.net

11 12

Roundcube with PHP 5.2.0 and Zend Optimizer - blank screen
by Andrè Bauer 16 Jan '07

16 Jan '07

Hallo. My OS is Debian Sarge. I use the Sarge Backports Version of PHP 5.2.0. If the Zend Optimizer is enabled Roundcube just brings a balnk page. The error log got some seg faults. If i disable Zend it works. How do get Roundcube running with Zend optimizer enabled? -- Mit freundlichen Grüssen Andrè Bauer

2 1

stable svn branch?
by Jason 15 Jan '07

15 Jan '07

I was checking out svn.roundcube.net and it looks like there isn't a branch that I can checkout/update that'll always give me the latest stable release. Am I missing something, or could a /branches/stable be created that was always the latest stable released version? Thanks, Jason

6 9

Re: "Remember my user name" add-on for RoundCube
by mphill 15 Jan '07

15 Jan '07

Sounds reasonable, I will add that tonight On Mon, 15 Jan 2007 15:26:05 +0100, "muh Kuh" <kakulukia(a)gmail.com> wrote: > 2007/1/15, Michael J. Phillips <mphill(a)mphill.org>: >> Do you know the function call? >> > > should be show_message('<messages.inc line>', 'confirmation|error'); > > where confirmation will bring up a green and error a red box > > should be fairly easy to add, he? > > looking forward to see it in action > > In addition u could > . disable the checkbox and the text as long as the user and/or > password fields are empty > . let the description also be clickable > . let it just read "remember me" and display the "on this computer" in > the confirmation message - let it be as minimalistic as it is possible > ;P > > I didnt have the time to look into your patch, but please include as > many localizations as possible. > Send me your texts and ill be lucky to transalte em to german ... > > cya

1 0

managing address book and pictures
by Mathieu Lecarme 15 Jan '07

15 Jan '07

Adress book ----------- webmail is nice, but with addressbook syncing, it's better. For thunderbird user, waiting for 2.0 releases before starting coding is a good idea, in this version, adressBook is a true sqlite db. For mac user, the adressBook api is easy to access with scripting (like pyobjc), and the iSync api seems to be usable. For that, roundcube should expose some distant API. Is there any choice for that, actually? JSON seems easy and simple. With a json distant API, it will be easy to update the distant adress book. Pictures -------- Mail.app can display picture in mail header, like avatar. It's easy to implement such features. - There's an old protocol, used by http://freshmeat.net/projects/mailpictures/ - Gravatar (http://www.gravatar.com/) is the easiest way to match picture and mail adress - With adressbook sync, you can upload your picture. I use it with a dirty hack, is it usefull enough to make it cleaner and submit a patch?

3 3

Branch devel-addressbook
by Thomas Bruederli 14 Jan '07

14 Jan '07

Hi everybody Those of you who keep track of the changesets may have notices that I created a branch to re-write the addressbook interface. I also made some code cleanup and moved some functions around. I'm sure that you gonna hate me for that but I think it's worth it :-) The changeset is quite big so here's an overview what changed: - Created a new class rcube_contacts that abstracts the acess to the local address book. Another class with the same interface is on the way to handle the LDAP access. - Moved template parsing functions to a new class rcmail_template which extends the rcube_html_page class. The global object $OUTPUT is now an instance of rcmail_template. - Replaced all $OUTPUT->add_script("$JS_OBJECT_NAME.set_env('foo', '$bar');"); with the more elegant $OUTPUT->set_env('foo', $bar); Now also conditional template objects can access the env vars. - Got rid of the global vars $JS_OBJECT_NAME and $CHARSET. Those have been replaced by constans because they actually are constant values. - Moved simple steps (html2text and quotaimg) out of the common request process and created simple scripts in /bin/. These do not nead any user authentication or session values. - Started to send POST requests from the client for actions that alter data. Changing application states with GET is against RFC and allows for CSRF vulnerabilities. e.g. if someone were to email an RC user with: <img src="?_task=addressbook&_action=delete&_cid=1&_from=&_remote=1"> Then a contact would be deleted. Please check out the new branch from https://svn.roundcube.net/branches/devel-addressbook and test it. Don't replace an existing (productive) installation with it. Comments about the changes and the new classes are welcome. Regards, Thomas

2 2

Template Questions
by Ralf Scholle 14 Jan '07

14 Jan '07

Hello, i found 2 "problems" on the template: first in main.inc.php i have this variables $rcmail_config['skin_path'] = ''; and $rcmail_config['product_name'] = ''; why didn't we use this at the templates?? for example in /templates/login.html the information is "Hardcoded" <img src="skins/default/images/roundcube_logo.png" id="rcmbtn104" width="165" height="55" border="0" alt="RoundCube Webmail" hspace="10" /> or in /includes/header.html <roundcube:button command="mail" image="/images/roundcube_logo.png" alt="RoundCube Webmail" width="165" height="55" /> i think id would be better when we could use the variables?!! What do you think?? cu Ralf -- Sorry for my English :-/ ___________________________________________________________ Der frühe Vogel fängt den Wurm. Hier gelangen Sie zum neuen Yahoo! Mail: http://mail.yahoo.de

5 5

HTML Email bugs in latest beta (stable)
by Justin Frydman 14 Jan '07

14 Jan '07

Hey all, We just upgraded and we send html invoices out. The invoice template for these have not been adjusted but now looks like roundcube is not rendering the html properly anymore. Getting things right in the message like: __removed=red> and *__removed=https: Any ideas? *

2 4

Edit Identities During First Login (#1291605)
by Jim Pingle 14 Jan '07

14 Jan '07

I posted this in the forums, and didn't get much of a response, so I thought I'd try my luck here. Some time ago, the ability for new users to be presented with the "Edit Identity" screen after their first login was requested. (Ticket #1291605, http://trac.roundcube.net/trac.cgi/ticket/1291605 ) Attached is a patch that should add this feature in. This was patched against SVN rev 459, but it may work on older revisions. I'm sure there is room for improvement. NB: This feature is controlled by an additional setting in config/main.inc.php : $rcmail_config['new_user_edit_identity'] = TRUE; I suppose you could display a "welcome" message on the edit identities screen if they are a new user also, but that would require additional localization / translation, among other changes. Jim P.S. RE: Developer Guidelines, should boolean variables be in all caps (TRUE/FALSE) or lower case (true/false)? It seems to goes back and forth a lot in the code, so I wasn't sure. Index: config/main.inc.php.dist =================================================================== --- config/main.inc.php.dist (revision 459) +++ config/main.inc.php.dist (working copy) @@ -31,6 +31,10 @@ // set to false if only registered users can use this service $rcmail_config['auto_create_user'] = TRUE; +// present the user with an "edit identity" screen upon first login +// This is only useful if auto_create_user is also set to true. +$rcmail_config['new_user_edit_identity'] = TRUE; + // the mail host chosen to perform the log-in // leave blank to show a textbox at login, give a list of hosts // to display a pulldown menu or set one host as string. Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 459) +++ program/include/main.inc (working copy) @@ -548,6 +548,8 @@ else if ($CONFIG['auto_create_user']) { $user_id = rcmail_create_user($user, $host); + if ($CONFIG['new_user_edit_identity']) + $_SESSION['new_user'] = TRUE; } if ($user_id) Index: index.php =================================================================== --- index.php (revision 459) +++ index.php (working copy) @@ -177,6 +177,24 @@ get_input_value('_pass', RCUBE_INPUT_POST, true, 'ISO-8859-1'), $host)) { // send redirect + if (isset($_SESSION['new_user']) && $_SESSION['new_user'] === TRUE) + { + // Get identity id + $sql_result = $DB->query("SELECT identity_id + FROM ".get_table_name('identities')." + WHERE user_id=? + AND del<>1 + LIMIT 1", + $_SESSION['user_id']); + + // If we can find an identity, redirect to the edit screen. + if ($DB->num_rows($sql_result) && ($sql_arr = $DB->fetch_assoc($sql_result))) + { + $identity_id = $sql_arr['identity_id']; + if (!empty($identity_id) && ($identity_id > 0)) + $COMM_PATH = "./?_task=settings&_action=edit-identity&_iid=" . $identity_id; + } + } header("Location: $COMM_PATH"); exit; }

3 2

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev