Dev

dev@lists.roundcube.net

2 participants
4301 discussions

Drafts in latest SVN
by Steve Block 26 Dec '06

26 Dec '06

Although I don't use roundcube as my primary mail client, I do tend to use it at the office, which firewalls regular IMAP ports. One thing I noticed today while composing a message was that I ended up with multiple copies of said message in the drafts folder. The message took a while to put together, and I appreciate the automatic draft saving, but I also feel like subsequent saves should replace the current, rather than add to it. If not, then all of the copies should be removed when the final message is sent. Not sure if this is a bug or a 'feature', but I thought i should point it out. Thanks. -- Steve Block

5 8

Re: Webmail competition
by Tomasz Pajor 24 Dec '06

24 Dec '06

That's a very good idea. I'm looking forward in to it. Still waiting for svn access, i hope Thomas will add me soon. There are some tickets I want to close, and reorganize roadmap. I've started some, but I think we need to discuss it in a group, what we want to put to 0.1-release. -- Best regards Tom Dnia Thu, 21 Dec 2006 09:29:39 -0600 napisales[as]: > I am all for a scheduled push for contributors to meet online to work on the tickets for the next release. Perhaps we can schedule something for > January for all of us to meet online using a IM client which supports a group chat. (Skype, GTalk, etc) > > Thomas, you could walk us through your plans and each of us could volunteer to work on specific tickets. Perhaps after a few of these sessions we > will be past the next release. > > Brennan > > On Thu, 21 Dec 2006 15:17:46 +0100, Michael Bueker m.bueker(a)berlin.de> wrote: >> I couldn't have said it any better - I totally agree. I like the way how >> roundcube is developing very much, we are making slow but steady progress. >> >> If you think we need a "cleanup offensive" of the code or the ticket >> system, just call for it, maybe lay out some rules (like, which tickets to >> keep, delete or tag in which way) and I'll be happy to help out. >> >> Or a drive to write up some more/revised documentation or vamp up the wiki >> - I'm sure that if you announced a major task, there will be enough people >> willing to help out. >> >> Cheers, >> ~Mik > -- > Brennan Stehling > Offwhite.net LLC > brennan(a)offwhite.net >

8 12

Preview Pane on Safari (& other minor glitches)
by Brian Devendorf 24 Dec '06

24 Dec '06

I found that I had to tweak the CSS code for the preview pane to display properly in Safari. (This is when using the latest svn code: r432). Line: 144-151, /skins/default/mail.css /*\*/ html>body*#messagecontframe { [height: 40%; height: 54%; ]height: 100%; } /**/ I changed the value on line #148 from 40% to 54%. This adjustment was a perfect fit for the preview pane on Safari for me. I am running 10.4.8. Safari 2.0.4. Has anyone else seen this issue? According to the information in trac, the middle value only applies to Safari, so I do not expect that it would break anything else. I do most of my work in Camino, so I just noticed this little glitch today. Other minor issues I am looking into... On Safari, with preview pane, the first time I click on an email, the preview pane flickers (keeping the empty message logo). After that, everything works fine. In Camino, with preview pane or standard display, when I click Display Images on an email, it works the first time, but fails each subsequent time. This is true on an individual message basis. It always works the first time on ever message. In fact, it works the first time in preview pane, and the first time in standard view. I hope to do more research into these issues, but thought I'd check to see if anyone else had seen them first. Thanks, Brian

1 1

Suggestion
by Eric Stadtherr 23 Dec '06

23 Dec '06

In light of the recent discussions, I've been browsing through the Trac tickets trying to get a feel for the distribution of bugs (display, database, IMAP interface, etc.). There appear to be quite a few tickets that follow the pattern of "RoundCube exhibits incorrect behavior when displaying an e-mail with ." These special cases range from message header contents to HTML contents to attachment formats. Instead of trying to fabricate my own e-mail messages that match these special cases (and possible get it wrong), what does everyone think about standing up a "test case" e-mail account on an IMAP server somewhere that people can send these "special case" messages to? The RC development team could then each access this IMAP server from their own RC installations to troubleshoot the handling of the messages. We'd have to keep the login credentials relatively secure, and somebody would have to volunteer an IMAP server. What does everyone think? -- Eric Stadtherr estadtherr(a)gmail.com

3 2

HTML Cleanup for onclick/onchange/etc causes problems
by Brian Devendorf 23 Dec '06

23 Dec '06

I identified a problem in the /program/steps/mail/func.inc regexp for cleaning html code. To summarize, the cleanup code looks for the word 'on' followed by a number of non-equal characters. This should identify onchange, onclick, etc... the problem is the code fails when the word 'on' is outside of an html tag and a tag with an equal sign (eg. html link) follows it in the email. I saw the problem on order confirmation emails from Amazon.com. I created a ticket in trac that contains a patch for this regexp to verify that the word on is contained inside a tag. The patch is a unified diff, and I also attached a testcase. View the ticket here: http://trac.roundcube.net/trac.cgi/ticket/1484183 As my first post to this list, I must acknowledge what a truly fantastic product RoundCube is. Thanks, Brian

1 0

Re: Next Beta Release
by chasd 22 Dec '06

22 Dec '06

> Matt Kaatman said: > > Do we have any goals before we release the next beta? > > Maybe a feature freeze is in order to get a newer beta out? I think a release that includes the vulnerability fix - <http://trac.roundcube.net/trac.cgi/ticket/1484109> should be made, so new RoundCube users don't have to patch their fresh install. Many first time users will likely choose to download a beta release rather than an SVN snapshot that contains the fix. Charles Dostale System Admin - Silver Oaks Communications http://www.silveroaks.com/ 824 17th Street, Moline IL 61265

2 1

Hungarian language files, updated
by Szalma László 22 Dec '06

22 Dec '06

Here goes the updated Hungarian language files, please somebody commit it with the next update. http://dblaci.hu/hu.tar.gz Thanks DB

1 0

Re: #1326320
by Thomas Bruederli 22 Dec '06

22 Dec '06

Hi Pierre Please update your local copy to the latest revision (svn update) and then create the diff again. The current one removes newly added features :-( ~Thomas Pierre Lena wrote: > Here is the diff file. > > Regards. >

3 3

Webmail competition
by Thomas Bruederli 22 Dec '06

22 Dec '06

Hi everybody, Looks like the others are getting closer: Gmail like AJAX powered Web 2.0 version of IMP http://janschneider.de/news/25/252 Duroty System (BETA) is the open source Gmail http://www.duroty.com/en/index.jsp The main problem of RoundCube is the project manager's lack of time and as a consequence of that the bad project organization, both my faults. If somebody thinks he or she could afford some time (actually it's a full-time job) and who has some experience in project management, I'm willing to give away the "power" and become a regular developer (that's what I really am). Regards, Thomas

9 13

1388203 - Reuse HTTP authentication for login - PATCH
by Black.myst 21 Dec '06

21 Dec '06

Hello, I try to find a issue for bug 1388203 (http://trac.roundcube.net/trac.cgi/ticket/1388203) Diff explanation : - config/main.inc.php.dist : Add new configuration boolean 'http_authent'. False : use the standard login page. (default) True : use $_SERVER["PHP_AUTH_USER"] to log user. - skins/default/includes/taskbar.html : Add a <roundcube:if> to remove logout button when used http_authent - program/include/main.inc : Fixe <roundcube:include> to parse <roundcube:if> in included file. (Else my <roundcube:if> in taskbar.html not work!) - index.php : Add code to allow http authent. - program/steps/error.inc : Add "Allow cookies" in browser requirement page. (I display this page (409) if the user disable cookies with http_authent) Black Myst Index: config/main.inc.php.dist =================================================================== --- config/main.inc.php.dist (revision 414) +++ config/main.inc.php.dist (working copy) @@ -77,6 +77,9 @@ // best server supported one) $rcmail_config['smtp_auth_type'] = ''; +// use http authentication : get login and pass from PHP variables +$rcmail_config['http_authent'] = FALSE; + // Log sent messages $rcmail_config['smtp_log'] = TRUE; Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 414) +++ program/include/main.inc (working copy) @@ -1265,7 +1265,7 @@ { $incl = fread($fp, filesize($path)); fclose($fp); - return parse_rcube_xml($incl); + return parse_rcube_xml(parse_rcube_conditions($incl)); } break; Index: program/steps/error.inc =================================================================== --- program/steps/error.inc (revision 414) +++ program/steps/error.inc (working copy) @@ -35,6 +35,7 @@ <br /> »  JavaScript enabled<br /> »  Support for XMLHTTPRequest<br /> +»  Allow cookies<br /> <p><i>Your configuration:</i><br /> $user_agent</p> @@ -115,4 +116,4 @@ </html> EOF; -?> \ No newline at end of file +?> Index: skins/default/includes/taskbar.html =================================================================== --- skins/default/includes/taskbar.html (revision 414) +++ skins/default/includes/taskbar.html (working copy) @@ -2,5 +2,7 @@ <roundcube:button command="mail" label="mail" class="button-mail" /> <roundcube:button command="addressbook" label="addressbook" class="button-addressbook" /> <roundcube:button command="settings" label="settings" class="button-settings" /> +<roundcube:if condition="config:http_authent != true" /> <roundcube:button command="logout" label="logout" class="button-logout" /> -</div> \ No newline at end of file +<roundcube:endif /> +</div> Index: index.php =================================================================== --- index.php (revision 414) +++ index.php (working copy) @@ -162,8 +162,42 @@ } +// try to log in if http_authen +if ($CONFIG['http_authent'] && (!isset($_SESSION['user_id']) || !rcmail_authenticate_session())) + { + if (empty($_COOKIE) && !$_action=='login') + { // if no cookie, force reload the page to check if cookies is enabled. + header("Location: $COMM_PATH&_action=login"); + exit; + } + else if (empty($_COOKIE) && $_action=='login') + { // if action login and no cookies: user has disabled cookies -> error + raise_error( + array('code' => 409, + 'type' => 'php', + 'message' => "User not allow cookies"), + FALSE, + TRUE); + } + else if (isset($_SERVER["PHP_AUTH_USER"]) && isset($_SERVER["PHP_AUTH_PW"]) && + rcmail_login($_SERVER["PHP_AUTH_USER"], $_SERVER["PHP_AUTH_PW"], + rcmail_autoselect_host())) + { + // http_authen success + } + else + { // http_authent faild ! + raise_error( + array('code' => 401, + 'type' => 'imap', + 'message' => "Http_authent faild for user :".$_SERVER['PHP_AUTH_USER']), + TRUE, + TRUE); + exit; + } + } // try to log in -if ($_action=='login' && $_task=='mail') +else if (!$CONFIG['http_authent'] && $_action=='login' && $_task=='mail') { $host = rcmail_autoselect_host();

2 5

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev