Dev

dev@lists.roundcube.net

1 participants
4293 discussions

Webmail competition
by Thomas Bruederli 22 Dec '06

22 Dec '06

Hi everybody, Looks like the others are getting closer: Gmail like AJAX powered Web 2.0 version of IMP http://janschneider.de/news/25/252 Duroty System (BETA) is the open source Gmail http://www.duroty.com/en/index.jsp The main problem of RoundCube is the project manager's lack of time and as a consequence of that the bad project organization, both my faults. If somebody thinks he or she could afford some time (actually it's a full-time job) and who has some experience in project management, I'm willing to give away the "power" and become a regular developer (that's what I really am). Regards, Thomas

9 13

1388203 - Reuse HTTP authentication for login - PATCH
by Black.myst 21 Dec '06

21 Dec '06

Hello, I try to find a issue for bug 1388203 (http://trac.roundcube.net/trac.cgi/ticket/1388203) Diff explanation : - config/main.inc.php.dist : Add new configuration boolean 'http_authent'. False : use the standard login page. (default) True : use $_SERVER["PHP_AUTH_USER"] to log user. - skins/default/includes/taskbar.html : Add a <roundcube:if> to remove logout button when used http_authent - program/include/main.inc : Fixe <roundcube:include> to parse <roundcube:if> in included file. (Else my <roundcube:if> in taskbar.html not work!) - index.php : Add code to allow http authent. - program/steps/error.inc : Add "Allow cookies" in browser requirement page. (I display this page (409) if the user disable cookies with http_authent) Black Myst Index: config/main.inc.php.dist =================================================================== --- config/main.inc.php.dist (revision 414) +++ config/main.inc.php.dist (working copy) @@ -77,6 +77,9 @@ // best server supported one) $rcmail_config['smtp_auth_type'] = ''; +// use http authentication : get login and pass from PHP variables +$rcmail_config['http_authent'] = FALSE; + // Log sent messages $rcmail_config['smtp_log'] = TRUE; Index: program/include/main.inc =================================================================== --- program/include/main.inc (revision 414) +++ program/include/main.inc (working copy) @@ -1265,7 +1265,7 @@ { $incl = fread($fp, filesize($path)); fclose($fp); - return parse_rcube_xml($incl); + return parse_rcube_xml(parse_rcube_conditions($incl)); } break; Index: program/steps/error.inc =================================================================== --- program/steps/error.inc (revision 414) +++ program/steps/error.inc (working copy) @@ -35,6 +35,7 @@ <br /> »  JavaScript enabled<br /> »  Support for XMLHTTPRequest<br /> +»  Allow cookies<br /> <p><i>Your configuration:</i><br /> $user_agent</p> @@ -115,4 +116,4 @@ </html> EOF; -?> \ No newline at end of file +?> Index: skins/default/includes/taskbar.html =================================================================== --- skins/default/includes/taskbar.html (revision 414) +++ skins/default/includes/taskbar.html (working copy) @@ -2,5 +2,7 @@ <roundcube:button command="mail" label="mail" class="button-mail" /> <roundcube:button command="addressbook" label="addressbook" class="button-addressbook" /> <roundcube:button command="settings" label="settings" class="button-settings" /> +<roundcube:if condition="config:http_authent != true" /> <roundcube:button command="logout" label="logout" class="button-logout" /> -</div> \ No newline at end of file +<roundcube:endif /> +</div> Index: index.php =================================================================== --- index.php (revision 414) +++ index.php (working copy) @@ -162,8 +162,42 @@ } +// try to log in if http_authen +if ($CONFIG['http_authent'] && (!isset($_SESSION['user_id']) || !rcmail_authenticate_session())) + { + if (empty($_COOKIE) && !$_action=='login') + { // if no cookie, force reload the page to check if cookies is enabled. + header("Location: $COMM_PATH&_action=login"); + exit; + } + else if (empty($_COOKIE) && $_action=='login') + { // if action login and no cookies: user has disabled cookies -> error + raise_error( + array('code' => 409, + 'type' => 'php', + 'message' => "User not allow cookies"), + FALSE, + TRUE); + } + else if (isset($_SERVER["PHP_AUTH_USER"]) && isset($_SERVER["PHP_AUTH_PW"]) && + rcmail_login($_SERVER["PHP_AUTH_USER"], $_SERVER["PHP_AUTH_PW"], + rcmail_autoselect_host())) + { + // http_authen success + } + else + { // http_authent faild ! + raise_error( + array('code' => 401, + 'type' => 'imap', + 'message' => "Http_authent faild for user :".$_SERVER['PHP_AUTH_USER']), + TRUE, + TRUE); + exit; + } + } // try to log in -if ($_action=='login' && $_task=='mail') +else if (!$CONFIG['http_authent'] && $_action=='login' && $_task=='mail') { $host = rcmail_autoselect_host();

2 5

SysAdmins and RoundCube
by Brennan Stehling 21 Dec '06

21 Dec '06

As Jim stated in the previous email... "On another subject: It seems we have a lot of sysadmins offering time, so we might even be able to dedicate certain ones to certain setups ("specialists" I guess they could be called). For example, it would be best to have an admin who uses Dovecot on a daily basis to be responsible for its testing. They would be more likely to know quirks and what might be a configuration issue. If someone reports a problem, a specialist could test, attempt to reproduce the problem, and gather more information before the ticket is passed on to an actual developer. Just another idea..." If you are a SysAdmin and would like to be involved in a non-developer aspect please respond to this email. It sounds like Jim has some resources at his disposal and we could pool our efforts to produce a good testing environment. What Jim and I have already discussed is scheduling a script to pull down the current versions from SVN and redeploy and test the RC installs. Scripting the syncing via SVN, putting the files in place, adjusting the config file and rebuilding the database are all simple steps that we can put together. From there we need to generate a set of sample emails into the system so that we can test show RC handles it. One way to automate those test is the Selenium tool. (http://www.openqa.org/selenium/) We can put together a series of testing using Selenium IDE (http://www.openqa.org/selenium-ide/) which one of can run manually to go through each of the automated tests. We can log any bugs as they happen. And the Selenium tests will run in FireFox, MSIE, Opera or Safari, so once we have these tests working we can make the available for testers to run on the various browser and platform versions beyond what we may test among ourselves. I expect to just test FireFox and MSIE. These tests will help accelerate development and offload some of the testing done by the developers. Brennan Stehling Offwhite.net LLC brennan(a)offwhite.net

1 0

Re:
by Ryan Rittenhouse 20 Dec '06

20 Dec '06

I've been hacking away at this trying to get it to work with the latest svn, mostly by manually going through and patching everything. So far, no luck. I get to the Mail rules page and the button to add new rules does nothing. I guess the next step is for me to backup to v400 and try it first. Has anyone gotten this working yet? -Ryan Network Administrator Goshen College (574) 535-7004 Pierre Lena wrote: > The diff file can be downloaded there > http://www.mangoose.org/RoundCube/filters/filters_diff.diff > > The table structure to handle mailrule is: > CREATE TABLE `mailrules` ( > `mailrule_id` int(11) NOT NULL auto_increment, > `from` varchar(128) default NULL, > `to` varchar(128) default NULL, > `subject` varchar(128) default NULL, > `user_id` int(10) unsigned NOT NULL default '0', > `del` tinyint(1) NOT NULL default '0', > `location` varchar(128) default NULL, > PRIMARY KEY (`mailrule_id`) > ) TYPE=MyISAM; > > Here are the added files: > http://www.mangoose.org/RoundCube/filters/addmailrule.html goes to skins/default/templates > http://www.mangoose.org/RoundCube/filters/delete_mailrule.inc goes to program/steps/settings/ > http://www.mangoose.org/RoundCube/filters/editmailrule.html goes to skins/default/templates > http://www.mangoose.org/RoundCube/filters/edit_mailrule.inc goes to program/steps/settings/ > http://www.mangoose.org/RoundCube/filters/mailrules.html goes to skins/default/templates > http://www.mangoose.org/RoundCube/filters/mailrules.inc goes to program/steps/settings > http://www.mangoose.org/RoundCube/filters/save_mailrule.inc goes to program/steps/settings/ > > Regards. > > > On Wed, 20 Dec 2006 20:37:40 +0100, Pierre Lena <plena(a)mangoose.org> wrote: >> Here is the diff file. >> >> Regards. >> >> On Wed, 20 Dec 2006 20:17:59 +0100, Pierre Lena <plena(a)mangoose.org> >> wrote: >>> How do I create the diff? >>> Do I need to reload the svn400 to create it? >>> >>> On Wed, 20 Dec 2006 20:14:53 +0100, Tomasz Pajor <t.pajor(a)kei.pl> >> wrote: >>>> You send the diff to mailing list, or create a ticket on >>>> http://trac.roundcube.net/ >>>> >>>> -- >>>> Best regards >>>> Tom >>>> >>>> Dnia Wed, 20 Dec 2006 19:56:36 +0100 napisales[as]: >>>>> Hi, >>>>> >>>>> I am new to the list. >>>>> I developped mail filters for roundcube based on svn400. >>>>> How can I send the file I modified to make them part of the project? >>>>> >>>>> Regards. >>>>> Pierre >>>>> >>>>> >>>>> --- >>>>> Antivirus avast! : message Sortant sain. >>>>> Base de donnees virale (VPS) : 0661-0, 20/12/2006 >>>>> Analyse le : 20/12/2006 19:56:37 >>>>> avast! - copyright (c) 1988-2006 ALWIL Software. >>>>> http://www.avast.com >>>>> > > >

2 1

(no subject)
by Pierre Lena 20 Dec '06

20 Dec '06

The diff file can be downloaded there http://www.mangoose.org/RoundCube/filters/filters_diff.diff The table structure to handle mailrule is: CREATE TABLE `mailrules` ( `mailrule_id` int(11) NOT NULL auto_increment, `from` varchar(128) default NULL, `to` varchar(128) default NULL, `subject` varchar(128) default NULL, `user_id` int(10) unsigned NOT NULL default '0', `del` tinyint(1) NOT NULL default '0', `location` varchar(128) default NULL, PRIMARY KEY (`mailrule_id`) ) TYPE=MyISAM; Here are the added files: http://www.mangoose.org/RoundCube/filters/addmailrule.html goes to skins/default/templates http://www.mangoose.org/RoundCube/filters/delete_mailrule.inc goes to program/steps/settings/ http://www.mangoose.org/RoundCube/filters/editmailrule.html goes to skins/default/templates http://www.mangoose.org/RoundCube/filters/edit_mailrule.inc goes to program/steps/settings/ http://www.mangoose.org/RoundCube/filters/mailrules.html goes to skins/default/templates http://www.mangoose.org/RoundCube/filters/mailrules.inc goes to program/steps/settings http://www.mangoose.org/RoundCube/filters/save_mailrule.inc goes to program/steps/settings/ Regards. On Wed, 20 Dec 2006 20:37:40 +0100, Pierre Lena <plena(a)mangoose.org> wrote: > Here is the diff file. > > Regards. > > On Wed, 20 Dec 2006 20:17:59 +0100, Pierre Lena <plena(a)mangoose.org> > wrote: >> How do I create the diff? >> Do I need to reload the svn400 to create it? >> >> On Wed, 20 Dec 2006 20:14:53 +0100, Tomasz Pajor <t.pajor(a)kei.pl> > wrote: >>> You send the diff to mailing list, or create a ticket on >>> http://trac.roundcube.net/ >>> >>> -- >>> Best regards >>> Tom >>> >>> Dnia Wed, 20 Dec 2006 19:56:36 +0100 napisales[as]: >>>> Hi, >>>> >>>> I am new to the list. >>>> I developped mail filters for roundcube based on svn400. >>>> How can I send the file I modified to make them part of the project? >>>> >>>> Regards. >>>> Pierre >>>> >>>> >>>> --- >>>> Antivirus avast! : message Sortant sain. >>>> Base de donnees virale (VPS) : 0661-0, 20/12/2006 >>>> Analyse le : 20/12/2006 19:56:37 >>>> avast! - copyright (c) 1988-2006 ALWIL Software. >>>> http://www.avast.com >>>>

1 0

Re: #1326320
by Pierre Lena 20 Dec '06

20 Dec '06

Here is the diff file. Regards. On Wed, 20 Dec 2006 20:17:59 +0100, Pierre Lena <plena(a)mangoose.org> wrote: > How do I create the diff? > Do I need to reload the svn400 to create it? > > On Wed, 20 Dec 2006 20:14:53 +0100, Tomasz Pajor <t.pajor(a)kei.pl> wrote: >> You send the diff to mailing list, or create a ticket on >> http://trac.roundcube.net/ >> >> -- >> Best regards >> Tom >> >> Dnia Wed, 20 Dec 2006 19:56:36 +0100 napisales[as]: >>> Hi, >>> >>> I am new to the list. >>> I developped mail filters for roundcube based on svn400. >>> How can I send the file I modified to make them part of the project? >>> >>> Regards. >>> Pierre >>> >>> >>> --- >>> Antivirus avast! : message Sortant sain. >>> Base de donnees virale (VPS) : 0661-0, 20/12/2006 >>> Analyse le : 20/12/2006 19:56:37 >>> avast! - copyright (c) 1988-2006 ALWIL Software. >>> http://www.avast.com >>>

1 0

Re:
by Tomasz Pajor 20 Dec '06

20 Dec '06

For example: diff -aur newdir olddir for more information: man diff -- Best regards Tom Dnia Wed, 20 Dec 2006 20:17:59 +0100 napisales[as]: > How do I create the diff? > Do I need to reload the svn400 to create it? > > On Wed, 20 Dec 2006 20:14:53 +0100, Tomasz Pajor t.pajor(a)kei.pl> wrote: >> You send the diff to mailing list, or create a ticket on >> http://trac.roundcube.net/ >> >> -- >> Best regards >> Tom >> >> Dnia Wed, 20 Dec 2006 19:56:36 +0100 napisales[as]: >>> Hi, >>> >>> I am new to the list. >>> I developped mail filters for roundcube based on svn400. >>> How can I send the file I modified to make them part of the project? >>> >>> Regards. >>> Pierre >>> >>> >>> --- >>> Antivirus avast! : message Sortant sain. >>> Base de donnees virale (VPS) : 0661-0, 20/12/2006 >>> Analyse le : 20/12/2006 19:56:37 >>> avast! - copyright (c) 1988-2006 ALWIL Software. >>> http://www.avast.com >>> > -- -- Pozdrawiam Tomasz Pajor

1 0

Re: #1326320
by Tomasz Pajor 20 Dec '06

20 Dec '06

You send the diff to mailing list, or create a ticket on http://trac.roundcube.net/ -- Best regards Tom Dnia Wed, 20 Dec 2006 19:56:36 +0100 napisales[as]: > Hi, > > I am new to the list. > I developped mail filters for roundcube based on svn400. > How can I send the file I modified to make them part of the project? > > Regards. > Pierre > > > --- > Antivirus avast! : message Sortant sain. > Base de donnees virale (VPS) : 0661-0, 20/12/2006 > Analyse le : 20/12/2006 19:56:37 > avast! - copyright (c) 1988-2006 ALWIL Software. > http://www.avast.com >

2 1

#1326320
by Pierre Lena 20 Dec '06

20 Dec '06

Hi, I am new to the list. I developped mail filters for roundcube based on svn400. How can I send the file I modified to make them part of the project? Regards. Pierre --- Antivirus avast! : message Sortant sain. Base de donnees virale (VPS) : 0661-0, 20/12/2006 Analyse le : 20/12/2006 19:56:37 avast! - copyright (c) 1988-2006 ALWIL Software. http://www.avast.com

1 0

MIME messages with no body
by Jim Pingle 20 Dec '06

20 Dec '06

There are several tickets that appear to be related, all related to MIME messages that have attachments but no body (or bodies in alternative content types) The changes made by robin in SVN revision 413 have helped quite a bit, but there are still some quirks. Most of these can probably be closed with a little bit of testing to be sure they have been fixed. If not, it would be nice if someone could take a closer look at them. Ticket #1484050 (Bugs) Messages with attachment only (no body part) are not parsed correctly "attachment" (really the only part) shows up now and I can download it, but the message list does not indicate that an attachment is present in the message. Ticket #1483818 (Feature Requests) Support for viewing Content-Type: application/pgp et al. I can't reproduce this, but it looks like the programs I'm using to test are encoding the messages differently than the messages the original ticket opener sees. Thunderbird/Enigmail-generated messages work OK for me. I opened a bunch of signed PGP/MIME messages from some mailing lists, all worked OK. Ticket #1443276 (Bugs) mail rendering problem with base64 encoded messages This may be fixed now but oddly enough I can't find a test message with a base64-encoded text body to see if it works. base64-encoded attachment bodies work for me since SVN rev 413. Ticket #1484072 (Bugs) Weird forward behaviour. When attempting to forward one of these messages with only an attachment and no body text, it is not included. I'm not sure this one is really related or not, but it could use a couple people to test on their systems and comment on it or close it. Ticket #1483968 (Bugs) Message is not showing content Messages from Cron show up fine for me on FreeBSD, but if someone on Linux could double check this can probably be closed.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev