Dev

dev@lists.roundcube.net

4290 discussions

Small bug in spell checker
by Aurélien Pocheville 31 Aug '06

31 Aug '06

Hi, I just upgraded to latest svn (rev 329 I think) and I noticed a small bug in the spell checking. I you click twice on the spell check _icon_ (the one on the very top, not the textual one), a graphical bug appears with a double bar on top of edit box. In fact, it is creating another editbox, and if you click a third time, a third editbox is created (they are very small), and so on... I managed to have a ten of them. I you click on the "resume editing" text, everything is coming back to normal. I think that the solution to this would be to have the top icon to also have the same behavior as the textual one, that is switch between "check/resume". Regards, -- Aurelien Pocheville PhD Student IBISC-CNRS Engineer IIE 2003 aurelien.pocheville(a)haptique.com http://www.haptique.com/ Tel : 33 1 69 47 06 05 Fax : 33 1 69 47 06 03 University of Evry Val d'Essonne 40 rue du Pelvoux - CE 1455 91020 EVRY CEDEX

1 0

Re: IMAP SORT
by Andrew Fladmark 31 Aug '06

31 Aug '06

On Wed, 30 Aug 2006 15:55:42 -0700, Joe Auricchio <jauricchio.lists(a)gmail.com> wrote: > Hi Andrew, > >> RoundCube then resorts to sorting the messages itself... I guess >> the question is.. why is Roundcube sending "s SORT (DATE)..."? >> What is this 's'? > > The 's' is a tag. All commands sent from the client to the server > start with a tag specified by the client. All responses to that > command will have the same tag, so the client can keep track of which > command the server is responding to. In this case, RC is using the > unimaginative tag 's' to designate its sort commands. > > RFC 3501 says it better: > http://www.apps.ietf.org/rfc/rfc3501.html#sec-2.2.1 > > The 's' is valid syntax, so it's not causing the BAD response. Hope > this helps direct your investigation =] > > -joe Thanks Joe! Forgive my ignorance. I've done some more testing and it seems that the issue is the fact that RoundCube is not including UID in the command its sending to my IMAP server. RoundCube is sending: s SORT (DATE) US-ASCII ALL UNDELETED This returns an error, but when I alter the command and test as: s UID SORT (DATE) US-ASCII ALL UNDELETED It works perfectly. I notice in the imap library code we now have a parameter which controls whether or not UID sort should be used... Does anyone have any ideas why it wouldn't be set true? Is there something I need to change or should it be autodetected? Thanks as always for the help! Andrew

1 0

IMAP SORT
by Andrew Fladmark 31 Aug '06

31 Aug '06

Hi! I know the topic of IMAP sorting has sort of died down, but I'm still having a problem with it. I'm using hMailServer on Windows. Here's what appears to be happening in the IMAP conversation: "RECEIVED: cp01 CAPABILITY" "SENT: * CAPABILITY IMAP4 IMAP4rev1 QUOTA SORT[nl]cp01 OK CAPABILITY completed[nl]" "RECEIVED: a001 LOGIN my(a)email.com "password"" "SENT: a001 OK LOGIN completed[nl]" "RECEIVED: sel1 SELECT "INBOX"" "SENT: * 44 EXISTS[nl]* 0 RECENT[nl]* FLAGS (\Deleted \Seen \Draft \Answered \Flagged)[nl]* OK [UIDVALIDITY 0][nl]* OK [PERMANENTFLAGS (\Deleted \Seen \Draft \Answered \Flagged)][nl]sel1 OK [READ-WRITE] SELECT completed[nl]" "RECEIVED: srch1 SEARCH ALL UNDELETED" "SENT: * SEARCH 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44[nl]srch1 OK Search completed[nl]" "RECEIVED: s SORT (DATE) US-ASCII ALL UNDELETED" "SENT: s BAD Unknown or NULL command[nl]" RoundCube then resorts to sorting the messages itself... I guess the question is.. why is Roundcube sending "s SORT (DATE)..."? What is this 's'? Is anyone else having this problem? I looked in the code at imap.inc and I think the related code is around line 653: $command = 's '. $is_uid .'SORT ('.$field.') '.$encoding.' ALL'."$add\r\n"; Any help getting this resolved would be greately appreciated! Andrew

2 1

Problem with message parsing with >= r326
by Jim Pingle 31 Aug '06

31 Aug '06

Since SVN rev 326, I've had problems on one of my Roundcube setups (of course it's the one that's always the most problematic, the BincIMAP/Apache 1.3/PHP5 server) With 325, I would see headers but no body on most messages. With 326 I see the body but no headers. I'm also getting an SQL error in the log. I increased the length of the error that gets printed so it would show the whole thing: [29-Aug-2006 11:52:22 -0400] DB Error: DB Error: syntax error Query: INSERT INTO messages (user_id, del, cache_key, created, idx, uid, subject, `from`, `to`, cc, date, size, headers, structure) VALUES ('2', 0, 'INBOX.msg', now(), '823', '4812', '', '', '', '', FROM_UNIXTIME(), 779, 'O:14:\"iilBasicHeader\":23:{s:2:\"id\";s:3:\"823\";s:3:\"uid\";s:4:\"4812\";s:7:\"subject\";s:0:\"\";s:4:\"from\";N;s:2:\"to\";N;s:2:\"cc\";N;s:7:\"replyto\";N;s:11:\"in_reply_to\";N;s:4:\"date\";N;s:9:\"messageID\";N;s:4:\"size\";s:3:\"779\";s:8:\"encoding\";N;s:5:\"ctype\";N;s:5:\"flags\";s:0:\"\";s:9:\"timestamp\";N;s:1:\"f\";N;s:4:\"seen\";b:0;s:7:\"deleted\";b:0;s:6:\"recent\";b:0;s:8:\"answered\";b:0;s:4:\"junk\";N;s:12:\"internaldate\";s:20:\"29-Aug-2006 04:05:35\";s:8:\"is_reply\";N;}', NULL) [nativecode=1064 ** You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '), 779, 'O:14:\"iilBasicHeader\":23:{s:2:\"id\";s:3:\"823\";s:3:\"uid\";s:4:\"48' at line 3] in /usr/home/webmail/roundcubemail/program/include/rcube_db.inc on line 479 I have caching disabled in the config, yet it appears to be attempting to write to the cache. It looks like the information isn't getting into the headers at all. The SQL insert is choking because FROM_UNIXTIME() needs an argument but it's getting an empty string. I'm using the most current version now (327) and the same problem is still there. On another server (using Courier IMAP, Apache 2, PHP5), it's working just fine. I'm sure that BincIMAP is partially to blame, and I wish I could drop it but the server's current setup makes it difficult. Any ideas?

2 2

RC & SQL Server
by WOODS John 30 Aug '06

30 Aug '06

Whilst on the subject of different databases some of you may be interested in a port to MS SQL Server that I have made. The attached zip contains four files: mssql.initial.sql This is the TSQL code for creating the DB objects insert_id.txt This modifies the insert_id function in the rcube_db.inc file to allow for retrieval of the last identity value (@@IDENTITY) made to the database. unixtimestamp.txt This modifies the unixtimestamp function in the rcube_db.inc file now_function.txt This is a new function that is required to place the now() mysql function or getdate() mssql function in SQL query strings. For this to work all occurrences of the string "now()" in the project have to be replaced with a call to this function. Please let me know whether any of you can make use this port. John Woods

2 1

Re: Ticket #1483986 (Bugs) Session expires
by Patrick Vogt 30 Aug '06

30 Aug '06

Had some similiar problems time ago... I use roundcube behind a proxy/firewall which is changing it's IP adress. try setting: // check client IP in session athorization $rcmail_config['ip_check'] = FALSE; in config/main.inc.php maybe this will help... patrick

2 1

Client rewrite for RoundCube
by Thomas Bruederli 29 Aug '06

29 Aug '06

Hi Brennan, I understand your concepts for enhancing the client code of RoundCube and I mostly agree with your ideas. The current code is very straight forward and grew with the application. It currently counts about 3900 lines! All actions are held in one object and are (mostly) invoked using one method: rcube.command(); I already wanted to split the code into task-specific files such as mail, address book and settings where all methods are added to the main class using rcube_webmail.prototype.nnn. Also creating some new classes for list functionality etc. was in my mind. There also popped up some plans and suggestions to make the client even more ajaxy and eliminate full page loads when switching between list, view and compose mode. Probably that's something we could include in this concept. Actually I agree with a rewrite as you suggested, the only disadvantage I see, is that this will take some time and it will stop the current development because merging could become very difficult. That's also the reason, why I cc-ed the mailing list because that's a task that concerns all developers. For me, it's no problem because I'll go on holiday for more than a month soon and will not work on the project then. Best regards, Thomas 2006/8/25, Brennan Stehling <offwhite(a)gmail.com>: > My approach with the frontend would be to make it much more object oriented > and event-driven. Each mail folder would be represented by a folder object > which would hold a series of message objects. And when you need to add a > message to the display, you simply add a message to the folder object. > Adding it will trigger an event to update the display. Essentially I would > create a model in Javascript to represent the system and have the screens > rendered from that model. > > The current frontend code is writing out HTML DOM directly when the backend > requests it. And there is no good way to trigger an event based on > something happening with a message or folder. Like when you move a message > from the current folder to another (or folder at this point), I would simply > use the following code. > > inboxFolder.remove(message1); > trashFolder.add(message1); > > A controller object (MailAgent) may wrap this behavior. > > mailAgent.moveMessage(message1, inboxFolder, trashFolder); > > Internally when the folders are changed at the model level they can trigger > display events which update the screen as needed, like updating the page > Title for the current count, the folder tray and the message tray. The > counts to show are the counts for the messages held by the folder objects. > It is no longer just dictated from the server-side. > > And at the UI level you would have those objects: PageTitle, MessageTray, > FolderTray, etc. In the FolderTray you would simply have it bound to the > Folder object which holds a collection of Message objects. And since the > Message objects have date and string values it would be very easy for the > MessageTray to sort them on those properties. > > Notice that at this point there is no HTML DOM being managed. By separating > those conceptual areas you can have project volunteers focus on what they > know best. I know XHTML, CSS and Javascript well and if all I did was help > out by handling the UI portion of the Javascript I would be productive at > it. I would not have to concern myself with how I need to interact with the > mail system. I would just work with the methods and properties available on > the objects I had available to me. I would work against the API of the mail > model. > > The same is true for the mail model. A developer could focus on enhancing > the model to do some amazing stuff. Like when the message is moved from one > folder to another it would trigger the server-side interaction to make that > happen. If that fails, they can have the message returned back to the > folder it came from to ensure UI properly matches the server-side state. > And they would do so without touching any HTML DOM. > > Brennan >

4 4

unsubscribe
by Erik 28 Aug '06

28 Aug '06

unsubscribe

1 0

Problems seeing mail
by Martin Marques 28 Aug '06

28 Aug '06

I'm having some trouble seeing the contents of mail some mail, and I thought it had to do the encoding specified in the header of the mail. But today I tried the latest svn version on a server I have with an older RC running, and I can't see the contents of a message sent by cron. If I click on "view source" I see the contents of the message, which are these (I eliminated all the received and delivered-to headers):

4 5

Hula for comparison
by Brennan Stehling 27 Aug '06

27 Aug '06

http://hula-project.org/Hula_Project I was just reminded on this project. It is a good contrast to RoundCube. And possibly a source for some inspiration. -- Brennan Stehling Offwhite.net LLC brennan(a)offwhite.net

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev