Dev

dev@lists.roundcube.net

1 participants
4297 discussions

Update 0.9.2 released
by Thomas Bruederli 16 Jun '13

16 Jun '13

Hello folks We're proud to announce the second service release for the 0.9 series of Roundcube webmail. It contains 25 bug fixes and improvements as well as some translation updates for Estonian, Romanian Finnish and French. It's considered stable and we recommend to update all productive installations of Roundcube with this version. As usual, download it from http://roundcube.net/download, see the full changelog here: http://trac.roundcube.net/wiki/Changelog Have fun! Thomas

1 0

create folders from mail view
by Phil Weir 14 Jun '13

14 Jun '13

Hi, I have been looking into adding an option for quick folder creation from the mail view. Something like adding a "create folder" option to the contextmenu plugin. I think I remember some talk about this a little while ago but I cannot find anything on the list. I think the UI would be similar to the one used for adding groups in the addressbook. At the moment the folder creation functions are heavily linked into the folders settings page - sending AJAX requests to refresh it etc every time. My idea is to move the code to create and update folders into separate functions and then call those functions in save_folder.inc but also if would allow other things like plugins to reuse the code. Is this something that is interesting to people and more importantly acceptable to the devs? Thanks, Phil

2 2

Need 2 hooks and small patch for auto refresh virtual mailbox
by Sergey Sidlyarenko 12 Jun '13

12 Jun '13

trac.roundcube.net not worked!!! After add this Feature patch return message: Submission rejected as potential spam Content contained these blacklisted patterns: 'MESSAGE' I am use dovecot virtual mailbox \All, i am write plugin for auto refresh this box if changes in real boxes, but need small patch in core. {{{ diff --git a/program/steps/mail/func.inc b/program/steps/mail/func.inc index 1a687f5..4bedae3 100644 --- a/program/steps/mail/func.inc +++ b/program/steps/mail/func.inc @@ -539,7 +539,7 @@ function rcmail_get_mailbox_name_text() } -function rcmail_send_unread_count($mbox_name, $force=false, $count=null, $mark='') +function rcmail_send_unread_count($mbox_name, $force=false, $count=null, $mark='', $parent=false) { global $RCMAIL; @@ -551,7 +551,7 @@ function rcmail_send_unread_count($mbox_name, $force=false, $count=null, $mark=' $unseen = $count; if ($unseen != $old_unseen || ($mbox_name == 'INBOX')) - $RCMAIL->output->command('set_unread_count', $mbox_name, $unseen, + $RCMAIL->output->command(($parent ? 'parent.' : ''). 'set_unread_count', $mbox_name, $unseen, ($mbox_name == 'INBOX'), $unseen && $mark ? $mark : ''); rcmail_set_unseen_count($mbox_name, $unseen); diff --git a/program/steps/mail/mark.inc b/program/steps/mail/mark.inc index dfc892e..7c22ad2 100644 --- a/program/steps/mail/mark.inc +++ b/program/steps/mail/mark.inc @@ -130,4 +130,6 @@ else { $OUTPUT->show_message('internalerror', 'error'); } +$RCMAIL->plugins->exec_hook('mark_success', array()); + $OUTPUT->send(); diff --git a/program/steps/mail/show.inc b/program/steps/mail/show.inc index d8d4372..48b13e1 100644 --- a/program/steps/mail/show.inc +++ b/program/steps/mail/show.inc @@ -305,14 +305,6 @@ $OUTPUT->add_handlers(array( )); -if ($RCMAIL->action == 'print' && $OUTPUT->template_exists('messageprint')) - $OUTPUT->send('messageprint', false); -else if ($RCMAIL->action == 'preview' && $OUTPUT->template_exists('messagepreview')) - $OUTPUT->send('messagepreview', false); -else - $OUTPUT->send('message', false); - - // mark message as read if ($MESSAGE && $MESSAGE->headers && empty($MESSAGE->headers->flags['SEEN']) && ($RCMAIL->action == 'show' || ($RCMAIL->action == 'preview' && intval($CONFIG['preview_pane_mark_read']) == 0))) @@ -324,5 +316,15 @@ if ($MESSAGE && $MESSAGE->headers && empty($MESSAGE->headers->flags['SEEN']) && } } +$RCMAIL->plugins->exec_hook('show_success', array()); + +if ($RCMAIL->action == 'print' && $OUTPUT->template_exists('messageprint')) + $OUTPUT->send('messageprint', false); +else if ($RCMAIL->action == 'preview' && $OUTPUT->template_exists('messagepreview')) + $OUTPUT->send('messagepreview', false); +else + $OUTPUT->send('message', false); + + exit; }}}

2 4

Small glitch with Settings/Preferences/User_Interface/Refresh
by Michael Heydekamp 09 Jun '13

09 Jun '13

We just moved from a dedicated server to a managed server at df.eu (domainfactory) and therefore had to freshly create all our users on the new system. Checking the config defaults of these users after first login, the "Refresh" setting under Preferences/User_Interface was by default set to "never". When this setting is manually changed within Roundcube to "every 1 minute(s)" and being saved by clicking the Save button, it does indeed first look as if it would have been saved. But if you later look again at the User Interface page (after you checked all other pages such as "Mailbox view" etc.), Refresh is still set to "never". You need to change and save it a second time. All other settings of that page (Language, Time zone etc.) are correctly saved at first attempt. Even the option "every 60 minute(s)" of the Refresh item is correctly saved at the first attempt, just not the option "every 1 minute(s)". (Well, to be honest, I didn't check all options, just "1" and "60".) This applies to 0.9.1 [GIT 20130602.1444] with classic skin, didn't check 1.0-git (yet). Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

4 7

Saving "Special Folders" breaks custom sort order of special folders
by Michael Heydekamp 06 Jun '13

06 Jun '13

Just found that small glitch: The sort order of special folders is customized in the config this way (different to the default sort order): > $rcmail_config['default_folders'] = array('INBOX', 'INBOX.Sent', 'INBOX.Drafts', 'INBOX.Trash', 'INBOX.Junk'); This is being reflected in the database this way: s:15:"default_folders";a:5:{i:0;s:5:"INBOX";i:1;s:10:"INBOX.Sent";i:2;s:12:"INBOX.Drafts";i:3;s:11:"INBOX.Trash";i:4;s:10:"INBOX.Junk"; } All OK. But when I (accidentally or deliberately) save the page "Special Folders", the custom sort order in the database is being replaced with the default sort order, although config and database are telling different. This is not by design, is it...? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

1 0

sig dashes broken in 1.0-git?
by Michael Heydekamp 05 Jun '13

05 Jun '13

I used to include the sig dashes "-- " in all o my my signatures, but as I realized today, Roundcube will add them anyway (if not existent). So I removed them in all signatures of all of my identities. This leads to the following behaviour: 1) Composing a new message: All OK. 2) Replying to to a message: Roundcube creates THREE sig dashes instead of two ("---"), and without the mandatory WSP at the end of the string. Strange, uh...? Cheers, -- Michael Heydekamp Co-Admin freexp.de Düsseldorf/Germany

2 2

Re: [RCD] Custom Session Handlers (was: Update 0.9.1 released)
by Thomas Bruederli 05 Jun '13

05 Jun '13

Hello! I'm trying to ignore all the rants and personal accusations and get back to the a constructive conversation about a technical problem. First, let's start a new thread since it has actually nothing to do with the 0.9.1 update. Second, there are reasons that Roundcube comes with a custom session handler and those are still valid. We didn't do this just for fun, believe me! The main reason are concurrent http request which alter session data. Image the following scenario: A) [r]----------- big file being uploaded ------------[w] B) [r]----- fast upload ----[w] In PHP, session data is read when the process starts and written when the process ends. With the scenario from above, the session changes of request B) would be lost when A) finishes. Until now I don't know of any solution with default PHP session handlers that would be able to handle such a case properly. Another more performance related reason for you custom handler is the check if session data actually changed before issuing a (useless) update query. Sure, we could store file upload information somewhere else than in session but the underlying problem of concurrent requests overlapping each others still persists and can happen in other cases, too. On Wed, May 22, 2013 at 9:00 PM, till <klimpong(a)gmail.com> wrote: > I agree that session handling could be nicer in RoundCube — or maybe not at > all. ;-) If we wouldn't have customized session handling code we could let > people configure PHP directly to use the filesystem, memcache or database. I > think the least we could (or should) do is use an external library for > session handling because that doesn't seem our domain (which is an email > client). > > Not sure if we could use something from Symfony2 or ZF2. They each provide > wrappers — PHP 5.3, et all. Are people ready to move/upgrade yet? We're open for suggestions to get rid of the custom session handlers but please keep the above scenario in mind. Switching to an external library might be a solution but don't they use custom save handlers, too? Speaking of which: what Roundcube does is to call session_set_save_handler() in a very early stage of the script startup. That's the API PHP provides and we sticked to the documentation for implementing the handler functions including returning true to signalize success. Unfortunately I don't have an explanation for the errors you reported without being able to reproduce it. So let's try it the old fashioned way and eliminate possible factors. @Harald, could you run Roundcube on a PHP5.4 without Suhosin to rule that out first? And please everybody, choose your words wisely! Regards, Thomas > -------- Original-Nachricht -------- > Betreff: Re: [RCD] Update 0.9.1 released > Datum: Mon, 20 May 2013 16:39:51 +0200 > Von: Reindl Harald <h.reindl(a)thelounge.net> > > and when will sessions continue to work on machines with > Apache 2.4 / PHP 5.4 / MariaDB while the error messages > below make ZERO sense because RC refuses to work with a > untouched session management like every other webapp > > would RC use simply session_start() and not fuckup the > admin settings it *would* in fact use /var/www/sessiondata > and it would it use *with success* > > ** give us a option to NOT touch any session setting ** P.S. we can but for the just explained reasons your Roundcube users will complain about lost attachments and other weird behavior.

4 15

Zimbra server and roundcube INBOX messages list problems
by kaifamm＠libero.it 04 Jun '13

04 Jun '13

Hi, I have a problem with my zimbra server 7.2.3 with which, however, use rouncube as imap client , when a new message arrives, the number of unread messages in INBOX on the left box is updated while the list of messages to the center box (subject, date, sender, etc.. ) it does not appear, appears only changing folder. I've tried various settings on zimbra, I also tried to enable and / or disable the proxy imap but it does not work. I also tried various settings in IMAP section in CR especially with imap_force_caps but does not work. Any ideas ? Thank you Marco

2 1

error logs
by Reindl Harald 02 Jun '13

02 Jun '13

something is going wrong here, see blow ______________________________________________________________ BTW: it would be nice to sse in the error log which idiot user tried to send mass-mails here: [root@localhost:/var/log/roundcubemail]$ cat errors | grep "Failed to add recipient" | wc -l 68 [31-May-2013 15:14:08]: SMTP Error: SMTP error: Failed to add recipient '***************' in /usr/share/roundcubemail/program/include/rcmail.php on line 1009 (POST /tl-webmail/?_unlock=loading1370006047347&_lang=undefined?_task=mail&_action=send) ______________________________________________________________ [31-May-2013 15:21:35 Europe/Vienna] PHP Warning: strtolower() expects parameter 1 to be string, array given in /usr/share/roundcubemail/program/lib/Roundcube/rcube_imap.php on line 1792 [31-May-2013 15:21:46 Europe/Vienna] PHP Warning: strtolower() expects parameter 1 to be string, array given in /usr/share/roundcubemail/program/lib/Roundcube/rcube_imap.php on line 1792 [31-May-2013 15:21:48 Europe/Vienna] PHP Warning: strtolower() expects parameter 1 to be string, array given in /usr/share/roundcubemail/program/lib/Roundcube/rcube_imap.php on line 1792 [31-May-2013 15:28:19 Europe/Vienna] PHP Warning: strtolower() expects parameter 1 to be string, array given in /usr/share/roundcubemail/program/lib/Roundcube/rcube_imap.php on line 1792 [31-May-2013 15:29:07 Europe/Vienna] PHP Warning: strtolower() expects parameter 1 to be string, array given in /usr/share/roundcubemail/program/lib/Roundcube/rcube_imap.php on line 1792 [31-May-2013 15:29:11 Europe/Vienna] PHP Warning: strtolower() expects parameter 1 to be string, array given in /usr/share/roundcubemail/program/lib/Roundcube/rcube_imap.php on line 1792 [31-May-2013 15:29:15 Europe/Vienna] PHP Warning: strtolower() expects parameter 1 to be string, array given in /usr/share/roundcubemail/program/lib/Roundcube/rcube_imap.php on line 1792 [31-May-2013 15:29:20 Europe/Vienna] PHP Warning: strtolower() expects parameter 1 to be string, array given in /usr/share/roundcubemail/program/lib/Roundcube/rcube_imap.php on line 1792 [31-May-2013 15:29:56 Europe/Vienna] PHP Warning: strtolower() expects parameter 1 to be string, array given in /usr/share/roundcubemail/program/lib/Roundcube/rcube_imap.php on line 1792

2 3

Zimbra server and roundcube INBOX messages list problems
by kaifamm＠libero.it 02 Jun '13

02 Jun '13

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev