Dev

dev@lists.roundcube.net

4304 discussions

Not-so-unique filenames in $_FILES
by Robin Elfrink 10 Oct '12

10 Oct '12

Hi all, I got reports from RC users claiming their recipients got the wrong attachments, attachments belonging to other RC users. So I added some logging to plugins/filesystem_attachments/filesystem_attachments.php: <> if (!$args['path']) { $rcmail = rcmail::get_instance(); $temp_dir = $rcmail->config->get('temp_dir'); $tmp_path = tempnam($temp_dir, 'rcmAttmnt'); write_log('sendmail', sprintf('Saving attachtment for %s to %s.', $RCMAIL->user->get_username(), $tmp_path)); ... <> Here are some (anonymized) lines from logs/sendmail (notice the typo, which accidentally makes for easier grep'ing): <> [09-Oct-2012 09:11:29 +0200]: Saving attachtment for <user1> to <path>/temp/rcmAttmntP007sn. [09-Oct-2012 09:18:10 +0200]: Saving attachtment for <user2> to <path>/temp/rcmAttmntP007sn. [09-Oct-2012 09:26:33 +0200]: Saving attachtment for <user3> to <path>/temp/rcmAttmntP007sn. <> With an average of 30 attachments total for all users on this server, those filenames don't look very random to me. So I added some more logging to program/steps/mail/attachments.inc: <> if (!$err) { $attachment = array( 'path' => $filepath, 'size' => $_FILES['_attachments']['size'][$i], 'name' => $_FILES['_attachments']['name'][$i], 'mimetype' => rc_mime_content_type($filepath, $_FILES['_attachments']['name'][$i], $_FILES['_attachments']['type'][$i]), 'group' => $COMPOSE_ID, ); write_log('sendmail', sprintf('Uploaded attachtment for %s in %s.', $RCMAIL->user->get_username(), $filepath)); ... <> Which gives me duplicate filenames as well: <> [09-Oct-2012 09:16:59 +0200]: Uploaded attachtment for <user1> in <path>/tmp/phpH007sn. [09-Oct-2012 09:23:52 +0200]: Uploaded attachtment for <user2> in <path>/tmp/phpH007sn. <> So this is obviously not an RC bug, but a PHP bug. My question is: Has anyone seen this before? I cannot find a related bug on https://bugs.php.net/ Robin

3 8

signing release tags?
by Daniel Kahn Gillmor 09 Oct '12

09 Oct '12

hi folks-- Thank you very much for your work on roundcube, and for your transition From svn to git. very nice! I note that tag v0.8.2 isn't signed by any OpenPGP key. If you could sign the release tags with a well-known OpenPGP key, that would be great. In particular, it would make it possible for people to verify that what they're fetching from git is actually the data intended by the developers. I'd be happy to help you tag signing sorted out, if you're not used doing this with OpenPGP (i don't see any @roundcube.net user IDs on the public keyservers yet). What do you think? Regards, --dkg

1 0

sessions started on connect?
by Cor Bosman 04 Oct '12

04 Oct '12

Hey all, we use hardware loadbalancers that connect to apache to see if the server is still ok. It does not login. I just realised these do actually create sessions, causing problems with garbage collection :( select ip,count(ip) from session group by ip order by count desc; ip | count -----------------------------------------+------- 194.109.20.222 | 14321 194.109.20.221 | 14295 2001:888:0:22::4 | 4296 2001:888:0:22::3 | 4288 Are connects without login supposed to create a session? If so, why? This is with a relatively recent 0.7 from svn. Cor

3 3

mysql users case
by Mirko Buffoni 04 Oct '12

04 Oct '12

Hi, I have a question about users: I noticed I have different users filed under `users` mysql table. This happens because of this options in configuration: // automatically create a new Roundcube user when log-in the first time. // a new user will be created once the IMAP login succeeds. // set to false if only registered users can use this service $rcmail_config['auto_create_user'] = true; which created different user entries when I have caps lock turned on or accidentally hit Shift key during typing. Anyway, shouldn't case of user be put to lowercase before authentication and all subsequent operations? is there any reason to have different user_id which lead to different entries in contacts/contacts_groups/cache etc? Mirko

4 5

Add link to inbox overview on the logo
by Dominic Lüchinger 03 Oct '12

03 Oct '12

Hello The new theme 'larry' removed the link on the logo that navigates back to the inbox overview. For me and I guess a lot of users it was convenient to click on the logo to go back to the inbox overview. This is how most of the websites work and kind of a common UI pattern. I could write a custom plugin to overcome this issue. What is the reasons behind the removal of the link? I think a link adds additional value and not interferes with the new design. Any other thoughts on this? PS: Next week we will switch our webmail from 0.7.3 to 0.8.1. Our current email user base is about 40k. 10k users have a last_login date within the latest 60 days. So far we are very happy to switch to the new skin. Good work!!! Regards Dominic

5 5

How to mark a message unread?
by Rob Sheldon 10 Sep '12

10 Sep '12

Hi, I'm trying to mark a saved message unread in markasjunk2's cmd_learn driver. The set_flag() function appears to be succeeding, but the message is not showing up as unread in the user's inbox. (markasjunk2 won't detach spamassassin messages if you use its cmd_learn driver (and even if it did, it would choke on my spamassassin config, unfortunately).) I compared what I'm doing to the mail/mark.inc file, and I can't figure out what I'm doing wrong. I've reviewed the dev docs but didn't find anything helpful there. I was hoping somebody could point me in the right direction. Here's the current relevant code: // Got message to move as $message foreach ($message->parts as $part) { if ( array_key_exists('x-spam-type', $part->ctype_parameters) && $part->ctype_parameters['x-spam-type'] == 'original' ) { $saved = $storage->save_message('INBOX', $storage->get_message_part($message->uid, $part->mime_id, $part)); if ($saved !== false) { $storage->set_flag(array($saved), 'UNSEEN'); $rcmail->output->command('rcmail_markasjunk2_move', null, $uid); array_push($new_uids, $saved); } } } // $saved appears to be a good message UID, but maybe there's some other step missing that I'm not aware of? This code is being inserted into the ham() function in the current version of cmd_learn.php. Thanks. And btw, if this is the wrong list for questions like this, please let me know. - R. -- [__ Robert Sheldon [__ No Problem [__ Information technology support and services [__ (530) 575-0278

1 0

Fwd: Add link to inbox overview on the logo
by S c o t t K r a m e r 07 Sep '12

07 Sep '12

+1 -------- Original Message -------- SUBJECT: [RCD] Add link to inbox overview on the logo DATE: 2012-09-07 13:57 FROM: Dominic Lüchinger <d.luechinger(a)snowgarden.ch> TO: dev(a)lists.roundcube.net REPLY-TO: Roundcube Development discussion mailing list <dev(a)lists.roundcube.net> Hello The new theme 'larry' removed the link on the logo that navigates back to the inbox overview. For me and I guess a lot of users it was convenient to click on the logo to go back to the inbox overview. This is how most of the websites work and kind of a common UI pattern. I could write a custom plugin to overcome this issue. What is the reasons behind the removal of the link? I think a link adds additional value and not interferes with the new design. Any other thoughts on this? PS: Next week we will switch our webmail from 0.7.3 to 0.8.1. Our current email user base is about 40k. 10k users have a last_login date within the latest 60 days. So far we are very happy to switch to the new skin. Good work!!! Regards Dominic _______________________________________________ Roundcube Development discussion mailing list dev(a)lists.roundcube.net http://lists.roundcube.net/mailman/listinfo/dev [1] Links: ------ [1] http://lists.roundcube.net/mailman/listinfo/dev

1 0

logging in with wget (or curl)
by Benjamin Connelly 07 Sep '12

07 Sep '12

We are attempting to build some tools so we can track metrics (when our users' experience might be getting too slow and we need to add resources.) So we want to be able to script logging in to RoundCube and viewing an inbox (and measure the time it takes.) I figured we could use wget with --save-cookies and --keep-session-cookies to load the login page and get a cookie, then wget again with --load-cookies and --post-data to feed in all the form fields, including username and password, but now I've gotten myself very confused about the _token field in the form, and the roundcube_sessid string in the cookie (and the s=##### javascript stuff. . .) and haven't been able to get it working by flailing. Has anyone experience with this? Or is there documentation somewhere I could grok the whole login / session process? Or is this just not going to be possible without running some javascript? Thanks in advance, Benjamin

4 4

Github x Launchpad
by Victor Benincasa 06 Sep '12

06 Sep '12

Hello Thomas, There are plans to synchronize the RC translations between Github and Launchpad? Currently we already have problems with this, there are strings that were created or modified directly on Github and are not available in Lauchpad, like $labels['forwardmode'] (0.8) or $labels['undeleted'] (0.9-git). Tks! -- *Victor Benincasa* # *Mobile*: +55 (11) 992-227-227 | ID: 55*11*51775 | Skype: vbenincasa # *IT Manager* :: Networks, Applications, Systems, Security, Advanced Support

2 1

Strange behavior
by Claudio Filho 04 Sep '12

04 Sep '12

Hi I updated my RC instance and I got a look in the /logs directory. I enabled the log to see what happens behind the scenes and I found some curious errors. [24-Aug-2012 14:27:14 -0300]: PHP Error: Failed to load plugin file /var/www/webmail/plugins/globaladdressbook/globaladdressbook.php in /var/www/webmail/program/include/rcube_plugin_api.php on line 202 (GET /webmail/?_task=mail) [24-Aug-2012 14:27:14 -0300]: PHP Error: Failed to load plugin file /var/www/webmail/plugins/tinymce/tinymce.php in /var/www/webmail/program/include/rcube_plugin_api.php on line 202 (GET /webmail/?_task=mail) [24-Aug-2012 14:27:14 -0300]: PHP Error: Failed to load plugin file /var/www/webmail/plugins/piwik_analytics/piwik_analytics.php in /var/www/webmail/program/include/rcube_plugin_api.php on line 202 (GET /webmail/?_task=mail) The strange is that i have piwik_analytics, but i haven't tinymce or globaladdressbook, in main.php.inc or /plugins directory. Some suggestion or explanation of what are happing? Best, Claudio

2 1

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev