Dev

dev@lists.roundcube.net

1 participants
4289 discussions

Ticket #1295420: Scrolling message list obscures column headers
by Roland Liebl 23 Jun '11

23 Jun '11

Hello, I have created a script to fix messagelist table header. http://www.roundcubeforum.net/5-release-support/14-release-discussion/8599-… The code can be inserted in template mail.html before closing body tag or used by a plugin (hook render_page). It works with recent versions of: * IE * FF * Chrome * Opera There are issues with Safari. A fixed table header is slightly misplaced for some reason. I was not able to find a solution yet (Safari is locked out yet). It has been not test tested with Konquerer/Netscape/Android; I don't use these browsers. Please review the code. I appreciate any feedback. Maybe someone is able to solve the Safari issue. Please focus on comments "ToDo" aswell. These comments mark hard coded stuff which should be replaced to make the script skinable. Thanks for contributions in advance! Please notice, I'm not the most skilled Javascript/Jquery coder! R. --- Schnipp ---- {{{ <script> $(document).ready(function(){ function fixTHEAD(){ // always remove the dummy row first $('#messagelist_empty_row').remove(); var last_row = $('#messagelist > tbody > tr:last').position().top; // check if messagelist has vertical scrollbar if(last_row < ($('#messagelistcontainer').height() - $('#messagelist > tbody > tr:first').height())){ //No scrollbar, so we can unfix thead $('#messagelist thead tr').css('position',''); return; } // add a dummy row because first row gets hidden when we fix thead $('<tr id="messagelist_empty_row"><td> </td></tr>').insertBefore('#messagelist > tbody > tr:first'); // add missing min-width style to threads column to getter a proper table rendering // when thead is fixed $('#messagelist tbody tr td').each(function(){ var elem = $(this); if(elem.attr('class') == 'threads'){ elem.attr('style','min-width: 17px'); } }); // unfix thead to get default column widths $('#messagelist thead tr').css('position',''); // read default column widths var width = new Array(); var i = -1; var w = 0; var subject_col; var rightwidth = $('#mailrightcontainer').width(); $('#messagelist thead tr td').each(function(){ var elem = $(this); i++; // remember where subject column is located if(elem.attr('class') == 'subject'){ subject_col = i; } width[i] = elem.width(); w = w + width[i]; }); // adjust the subject column width if there is not enough space for default column widths // ToDo: is it detectable? var scrollbar_width = 17; // ToDo: is the left space of 40px detectable? var space = rightwidth - w - (40 + scrollbar_width); if(space < 0 && subject_col){ width[subject_col] = Math.max(width[subject_col] + space, 150); } // now fix thead and adjust column widths $('#messagelist thead tr').css('position','fixed'); i = -1; $('#messagelist thead tr td').each(function(){ var elem = $(this); i++; elem.width(width[i]); }); } // lock out safari if(!bw.safari){ // add border-spacing style for IE to avoid unwanted spaces in fixed thead $('#messagelist').attr('style', 'border-spacing:0'); // remove the fixed table layout style $('#messagelist').css('table-layout','auto'); rcmail.addEventListener('listupdate', function(evt) { fixTHEAD(); // adjust messagelist table if the container is resized $('#mailrightcontainer').resize(function(){ fixTHEAD(); }); // adjust messagelist table if row is inserted and there were no scrollbars before rcmail.addEventListener('insertrow', function(evt) { fixTHEAD(); }); }); } }); </script> }}} --- Schnapp --- _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/8d1870bd _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

1 1

Patches proposals
by Vincent BOURDEIX 23 Jun '11

23 Jun '11

Hi everyone, Today I propose you 4 small patches which I needed for a client. I generated them with git which explains the numbers in the patches names. These four patches do the following : - Add of a french translation for a preference setting (default addressbook) - Add of a user's preference to be able to display a contact's lastname before his firstname in autocompletion when composing an email. - Small bug fix where a contact with an empty email was displayed at autocompletion - Add of a user's preference to be able to sort contacts on their lastname in emails autocompletion Have a good day. Vincent BOURDEIX --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/8S/gqbypSSE/0006-Modification-to.patch http://detached.gigo.com/rc/8S/gqbypSSE/0002-Add-of-a-transl.patch http://detached.gigo.com/rc/8S/gqbypSSE/0004-Add-setting-to-.patch http://detached.gigo.com/rc/8S/gqbypSSE/0005-Modification-to.patch Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

3 3

GPG Support for Roundcube
by morphium 22 Jun '11

22 Jun '11

Hi, I would really love to have a PGP plugin for roundcube. Did - since 2009 - anything happen that isn't listed here: http://trac.roundcube.net/wiki/PluginRepository/Encryption ? What can I do to encourage you to continue this project? ;) We want to start a webmail service here in germany, that makes PGP usable for everyone via web-browser. The only webmailer I found until now is squirrelmail - but I'd love to set up roundcube instead for this project. I know PHP, but didn't develop anything for roundcube yet. Would be cool if we could continue the Encryption Plugin :) Best regards! -- morphium - morphium(a)jabber.ccc.de - 113332157 http://identi.ca/morphium - http://twitter.com/morphium86 _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

2 1

updated slovene translation
by Barbara Krasovec 20 Jun '11

20 Jun '11

Hello! Sending an updated slovene translation. Cheers, Barbara --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/R4/6eDpsRMd/sl_SI.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

1 0

change to tables after r4853
by Phil Weir 18 Jun '11

18 Jun '11

Hi, Changes to the set_row_attribs function for tables in r4853 mean that the add_row function always has to be called first if you want to set attributes on the first row of a table. Setting attributes on subsequent rows is unchanged. For example, before r4853: $table = new html_table(array('cols' => 1)); $table->set_row_attribs(array('id' => 'rcmrow1')); $table->add(null, 'first row'); Would have given the first row an id of rcmrow1. But now you have to do: $table = new html_table(array('cols' => 1)); $table->add_row(); $table->set_row_attribs(array('id' => 'rcmrow1')); $table->add(null, 'first row'); I am not sure if this is an intended change or a bug. Does anyone know? Phil _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

2 1

French translation - traduction en français
by Martial Briand 17 Jun '11

17 Jun '11

--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Aj/CwmppUrn/labels.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

1 0

Simplified Chinese localization update
by c3536-rcmail＠yahoo.cn 17 Jun '11

17 Jun '11

Hi, I've update the Simplified Chinese localization program/localization/zh_CN the former $labels['fromknownsenders'] has false translation to 'from unknown senders' back in english. see attach. Best regards, waiting@CCF --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/GR/ZwVwK0uc/zh_CN.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

1 1

Arabic translation update
by Ossama Khayat 15 Jun '11

15 Jun '11

Attached --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/Ua/93Nxsj9C/roundcube-ar.zip Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

1 0

Estonian (et_EE) localization update
by Günter Kits 09 Jun '11

09 Jun '11

Hello, Please commit the updated translation to the repository. -- Best regards, Günter Kits --- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/tC/ZwBQrkIO/labels.inc http://detached.gigo.com/rc/tC/ZwBQrkIO/messages.inc Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< --- _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

1 0

rc 0.5.3 bug ?
by Benny Pedersen 06 Jun '11

06 Jun '11

$rcmail_config['referer_check'] = true; makes address book fails, still happy with the update, keep the good work _______________________________________________ List info: http://lists.roundcube.net/dev/ BT/aba52c80

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Dev