Re: [RCD] Skin unaware plugins

On Mon, 02 May 2011 08:14:31 +0000, Kees de Keizer (RC) wrote:

Hi,

I use (and develop) the skin Groupvice4. I've just upgraded to v0.5.2 and noticed that the buttons for the plugins Archive and MarkAsJunk have code in the plugin which is skin unaware:

     'width' => 32,
     'height' => 32,

The cause of the problem are these width and the height values. why are they added? Can this be fixed?

For now I've removed these values and the buttons show fine.

IMO, it is good for rendering performance to set image dimensions. But it should be done dynamically:

$temparr = getimagesize(INSTALL_PATH . $icon); $temparr['width'] ... $temparr['height']

List info: http://lists.roundcube.net/dev/ BT/aba52c80