Sjon wrote:
I agree that the highlighting should only be active when dragging around something. That is exactly the reason why I suggested javascript instead of the :hover property. I like the droptarget class idea as well. It could be useful if/when we implement (read-only) folders. I would combine the 'droptarget' class with a 'mouseover' class; that way you can customize colors for both valid targets, invalid targets, valid moused-over-targets and invalid moused-over-targets.
IMO the mouseover class is not necessary. You can set droptarget:hover in the skin CSS in order to get this effect.
Regards, Sjon
Regards, Thomas
On Wed, 22 Feb 2006 09:20:53 +0100, Thomas Bruederli roundcube@gmail.com wrote:
Hi everybody,
The main target of that folder highlighting IMO would bet to highlight only valid drop targets. That also means that the highlighting is only active when the user drags something around. I was thinking of setting an additional class (like "droptarget") to the <li>s on the valid (originating folder isn't really valid) target folders when drag starts. Then it's up to the skin to highlight them when dragging starts or when the mouse is over. After dropping the messages on a folder, javascript will remove that class again from the objects. I guess altering the PHP code is not necessary to implement this feature.
You see, it's a bit more complicated than just adding a CSS class and that's the reason why it has not been coded yet. Hope you understand what my intention for this feature is.
Regards, Thomas
Anders Karlsson (X:et) wrote:
Hi,
I would prefer to do this with the :hover tag in css instead of javascripts, then it's easy to change the colors, is there any practical issue not to use "hover" in the css ?
Cheers Anders
On Feb 21, 2006, at 22:00, Charles McNulty wrote:
Sorry, I should have been clearer that I meant the color only, not the functionality, which should be kept where Mykeul found it.
-Charles
Sjon wrote:
I do not see how this core-behaviour would belong in a stylesheet. How about putting the onmouseover/onmouseout stuff in a javascript file and let that script add classes (like '.mouseover') dynamically using the DOM. Skins can then override these classes with custom
styles.
Charles McNulty wrote:
Hi Mykeul, you're certainly going in the right direction, but if you want to put a little more work into this, can you see if you can accomplish the same thing using roundcube's stylesheet? We want people to be able to edit everything about the look (including the color of the background when the mouse is over) using the
stylesheets.
-Charles