On Sun, Jul 13, 2008 at 12:38 AM, Amitai Schlair schmonz@schmonz.com
wrote:
On Jul 12, 2008, at 3:54 PM, Michael Baierl wrote:
Please be aware that not everyone has access to the Apache
configuration. Actually most people using hosted services don't have.
Sure, my proposal doesn't help those users, but neither does it make things any worse for them. What would you suggest instead?
But being productive I suggest that instead of an env variable (which setting is so system specific etc.), I think we could implement a constant in index.php which would direct the code to the location of the configuration files. If empty, fall back on "local" (which is roundcube/config/).
This could be overwritten/replaced with a simple sed by a package maintainer if he thinks this is absolutely necessary.
I like an idea similar to how BSD (and probably most *nixes too) handles /etc/rc configs. (rc is a bunch of system startup scripts, not Roundcube in this case). Variables are loaded from /etc/rc.conf and then machine specific variables are overridden in /etc/rc.conf.local
The idea is that when upgrading between releases, your distro's scripts do not touch /etc/rc.conf.local. How does this affect us as developers, admins and users? When upgrading from 0.1 to 0.2 or even between svn checkouts, we have a shortlist of variables that are changed from the defaults.
I run two version of RC at the moment, one is against an "svn co" that I run whenever I see a few diffs I like, the other is the stable release. If I can have two config files, the default one, and I can override specific values in a local config (think /etc/rc.conf with /etc/rc.conf.local in BSD) I can save myself some time with my checkouts.
I've attached a small diff that hopefully piques a developer's interest who wants to implement this.
I'm trying to understand the host specific configuration - it sounds like if I have multiple domain names being served from a single RC install, it will override specific values for the supplied HTTP Host header value. My diff should work in tandem with this, changes to the defaults that will be applied to all hosts, and a host can still override these changes. Given I'm looking at the RC source after only a brief period, I seek forgiveness if I've replicated this functionality elsewhere.
end user to deal with it. Not everyone running roundcube is a system administrator - it's more the contrary.
+1 to this idea. Not everyone runs Apache, so you can't just stick a SetEnv in a .htaccess and say the problem is fixed. IIS and Lighttpd admins would need to modify their configs, and some Apache installs may not accept a SetEnv from within a .htaccess file. A constant seems safer to me.
Further apologies if this doesn't thread properly - I just joined the lists today and didn't have an original post to reply to.
Best Regards,
Adam