5 Aug
2008
5 Aug
'08
2:14 p.m.
Hi Raoul,
Thanks for the feedback. At least in svn, rcmail::get_instance()->config->get('imap_root') will return null if there is no imap_root configuration variable. So roundcube keeps on ticking.
I'm also uncomfortable using globals the way iloha uses $my_prefs. However, from what I could see, that's just how iloha works. It looks like a choice between using some undesirable global variable "action at a distance" or modifying the iloha's imap library. Modifying iloha wouldn't be hard, but it looks like developers have avoided putting roundcube configuration specific code into iloha so far.
Cheers, Ziba
--
Ziba Scott
Web Application Developer
Web/DB Team, Information Technology Central Services
The University of Michigan
On Tue, 05 Aug 2008 11:21:59 +0200, "Raoul Bhatia [IPAX]"
r.bhatia@ipax.at wrote:
> hi ziba,
>
> Ziba Scott wrote:
>> Hi,
>> We're testing roundcube in a fairly large environment (80K users, 900K
>> mailboxes) with a cyrus imap backend. In our environment,
>> roundcube/iloha imap's namespace discovery phase takes about 1.5 seconds
>> on an unloaded machine. This happens on every email view.
>>
>> Iloha has the ability to skip the namespace discovery phase if a
>> imap_root is configured and roundcube has a configuration option for
>> imap_root. But the two aren't connected! By handing off the imap_root
>> variable to iloha mail sooner rather than later we cut our time to view
>> a message from 1.7 seconds to 0.2 seconds.
>>
>> I've submitted a patch with this ticket:
>> http://trac.roundcube.net/ticket/1485172
>
> thank you for your patch. i would like to add two things:
>
> 1) if rcmail::get_instance()->config->get('imap_root') gives an empty
> string, the patch renders roundcube unusable.
> (ok, i internally ported the patch back to 0.1.1 - maybe
> rcmail::get_instance()->config->get('imap_root') takes care of that)
>
> 2) normally i am against the usage of globals in such a way. but this is
> better than nothing :) (note: i did not check the iil sourcecode if
> there is a better way to achieve that)
>
> cheers,
> raoul
>
_______________________________________________
List info: http://lists.roundcube.net/dev/