On Tue, Feb 19, 2008 at 12:33 PM, Emanuele Rocca ema@galliera.it wrote:
Hello Colin,
- Colin Alston karnaugh@karnaugh.za.net, [2008-02-19 12:18 +0200]:
On 19/02/2008 12:14 Emanuele Rocca wrote:
$filter = '(&('.$this->prop['filter'] .')' . $filter . ')';
$filter = '(&'.$this->prop['filter'] . $filter . ')';I don't grok this patch, the property filter _should_ be in brackets - ldap AND syntax being (&(arg)(arg)).
We have 'filter' => '(accountStatus=active)' in main.inc.php, which produces "bad search filters".
So, two options: reverting that patch or stating in main.inc.php that 'filter' should be without surrounding brackets; the current comment is: // &'d with search queries. ex: (status=act).
I'd be for the latter.
Hey guys,
so where do we stand on this? I'd be for "fixing" the comments. In general, I'd like to support the syntax most people are familiar wit and use. So I have no idea about general LDAP usage. But please let us know so we can fix that before we release the next version.
Thanks, Till _______________________________________________ List info: http://lists.roundcube.net/dev/