I'm not 100% sure of this patch (I'm a roundcube noob) but it seems that
the JS url variable was undefined. I think that the url variable should
have been qstring. I may have extra or not enough concat operators
(either + for JS or & for the GET vars) - I'm not sure, but the crux of
the fix is changing url to qstring. This resolved some of the problem
that Chris outlined below. There also seems to be possibly some
MIME-type passing problems but I haven't figured those out.
These changes were made on version 363 and more info about our
environment is below in Chris's message (our production site is running
367 our devel svn is 363).
--- app.js (revision 4)
+++ app.js (revision 7)
@@ -628,11 +628,12 @@
case 'load-attachment':
var qstring =
'_mbox='+this.env.mailbox+'&_uid='+this.env.uid+'&_part='+props.part;
find_in_array(props.mimetype, this.mimetypes)>=0)
{
window.open(this.env.comm_path+'&_action=get'+url+'&_frame=1',
'rcubemailattachment');
window.open(this.env.comm_path+'&_action=get&'+qstring+'&_frame=1',
'rcubemailattachment');
if (this.attachment_win)
{
setTimeout(this.ref+'.attachment_win.focus()', 10);
@@ -3028,9 +3029,8 @@
{
if (lock)
this.set_busy(true);
- var querystring = query ? '&'+query : '';
- location.href = this.env.comm_path+'&_action='+action+querystring;
- location.href = this.env.comm_path+'&_action='+action+'&'+querystring;
};
--
Jay Lanstein
Vice President
Cantella & Co., Inc.
2 Oliver Street, 11th Floor
Boston, MA 02109
(617)224-1426 - direct
(617)521-8630 - office
(617)521-8604 - fax
Chris Richardson wrote:
> Hey guys i wrote a little while back about this and I was wondering if
> anyone had any ideas on this we are working on it but haven't found a
> decent solution. Has anyone else ran into this and found a solution?
>
> problem is when there is an attachment of a pdf when you click on the
> link next to the paper clip it opens a new window but it si the
> content of your inbox and only way you can open it is by right
> clicking and saving target as.
>
> our env is php5, roundcube svn 367and IE 6 thanks guys
>
>
>
> The information transmitted is intended only for the person or entity
> to which it is addressed and may contain confidential and/or
> privileged material. Any review, retransmission, dissemination or
> other use of, or taking of any action in reliance upon, this information
> by persons or entities other than the intended recipient is prohibited.
> If you received this in error, please contact the sender and delete this
> material from any computer.
>
> In accordance with industry regulations, all messages are retained and
> are subject to monitoring.
> This message has been scanned for viruses and dangerous content and is
> believed to be clean.
> Securities offered through Cantella & Co., Inc., Member NASD/SIPC.
> Home Office: 2 Oliver Street, 11th Floor, Boston, MA 02109
> Telephone: (617)521-8630
>
>
>
The information transmitted is intended only for the person or entity
to which it is addressed and may contain confidential and/or
privileged material. Any review, retransmission, dissemination or
other use of, or taking of any action in reliance upon, this information
by persons or entities other than the intended recipient is prohibited.
If you received this in error, please contact the sender and delete this
material from any computer.
In accordance with industry regulations, all messages are retained and are subject to monitoring.
This message has been scanned for viruses and dangerous content and is believed to be clean.
Securities offered through Cantella & Co., Inc., Member NASD/SIPC.
Home Office: 2 Oliver Street, 11th Floor, Boston, MA 02109
Telephone: (617)521-8630
