Hi all,
here is the next revision of threaded message list patch
Changes comparing to roundcubemail-threading-20090706.patch from http://www.atomice.com/blog/?page_id=34:
- Ported to 0.3-SVN-r2976
- Implemented auto expand of threads with unread messages only.
- Added GUI configuration option for autoexpand control (on, off, unread).
- Autoexpansion works in both static and JS message lists.
- Automatically change between 'unread children' and message icons in a
list (in parent message rows) when child message is marked read/unread. 6. Count messages, not threads in a message view pane. 7. Fixed navigation in a message view pane when threading is enabled. 8. Fixed setting folders with non-ASCII named to threaded mode. 9. Fixed incorrectly displayed rows (children of collapsed row) after multi-level expand/collapse. Simplified expand logic. 10. Fixed expand indicator is not changing when expanding/collapsing with keyboard. 11. Fixed plus key on a numeric keypad is not working (at least on linux Fedora 11 + Firefox 3.5.2). 12. Added support for whole thread expand/collapse with clicking/pressing hotkeys while holding the Control key. 13. Save expand state in env everywhere (after keypresses too). 14. Added russian translation. 15. Fixed indentation and braces style in JS to comply with RC coding style.
Changes to my previous public revision:
- (Multiple) selection works fine with threaded view too now (based on
patch published by Nathan Kinkade). Selection list is altered immediately on a select action (opposed to Nathan's patch). Nested messages are added to selection list when collapsed parent is selected, and removed from it on a thread expand. I ask everybody to test this feature with both mouse and keyboard shortcuts. 17. Remove a bit of unused code. 18. Add only one div of a variable width to a messagelist row instead of set of divs. See comments inline. 19. Make dragging work with threaded view (locate subject text differently). 20. Re-read messagelist portion after move/delete operation if threading is enabled. See comments inline. (This does not fix a bug with non-atomic move/delete operations I noted before). I'm not sure I did it 100% right because of that bug which makes testing nearly impossible in my setup.
I think that code (except thread caching which I don't use and didn't touch it at all, it is up to Chris) is a true beta quality now (based on my testing) and is ready to be tested intensively in different setups. Comments are welcome as usual.
Best, Vladislav
--- 8< --- detachments --- 8< --- The following attachments have been detached and are available for viewing. http://detached.gigo.com/rc/1h/WkvtBXFZ/roundcubemail-thread.patch http://detached.gigo.com/rc/1h/WkvtBXFZ/unread_children.png Only click these links if you trust the sender, as well as this message. --- 8< --- detachments --- 8< ---
List info: http://lists.roundcube.net/dev/