On 11/19/2012 02:30 PM, Thomas Bruederli wrote:
What about moving framework classes/files to program/framework and keep the Roundcubemail app related classes and files in program/include?
I prefer lib/Roundcube because this allow as to re-use rcube_autoload(). It's better to have /usr/share/php/Roundcube than /usr/share/php/framework.
I think both, the framework and the include directory, should have an iniset.php (you can rename it to bootstrap.php if you want) which does the necessary setup to use either the framework or the Roundcube application. program/include/iniset.php would most likely include program/framework/iniset.php to effectively load the framework to be used within the application.
Not a bad idea, but we still have 4 files in program/include, that's why I thought about getting rid of this directory.
clisetup.php is part of the application but maybe the included functions could be moved to framework/rcube_cli.class
These are only two functions, so we can just move them to rcube_utils.