Hello Vladislav,
On Thu, 20 Aug 2009 15:41:08 +0300, Vladislav Bogdanov bubble@hoster-ok.com wrote:
I'm just subscribed, so first thanks to all devs for all efforts on making RC really great.
I noticed that threaded view support is planned for 0.4-beta1, so I attach a reworked patch for a threaded mailbox view mode. It is not fully perfect, but is a good (re)starting point for that anyway.
Changes comparing to roundcubemail-threading-20090706.patch from http://www.atomice.com/blog/?page_id=34:
- Ported to 0.3-SVN-r2863
...
- Fixed indentation and braces style in JS to comply with RC coding
style.
All these changes look good to me!
Known issues:
- Messages from a threaded folder are sorted not in a thread-aware
order but rather in a natural order when browsing with GUI controls at the bottom of a message view pane. This is probably a minor issue because it is more convenient anyway to browse through threaded discussions with a preview pane enabled. Maybe we need to explicitly enable a preview pane for a threaded folders.
I don't fully understand what you're saying here. Would you mind expanding?
- Last selected message is neither focused nor centered in a list when
returning to a list from a message view pane. I think it is minor issue too.
This patch (and original one too) is sometimes too intrusive, so it needs to be checked at least twice just not to break things.
That is true. I was disappointed my original patch couldn't be made into a plugin for 0.3 but as you say it is too intrusive.
Did you notice Lacri's last comment on the blog page? There is a bug with messages showing up again after you delete them (it's purely client side).
Chris
List info: http://lists.roundcube.net/dev/