2010.04.22 09:48, A.L.E.C rašė:
Rimas Kudelis wrote:
I think Alec shouldn't have closed the bug as wontfix. I also guess that your bugreport wasn't clear enough about what you want to achieve (too much background info). From the code you pasted, it seems that you get the desired behavior by just switching positions of the foreach and the if blocks, and (at least for me) it doesn't look like this would break something.
Perhaps it would be clearer if you rephrased what you wanted to achieve, perhaps like this:
" When the same folder is used for sent mail and as inbox, its name should be inbox, not sent. "
Alec, do you really see such slight adjustment to folder name resolution logic as undesired?
This is not only a matter of a display name. See Special Folders section in Settings, it's not possible to set Inbox as any of special folder and there was a reason to do this, e.g. http://trac.roundcube.net/ticket/1486114 Setting Inbox as Sent will make the Sender/Recipient column confusing. Maybe there are other reasons...
If I understood correctly, Jamie's bug wasn't about allowing to set inbox as sent folder, because he's already done that. The bug was about what folder name is shown in case inbox is sent. IMO, inbox should always be shown as inbox regardless of whether or not it's also used for sent, drafts, trash, and/or junk. Don't you agree?
This is a different issue from that of actually setting inbox folder as sent (isn't it gmail style?). I think there may actually be more people who may want it, but this is a separate issue, which could be dealt with later, if/when there is more demand.
Rimas
List info: http://lists.roundcube.net/dev/