On 08/20/2013 09:15 PM, David Deutsch wrote:
So - in a nutshell, that's what I'm offering to do for Roundcube.
In general we accept such contribution.
I'd be happy to accommodate to special customs, of course, although I do think that sticking to PSR - flawed as it may be in spots - really helps enable collaboration by convention. Let me know if this sounds like something that would at all be welcome in this project.
I don't like some of your style, precisely, space after/before brackets. I also prefer a new line before else/catch.
If you want to learn Roundcube code, consider also creation of more test scripts.