Hi Alec,
thanks for comments.
I can't contribute with patches due lack of knowledge (Windows fuzzy). I will make it to disable links if mailbox is empty. As soon as 'invert' is part of core I'll strip 'invert' of the plugin code.
One question ... Is there any reason not to provide a default command case in app.js? Such like ...
case 'delete-folder':
this.delete_folder(props);
break;
// Find me: API: Javascript command,
default:
if(typeof eval(command) == 'function'){
return eval(command)();
}
... would make it easier to jump in - at least for me.
Regards, Roland
----- Original Message ----- From: "A.L.E.C" alec@alec.pl To: dev@lists.roundcube.net Sent: Saturday, May 30, 2009 7:31 PM Subject: Re: [RCD] Feature Discussion
Roland Liebl wrote:
I have coded #4 (Invert Selection and Select Range) as plugin (see attachment). Perhaps not all will like this features. Any criticism is welcome. I'm not the most skilled programmer!
As I said previously, this should be added into core. Two points from me:
- Create a patch not a plugin. Since 'range' is targeted for IE users,
maybe we should split this: 'invert' as core feature and 'range' as plugin. 3. If mailbox is empty links should be disabled.
-- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Developer http://roundcube.net _______________________________________________ List info: http://lists.roundcube.net/dev/
List info: http://lists.roundcube.net/dev/