Thomas Bruederli wrote:
Hi everybody,
I'd like to discuss the meaning of the option named 'flag_for_deletion'. In http://trac.roundcube.net/changeset/1508 RoundCube changed it's behavior based on the bug reported in http://trac.roundcube.net/ticket/1485002
This config option was initially created to control the behavior when deleting a message and no Trash folder is available (see comment in config/main.inc.php) and was set to true by default. When I now delete a message (move it to the Trash) the original message is only flagged as deleted but still visible (no expunge command is issued) and this is not what most users expect to happen.
now we can flag messages as deleted if we have or we have not a Trash folder
Since http://trac.roundcube.net/changeset/1403 this config option is even editable for the user but it's still set to true for all users until they manually disable it.
it should be enabled by default, I think.
To respect the issue described in ticket #1485002 I suggest to also check if a Trash folder is specified ('trash_mbox') in rcube_imap.php as well as in app.js and to remove the config option from the user prefs form. To make it complete, we could allow the user to select his trash folder in the users prefs with the option to leave it empty (which would enable the checkbox for 'flag_for_deletion')
What do you think about this? Do you like the behavor of the current svn trunk?
I like current behaviour and it's an additional feature, but I don't use it, so, do what you want ;)