Re: [PATCH] Fix PHP Warning in imap.php

On Mon, May 01, 2006 at 12:22:15PM -0400, Jared McKnight wrote:

I occasionaly get a similar error, but it is usually paramter 2 or 3 for mktime() (and for me it happens on any folder with the invalid message). i find it is due to spammers not abiding by the date formatting of the RFC.

I had been meaning to go back and figure out why that param was not an int. It obviously is in some (most?) cases.

• should we not type cast all of those parameters? or

• if the mktime() call fails, catch the error and use the date written

in the email?

In retrospect, I would catch the error and branch. I really should have figured out the cause and addressed that instead of the symptom.

I'll make a second try, probably next week.

m